summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-06-25UITest_writer_tests7: Wait for async events (blind fix)Xisco Fauli
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62483/> failed spuriously with ERROR: test_tdf133348 (tdf133348.tdf133348) ---------------------------------------------------------------------- Traceback (most recent call last): File "sw/qa/uitest/writer_tests7/tdf133348.py", line 44, in test_tdf133348 self.assertEqual(xEnum.nextElement().Author.strip(), 'Known Author') tdf133348.com.sun.star.container.NoSuchElementException: SwXFieldEnumeration::nextElement Change-Id: I5504f6febb20eb174b480f0d38176b1a70407716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97097 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25Get the property dump of the text at the cursorShivam Kumar Singh
We need the property dump consisting of 1) Character Properties 2) Paragraph Properties 3) Character Style Properties 4) Paragraph Style Properties This patch gives all the properties related to 'Character Styles' at the cursor. This patch manages inheritance features, which means, it lists any property only at that level in which the property has been redefined for the last time. Change-Id: Ice2ae9ac92aec4af9d395885e06602753e636457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-25use tools::JsonWriter for dumping property treeNoel Grandin
Change-Id: I8f55af19ba10b71bd621e69b27000ab7cb565309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25tdf#125893 DOCX import: fix "half" contextual paragraph spacingLászló Németh
Always ignore own top margin setting of the actual paragraph with contextual spacing, if the previous paragraph is identical. I.e. in that case, too, when the previous paragraph has no contextual spacing, like MSO does. Note: PARA_SPACE_MAX mode hasn't included this modification, yet, so only ODT documents converted from DOCX use it at the default setting. See also commit ba18832ceeda21f047a664b71a4333a54737e6c8 (tdf#75221: make margin collapsing implementation conform OASIS proposal) Change-Id: Ida9d12b2c511fcd5e38ade7eb5f4650387c65813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97081 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-25sw: handle BackgroundParaOverDrawings when replacing compat optionsMiklos Vajna
This was added in commit 18b3feb8bef06bf7b126fd0bc743e19479cb8026 (n#778133 sw: add BackgroundParaOverDrawings compat flag, 2012-09-12), it's off by default and on for DOCX documents. Change-Id: If584f8eef2672d5d41c249e2b77b20f029587e23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-25Fix typosAndrea Gelmini
Change-Id: I2bccc7beb2e9dfccd84b118a33a7aee9753a8be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-24Remove obsolete comment about LF on old Mac OSStephan Bergmann
(and where sticking to numeric '\x0A' is probably cleaner anyway) Change-Id: I77efcffea7fe246984be0a599f3c403397b8a9c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-24tdf#124176 Use pragma once instead of include guardsWyatt Turner
Changes include guards in threadmanager.hxx to #pragma once Change-Id: I9cdc391f68389b0e23fa52598f5c2f1281d4e7a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91080 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-06-24sw: make postithelper.hxx self-containedMiklos Vajna
The problem was that the inline SwSidebarItem ctor/dtor needed a complete type for sw::annotation::SwAnnotationWin, but AnnotationWin.hxx already includes this header, so we can't include it. Move the ctor/dtor to postithelper.cxx where we include AnnotationWin.hxx already. Change-Id: I619bd5d21493a80436a333c128eadfff2a6834b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97011 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-24tdf#128197: sw: different line height for DOCX with compat=14Vasily Melenchuk
Lines containing just a shape inline without any other text are treated in DOCX with compatibility option 15 and 14 in a different way: while compat=15 is layouting line exatly as LO does, in compat=14 mode minimal line height takes into account just shape height and not current font. Change-Id: Id2bdab941a0bbaa9080567d736435d9e0babd490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96080 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-24tdf#133670 DOCX import: fix shape width relative to right marginSzabolcs Toth
using UNO API RelativeWidthRelation and the associated lo-ext attribute for OpenDocument export. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). Co-authored-by: Balázs Regényi Change-Id: Ic5d25701d46cdace6502ec55dbc0e5f0ebd7742b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95582 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-24use more std::container::insert instead of std::copyNoel Grandin
which is both more compact code, and more efficient, since the insert method can do smarter resizing Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23tdf#134243 only do the toc-terms localization when showing toc previewCaolán McNamara
and not when previewing another document, which sidesteps the infinite loop in this example Change-Id: Ideb41029f4c98a50555cd35227867d9fdd5ae5a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-23tdf#132976 DOCX import: fix shape width relative to left marginSzabolcs Toth
using UNO API RelativeWidthRelation and the associated lo-ext attribute for OpenDocument export. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). Co-authored-by: Balázs Regényi Change-Id: I2dada8ad764a1fba33d241117cc4bc5eddae74ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95525 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-23tdf#83309: sw: do not create bullet with no charVasily Melenchuk
On some machines (depending on fonts installed) creation of SwBulletPortion with bullet = \0 leads to drawing a bullet as a empty rectangle. Change-Id: I2826944f2278e8c9a6c740b11b69d2e4e5108158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96711 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-23sw doc model xml dump: improve undo-redo coverage:Miklos Vajna
- show the undo manager's node array - show SwUndoDelete - show SwUndoSaveContent - show SwHistory - show SwHistoryHint - show SwHistoryTextFlyCnt - show SwUndoFlyBase - show SwHistorySetFormat - show SwUndoInserts When an action + undo pair goes wrong, it's easier to see the state of the undo stack after the action this way, then decide if the undo stack is already bad, or the problem is with the undo implementation. Change-Id: Ic509a233dce3c47db9697982eb7ea423f4706129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96930 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-23tdf#130218 sw: show hanging indent in narrow cellsLászló Németh
Instead of hiding it, show hanging first paragraph line in narrow table cells, like MSO does. Change-Id: Ibfa7242644db36c1be4d2fe93af75cb295d443b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96865 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-23sw: fix missing OLE preview on updating linksMiklos Vajna
Regression from commit 74844277cc2194c9e43f5bd7a6f78a9603da32f3 (disable generation of ole previews in ODF format until after load, 2016-09-13), if the document has charts without previews, it's loaded, fields are updated and saved, we no longer generate those previews. Given that Tools -> Update -> Update all is always an explicit user action, restore the permission to update OLE previews / links before performing the actual update. With this, comphelper::EmbeddedObjectContainer::StoreAsChildren() will generate those missing previews inside the getUserAllowsLinkUpdate() conditional block. Change-Id: Ib54e06a2e2f2e1c65951fdec302e59e63c71d008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96928 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-23FixedBitmap can be in a toolkit only headerCaolán McNamara
Change-Id: I22bb548f7f0c1ef0de157f99915fbaf6473c284b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-23tdf#119081 sw: fix RTF paste into outer table cellMiklos Vajna
Regression from commit ed654c4aa7f9f10fcb16127349009bc0c38b12e8 (Revert "fdo#43869 use the old rtf importer for paste", 2012-11-30), the direct problem is that SwXText::insertTextPortion() is now used by writerfilter, so in case it's not as good as the internal API used by the old RTF filter, we have a problem. This function calls SwXCell::CreateCursor(), which calls SwXCell::createTextCursor(), which uses Move() to go to the first content node in the cell, but that means we end up at the inner cell's XText for an outer cell. So later when we want to go to the end of the outer cell, we can't, as that would be a different XText and we throw an exception. Fix the problem by instead using createTextCursorByRange(), which immediately positions the cursor at the insert position, so the XText will be correct. FWIW, the ODF import at SwXMLImport::setTextInsertMode() also uses createTextCursorByRange() to handle this situation. Change-Id: I1db13b860bc60771d98c2b4099be73f4bf41c375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96901 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-22tdf#134112 Don't call UNO listeners with SolarMutex lockedStephan Bergmann
Change-Id: I20f616819ce25fa6873872d1f07ae8967a72e9bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96843 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-22sw: prefix members of SwDocDisplayItem, SwNode2LayoutSaveUpperFrames, ...Miklos Vajna
... SwShadowCursorItem and SwUndoSort See tdf#94879 for motivation. Change-Id: Ic41cd974cc91bf29d73611a7ca920adc9a6551d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96833 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-21weld date selection widgetCaolán McNamara
Change-Id: If7ea24d85c20f1bda972688e97c7f74b26e533e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-21Fix typoAndrea Gelmini
Change-Id: If5237578c5a836ff99541faeb9ae8deca0908134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96565 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-20use JsonWriter for the rest of ITiledRenderableNoel Grandin
and fix bug in buffer reallacotion where mPos pointing at the beginning of the new buffer instead of at the correct index inside it. Change-Id: Ie1ffaa176f6165e2cec85c93adc945312eff38e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-20indicate popup menu was shownCaolán McNamara
Change-Id: I4d0e8f31fd8c30368497e52c6eb1ba2b7e960bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96773 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-20tdf#101830 sw: highlight empty 'invisible' input fieldsSerge Krot
Change-Id: Ibcf4f7ce88c7bf364510c522e224028aa4737790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96717 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-19tdf#127635 sw_redlinehide: put point at the end of deletionMichael Stahl
SwWrtShell::Insert() is called with a selection, so it first calls DeleteAndJoin() to get rid of the selection. With redlining enabled, this leaves the cursor as it was before, so if the point was at the start it still is at the start, so the following Insert will insert at the start of the selection. But then AutoCorrect wants to do things and it uses TextFrameIndex and ViewToModelPos and gets a result at the end of the delete redline, while the cursor remains at the start of the delete redline. Avoid this by swapping the selection after DeleteAndJoin() (and also DeleteRange() for consistency) so that insertion happens at end of redline (swap "above" DoWithBreaks because it creates temporary PaMs). (regression from sw_redlinehide) Change-Id: Ib5b0475f610c2ce426e9202e9d325dd0cc451d5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96743 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-19tdf#132326 sw_redlinehide: no frames allowed in Undo SwNodesArrayMichael Stahl
This crashes in SwAccessibleParagraph::GetRealHeadingLevel(); the a11y should have been disposed earlier because the node it's connected to is in the Undo SwNodesArray. When SwUndoDelete::SwUndoDelete() calls SwNodes::MoveNodes(), all existing frames must be destroyed; the MoveNodes() would reset its flag temporarily inside a section, to delay creating the frames inside the section when moving to the live SwNodesArray, but this also prevents the deletion when moving in the other direction. (crash is regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I13719bf98ea96b8d68db3ee78cf7f4b61a99e7e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96734 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-19tdf#133990: sw: Add unittestXisco Fauli
Change-Id: I3b5d1a2a2396fba9d350350ac4d04f7f97401ebe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96714 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-19tdf#133924 DOCX export: fix text wraps around frameTibor Nagy
Co-authored-by: Attila Bakos (NISZ) Change-Id: I08f0c8a8f4f554178548ca5fc8d072998a379b32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96290 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-19tdf#133701 DOXC export: fix frame distance from textTibor Nagy
Vertical and horizontal minimum distances of frame and the text wrapping around the frame were not exported. Note: different left/right, top/bottom values aren't supported by OOXML hSpace, vSpace, so calculate average values to keep the page layout. Co-authored-by: Attila Bakos (NISZ) Change-Id: Ieef999003bcc6b9bba0a932ee4dd2b5461380c17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96110 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-19tdf#108505 DOCX: fix legacy dropdown fields direct font settingGabor Kelemen
if it is at the beginning of the paragraph. See also commit 22ad4d69d771708f28a2d9e137cfd43ac846cf3a (tdf#121045 DOCX import: fix checkbox size in table). Change-Id: Ic4d4fc56cf031cc941c3f81930c6eba497090cba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91540 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-19tdf#133981 sw_redlinehide: oops, InsertCnt_() is missing null...Michael Stahl
... pointer check. (regression from 55576842ec72a748d0bad123d41fa03c89fc136d) Change-Id: I4478c45d10ac516afd6360e4083b00d667c678fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96621 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18Revert "uitest: Add demo for Writer-comments"Stephan Bergmann
This reverts commit ba33a51ff1eb34a5983870dcb50e975002e6d3a4. Reason for revert: These new tests do not only occasionally fail for <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/> (see comment at <https://gerrit.libreoffice.org/c/core/+/96295/11# message-50341d16b29be9704f1c25bf59e27ab6aa20a1ec> "uitest: Add demo for Writer-comments", they also appear to massively impact Jenkins builds of Gerrit master changes, see e.g. <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62008/>, <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62002/>, and <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/61999/>. Change-Id: Ibad0e0523fa15491212c283cada4b1c51b22dea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96636 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-18sw: SelectAll should copy section before table at start of documentMichael Stahl
Change-Id: I51c9c84073a89402e7e4952c346ad13e1d264622 related: tdf#133982 tdf#133990, see bugdoc of the latter Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96619 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18tdf#133990 sw_redlinehide: fix Undo with section before tableMichael Stahl
... at start of document. The section node wasn't included in the PaM passed to SwUndoDelete, so on Undo it called MakeFrames() starting from the contained table node and crashed when reaching the section's end node. Fixed, then it crashes in Redo, because SwDoc::DelSectionFormat() calls SetModified() which calls some event listener which causes EndAllAction() to be called, which by itself is scary and then it crashes because the nodes array contains a bunch of deleted nodes. Not sure if that SetModified() serves any purpose, but it's pointless in Undo. (1st crash is regression from 68880a3004623553bf1920ad8a4a4d2be4bca234) Change-Id: Iafdd073ca9577bf54dd5a8ad2eb8f8f110db93b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96620 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18tdf#134021 sw_redlinehide: fix crash if document contains only tableMichael Stahl
This sets the m_bTableDelLastNd flag in SwUndoDelete, so a SwTextNode is created so that there's something in the document, and there are 2 problems with Undo: 1. ~SwIndexReg assert because there's a shell cursor on the text node; could fix this with some PaMCorrAbs() but let's just call DelFullPara() which takes care of that. (this likely isn't possible in the !m_bTableDelLastNd case) 2. no frames are created in MakeFrames() because there's no node in the document with layout frames, so delete it at the end. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I6d8535ae1a2e607d665660f149b344e817bc8ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96604 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18sw: try not to layout in SwShellTableCursor::FillRects()Michael Stahl
This crashes after Undo in tdf#134021 bugdoc, because there's no Action there so a SwTabFrame::RemoveFollowFlowLine() deletes a row and a11y events are sent synchronously, then the a11y code calls back into sw and accesses semi-connected cell frames. Change-Id: I98e8acf4756a44b8776e01d6b831d4b1494792f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96603 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18tdf#133982: sw: Add unittestXisco Fauli
Change-Id: I1a9b0a1150f8e3e1832aaa15a09049622bd83afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-18distinguish active dnd-operation case from simple query caseCaolán McNamara
Change-Id: I1d8e95e46b45c71c0c83316ab4f19ba85eddcf75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96598 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-18tdf#134035 sw: insert long date format for HungarianLászló Németh
in Writer using Insert->Field->Date or the similar toolbar function. Note: the previously used short date format YYYY-MM-DD is rare in Hungarian text documents, and it is no longer mentioned in the last Hungarian orthographic standard (But it's still default in Calc, as standardized by (MSZ) ISO 8601.) Change-Id: I09f2f3314356e84c73a42be9f06ceaa6769e7338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96112 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-18tdf#133589 Numbertext: fix Hung encoding on WindowsLászló Németh
Workaround to fix non-BMP Unicode characters in the case of Hung (Old Hungarian) module, resulted by std::wstring limitation on Windows. Change-Id: I4f6a72ad0e3d4f70ef7e35910bb4147aedb0e4ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96562 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-18new json writer for LOKNoel Grandin
we shave about 3 memory copies off in the process, and make the class play nicely with our string types. Change-Id: I1f614fb35b1de499ac99e3b33ac638ad81054bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96393 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-18tdf#133982 sw: fix Copy of document that starts with nested tableMichael Stahl
Started to assert with ef8427d12a63127a2eb867637699343d630545dd because a bookmark was created on the wrong node but this never worked. Change-Id: Ife01a3c8041b4c7d08b2d749dde77ced388f7215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96556 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18tdf#134009 sw: prevent spurious undos in SwColumnFrame::DestroyImpl()Michael Stahl
SwUndoFrameFormatDelete is created for every destroyed column frame. Change-Id: I11e0399487a41c52768175faf3a3699b302ad317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96558 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18sw: handle TreatSingleColumnBreakAsPageBreak when replacing compat optionsMiklos Vajna
This was added in commit 93d7fc90b57bb08052299c94fa0a28bb8f494a9c (tdf#76349 writer: make 1column-as-page break a compatibility option, 2016-08-30), it's off by default and on for DOCX documents. Change-Id: I60f6d23feb278e8a234f5c571f9b647c2c08c491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96561 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-18uitest: Add demo for Writer-commentsShiko
Change-Id: Iaf7c4c646a1f64f0a97c95fd7133da89da44c7d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96295 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-17uitest: Add support for Writer commentsShiko
Change-Id: I88ed2894c3665fb421c5d8ea0f278c54ccd0d0e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96230 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-17tdf#134063: sw: redesigned support for tab at zero positionVasily Melenchuk
Initial support for tab position at zero (d2e428d1) was not taking into account hack for tab positions below zero. So previous behavior is restored (search is started from 0) but we also taking into account potential tabs at zero position in SwLineInfo::GetTabStop() Change-Id: I8b315ab69f9a53ac15002a41a81e069ff832f692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96526 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>