summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae Reviewed-on: https://gerrit.libreoffice.org/63981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25drop unnecessary vcl/window.hxx includes in writerCaolán McNamara
Change-Id: I9bf20f2b4a20444f910738e42789b219efcf51fd Reviewed-on: https://gerrit.libreoffice.org/63977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25weld SfxMacroAssignDlgCaolán McNamara
Change-Id: I80045f1d1ca189fc490dc88b3471d68782df6f1c Reviewed-on: https://gerrit.libreoffice.org/63976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25AbstractApplyTabDialog_Impl is now unusedCaolán McNamara
Change-Id: I6c0ab3ee8cadfd5eeb0aa6bd7828715401568e2b Reviewed-on: https://gerrit.libreoffice.org/63974 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25SwTemplateDlg is now unusedCaolán McNamara
Change-Id: If7de6baf5d2770d18926ee744a5c0fc6283c0195 Reviewed-on: https://gerrit.libreoffice.org/63973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25weld SwFrameDlgCaolán McNamara
and now can remove... commit 5d84af7e83404f22d3c9cd0b0bb88fb84d0550e7 Date: Tue Dec 4 22:43:46 2012 +0100 fdo#57553: Picture dialog Macro tab page: lazily init ... because JVM startup is annoying, so delay it until really activating Macro tab. This patch is sort of lame but with the change in bd2c14ec78a7549d4a19738154cdd5ea890f61c4 what can you do... and description is revealed to be a text_view not an entry Change-Id: Ibc92cf11870d4349ddc728ec17c846e4158e82ac Reviewed-on: https://gerrit.libreoffice.org/63916 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25tdf#121401 add shortcuts and Left2Right supportandreas kainz
Change-Id: If2be67b9c20d887b7c8ead500daabfd3d224a2f1 Reviewed-on: https://gerrit.libreoffice.org/63965 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: If173f42302553b164267909a0a3156bb25a6d558 Reviewed-on: https://gerrit.libreoffice.org/63957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-24Replace list by vector in unocoll.cxx (sw)Julien Nabet
Same logic as https://gerrit.libreoffice.org/#/c/63928/ Change-Id: I59d5329687f94dcf0dba53a428f580313467829c Reviewed-on: https://gerrit.libreoffice.org/63939 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-24Replace list by vector in acctable.cxxJulien Nabet
Change-Id: Ia31ce52893edb4d3a050062ddb8579aae877f697 Reviewed-on: https://gerrit.libreoffice.org/63926 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24Replace list by vector in unodraw.cxx (sw)Julien Nabet
Since m_aShapes is filled once during construction of SwXShapesEnumeration with n times call to insert_iterator (equivalent here to a push_front) then retrieving next element with begin() + pop_front we can simplify this by using a vector with: - n push_back during ctr - back() + pop_back in nextElement() Change-Id: I089c5fdfd59934b6cc1e392e9f0703b1ffaa234e Reviewed-on: https://gerrit.libreoffice.org/63928 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove unused RedlineFlags::IgnoreDeleteRedlinesNoel Grandin
Change-Id: Ic7c1b752c4511a0f55aa8be6b835763715c7738a Reviewed-on: https://gerrit.libreoffice.org/63930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24don't need function pointers here anymoreNoel Grandin
Change-Id: Ica36573da290bfc98de99fec6ed59dbf8acb8a73 Reviewed-on: https://gerrit.libreoffice.org/63924 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove unused TableChgWidthHeightType::InsertDeleteModeNoel Grandin
looks like as a consequence of commit 2d5ce0e1b233c83f91481cd6b9306ac8de7f5ff8 Date: Mon Mar 26 13:08:54 2018 +0200 tdf#116452 Remove "3 seconds to add/delete col/row" functions Change-Id: Iae3e2876ed0a0bc916bb4a53f3050d9baa45b0e7 Reviewed-on: https://gerrit.libreoffice.org/63923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove unused PROT valuesNoel Grandin
Change-Id: I2a0962c68e23722370ce36ce35e8cb86a3b7a7fb Reviewed-on: https://gerrit.libreoffice.org/63922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove unused VarHeight from Css1FrameSizeNoel Grandin
Change-Id: I3ac901a6eaa733a0a8b85a9e8ed8b71ff6ff8f96 Reviewed-on: https://gerrit.libreoffice.org/63921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24remove unused SwInsertNumTypesNoel Grandin
Change-Id: Iede167882414e77f54218e8458f5315c1e16f245 Reviewed-on: https://gerrit.libreoffice.org/63912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23tdf#121401 add can_focus to tabbsandreas kainz
Change-Id: I5e4b3559bdb642a3e0d8a44ad744efe65b684e59 Reviewed-on: https://gerrit.libreoffice.org/63859 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23Unit test for 0853b05b1fabb231a7d57d811c5a06ee542d3295Thorsten Behrens
Change-Id: Iea6554448f7a3fcc621eac7248abcee9c4285688 Related: i#117783 and tdf#38443 Reviewed-on: https://gerrit.libreoffice.org/58687 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23Related: tdf#118764 last of the GtkButtons with can-focus FalseCaolán McNamara
Change-Id: I8001d8c6c950e74df0f909e1cebfb3d1e52a84a4 Reviewed-on: https://gerrit.libreoffice.org/63846 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23sw: new unit test for XTextCursorVasily Melenchuk
Change-Id: I5b70f6dc8f7399be78daefa95d6d98687d99ec18 Reviewed-on: https://gerrit.libreoffice.org/61098 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new testcase for XTextVasily Melenchuk
Change-Id: I8c4b89e1e0851e808daa0902f970f967c6d057a9 Reviewed-on: https://gerrit.libreoffice.org/61348 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new testcase for XTextRangeVasily Melenchuk
Change-Id: Ia476f4f001851d0f8b51fca62b5c041b1d866cc3 Reviewed-on: https://gerrit.libreoffice.org/61174 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: fixup XAutoTextContainer testThorsten Behrens
This is a follow-up to 4967d498c486800b72ba34192c82c232bc0685bd and avoids to have setup errors making these tests silently pass. Also cleanup code a bit & share common init sequence. Change-Id: I043447a28f5e2c9f416aa906135030c07b2cacc8 Reviewed-on: https://gerrit.libreoffice.org/63800 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new unit test for XAutoTextGroupSerge Krot
Change-Id: I3928248b73025f304c0e1ef7b5f86349df9a3c8d Reviewed-on: https://gerrit.libreoffice.org/61267 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22weld SwFramePageCaolán McNamara
Change-Id: I12f868611860867df26bd29474aa19189c2b9a96 Reviewed-on: https://gerrit.libreoffice.org/63818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22coverity#1441484 Logically dead codeCaolán McNamara
Change-Id: I42a97ccb5cae95f57a03faf210af362a2874fcb1 Reviewed-on: https://gerrit.libreoffice.org/63809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwFrameURLPageCaolán McNamara
Change-Id: If189c6bbc11f85a47e3908e4ffcef36344ff8f9d Reviewed-on: https://gerrit.libreoffice.org/63819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#120426 save the style names when set or changedCaolán McNamara
instead of waiting until gaining focus of the listbox, because of the differences in what that focus means in the different backends. It was an odd way to do things anyway. Change-Id: I072e3da04db184b49a86a9888080b60223813729 Reviewed-on: https://gerrit.libreoffice.org/63820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22--enable-dbgutil --disable-assert-always-abort fixesStephan Bergmann
...which <https://ci.libreoffice.org/job/lo_tb_random_config_linux/> occasionally stumbles across; plus some related loplugin:staticmethods fixes Change-Id: If6998c302cfbabfcad626d9c68d94d3368548a41 Reviewed-on: https://gerrit.libreoffice.org/63808 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22Avoid busy-loop related to layout when dragging objects.Michael Meeks
Change-Id: I4fb437356bc154cfefc5958592ae5888e24d59c3 Reviewed-on: https://gerrit.libreoffice.org/63804 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-22tdf#121597 DOCX: don't export empty paragraphs at tracked deletionLászló Németh
of non-empty multiple paragraphs. Complete the fix for "tdf#115521 DOCX export: keep empty paragraphs in tracked deletion" in commit 2cdc870a7ee82d0faf35cdb5b2bf4e687cfd2b8d Change-Id: Ic3446e2a2118e604a7a4d269c8fed1f9f157846f Reviewed-on: https://gerrit.libreoffice.org/63731 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-22tdf#120703 PVS: V637 rename inconsistent < and == operatorsCaolán McNamara
i.e. lets not have... if (a == b) { if (a < b) } Change-Id: I8ffb8a1e591cbd5f9bf24fbef497660700ed47b0 Reviewed-on: https://gerrit.libreoffice.org/63802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#121607 defer other requests until password dialog is dismissedCaolán McNamara
Change-Id: I82b308f482cc5eb40a00afd01a6848afc3fb8ab1 Reviewed-on: https://gerrit.libreoffice.org/63793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22Resolves: tdf#121607 set parent for password dialogsCaolán McNamara
Change-Id: I02210a61d103aed4a181b0e907ea2fd141e5f587 Reviewed-on: https://gerrit.libreoffice.org/63787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#120703 PVS: V765 simplfy assignmentCaolán McNamara
Change-Id: I4cf55dfd0a4b4684b6e8fed2c36a8e79bbf138c1 Reviewed-on: https://gerrit.libreoffice.org/63799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22sw: new unit test for XCloseableSerge Krot
Change-Id: I1c89abffcc985d6f5b2e0f570fcb82601d923b5e Reviewed-on: https://gerrit.libreoffice.org/61091 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22improve function-local statics in swNoel Grandin
Change-Id: I36b0e9b2819a442f01182f551dbc2bf7d5c878f4 Reviewed-on: https://gerrit.libreoffice.org/63788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22convert SwTableAutoFormat::UpdateFlags to scoped enumNoel Grandin
and remove unused UPDATE_ALL Change-Id: Ib8f21dcddec66947fff8e9cda63f10711da02883 Reviewed-on: https://gerrit.libreoffice.org/63748 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22remove unused PAGESIDE enumNoel Grandin
Change-Id: I45185865ec0645040b129885beb97bebafefe70a Reviewed-on: https://gerrit.libreoffice.org/63747 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22remove unused enum AutoFormatLineNoel Grandin
Change-Id: I8e39be5a5f2306121358eaaf07bb026c2f577bf3 Reviewed-on: https://gerrit.libreoffice.org/63744 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22convert JumpToMarks to scoped enumNoel Grandin
and remove unused JUMPTO_FRAME Change-Id: Ic12350c66612a7be5f930d1cddd0481b397f3c53 Reviewed-on: https://gerrit.libreoffice.org/63746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22remove unused ColTopBig/ColTopSmallNoel Grandin
There once was code to implement this, mapped to KEY_UP/KEY_DOWN in combination with KEY_MOD2 | KEY_SHIFT introduced in commit aa5a224ede8bb040382d8bbfcd939c47f08e9fe8 Date: Thu Sep 27 10:40:19 2007 +0000 INTEGRATION: CWS swwarnings (1.140.102); FILE MERGED but it was commented out and removed in commit 43a36b36986dd2112fc90340e7a8a11ea5369def Date: Mon Nov 1 02:50:47 2010 +0200 Commented out code, bogus comments removed, some german comments translated. Change-Id: I67c1d1ed96b18d3bb8b20eae5994b476b07af31d Reviewed-on: https://gerrit.libreoffice.org/63745 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22convert FieldDialogPressedButton to scoped enumNoel Grandin
and removed unused EDIT Change-Id: I1bd4ac135f280e19ffbf51364f406f8068130874 Reviewed-on: https://gerrit.libreoffice.org/63743 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21add TreeView header supportCaolán McNamara
Change-Id: If3dd296e962b08120e07c35065bc18441691b7fd Reviewed-on: https://gerrit.libreoffice.org/63730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld writer char style dialogCaolán McNamara
Change-Id: Iaa61260e3d59dad782b32304aabe4e2d25069559 Reviewed-on: https://gerrit.libreoffice.org/63716 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld writer parastyle dialogCaolán McNamara
Change-Id: Id377af704ad9b0df90d6a494cc738fa2f62e4525 Reviewed-on: https://gerrit.libreoffice.org/61218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld SwCondCollPageCaolán McNamara
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21loplugin:redundantfcast improvementsNoel Grandin
check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-22 18:53:24 +0000