summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-04-30-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I8f5a09be47876496bce118c29ffe58b62d71b67a
2018-04-29sw: more fine-granular python testslinus
- cleanup unnecessary stuff - split tests up into smaller bits, so test failures give better error reporting Change-Id: I0a7d36c7c7afa574141c88bfe344024324969596 Co-authored-by: janniklas.weghorn@gmail.com Reviewed-on: https://gerrit.libreoffice.org/53586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-04-29Avoid getTokenCountMatteo Casalin
Change-Id: Iad8a623a219b1e6158a1ec447bdc7853817d2086
2018-04-29Avoid getTokenCountMatteo Casalin
Change-Id: Idf94fa126580623c879023b04a2d9cbe54679b21
2018-04-29Avoid OUString temporaries and bail out earlyMatteo Casalin
Change-Id: Ic4c1b2ce68ba992744bd68dece0afc417c22e5cd
2018-04-29Avoid comphelper::string::getTokenCount()Matteo Casalin
Change-Id: I6bc5740d9e2115a09b1b096f120ab3ae19e30d66
2018-04-29Use getToken with start positionMatteo Casalin
Change-Id: I6c8d928f7b5f0e8abaa2ce2d71096ed2ec666911
2018-04-29weld SwNumNamesDlgCaolán McNamara
Change-Id: Ife0b7b7c996a5764040a33991cf83ba7e28a6e40 Reviewed-on: https://gerrit.libreoffice.org/53611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-29flip numberingnamedialog action area orientation to standardCaolán McNamara
Change-Id: I682ff6b50244bda9ba148ffe48dd26e2ff69cb0e Reviewed-on: https://gerrit.libreoffice.org/53610 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-29weld SwFootNoteOptionDlgCaolán McNamara
Change-Id: I00713527deab7f8cb9f137c35db7d28c5a896171 Reviewed-on: https://gerrit.libreoffice.org/53609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-29weld SwEndNoteOptionPageCaolán McNamara
Change-Id: I2313352a66b088a4198ac8a96d2fd218bb2176fd Reviewed-on: https://gerrit.libreoffice.org/53608 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-29tdf#117311 Ctrl/Shift+Insert do not work in Writer commentsMaxim Monastirsky
Change-Id: Ide4f3c57f67107995a90dff965a53324c052f715 Reviewed-on: https://gerrit.libreoffice.org/53619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-04-29tdf#117063 Modify tree list double click behavior in the navigatorJim Raykowski
Change-Id: I369a7a2075aabd3574bdda39dac74e2b132f6923 Reviewed-on: https://gerrit.libreoffice.org/53074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-28weld SwEnvDlgCaolán McNamara
Change-Id: Ib92f790030ca6fbf64273cf45c710b2f698f45a4 Reviewed-on: https://gerrit.libreoffice.org/53569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-28sw: add frame size & content logging to dbg_layManfred Blume
Change-Id: Ibc4f3dbfb9f6a4ad182185deac71d5fd31d5597f Reviewed-on: https://gerrit.libreoffice.org/43926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-28loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I84868b3115c534a8240394283cc3beedf8cb3a80 Reviewed-on: https://gerrit.libreoffice.org/53543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-28tdf#106062 ww8import: skip fake tab only on hanging indentJustin Luth
Export has changed, so that it only exports a tab when the footnote paragraph has a hanging indent. Adjusting the import code to match that change. Please test with MSO before flagging this patch as a regression. Certainly there will be some documents previously saved by LO which will now, in LO, show an extra tab character after the footnote. Any previously saved document without a hanging indent will display this extra tab. However, MSO has always seen that extra tab, so these patches are enhancing compatibility. Change-Id: Id074ca0f3246eaee9807b907757cbeb6f1bbe7b4 Reviewed-on: https://gerrit.libreoffice.org/52173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-04-28[API CHANGE] deprecate and revert GraphicURL prop. NumberingLevelTomaž Vajngerl
This deprecates the GraphicURL properties for NumberingLevel used for bullet graphic. It also makes the proeprty work again, but only setting it is supported. Change-Id: I7727918677514b4846fd271ba606a0255bf9fe1b Reviewed-on: https://gerrit.libreoffice.org/53458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-27ofz#8038 defer subdocument redlining to end of parse like main documentCaolán McNamara
Change-Id: Ibdec7e5f9cee45ba11fc0e3aabcc46bb5da54c2c Reviewed-on: https://gerrit.libreoffice.org/53567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-27weld pages of the insert envelope dialogCaolán McNamara
SwEnvPrtPage, SwEnvFormatPage, SwEnvPage Change-Id: I76b0298994fcd663c0b415ae6e29af054a335bbf Reviewed-on: https://gerrit.libreoffice.org/53503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-27Remove remaining references to xsec_xmlsec.windowsMiklos Vajna
Change-Id: I08f1d0c105f4cb17dcf0c5949326e35f9fa7622c Reviewed-on: https://gerrit.libreoffice.org/53560 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-27use SwFrameDeleteGuardCaolán McNamara
Change-Id: I40970d1f4ece49e2b9faa0a534ae1d85358591b3 Reviewed-on: https://gerrit.libreoffice.org/53554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-27restore and deprecate FillBitmapURLTomaž Vajngerl
FillBitmapURL was restored so when setting the property, it loads the Bitmap from the provided URL and creates a XBitmap. Get is not supported anymore however. Change-Id: Ie250d9f751ba33fc45b759dd3a773b4ec5c864d3 Reviewed-on: https://gerrit.libreoffice.org/53443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-27loplugin:constantparamNoel Grandin
Change-Id: I966dcf87be021520e7cc394338b9c0574bb8afee Reviewed-on: https://gerrit.libreoffice.org/53541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-27weld SwLabDlgCaolán McNamara
Change-Id: I55c543776c03b1d1da0331552b98e6e281e35937 Reviewed-on: https://gerrit.libreoffice.org/53488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-27convert auto correct flags to scoped enumNoel Grandin
Change-Id: I73356493d97bb4f0d5b7db8b5c742837d7a4c78b Reviewed-on: https://gerrit.libreoffice.org/53505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-26Use async dialog path for format columns.Michael Meeks
Change-Id: I7097abd68b5921697d1d5f39f5e81ac961b61226 Reviewed-on: https://gerrit.libreoffice.org/53537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-04-26tdf#117129 ww8import: prevent divide-by-zeroJustin Luth
Before commit ffc3358515799057e72379b76a1165c6ea5a9bd1 for tdf#75539, the divisor was hard-coded at 1000. The preceeding code also notes that an undefined relativeWidth is forced to 1000. So, on an invalid divisor, revert to previous behaviour. Change-Id: I40210194eec39682d9ab3ce68268d343af16e2b1 Reviewed-on: https://gerrit.libreoffice.org/53308 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-04-26[API CHANGE] deprecate XGraphicObjectResolverTomaž Vajngerl
XGraphicObjectResolver was used to get the GraphicObject URL from an storage (package) URL. This isn't possible anymore in LO 6.1 since creating GraphicObject from uniqueID was removed for its lifecycle issues. XGraphicObjectResolver is now deprecated and when the "resolveGraphicObjectURL" is called, it throws a RuntimeExeption. In places where XGraphicObjectResolver was used, we now use the XGraphicStorageHandler as the alternative. Both share a common implementation so previously we could cast one to the other at any time. Now only XGraphicStorageHandler is used. GraphicObjectResolver was removed and replaced by the alternative GraphicStorageHandler for instance creation - where needed. Change-Id: I5d3f759c6f95b7dbe2d93688d99c8aa4899ffa84 Reviewed-on: https://gerrit.libreoffice.org/53279 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-26tdf#115600 Display messages in FindBar for Section navigationJim Raykowski
...and make Section navigation wrap Change-Id: I3af8ba9ac1b3177f5aaf54628976c14a63a1685e Reviewed-on: https://gerrit.libreoffice.org/53275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-26tdf#115600 Display messages in FindBar for Bookmark navigationJim Raykowski
...and make Bookmark navigation wrap Change-Id: I3cba18e37c4887ad68d358c10ebb9c9ff592f6ad Reviewed-on: https://gerrit.libreoffice.org/53370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-26weld SwPrivateDataPageCaolán McNamara
Change-Id: Ib52ea1714f807015087c0094844817f7561cb5c3 Reviewed-on: https://gerrit.libreoffice.org/53487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26wrong spin suffixCaolán McNamara
so the value allowed range is incorrect, glade adds a 1 if the id is duplicated, so I guess the name was copy and pasted and then the prefix renamed, leaving the incorrect 1 in the suffix Change-Id: If53790e49bc15e2a10d8ce5b9045eb6be0c25754 Reviewed-on: https://gerrit.libreoffice.org/53502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26weld SwBusinessDataPageCaolán McNamara
Change-Id: I722158b811d69cffc2daa01a6507479e3bc66a92 Reviewed-on: https://gerrit.libreoffice.org/53486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26weld SwLabPageCaolán McNamara
Change-Id: I98abbf67470fdd7be43680b02261f207a101d31c Reviewed-on: https://gerrit.libreoffice.org/53485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26tdf#117246 RTF import: don't loose page breaks inside nested groupsMiklos Vajna
Regression from e3f254ab8211fbab7541cde2100a35c875b0c240 (RTF import: fix spurious page breaks at doc end (related: rhbz#1065629), 2014-02-27), the problem was that now we update the parser state to remember the next section break should set the break type of the current section to "next page", but this state should be remembered once the RTF group ends ("}" character), otherwise \page will be represented with a continuous break, i.e. lost. Change-Id: I69a8413f45e17e11d6d676c7bfd13ca7560b4d43 Reviewed-on: https://gerrit.libreoffice.org/53498 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-26convert tabopts to scoped enumNoel Grandin
Change-Id: I6c9290e3319d2afd1bd71847091c7ab77b8ea6e6 Reviewed-on: https://gerrit.libreoffice.org/53497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-26weld SwLabPreviewCaolán McNamara
Change-Id: I710eacd28f3b6c38890145cf82eeca8bec6ae1f6 Reviewed-on: https://gerrit.libreoffice.org/53328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-26tdf#115344 - bring back Format > Columns in WriterCor Nouws
Change-Id: I4bcfd72deb6e317e70118bfad066221caa42e4e1 Reviewed-on: https://gerrit.libreoffice.org/53217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-26tdf#117221 - MailMerge: Not recognising outgoing SMTP Server passwordAlex McMurchy1917
when supplied by macro After testing the pointer m_sOutServerPassword it incorrectly assignes the value from m_sInServerPassword. This change fixes this issue. Change-Id: I868da1891af4d479c7dd4371297017a78248187f Reviewed-on: https://gerrit.libreoffice.org/53438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-26SwEditShell functions that really want to return boolNoel Grandin
but just couldn't, because they were too shy, so they went to ToastMasters, and now they are all grown up and can bool all the day long Change-Id: Id06e0791ec3c930be8a165cc7b05ce4f0c8f7499 Reviewed-on: https://gerrit.libreoffice.org/53462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-26set current frame as default SfxRequest dialog parentCaolán McNamara
Change-Id: Ib7986ef786af3b5dd7fcad355976ee33705d3112 Reviewed-on: https://gerrit.libreoffice.org/53483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-25weld SwLabPrtPageCaolán McNamara
Change-Id: I64ae3826298ad210ec095256e4364b607684abca Reviewed-on: https://gerrit.libreoffice.org/53327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-25SwVisitingCardPage is now unusedCaolán McNamara
Change-Id: I0d9d3cbcbc9c3e6019dbd220a42c0a18fdd1ca67 Reviewed-on: https://gerrit.libreoffice.org/53442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-25we add and remove this tab page just to get its tab nameCaolán McNamara
Change-Id: Iac48d1c3137cb898a81e5f01442d26a7a81979f0 Reviewed-on: https://gerrit.libreoffice.org/53441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-25no users of the numeric SetCurPageId leftCaolán McNamara
Change-Id: I0bf708b9924fa006da801483e178e18430b9443a Reviewed-on: https://gerrit.libreoffice.org/53440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-25tdf#42949 Remove unnecessary localization headers of svxGabor Kelemen
Found by searching for the header names and the localization functions: git grep -l -e \<svx/dialmgr.hxx\> -e \<svx/strings.hrc\> -e svdglob.hxx | xargs grep -c -e SvxResId -e SvxResLocale -e ImpGetResStr | grep :0$ | grep -v /pch Change-Id: I45c979589165086288030031e713d536005a9833 Reviewed-on: https://gerrit.libreoffice.org/53241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-25sw: fix remaining IWYU warnings in inc/*.hxxMiklos Vajna
Also check for not needed forward declarations. Change-Id: I92759f3f40d9458fd192665b39b87a78d8b97e5a Reviewed-on: https://gerrit.libreoffice.org/53418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-25SvTabListBox::SetTabs, pass count explicitNoel Grandin
passing count as first element in array, dodgy. Change-Id: I49905b554b3b4d6cc3fa419a36389cd2e5ded463
2018-04-24Put help button on far left of cross-ref dialogOlivier Hallot
Change-Id: I9a8bddebf06688ed7e65eacb680aa2d28ad94c54 Reviewed-on: https://gerrit.libreoffice.org/53220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>