summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2021-02-22uitest: sw: re-enable test to see if it still failsXisco Fauli
it doesn't fail for me, let's see for others. Anyway, I might have an idea how to fix it if it still fails Change-Id: Ie3b60c0e652302df3d2ff0331c3df765934620c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111203 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-22tdf#115853: sw: Add UItestXisco Fauli
Change-Id: Ie7b376a2329751120a30cbf17c29b80f46b87618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111332 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-22sw: prefix members of SwFixPortion, SwFlyPortion, SwGluePortion and ...Miklos Vajna
... SwTabPortion See tdf#94879 for motivation. Change-Id: Ic3918caa922cfd99e361010b44fe9d0c95e28b1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111298 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-21Typo fix: supress -> suppressTor Lillqvist
Change-Id: I72aeaff1bc8ac67253265ea99de91b9b9906e5d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111275 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-02-21Resolves tdf#140511 - UI glitchesHeiko Tietze
Clean-up of nested grids and boxes Change-Id: Iea2aa3d03210c0bbbf15b3eed546795de972b21b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111209 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-20uitest: sw: remove duplicated testXisco Fauli
Not sure why this test was added, but the fix for tdf#49683 already contains a unittest, see 831b712d3da08f0050d2ee92c384ad8e6a2e461c Change-Id: I6c52e075118ba0e438dfdff8b0ca3be94b0dd5bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111227 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-20tdf#122780: sw: Add UItestXisco Fauli
Change-Id: I9cd0c3e25842d69ee34f40ce206c022f86fc9545 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111242 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-20drop some unneeded includesCaolán McNamara
Change-Id: I0fe18c3e535bee2213606b7189778c40403a97ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20missing labels for two menu entries in writer readonly context menuCaolán McNamara
since... commit 45d57a0dba8bb5a92150cc07bdff0b37b3041007 Date: Tue Apr 18 13:13:27 2017 +0100 convert readonly menu to .ui Change-Id: Iaa65fc38be666067a3922e716902c8112da8ddde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20loplugin:refcounting in swNoel
Change-Id: I56f2f5aa4d9105e93f28701b8352d1fb97829ead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20loplugin:refcounting in svlNoel
Change-Id: Iae192caa9d05f71ce02aae966ef1d71232d1a7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19uitest: sw: test insert/remove of custom propertiesXisco Fauli
Change-Id: I6de4c73a79e3a3ae5f9fcd4e6efcf25dc846e880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-19uitest: sw: differentiate the elements in the custompropertieslinesXisco Fauli
Change-Id: Ic61cd1655df2bcd7b89c4dfadcda801b7160253c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111226 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-19add some missing use-underline propertiesCaolán McNamara
Change-Id: Ib6cc06ccb8986e85a09335c3fa06f8c2a50eec2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19update pchesCaolán McNamara
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19foward declare NotebookBarAddonsItem instead of using includeCaolán McNamara
Change-Id: I57e5a8f28a40994b61ab0f554401e4f70c8ffc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19weld inputwinmenuCaolán McNamara
Change-Id: I84995928412ed45b4b91939b8a0b48906bb3c13b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19Related: tdf#140409 scale the menubutton like the other widgetsCaolán McNamara
Change-Id: I6b42ef958dd1625cfef5e48e45c932aef9a5960f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111211 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19rename get_vscroll_width to get_scroll_thicknessCaolán McNamara
and add split customize_scrollbars to form a separate set_scroll_thickness Change-Id: Ia4b1c85d6ae85b0fb7aeb852d3a91b36b63143db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19tdf#140409 Comment text ignoring zoom sizeCaolán McNamara
Change-Id: If48d5c1085cbc86f81ba0c92c8875ef534900c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18tdf#139667 adjust Condition tab dialog for Text Body to "list"Seth Chaiklin
- This dialog referred to "Numbering", but better to refer to "List" because the level can also apply to bullets and graphics. - adjusted tooltip accordingly. Change-Id: I5256be054f44058f44711113a85f3053bfd4c755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111041 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-18tdf#139667 Bullet and Numbering tooltips, use verbs and add missing oneSeth Chaiklin
Change-Id: Id5439fb3820db94c08d9902c859da199127fd339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110791 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-18sw bibliography: make URLs in the bibliography table clickableMiklos Vajna
- Don't reuse the <text:index-entry-link-start> / <text:index-entry-link-end> mechianism from <text:table-of-content-entry-template>, because <text:bibliography-entry-template> doesn't allow this - Use STR_POOLCHR_INET_NORMAL as a char style, so the URL looks clickable - Allow absolute URLs for ToxAuthorityField::AUTH_FIELD_URL (other URLs like ToC are always relative) - Track the new text added by FillText() between the StartNewLink() and CloseLink() to figure out what is the URL to be launched on click Change-Id: I126fa06aecfff783e62b65a548228ff781b62c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111117 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-18adapt to prefixing , even when OSL_DEBUG_LEVEL > 1Tomoyuki Kubota
Change-Id: I5fe9755eaf0cce963fda2dbc2ec27b31d0d7dc52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111045 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-18Move GIF writer from filter module into VCLTomaž Vajngerl
Change-Id: I8db3ca0f7953b44791bda47534220902931fab8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111023 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17tdf#130629: sw: Move UItest to CppUnitTestXisco Fauli
Change-Id: I80f248ec79f5bc04dc370b4c549730392110aaca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111074 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-17tdf#115965 tdf#92622 NoList default in menu,tool,sidebarAnshu
Change-Id: Icbc612b44593c5366f3e7f81112f4013884f3599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108841 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-17sw: document SwTOXAuthorityMiklos Vajna
Even if it derives from a "Tab", it's not a table, just a row in it. Change-Id: I303fdcb8719e61ca790096b8cc342af3ffb28930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-17Avoid crash in online on a document with commentsAron Budea
Crashed on a specific doc with the following backtrace: Thread 1 "kitbroker_001" received signal SIGSEGV, Segmentation fault. 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 71 const SwPostItField* GetPostItField() const { return mpField; } 0 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField() const (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 1 0x00007f4807f0641b in SwXTextDocument::getPostIts(tools::JsonWriter&) (this=0x557e1d985a10, rJsonWriter=...) at /.../libreoffice/sw/source/uibase/uno/unotxdoc.cxx:3337 2 0x00007f4823216534 in getPostIts(LibreOfficeKitDocument*) (pThis=0x557e1d93c890) at /.../libreoffice/desktop/source/lib/init.cxx:3425 ... Change-Id: Ib97fd33fda936cad0c9ed3a29564fc0a49ff20c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110958 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-16Use some more o3tl::convertMike Kaganski
Change-Id: I811a00592c3ac5d8cc551090b847f80fc6673032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110918 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-16Revert "Revert "replace SwClient by SvtListener in SwGrammarContact""Bjoern Michaelsen
- This reverts commit 89d770f9727b9e7eddf933c96771df98082b3efb. - ... and replaces the old Notify() with a simpler check for the Broadcaster. - note however, that the ASAN use-after-free reported in the revert was not reproducable locally even with a hundred runs of unoapi_1, so cant claim to have removed what was not there. The fix is just a guess of what might have happened (namely: that the TextNode was locked on destruction and therefore do not send a RES_OBJECTDYING message). Change-Id: I3ff53d8f8537470573cf06314947d9b23bdf578b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110885 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-02-16tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16sw_ww8export3: missing dependencyXisco Fauli
This unit test fails when called after 'make clean': > make clean > make CppunitTest_sw_ww8export3 ... testdf79553_lineNumbers::Load_Verify_Reload_Verify finished in: 9591ms C:/lo/src/core/sw/qa/extras/ww8export/ww8export3.cxx(149) : error : Assertion Test name: testTdf128501::Load_Verify_Reload_Verify equality assertion failed - Expected: FrameShape - Actual : com.sun.star.drawing.RectangleShape Failures !!! Run: 47 Failure total: 1 Failures: 1 Errors: 0 See https://gerrit.libreoffice.org/c/core/+/107003 Change-Id: I4970529f23ad38cb8cc9f403000ac19b0f79008f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110943 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-15tdf#74367 DOCX: fix page margins imported as border paddingAttila Szűcs
Trying to import non-existing "none" borders of w:pgBorders zeroed page margins, removing their values to border padding. Note: according to OOXML standard 2.6.10. pgBorders (Page Borders), "nil" should be treated the same. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ibbc9375b2f8b3daf7b4bdea84e078676ce588586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110396 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-15sw: prefix members of SwHangingPortion, SwKernPortion, SwTextGuess and ...Miklos Vajna
... SwTmpEndPortion See tdf#94879 for motivation. Change-Id: I36ef3b7abd4b4e1fd7f246ea4373794826c2add4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110893 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-15Missing dependencyMike Kaganski
Fixes "GpgME not installed correctly" at 'make CppunitTest_sw_ww8export2' after 'make clean'. See commit 5b66a038701241e0b9fa3a339acbd74f9ca4cf92. Change-Id: If274b13b7d9328c8e63325b113f5b4d99133e7d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110864 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-15loplugin:referencecasting in swNoel
Change-Id: Ie923fc8baaa26938378407f6e5f3c50b2cea7cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110815 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-15Missing dependencyMike Kaganski
Fixes "GpgME not installed correctly" at 'make CppunitTest_sw_ww8export3' after 'make clean'. See commit 5b66a038701241e0b9fa3a339acbd74f9ca4cf92. Change-Id: I76fef25f95fbe45a21542fecf9f4b9f1c2671981 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110863 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-14Handle system paths and URLs properlyMike Kaganski
Avoids errors like this: make UITest_conditional_format ... Execution time for tdf117899.Tdf117899.test_tdf117899: 9.992 tearDown: calling terminate()... ...done ERROR ====================================================================== ERROR: test_tdf117899 (tdf117899.Tdf117899) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:/lo/src/core/sc/qa/uitest/conditional_format/tdf117899.py", line 64, in test_tdf117899 self.ui_test.load_file('file://' + xFilePath) File "C:\lo\src\core\uitest\uitest\test.py", line 76, in load_file component = desktop.loadComponentFromURL(url, target, 0, tuple()) uitest.test.com.sun.star.lang.IllegalArgumentException: Unsupported URL <file://C:\cygwin64\tmp\tmpfs3x8j2r/tdf117899-temp.ods>: "type detection failed" ---------------------------------------------------------------------- Change-Id: Ifbf62c0aaa72412dc0efca921f59441d09c54d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110882 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-14remove blank linebuseorak
Change-Id: I8f0a6654be335053c6cc1d398765060275feb092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110850 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-14tdf#124176: Use pragma once instead of include guardsBuse Orak
Change-Id: I59db23da3305d68567e09d6d7f23ca762bc75ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110843 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-14Move unit conversion code to o3tl, and unify on that in more placesMike Kaganski
This also allows to easily add more units, both of length and for other unit categories. The conversion for "Line" unit (312 twip) is questionable. Corresponding entries in aImplFactor in vcl/source/control/field.cxx were inconsistent (45/11 in; 10/13 pc; 156/10 pt). They were added without explanation in commit c85db626029fd8a5e0dfcb312937279df32339a0. I haven't found a spec of the unit (https://en.wikipedia.org/wiki/Line_(unit) is not specific). I used the definition based on "by pt", "by mm/100", "by char" (they all were consistent); "by pc" seems inverted; "by twip" was half as much. This accepted conversion makes unit test for tdf#79236 pass. Change-Id: Iae5a21d915fa8e934a1f47f8ba9f6df03b79a9fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110839 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-12tdf#76260 DOCX import: fix slow footnote importLászló Németh
by parsing footnotes.xml only once instead of parsing again and again for every footnotes. This was a serious performance problem for documents with hundreds of footnotes, where the footnote import took minutes instead of seconds. Note: switch off CHECK_NOTMERGED in a debug build to measure realistic speed-up, e.g. with the reported document: 2 min 36 sec -> 22 sec, and not 1 min 40 sec, as with CHECK_NOTMERGED. Revert commit 60dbe21f59a45889c433727d0862c9a4274d94d2 ("tdf#88126: sw_ooxmlexport15: Add unittest"), because it was a fragile table layout test, worked only by accident. Change-Id: I9460442cf0c30f2bc5ff393c947a008ca7bba6df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110811 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-12weld impress annotation windowCaolán McNamara
Change-Id: Idc89f4e382392103d373b6a84edaae10abd56056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-12Release mouse on showing context menuCaolán McNamara
Change-Id: Id94e8ab3bee1dd4629486e5455ac935b59fa56bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110821 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-12cid#1472878 silence Unchecked dynamic_castCaolán McNamara
Change-Id: I5c2661ff6040225d32fcdc32b1e00650f9b4e058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-12tdf#72727: sw_layoutwriter: Add unittestXisco Fauli
Change-Id: I836c4a90e344c6f7fb1c60ac07d9575749adfa9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110803 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-12tdf#40260: sw_layoutwriter: Add unittestXisco Fauli
Change-Id: I9e9820c31735703b1fa8583ada74af47534df186 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110799 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-11tdf#140257: sw: Add UItestXisco Fauli
Change-Id: I4de5287a523c9f1006c8511bc2effe4e6f4e4c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110766 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-11sw tooltip on bibliography fields: add the actual tooltip functionalityMiklos Vajna
- Similar to e.g. SwMacroField::GetMacro(), add a new SwAuthorityField::GetAuthority() that returns a string which is similar to the one-liner text node in the bibliography table for a given bibliography reference. - Base this on the recently added SwAuthorityFieldType::CreateTOXInternational() and SwTOXAuthority::GetText() to share code with sw::ToxTextGenerator::GenerateText() and SwTOXBaseSection::Update(). - Finally extend SwEditWin::RequestHelp() to actually provide the tooltip on mouse hover. Change-Id: I33a58076c6d141566298259e7e4681541fac1055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110765 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-13 12:51:36 +0000