summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-02-27Resolves: tdf#115951 wrong entry selected for numbering posCaolán McNamara
Change-Id: I4e317abb3cfceee2de4826f967a27d14fb3878ef Reviewed-on: https://gerrit.libreoffice.org/50354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27drop old tools/gen.hxx methods in swNoel Grandin
Change-Id: I1db8954b86e9b2ec27ecc1f65e8ff7715612d756 Reviewed-on: https://gerrit.libreoffice.org/50363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27tdf#115715 RTF import: ignore zero para indents in styles without parentsMiklos Vajna
The only reason the DOCX equivalent of the bugdoc was imported correctly is that these default zero margins are simply missing from the DOCX markup, suggesting Word ignores them. We now do the same, this way the stripped down document's 3 paragraphs all have different margins as expected. (Also rework the testTdf112211_2 testcase to test the original problem better: I verified that the layout is unchanged before/after this patch.) Change-Id: I88d56c27c19e070e983c3392f99bca96597cd56e Reviewed-on: https://gerrit.libreoffice.org/50391 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27sw HTML import: allow custom XHTML namespace aliasMiklos Vajna
This helps in case the HTML filter is given an XHTML that has an explicit namespace alias for <http://www.w3.org/1999/xhtml>. Change-Id: I437fa85ba19ce907c9c4b10c8d10aaf2217dc0ea Reviewed-on: https://gerrit.libreoffice.org/50380 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27sw: prefix members of SwScriptField, SwTemplNameField and SwWrongListMiklos Vajna
Change-Id: Ia82df7c6c8260c90f76d77355b70b8589978b9c2 Reviewed-on: https://gerrit.libreoffice.org/50341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-26tdf#114076: Expand ClipRange to next PixelBoundArmin Le Grand
Do this by going to basegfx::B2DRange, adding a single pixel size and using floor/ceil to go to full integer (as needed for pixels). Also need to go back to basegfx::B2DPolyPolygon for the creation of the needed MaskPrimitive2D. The general problem is that Writer is scrolling using blitting the unchanged parts, this forces this part of the scroll to pixel coordinate steps, while the ViewTransformation for paint nowadays has a sub-pixel precision. This results in an offset up to one pixel in radius. To solve this for now, we need to expand to the next outer pixel bound. Hopefully in the future we will someday be able to stay on the full available precision, but this will need a change in the repaint/scroll paradigm. Change-Id: Idb4a596bc298d1b80aab6f36ad4204afe94d54f7 Reviewed-on: https://gerrit.libreoffice.org/50369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-02-26split out GetStandardWarningBoxImageCaolán McNamara
Change-Id: I2c8315c7223adac2d7e0e2aa403db0f865bdc48e Reviewed-on: https://gerrit.libreoffice.org/50377 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26ofz#6571 Integer-overflowCaolán McNamara
Change-Id: If4a0b9532c69a1b3746fab8c727f245cd2e8a131 Reviewed-on: https://gerrit.libreoffice.org/50375 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26Revert "tdf#97361 Tests in sw should be more pythonic"Saurav Chirania
This reverts unnecessary changes in commit 4469c1d4061e8cb463469e60e5d87af5f9bf9636 as suggested in comments at- https://gerrit.libreoffice.org/#/c/49163/ Change-Id: Iad5da22624d7c543177a2271abb58bc4f6f31ecd Reviewed-on: https://gerrit.libreoffice.org/49660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26sw: add props. BackGraphic as replacement for BackGraphicURLTomaž Vajngerl
This adds BackGraphic, HeaderBackGraphic, FooterBackGraphic properties, which are a repalcement for BackGraphicURL and similar properties that will be removed in the future commits. Change-Id: Iff20f2a97342d7c586c933d51614b5e0b54d2da0 Reviewed-on: https://gerrit.libreoffice.org/50338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-26Removed duplicated includesAndrea Gelmini
Change-Id: Ib93cb76a3b667ca96e228d0b59da9f9849850081 Reviewed-on: https://gerrit.libreoffice.org/50330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-26forcepoint #10 pop empty stackCaolán McNamara
Change-Id: I96452a86187a6b03251614625445d1b18a5ee218 Reviewed-on: https://gerrit.libreoffice.org/50357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26use less RGB_COLORDATANoel Grandin
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26sw: Fix build with older boost::optional like 1.54Rico Tzschichholz
Change-Id: I2256a52e2017bfda04b3a2395f82b0aff0aa5b22 Reviewed-on: https://gerrit.libreoffice.org/50343 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-26RES_CHRATR_SHADOW should be SvxShadowItemMike Kaganski
Follow-up for commit 35f5274ece0fcbb70753a71619b526ed0d4cbd6b Change-Id: I7bd2f28565e574a6f0e36bc34959b8ecaf8cc4b1 Reviewed-on: https://gerrit.libreoffice.org/50340 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-26Translate German variable namesJohnny_M
Akt -> Current in prcntfld Change-Id: If9e4ecc36ad89837825b6d2581424d316dd20e30 Reviewed-on: https://gerrit.libreoffice.org/50313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26Translate German variable namesJohnny_M
Akt -> Current in callnk Change-Id: I53506b07c73f4cd663be01f6a224a7fcd8c3ac89 Reviewed-on: https://gerrit.libreoffice.org/50311 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-26nfc: use std::min in fly.cxx:CalcRelJustin Luth
Other parts of CalcRel are already using std::min. It makes it much easier to read when the code is consistent. Change-Id: Ie3b07b96e48843271683cdf6a7dabca16cfab10b Reviewed-on: https://gerrit.libreoffice.org/50035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-26tdf#116020: use actual whichIds in dialogs for character propertiesMike Kaganski
... instead of converting back and forth between character-specific whichIds and generic. This eliminates creating duplicate properties in the set passed to dialog. A temporary GrabBag entry "DialogUseCharAttr" is used to indicate that dialogs should use character-specific Ids. This simplifies and unifies preparation of the set for different dialogs. Change-Id: I41b982ff05d54b0dfc283c07aef806f51c87209c Reviewed-on: https://gerrit.libreoffice.org/50339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-26extend testTextBoxPictureFill - check that the graphic is presentTomaž Vajngerl
Change-Id: Ib7ee52bbbf4bbbd41adcc7c15740b8d13bbe5bfa Reviewed-on: https://gerrit.libreoffice.org/50337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26move MovePoint and MoveRect into Rectangle and PointNoel Grandin
Change-Id: Ie75c7c10288da00aac89479879e0b9fb1a4459b2 Reviewed-on: https://gerrit.libreoffice.org/50247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26ColorData->Color in variousNoel Grandin
Change-Id: I22018b6a535224316d93bfd621771248b873a218 Reviewed-on: https://gerrit.libreoffice.org/50167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25tdf#115329 make navigate by drawing to previous drawing workJim Raykowski
Change-Id: I7d93dc3accd7cc092f068524cb567de74a479343 Reviewed-on: https://gerrit.libreoffice.org/50273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-25tdf#115329 Fix Navigate By Table after Navigate By Drawing or ControlJim Raykowski
Change-Id: I2068d5d9c0ccebc83834d4db5a40225c972829ff Reviewed-on: https://gerrit.libreoffice.org/50315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-25convert remaining InfoBox to weld::MessageDialogCaolán McNamara
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8 Reviewed-on: https://gerrit.libreoffice.org/50205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25uitest for bug tdf#53460Zdeněk Crhonek
Change-Id: I6e1f720bf815ebdcb3eb94d45b5ceb8863f1ddb5 Reviewed-on: https://gerrit.libreoffice.org/50215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25uitest - Writer Asian phonetic guide dialogZdeněk Crhonek
Change-Id: Ied8c5c880e1a6aa77ac478f988d579fa469a86c3 Reviewed-on: https://gerrit.libreoffice.org/50184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25uitest for bug tdf#51352Zdeněk Crhonek
Change-Id: I5ad054c7226c43c60dd0770ff7f7bd7bba34c93d Reviewed-on: https://gerrit.libreoffice.org/50263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25remove "FillBitmapURL" propertyTomaž Vajngerl
Change-Id: Icac13a412ae16e4b367362ca85a37fa29802c68b Reviewed-on: https://gerrit.libreoffice.org/50169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25fix import of graphic bulletsTomaž Vajngerl
When changing to use "GraphicBitmap" property instead of "ImageURL", the import wasn't adapted and there was no test which would warn of such an situation. This also changes the difference between writer and impress where impress used "Graphic" and not "GraphicBitmap" property. Also adds missing tests for both writer and impress Change-Id: Ieed629d2d37f7806d63e729b6ef23cd848593071 Reviewed-on: https://gerrit.libreoffice.org/50140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25convert all help responses to gtk's -11Caolán McNamara
and ok responses to gtk's -5 and cancel responses to gtk's -6 and close responses to gtk's -7 and yes responses to gtk's -8 and no responses to gtk's -9 Change-Id: Ia1a261a3a711ed9f5d8c0b0c639897c3064bb08c Reviewed-on: https://gerrit.libreoffice.org/50206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-24Removed duplicated includesAndrea Gelmini
Change-Id: I04ea7b0e923e903210aef81e9d72e554bbf9e1c9 Reviewed-on: https://gerrit.libreoffice.org/50208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-24Make shell stack more robust against rogue extensionsKatarina Behrens
It shouldn't happen that a view is placed above the shells it has spawned on sfx2 dispatcher's shell stack 'cause during dispose, such view gets deleted before the shells that still refer to it. Alas it does happen with Wollmux (which makes couple of Writer UNO API calls before SwView is activated) so guard against that Change-Id: Ic7f21992c5e55a48c63dffc733c8f5b0a59a9126 Reviewed-on: https://gerrit.libreoffice.org/50256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-24tdf#115880 end drawview text editing on move navigationJim Raykowski
and leave draw mode This fix provides a bonous fix for incorrect behaviour of Table move when a Drawing Object has focus. Change-Id: Id554f4f0bac547e65f47544f116f40f49d4d6135 Reviewed-on: https://gerrit.libreoffice.org/50154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-23tdf#80282 swpagerelsize: corner case frame size maxJustin Luth
Before the swpagerelsize commits, (specifically 7c7fdf3e97bbf2301f9938082d4d44162f4ec3c0), the max size was always Prt(). The regression comes if the RelFrame is a pageFrame (like when the image is anchored to the page). Then sometimes no maximum is set. Change-Id: If1e93ce670bd0908eb2d1f89dabbe9861163d29e Reviewed-on: https://gerrit.libreoffice.org/50034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-23tdf#115883 DOCX import: catch RuntimeException from SwXFrameMiklos Vajna
getPropertyValue("Surround") for a non-inserted frame can throw, but hasPropertyValue("Surround") still returns true. So fix the regression by just catching the exception, assuming that in that case no increased spacing is needed. Change-Id: I49a78ce8d41b4e1cc7d23721d5dc70f7550c94af Reviewed-on: https://gerrit.libreoffice.org/50175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-23lok: Factor out the code for finding vcl::Window of a documentPranav Kant
This should also help with IME input on charts Change-Id: Ie513790a5d0c87397c39301a328a44b59d394a45 Reviewed-on: https://gerrit.libreoffice.org/50091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-22weld native message dialogsCaolán McNamara
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22sw: remove "ReplacementGraphicURL" related thingsTomaž Vajngerl
Change-Id: Ia6892e3cd84b2466ea30828e9b18310789dc1686 Reviewed-on: https://gerrit.libreoffice.org/50138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-22Remove unused forward declarations from vcl/syswin.hxxStephan Bergmann
Change-Id: Ide4990afa32ba4cc7851d0e7d3d8d1247eb27b3b Reviewed-on: https://gerrit.libreoffice.org/50155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22tdf#112689 : Replace chained O(U)StringBuffer::append() with operator+Shubham Verma
Change-Id: I119d33b171da7024daab5c4ca4488ceb495eab2f Reviewed-on: https://gerrit.libreoffice.org/49898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-02-22uitest - writer Watermark dialogZdeněk Crhonek
Change-Id: If701a563ce2ff0e811dfcaae6852ada05c925ce3 Reviewed-on: https://gerrit.libreoffice.org/50126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-22Replace "ReplacementGraphicURL" with "ReplacementGraphic" propertyTomaž Vajngerl
To transport the replacement graphic we use "ReplacementGraphicURL" property, but as it uses an GraphicObject URL it needs to be replaced. The new "ReplacementGraphic" does this with an XGraphic object as instead of the String URL. Change-Id: Iddf01c9aecb2a31a467e7b9d399495e0428d1859 Reviewed-on: https://gerrit.libreoffice.org/49993 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-22sw: clang-format textboxhelperMiklos Vajna
This was more or less consistent before, but the recent automatic rewrites broke consistency, just give up on manual formatting here. Change-Id: Ieb387e3d7230d227e33ba0b420cfa572309c5330 Reviewed-on: https://gerrit.libreoffice.org/50119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcopy extend to ColorNoel Grandin
Change-Id: I224cc955d49ee100d328e0171da710f38068d2d4 Reviewed-on: https://gerrit.libreoffice.org/50114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21forcepoint #3Caolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I5681f9123a21fee100a2eda1e8284e559ede51b4 Reviewed-on: https://gerrit.libreoffice.org/50064 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-21loplugin:changetoolsgen in swNoel Grandin
Change-Id: If07efe4c15cfc28df38a9327856d39313ca78d50 Reviewed-on: https://gerrit.libreoffice.org/50078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>