summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2021-06-22configure: Improve help-options handlingJan-Marek Glogowski
This patch includes: * A README.help.md as a general documentation for the different help types, the LO code and help-related build options. * Adds --disable-xmlhelp for removing the xmlhelp support from the build. Disable for iOS, Android and Emscripten. This was partly included in HAVE_FEATURE_DESKTOP before. * Rename WITH_HELP define to WITH_HELPPACKS, which reflects the actual usage AFAIK. * Depend --with-omindex on --with-help=online and don't override the --with-help setting. Error out on conflicting options. * Depend --with-helppack-integration on build help variants, which actually result in help packs. Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a ("Building without --with-help is not supposed to disable help functionality"). Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-22cid#1486261 Dereference before null checkCaolán McNamara
since... commit 2e6e87decdb87221a7b832958e03195b1d8fc133 Date: Mon Jun 21 13:18:00 2021 +0200 replace dynamic_cast<SwLayoutFrame> with cheaper check Change-Id: I4623e3eca5a82fa37f52697c189310a835fc76e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22cid#1486260 Uncaught exceptionCaolán McNamara
Change-Id: I12613ed381e961fd36348eabd543b11a1960337d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117613 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21gtk4: GtkPicture triggers some sort of unexplained vertical expandCaolán McNamara
an intermediate horizontal GtkBox works to stop the propogation Change-Id: I9fd51c3968c463c7b872b7a12bc3960602d0b025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21create SfxHintId::SwLegacyModify idNoel Grandin
to avoid expensive dynamic_casts in writer Change-Id: Ic73ae7d4af985043f8533913b33939e3445ec7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21related tdf#81705 doc export: eliminate duplicating OutlineNumberingJustin Luth
It just looks redundant. And all three formats handle it very different. RTF - never writes RES_PARATR_OUTLINELEVEL or RES_PARATR_NUMRULE in styles, only via this OutlineNumbering. DOCX does nothing. That's because there always seems to be a RES_PARATR_OUTLINELEVEL and RES_PARATR_NUMRULE. DOC does BOTH. It writes RES_PARATR_NUMRULE (and now also writes RES_PARATR_OUTLINELEVEL) and also writes them via OutlineNumbering. So OutlineNumbering seems to always have been partially redundant and now is fully redundant. Thus it can be treated like DOCX. Change-Id: Ib9fd32c440e0151b462d6499a60952f120887082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113452 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-21replace dynamic_cast<SwCellFrame> with cheaper checkNoel Grandin
Change-Id: I672be703fb097c71303434127d832681843607e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21sw: add BIRT layout test documentMichael Stahl
This nested table is an example that was broken by commit 91b2239783dc716bd71ce7962bfd7e341dfe4175 - if loaded with a wide window, it goes into layout loop; if loaded with a tall window size where page 2 is visible, strangely it doesn't loop. Change-Id: I5e73cfcd928ff1a321667c1a75b0ba7f348d4b77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117587 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-21bundle the FolderPicker instantiations behind a single callCaolán McNamara
in prep to add parent support Change-Id: I2aa4b9343f895ae866f600dd3260b7fdc4e1efec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21replace dynamic_cast<SwFlyFreeFrame> with cheaper checkNoel Grandin
Change-Id: Ia84984e47c60eb8407bbddaf9e3365d9f7f52311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117581 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21replace dynamic_cast<SwLayoutFrame> with cheaper checkNoel Grandin
Change-Id: I2102d27fe2b38e3787e39a2b7234991a57c30d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117578 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21tdf#116501 sw: layout: check for flys in SwTabFrame::ShouldBwdMoved()Michael Stahl
On loading, this hits loop control warn:legacy.osl:580715:580715:sw/source/core/layout/layact.cxx:543: LoopControl_1 in SwLayAction::InternalAction This is because there's a fly frame 404 anchored at the last text frame 353 on page 2 inside the nested table 347. ShouldBwdMoved() sees that there is space on the bottom of page 2 and hence the follow flow row joined, but then it immediately splits again in the same way as before due to the fly with WrapTextMode_NONE. But then the outer table's cell 273 (upper of 347) is invalidated again, hence the loop. Try to check for overlapping flys in SwTabFrame::ShouldBwdMoved() by reusing CalcFlyOffsets(), which is ... not quite ideal, but perhaps better than copy-pasting half of it to a new function. This should have less side effects than the previous fix, but a problem remains that clicking on the shape on bottom of page 2 causes the layout to go wonky, but that was also the case with previous fix. Note there's a check of SwLayouter::DoesRowContainMovedFwdFrame() there already, but that doesn't help because it will only detect when the fly itself was moved forward, but in this case the fly remains on the page. Also likely it wouldn't be a good idea to move a text frame forward if the only thing of it that fits on a page is an anchored fly (i.e. its follow has mnOffset=0) because that can be intentional. Change-Id: I0376f7dcb784c006990336233c97f5093aaccb77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117473 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-21Revert "tdf#116501 fix freezing at embedded text tables"Michael Stahl
This reverts commit 91b2239783dc716bd71ce7962bfd7e341dfe4175. This breaks documents that have many nested tables. For example Eclipse BIRT generates reports with tables nested 8 levels deep, they run into the counter in no time and, ironically, one goes into a layout loop because of this counter. Change-Id: I7451d01787903bbc60b305da3dc72f8259175e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117472 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-21cid#1486007 establish that SwFootnoteFrame::Paste doesn't delete itselfCaolán McNamara
Change-Id: Ifbc1fc73be6824917dfe91811ecb5b58409f042e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117551 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21merge SwList and SwListImpl (tdf#135316 related)Noel Grandin
to reduce allocations when loading large documents Change-Id: I734aec4b22844e999d19f649e8e9cd5949a7cbfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21uitest: guard execute_blocking_actionXisco Fauli
so even if an assert fails, the dialog is closed afterwards for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I9a3adb52546238d960eeaaaf03b6bdbbd5718cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117392 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-21ofz#34898 TimeoutCaolán McNamara
we expect the editengine to be able to select a preexisting range of text to convert into the symbol char, typically range is of length 1 Change-Id: I13f56e716a00e243bf1c578580dc0ba31755e581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21tdf#106541 doc import: always register listLevelJustin Luth
LFO and listLevel are NOT a required pair. The path on the Paragraph side is safe to re-enter. This patch makes the style side safe to re-run with partial information. If we don't register immediately, then a non-existant LFO means that we totally lose the provided listLevel. So just RegisterNumFormat even though it likely will be run again by Read_LFOPosition. Change-Id: Iad10cdd1ff7e6fc0a77b01849b3b157703945556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114400 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-21drawinglayer: put BufferedDecompositionPrimitive2D in its own fileTomaž Vajngerl
And fix includes all over the place... Change-Id: I6e2696bbeeac6ab7467cac70545fa7209aa981a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117528 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-20ofz#34221 avoid OOMCaolán McNamara
Change-Id: I1987d39ea8ff195b397b0ee3fb0e45f9bfbfb572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-20cid#1485150 suppress Uncaught exceptionCaolán McNamara
Change-Id: Ic1b2a44afd15e0720edd48f3502dd2799795551a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117508 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-20cid#1486006 help coverity see that pGlossaries won't be nullCaolán McNamara
Change-Id: I0f0e8e5ac0169090cd1f99c8aa6bf16b1edf8a85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117506 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-20drawinglayer: remove ImplPrimitive2DIDBlock macroTomaž Vajngerl
We can just implement the simple getPrimitive2DID method in all primitives. The ImplPrimitive2DIDBlock macro doesn't save us anything. Change-Id: I02f44d4891d7b340220890bf52a7ebfc8e41850a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117509 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19use more unique_ptr in WW8ExportNoel Grandin
Change-Id: I4fb6f4d42be350df5c1ccc0c87b779224000325d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-19tdf#142404 DOCX c15: handle remaining TabOverSpacing tabsJustin Luth
The previous commit handled the case where a non-first LEFT tab was beyond the text area. But the remaining cases were still being (mis)treated as automatic tabs. We won't worry about the impact where compatibilityMode is less than 15/2013+ since Word is absolutely goofy, and LO doesn't even come close to matching it. But in compat15 mode, the end result of having a non-LEFT tab over the margin effecively means that the text will flow backwards from the right margin, just as if it was a RIGHT tabstop. So treat all of the remaining tabs as a right-tab at the end of the paragraph-area. Change-Id: I43a38516c0639c56341bdba0213ffb4a7d5cbf3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117340 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-19tdf#106541 doc import: inherit style numbering from parentJustin Luth
This patch depends on FOLLOWUP patches. I thought the best way forward is to break the existing unit tests, and then fix them with followup patches. That best proves the validity of each follow-up patch. This patch is especially needed for Chapter Numbering. In LO, Chapter Numbering is treated uniquely with its own special rules that run counter to all other conventions. So special handling is needed to import styles that in MS Word would inherit, but which don't in this special case. Change-Id: I06b737ad96ff73dbd09bef252d09aa42adf2dc76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114401 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-19use more TellEnd()Noel Grandin
which has the potential to be more efficient than STREAM_SEEK_TO_END Change-Id: I64d84632bc4751e07309332c9dff7a02bcd507fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-19indexing: indexing sections for the IndexingExportTomaž Vajngerl
Adds handling of sections to the IndexingExport. SectionNode also derives from StartNode, so we handle it similar as the tables. Change-Id: I5eb8d599bdf680144b161aa93295ea3d360eb5c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117452 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19indexing: write parent index to paragraphs if possibleTomaž Vajngerl
When writing paragraphs from a table we want to associate the parent table to the paragraphs so we also write the parent index. Change-Id: Idf9c285f08481ed0556700e92adda27027b91408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117451 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19indexing: indexing tables for the IndexingExportTomaž Vajngerl
Adds handling of tables to the IndexingExport and also handling of the end node (as table node is also a start node), so we know which paragraphs belong to a table. Change-Id: I624ce12a3e810797a37ae2efe5baa552828f75dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117450 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19indexing: indexing shapes/text boxes for the IndexingExportTomaž Vajngerl
Adds handling of shapes and text boxes to the IndexingExport with exporting the the name, alt text, description and paragraphs of the inner shape text to the indexing xml. Change-Id: I3db68078b7e793cab552b4f7f8e8ddf9bfd1a6f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117359 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19indexing: indexing OLE objects for the IndexingExportTomaž Vajngerl
Adds handling of OLE objects to the IndexingExport with exporting the alt text and the name to the indexing xml. Change-Id: Ie357f55195cda864ee12d6b120babd106eff6179 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117358 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19indexing: indexing graphics for the IndexingExportTomaž Vajngerl
Adds handling of graphics to the IndexingExport with exporting the alt text and the name to the indexing xml. Change-Id: I20344dd04c5da4668c8eafbf1f863a26357ad616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117357 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-19indexing: indexing paragraph text with the ModelTraverserTomaž Vajngerl
This adds the basic paragraph text export for indexing, which uses the new ModelTraverser, which is inspired by AccessibilityCheck (and in the future it will be changed to use the ModelTraverser too, when it matures). ModelTraverser implements traversing through the model and executes a handler for a element of a model (which can be various things). IndexingExport class implements indexing export that uses the ModelTraverser to write into the indexing xml document, that uses the tools::XmlWriter. Change-Id: I7a6a5de332534270fe894a881131e5eb5ea9d881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117356 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-18Simplify some OUString construction in test codeStephan Bergmann
Change-Id: I1891f5e676818b5657b7ee7a7563f217a1af65cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117457 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-18help button should be packed as 'secondary'Caolán McNamara
Change-Id: Ia5f2e0c6c8d818e6d0e80acde2c518da30371eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18resave with latest gladeCaolán McNamara
Change-Id: I4c817f06c69f2442b0b0ecb63d42c87db439751f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117455 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18tdf#142852 forward surrounding-text requests to an active drawing editengineCaolán McNamara
when present. As we do for related CommandEventId::[StartExtTextInput/EndExtTextInput] Change-Id: Ie5b57c8a8a1a258efc2be079a2674b1ca620dc9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117465 Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins
2021-06-18related tdf#140336 docxsdrexport: always clear vmlTextFrame attrsJustin Luth
Blind fix - it just doesn't look right, and caused troubles when making a patch for bug 140336. When the VMLTextFrame is written out, surely the collected attributes for it should be cleared instead of spilling over into the next non-textbox-only VMLTextFrame. I expect the textbox-only frames never have any gradients or SOLID fills, so it has never been a problem yet. Change-Id: I3aa23aadf9ab5a0be54ffbd7ea114f94c48aaddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113206 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-18tdf#109083 sw table styles: fix missing format update of tablesBalazs Santha
at table (cell) selection. Table styles (implemented as table templates yet) allows to format all tables (with the same table style) at once. Unfortunately, this worked only without table selection, putting the text cursor in a table cell. But if a table cell/row/column or the whole table was selected (e.g. after changing its format), Manage Styles(F11)->Table Styles-> Style actions menu (see top-right corner of the pane)-> Update Selected Style updated only the style, but it doesn't propagate the changes to the other tables with the same table style. This patch removes the selection to fix the problem in the same way, as the proposed workaround. Note: this fixes the usage of the user-defined table styles, too (created by Style actions->New Style from Selection). Change-Id: I58d01036d5a11e522407405e9ebc16c2c3c83e9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117079 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-18more 32bit build fixesRene Engelhard
Change-Id: I5906ef714a482afffe40e59e90fd709fe857d3ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117404 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org>
2021-06-18ofz: fix use-after freeCaolán McNamara
https://oss-fuzz-build-logs.storage.googleapis.com/log-380241bb-ed71-4d4a-93d3-00473e186d65.txt since... commit 2bccb7e67b637c6312a0df610f870c8621eb296f Date: Tue Jun 15 09:02:59 2021 +0200 remove some unnecessary LanguageType copies reproducible with: LD_LIBRARY_PATH=`pwd`/instdir/program valgrind instdir/program/fftester ~/demo.html html Invalid read of size 8 at 0x1CC35A38: rtl::OUString::OUString(rtl::OUString const&) (ustring.hxx:191) by 0x1CC60F37: com::sun::star::lang::Locale::Locale(com::sun::star::lang::Locale const&) (Locale.hdl:17) by 0x1CD5AF77: LanguageTag::LanguageTag(LanguageTag const&) (languagetag.hxx:113) ... by 0x1D195944: SwStyleNameMapper::GetChrFormatUINameArray() (DocumentStylePoolManager.cxx:2683) Address 0x261e5d38 is 136 bytes inside a block of size 240 free'd at 0x4843669: operator delete(void*) (vg_replace_malloc.c:802) by 0x4BE7F8C: __gnu_cxx::new_allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> >::deallocate(std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2>*, unsigned long) (new_allocator.h:145) by 0x4BE7F64: std::allocator_traits<std::allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> > >::deallocate(std::allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> >&, std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2>*, unsigned long) (alloc_traits.h:492) by 0x4BE7A43: std::__allocated_ptr<std::allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> > >::~__allocated_ptr() (allocated_ptr.h:73) by 0x4BE7D40: std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2>::_M_destroy() (shared_ptr_base.h:538) by 0x4B0A5D3: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_weak_release() (shared_ptr_base.h:207) by 0x4B105B0: std::__weak_count<(__gnu_cxx::_Lock_policy)2>::operator=(std::__shared_count<(__gnu_cxx::_Lock_policy)2> const&) (shared_ptr_base.h:808) by 0x4BE7FF2: _ZNSt10__weak_ptrI24SvtSysLocaleOptions_ImplLN9__gnu_cxx12_Lock_policyE2EEaSIS0_EENSt9enable_ifIXsr20__sp_compatible_withIPT_PS0_EE5valueERS3_E4typeERKSt12__shared_ptrIS6_LS2_2EE (shared_ptr_base.h:1662) by 0x4BE6EC0: _ZNSt8weak_ptrI24SvtSysLocaleOptions_ImplEaSIS0_EENSt9enable_ifIXsr13is_assignableIRSt10__weak_ptrIS0_LN9__gnu_cxx12_Lock_policyE2EERKSt10shared_ptrIT_EEE5valueERS1_E4typeESD_ (shared_ptr.h:733) by 0x4BE5A64: SvtSysLocaleOptions::SvtSysLocaleOptions() (syslocaleoptions.cxx:544) by 0x4C54323: SvtSysLocale_Impl::SvtSysLocale_Impl() (syslocale.cxx:63) Change-Id: I95dfd56c5d445220918e4bfa9216a72317fd8421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117447 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18tdf#142925 render the button arrow like it used to beCaolán McNamara
in 7.1 Change-Id: Ibbe4b7dd2212d1bc28bad7588672bb37c8259605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18remove translation from SfxStyleFamily to charNoel Grandin
which seems unnecessary and just makes the code harder to read. This goes as far back as the 2001 "initial import" commit Change-Id: If98ce4da15e57ead9714a0796bfd8c182b9ca49a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-18resave with latest gladeCaolán McNamara
Change-Id: Iaf01858e74cecea966da4c81d060419b9d16c3e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117432 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18tdf#127864 - Export custom document properties using utf8 text encodingAndreas Heinisch
Change-Id: Iaca1f9251e87ec199b55888c1ab6421a654d1f9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117071 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-06-18tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Rename ::StateChanged methods using SfxItemState to allow better analysis of SfxItemState/SfxPoolItem usage(s), discussion see tdf#130428 comment 30 Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-18loplugin:finalclasses in swNoel Grandin
Change-Id: I5f228e839e0d5a51ece868b55715b04f0affc28d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17drop the bare set_busy_cursor, the scoped WaitObject is enoughCaolán McNamara
to set it back to its default on leaving the scope Change-Id: I303c201a1830ef24955fe35ad1058d6d88067f4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-17NFC sw PropagateOutlineRule: early exit if no outlineRuleJustin Luth
There is only one outline rule, and we are just getting a pointer to it, so there should be no reason why this is retrieved for every style defined on the system. Just get it right at the beginning, and exit if there is none. Change-Id: I09d122481623dd4667e3f67c5de98164ff106a27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115615 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2025-02-16 11:12:51 +0000