summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2015-07-02Add test for tdf#90808 duplicate CrossRefBookmarksVarun
Change-Id: I4aad0cbb07c07cfcb80bccbbd55d9a26fae88f73 Reviewed-on: https://gerrit.libreoffice.org/16689 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-02Table is actually Table of ContentsOlivier Hallot
Make it also more clear for translators Change-Id: I602ffb17e80c7078be19498d33b609fa3d980902 Reviewed-on: https://gerrit.libreoffice.org/16695 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-07-02crashtest: don't crash on layout of ooo70429-[1|2]Caolán McNamara
Invalid read of size 8 at 0x2DF1B82A: SwFlowFrm::HasFollow() const (flowfrm.hxx:163) by 0x2E3F80BF: CalcContent(SwLayoutFrm*, bool, bool) (fly.cxx:1652) by 0x2E49A960: SwSectionFrm::_CheckClipping(bool, bool) (sectfrm.cxx:1037) Address 0x20c1f978 is 248 bytes inside a block of size 288 free'd by 0x2E497284: SwSectionFrm::~SwSectionFrm() (sectfrm.cxx:153) by 0x2E4B0D1C: SwFrm::DestroyFrm(SwFrm*) (ssfrm.cxx:390) by 0x2E4B1485: SwLayoutFrm::DestroyImpl() (ssfrm.cxx:499) by 0x2E4B0CD3: SwFrm::DestroyFrm(SwFrm*) (ssfrm.cxx:388) by 0x2E4B1485: SwLayoutFrm::DestroyImpl() (ssfrm.cxx:499) by 0x2E454CC6: SwPageFrm::DestroyImpl() (pagechg.cxx:270) by 0x2E4B0CD3: SwFrm::DestroyFrm(SwFrm*) (ssfrm.cxx:388) by 0x2E458237: SwFrm::InsertPage(SwPageFrm*, bool) (pagechg.cxx:1226) by 0x2E49CD8B: SwFrm::GetNextSctLeaf(MakePageType) (sectfrm.cxx:1564) by 0x2E3EB912: SwFrm::GetLeaf(MakePageType, bool) (flowfrm.cxx:785) by 0x2E3EE83E: SwFlowFrm::MoveFwd(bool, bool, bool) (flowfrm.cxx:1840) by 0x2E3D7CF0: SwContentFrm::MakeAll(OutputDevice*) (calcmove.cxx:1171) by 0x2E3D2E8B: SwFrm::PrepareMake(OutputDevice*) (calcmove.cxx:277) by 0x2E4CE31C: SwFrm::Calc(OutputDevice*) const (trvlfrm.cxx:1798) by 0x2E56E174: SwTextFrm::CalcFollow(int) (frmform.cxx:282) by 0x2E56F718: SwTextFrm::_AdjustFollow(SwTextFormatter&, int, int, unsigned char) (frmform.cxx:590) by 0x2E5716D3: SwTextFrm::FormatAdjust(SwTextFormatter&, WidowsAndOrphans&, int, bool) (frmform.cxx:1110) by 0x2E570A6E: SwTextFrm::CalcPreps() (frmform.cxx:892) by 0x2E574163: SwTextFrm::Format(OutputDevice*, SwBorderAttrs const*) (frmform.cxx:1767) by 0x2E3D8E4F: SwContentFrm::MakeAll(OutputDevice*) (calcmove.cxx:1337) by 0x2E3D319F: SwFrm::PrepareMake(OutputDevice*) (calcmove.cxx:340) by 0x2E4CE31C: SwFrm::Calc(OutputDevice*) const (trvlfrm.cxx:1798) by 0x2E3F77B7: CalcContent(SwLayoutFrm*, bool, bool) (fly.cxx:1466) by 0x2E49A960: SwSectionFrm::_CheckClipping(bool, bool) (sectfrm.cxx:1037) Change-Id: I089981eda62bff63782338b5210b78f69b6d5f0b
2015-07-02some other coverity thingsCaolán McNamara
Change-Id: I89ffd2b918f8707cde1b1d015c1ad35ef484b69c
2015-07-02coverity#1309049 Unchecked return valueCaolán McNamara
Change-Id: I2140b14cab6640feb5c09421726a9b4eb97ba27b
2015-07-02coverity#1309050 pLayout might be 0 hereMiklos Vajna
Change-Id: I5756c033e173faaba373c145b15a07e275453643
2015-07-01tdf#86179 inc/dec font is missing in some shellsMaxim Monastirsky
Mostly in Calc, but also for the SwAnnotationShell. Also replace the current code in SwDrawTextShell with a call to EditView::ChangeFontSize. The latter is able to handle text with different sizes out of the box. Change-Id: I4b55da579ea51683140bce0544e481606d7e5f3e Reviewed-on: https://gerrit.libreoffice.org/16658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-06-30sw: remove SwUiWriterTest's empty.odtMichael Stahl
Change-Id: I44e2881bcf1d50fbc4d35802d90ea8ee19b39f3a
2015-06-30sw: fix SwUiWriterTest pointlessly loading an "empty.odt" ...Michael Stahl
... instead of just creating a new document. Change-Id: Ib336c07f6827775a9c1a4fa0b8fbfe4ae0ff8221
2015-06-30Added Test for tdf#69282 copy page style b/w docsVarun
Change-Id: If5960be7b04db418a1a42bd7b661391f65e79498 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-06-30make GetCellPosition a member and visibleBjoern Michaelsen
... to move test code out of production code Change-Id: I8bd38f57faba41a0af3740eda098144d9e49fe15
2015-06-30sw redercontext: fix missing draw of the overlayMiklos Vajna
With this, if e.g. Ctrl-A is hit for a hello-world document, then selection is properly visible. Change-Id: If3fae1e73dc76c50e62f6e1f31d99873636f0e93
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30sw: avoid layout recursion when loading documents with charts...Michael Stahl
... that have a Writer table as data source, such as ooo38798-1.sxw. The problem is that during layouting, the SwWrtShell::CalcAndSetScale() wants to call setVisualAreaSize() on the embedded chart object. This switches the state of the object to RUNNING, which loads it from the file, and during that the ODF filter calls into SwChartDataProvider and that uses a UnoActionRemoveContext; unfortunately that ends all pending Actions, so we get a recursive layout action. Apparently the UnoActionRemoveContext is required to call SwUnoTableCrsr::MakeBoxSels() for old-style tables, which need layout frames for selection?!? Try to avoid the problem by disabling UnoActionRemoveContext in case a new-style table will be selected, which can be done without layout. Change-Id: I097991ffb2e78ddf011db7575f7bb63ae8aa7005
2015-06-30loplugin:vclwidgetsStephan Bergmann
Change-Id: Icebaba828316b0f304ad407dc88d7a45f1f62cba
2015-06-30tdf#92386: Writer crashes in print preview if document in 2 windowsJulien Nabet
2 changes for the 2 following bts First bt: see https://bugs.documentfoundation.org/attachment.cgi?id=116883 Second bt: see https://bugs.documentfoundation.org/attachment.cgi?id=116888 Change-Id: I92ed3b7305bb5b714532f2dcffd615a8337db8b6 Reviewed-on: https://gerrit.libreoffice.org/16557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-30Fix error: chosen constructor is explicit in copy-initializationTor Lillqvist
Clang 3.2 (which is old, yes, I know) complains. Change-Id: Ia3fefd54cd234f14ddaf6159e2512760e4d53c95 Reviewed-on: https://gerrit.libreoffice.org/16613 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-06-30remove spurious line (should fix OSX)Bjoern Michaelsen
Change-Id: If422726f83532430f666ae17f6f71e2ccf5733cb
2015-06-30sw rendercontext: update drawlayer in SwViewShell::PaintMiklos Vajna
Fixes warnings on startup like: warn:legacy.osl:13026:1:svx/source/svdraw/svdpntv.cxx:813: SdrPaintView::UpdateDrawLayersRegion: No SdrPaintWindow (!) when double buffering is enabled for SwEditWin. Change-Id: I3dd8019a158b7d50c5e460abf504da31aabe72c3
2015-06-30SwViewShell::DLPrePaint2: paint to mpOut if isOutputToWindow()Miklos Vajna
With this, most of the SwEditWin is painted to the virtual device in case of double buffering, not directly to the screen (avoids flickering). Change-Id: If93aa082daaec6b0e2c417ebc7367e5ab601aa2c
2015-06-30getCells->GetCells(): not an UNO functionBjoern Michaelsen
Change-Id: I89335201083bd68fa199ce52e78d7750c60f8895
2015-06-30use initializer-listsBjoern Michaelsen
Change-Id: I801bb81a7c241b40377617d8f3567e62b79e3976
2015-06-30now use GetAny() hereBjoern Michaelsen
Change-Id: I23b6f2c53841a4f105d911d72c4d7fe1c077ed82
2015-06-30refactor out SwXCell:GetAny()Bjoern Michaelsen
Change-Id: Ia79bb08fb77bda3de6714b160df7007218ab309a
2015-06-30refactor out getCells() in for chart seqs tooBjoern Michaelsen
Change-Id: I1d18f1b7bdda8d95c2d2dd4256ca05aa0c60d5f4
2015-06-30kill ugly GetDataSequence, now unusedBjoern Michaelsen
Change-Id: Ib72d52c8641b9edfbc534a490fc27d20ff17f349
2015-06-30refactor getTextualDataBjoern Michaelsen
Change-Id: I122a4fb8526af0c3c40e6a6cdacaa11fe531e15f
2015-06-30refactor getNumericalData,Bjoern Michaelsen
- move some functions to be members, were sensible Change-Id: Ie94029f215102c62e96d314809ca78b079f2a6e6
2015-06-30remove one client of getDataSequenceBjoern Michaelsen
Change-Id: Iec8c3653497e213c085242085737dcc5985d70b3
2015-06-30simplifyBjoern Michaelsen
Change-Id: Icaf94870906ba2723de727d06037c343f26e87b8
2015-06-30remove dead codeBjoern Michaelsen
Change-Id: If60fd90f1ffb8a58cc43e4c4a0f80f68b7511937
2015-06-30simplifyBjoern Michaelsen
Change-Id: Ie9313bd8bb391d33e5f86fb86e0874b85594fedf
2015-06-30dont branch on the same conditional twiceBjoern Michaelsen
Change-Id: Icda8e94140d56d71b568ac52feb303bcc861ea31
2015-06-30should there be a size mismatch here, we already wrote out-of-boundsBjoern Michaelsen
Change-Id: I303e93635985fce53aaffc9af89cfa10cecadefb
2015-06-30tdf#92281 - FILEOPEN: Only western font is set for symbols in DOC filesMark Hung
Inserting a symbol in Writer set all fonts including CJK and CTL to the same one. This patch makes the behavior consistent with that, allows CJK and CTL user to see the symbols. Change-Id: I7a61868e8078c81c68e471760f080b3ce7df589f Reviewed-on: https://gerrit.libreoffice.org/16604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-30remove some unnecessary typedefs to pointerNoel Grandin
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-29SwViewShell::ImplEndAction: avoid direct paintMiklos Vajna
Commit 56dd27d9ed829ea0444b3b5932dcd0d431d6e251 (sw: invalidate after keypresses when we have a callback, 2015-01-13) only enabled invalidate-then-paint for the tiled rendering case, because the main loop had no priorities back then. This limitation went away with 48c2815dd20cf20eeec8bb4e003000f4a3d13291 (tdf#91727 - Unwind non-dispatch of idle handlers., 2015-06-10), so it's not a problem to always do this panting inside the Paint() call. Change-Id: I98ddfcc0f20f1553974b74ec3c859dde315612e4 Reviewed-on: https://gerrit.libreoffice.org/16587 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-29SwViewShell::Paint: restore old render context at the endMiklos Vajna
The idea is that mpOut is only used for non-drawing purposes outside Paint(), e.g. to do logic <-> pixel conversion. Change-Id: Ia83cd32dd0a5152dcfc1644e92af08b4ddf4653c Reviewed-on: https://gerrit.libreoffice.org/16584 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-29SwFrm::Calc: use vcl::RenderContextMiklos Vajna
Change-Id: I98de3f5413756c494c677d592ea921155e4c08be
2015-06-29coverity#1308580 Uncaught exceptionCaolán McNamara
Change-Id: I13722acfcdf3d1706c26796c56158c99d3d844ba
2015-06-29coverity#1308430 pSh may be 0 hereMiklos Vajna
Change-Id: I2aaee946bdc5a22cf5a83e1e50714556260280f3
2015-06-29remove custom RTTI from SvxAutoCorrectNoel Grandin
unused Change-Id: I2f4504fdbe88fa83abe6da8a1f733f9ae1c2742d
2015-06-29SwFrm::PrepareMake: use vcl::RenderContextMiklos Vajna
Change-Id: I34306bb1622c79489eb647ed45f398ad2634c144
2015-06-29sw: outline SwFrm::Calc()Miklos Vajna
Change-Id: I9c59116828585c9645bc415ef5fffe65a24d09ee
2015-06-28coverity#1308566 Uncaught exceptionCaolán McNamara
Change-Id: Ib7678784dc822bc84eee0c522c1b2df5de6d6713
2015-06-28coverity#1308534 Uncaught exceptionCaolán McNamara
Change-Id: Ia515fb55486cd5d3bb95ad3dbbb0cc554c0c1547
2015-06-28coverity#1308530 Uncaught exceptionCaolán McNamara
Change-Id: I13616337401c23fb95f83accb9a635204339405e
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28coverity#1308507 Uncaught exceptionCaolán McNamara
Change-Id: I235598d657f778f5e9f87c240eb86745f7f35e8b