summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2022-01-20use resolution independent positions for writer's screen-renderingCaolán McNamara
in favor of pushing it down to the text renderers and leave it to them to optimized as best they can the the rendering to make it look as well as possible. the separate ScrArray can then be dropped as a consequence Change-Id: Ic0849c091a36e1a90453771b1c91b8ff706b679e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128418 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20centralize these GetTextArray usesCaolán McNamara
no logic change intended Change-Id: Ide0a6afc30690d05647acf9bf1a0eccf72a9e60c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128570 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20Revert "can use the glyphcache for this GetTextArray call"Caolán McNamara
nothing wrong with this commit, but there's a an underlying bug in the direction I wanted to go here. This reverts commit 5fc43fe24c24c58e401707fa6fffe9250186b99c. Change-Id: Id670d9331cf41a0d2dcc2a74792c1aa7db4ec284 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20tdf#146294 Fix extended tooltips for Next/Previous buttonsRafael Lima
This patch also adds normal tooltips for the four navigation buttons. The corresponding help page will be updated in a subsequent patch. Change-Id: Ib7d77a643847e417cd66cf872739e39187555df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127950 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20tdf#128375: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I24b862d23d2e8dd9fbe930043457963f4cceec1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128636 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-20tdf#106899 - Import concordance file using appropriate charsetAndreas Heinisch
At the beginning of the import process for the various index entries, try to determine the correct character set for the tox concordance file. Change-Id: I3f48325a80ed08c2c06c295a24b2fc29ce1adf99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128194 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2022-01-19print out a debug warning when we ignore dodgy processingNoel Grandin
Change-Id: I92d758caea3942e6a2fccdf9eb1f8019c5acae14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128614 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-19tdf#139638: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I7b98453b629734b4b07830687d1ec26b4bd468ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111834 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-19sw: generalize ModelToViewHelper to handle all NonTextFieldmarksMichael Stahl
Rename getDropDownsFor() to getNoTextFieldmarksIn(). Move some code so that sw::mark::ExpandFieldmark can expand all fieldmarks that use CH_TXT_ATR_FORMELEMENT. Change-Id: I8a1e28fc0ad77df3a749d9e55c306cb45187a082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128606 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-19tdf#139638 sw_fieldmarkhide: hide fieldmark command in ModelToViewHelperMichael Stahl
The crash happened because the generated ToX text contained CH_TXTATR but the fieldmarks themselves were not copied. Just filter everything except the result of the fieldmark. Change-Id: I349e7793987624e64f5afe08dfa2ca977368156b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128605 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-19sw_fieldmarkhide: disable layout cache if there are fieldmarksMichael Stahl
... similar to the "ShowChanges" check that is already done. This prevents a crash in SwLayoutCache::CompareLayout() on fdo38619-2.ott Change-Id: I1a90c45f041ae18beacd3fbd4dcbdae5ba86c317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128556 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-19crashtesting: use SetTextIdxLen and SetIdxLenCaolán McNamara
as seen on loading e.g. kde112038-2.html Change-Id: I001733d63734d2138740afc74751b170fd268def Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128594 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2022-01-19ofz#43803 Null-dereference READCaolán McNamara
git show -w is your friend Change-Id: I2e451f3df4f093cb801dac0aaa61bc5a69aab0b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128577 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-19sw: fix unexpected paragraph border inside table cellsMiklos Vajna
The bug document has a table cell, which contains a paragraph with borders. Its left/right/bottom borders are rendered in Writer, but not in Word. The reason for the left/right border is that it's outside the paragraph's frame area, which is not rendered in Word. Fix this by clipping the rendered borders so they don't go outside the paragraph's frame area. (Normally the frame area is the larger rectangle, and then margins may cause a smaller "print area", but in this case we have a negative right margin, so clipping the print area to fit into the frame area actually does something.) This is quite similar to what commit 1e21902106cbe57658bed03ed24d4d0863685cfd (tdf#117884: intersect border with paint area of upper frame., 2018-05-26) did for table borders. The bottom border is a different problem: the cell has a fixed height and enough content so the paragraph is cut off vertically. This means that technically the bottom border would be inside the frame area, but Word cuts it off, because they apply clipping on the not-yet-cut-off rectangle. Fix this by dropping the bottom margin when the frame is cut off. Change-Id: I7f65b68997330b247db65839db8a484e74f78c64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128569 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-19CppunitTest_sw_odfexport2: rework to avoid mustTestImportOf()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id6d45cfa011a45b0e8ef9f486498d6a89af8e49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128574 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-18can use the glyphcache for this GetTextArray callCaolán McNamara
Change-Id: Ibe7c7ce788074e0990f3857e97a9ee037484577f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128564 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-18sw: rename Sperren to CharacterSpacing in codeJan-Marek Glogowski
Sperren is a German typography word related to Sperrsatz, which refers to increased space between characters. German UI calls it Zeichenabstand, English one "Character spacing". The English Wikipedia has an alias "tracking", but that seems as obscure as Sperren for most programmers. Change-Id: I2066bccac5e430b9ac2708559a6f2f262f2dea52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128554 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-18this width is always overwritten before being readCaolán McNamara
so drop this unnecessary calculation Change-Id: Ie79674098f947612e7f1f13de351f00d1d3ac41d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-18tdf#146515: sw_ooxmlexport4: Add unittestXisco Fauli
Change-Id: Ib273156124a677fc774340dbd780393dfbd3070b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128548 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-18tdf#145321: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: Id64d3469ed1bd4c38e684c4af0c20121a81043fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128552 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-18tdf#146515 export "Use printer metrics for document formatting" to docxCaolán McNamara
import already works Change-Id: Ia94c6d21ed2abc922a3f450a78dfaf3c331847ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128510 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-18SwNavigator: disallow tracking update when content tree has focusJim Raykowski
When document layout has not finished and there is no content to track at the cursor position, e.g. the cursor position is at the start of a document having text before the first heading paragraph, a selection made in the Navigator content tree can automatically unselect. This is not only annoying but causes a crash when action of a choice from the Navigator context menu is dependent on entry selection, e.g. 'Delete', 'Edit', 'Rename'. This patch prevents this annoyance and crash by disallowing content tracking when the content tree or the content tree context menu has focus. Change-Id: I2b0fd1ac4f53571e30ce1efa2934a70de2aad819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128520 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-17tdf#145321 Crash scrolling DOCX to bottomNoel Grandin
this is a consequence of commit d4dc6b5cfdb02ad00a06ad32650948648abe010d use std::vector for fetching DX array data which made pre-existing bugs easier to see. This crash made apparent that we have bad data ending up in SwDrawTextInfo. So I added some asserts there to catch that. However, that simply made apparent that there are bug(s) at a higher level that I have no idea how to to fix. So at the primary problem site in SwTextCursor::GetModelPositionForViewPoint I clamp the values to sane ones. Change-Id: Ic74f6944932bbfc22e8cf9addf9e7511755b18be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-17sw: prefix members of SwTableFUNC, sw::sidebar::PageFooterPanel, ...Miklos Vajna
... sw::sidebar::PageFormatPanel and sw::sidebar::PageHeaderPanel See tdf#94879 for motivation. Change-Id: I68ac0ba7d36ae9217a98d90245cac104c636fe1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128492 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-17tdf#142450 add code to store showing whitespaceDhiraj Holden
I have put in code to store the option to show whitespace. This option is stored at the document level like the other layout options. Change-Id: I26989da2714f884a5a4d5ced3329ff669771fe7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126497 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-16SwNavigator: use one loop instead of two to fill fields member listJim Raykowski
Change-Id: I02f20e48606a34b2f9f4739f1777dd8aea8637ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127798 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-15Let loplugin:nullptr look into template instantiationsStephan Bergmann
It missed some occurrences of 0 when only looking into uninstantiated template code, as Clang doesn't model them with an ImplicitCastExpr, even if the target is known to be a (dependent) pointer type. Looking into all template instantiations of course carries the risk that a given use of 0 is meant to be interpreted as a pointer in some and as an integer in other instantiations. But the only case where that happened in the current code base is RegistryValueList::getElement (include/registry/registry.hxx), where {} is arguably a better choice anyway. (And which would presumably also hold for any future such cases.) Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-15request the 2nd rect explicitly instead of one with a particular 'top' valueCaolán McNamara
Change-Id: I04caee2263e5e7345fb3fb0c07830d1bf504bf7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15Resolves tdf#139395 - Redesign of font name and effects pagesHeiko Tietze
* Western/CJK/CTL selection placed into a GtkNotebook * Font color and transparency in one line * Alignment adjusted at font effects page * Char-, para- & style dialogs made non-resizable according the guideline Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-15tdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-14make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin
(*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-14sw tests: audit uses of loadAndSave()Miklos Vajna
When it comes to changing import + import-export-import tests to do only import-export instead, this is only safe if we assert the resulting exported XML. Replace calls to loadAndSave() with loadAndReload() when we want to assert the doc model after an export. Thanks to Justin for flagging this, luckily it seems there is only a single test that fails after restoring the lost asserts (and that has already been fixed). Change-Id: I62cd4330c62d801dd9e6c7ef73decab3972c0b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128411 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-14tdf#146375: sw: add UItestXisco Fauli
Change-Id: I8d165b257f4bee3921f1a4624a7797ed22327e40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128419 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-14Restore tdf#134951 docxexport: stop duplicating stuff in postponed textMichael Stahl
Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3 to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported by jluth the test case testfdo79008 that failed was apparently somewhat misleading and the test case testTdf134951_duplicates that should test comments erroneously failed to fail because it is doing a loadAndSave() instead of a loadAndReload(). Change-Id: I7e788287da3b1742f65697ec350997d175db9e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-14tdf#146747 InternalItems has to be null terminatedCaolán McNamara
Change-Id: I15c0afdcae3e9bc1412e6564c15df2196515052e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-14tdf#146605: sw: Add UItestXisco Fauli
Change-Id: I203387db47c3b936ec79bbe951f21bec6c7c26ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128408 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-13tdf#134960: sw: Add test for multi-page viewXisco Fauli
Change-Id: Id3292de4eca6ab72d5116b967a619f78ab96082b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128391 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-13SwNavigator: fix outline delete removes first character of next outlineJim Raykowski
paragraph The to be deleted outline selection may already be to the start of the following outline paragraph as happens when a table is the last content of the to be deleted outline. In this case do not extend the selection right or the first character of the following outline paragraph will be removed. Also check if no selection was made which indicates an empty paragraph and the selection right is needed. Change-Id: I5b2516bd7b1e88ee415986dbe9313f93039dbac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128264 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-13tdf#144862 adjust positioning experimental optionsCaolán McNamara
drop GlyphPositioningMode::ClassicInspired as that just demos the tradeoffs of the original GlyphPositioningMode::Classic vs the chaos of GlyphPositioningMode::PreferReadability where hinting at small sizes pushes the text outside its layout bounds. add GlyphPositioningMode::LayoutAndMatchRender to demo the next option. so: GlyphPositioningMode::Classic This is as it ~always was, using the technique documented at https://wiki.openoffice.org/wiki/Writer/WYSIWYG GlyphPositioningMode::Layout This is just taking the high resolution layout positions, dropping the "Classic" technique and let vcl do its default scaling and rendering of the glyph positions as happens in editeng. GlyphPositioningMode::LayoutAndMatchRender same as Layout, but during text render preserve the scaled glyph positions as floating point positions and pass through to the various platform text renderers configured as best to handle that. Change-Id: Ic37bb8f3cf4472bdc3c48f02b1f9057a0f80cbd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128360 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13tdf#143039 tdf#143106 sw: DOCX export: don't export duplicate flysMichael Stahl
The problem is that at the end of the paragraph a second call to OutFlys() is made in line 2730 and that causes the duplication; for this call the value FLY_POSTPONED must be returned, not FLY_NONE. (regression from 3eced2d52415abeac266804ab682bee022322a19) Also revert commit deb892628a1501527c8c41b85a65282df95b81b1 because its test fails now as 0 comments are exported; it was apparently another problem introduced by the above commit, and apparently this fix helps for duplication of comments too. Change-Id: Ib9706e4c24db38c15a0170ba2e8f08fba5327f98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128386 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-13sw: fix swapped inner vs outer border for Word-style bottom table bordersMiklos Vajna
This is similar to commit fc04a84f297b78a1049182b6d8cf745f863ffe61 (sw: fix swapped inner vs outer border for Word-style left table borders, 2022-01-11), but that was for vertical borders, this is for horizontal ones. The other difference is that Word mirrors vertical lines, but not horizontal ones. This means that our horizontal line need less mirroring, while our vertical lines needed more mirroring. Change-Id: Iff07adac5c53420673139d5c93ce52f6148fb977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128383 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-13fix up label mnemonics in writer view options pageCaolán McNamara
Change-Id: I8acf5421c7e986a15a759f7b4c203d3c844b77f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-12Fix typosAndrea Gelmini
Change-Id: I38ca4904f28a67236b546ff267ab17ba4bfe42fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128352 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-12tdf#144270 sw: manage tracked table (row) deletion/insertionLászló Németh
in Manage Changes dialog window, where deleted/inserted tables and table rows were shown as multiple cell changes, as a regression. Now a single table deletion/insertion or deleted/inserted consecutive table rows are shown with a single tree item in the dialog window instead of showing multiple cell changes. Add new Action icons to the tracked table row insertion/deletion tree items (re-using table row deletion/insertion icons). Show cell changes as children of the single parent item tracked table row change. Accept/Reject and Accept/Reject All support 1-click acceptance or rejection of table (row) changes, instead of clicking on all cell changes of a single table (row) deletion/insertion. Regression from commit c4cf85766453982f1aa94a7f2cb22af19ed100be "sw: fix crash due to redlines on tables on ooo121112-2.docx". Change-Id: Id03a8075cc6849b70a8d32e1a955b79e7d3a3246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128314 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-12gbuild: build static LO / link static executablesJan-Marek Glogowski
This allows to build a complete static LibreOffice on Linux, except for linked externals. Since LO's static build implies disabled dynamic loading, one must select one VCL backend to be compiled in. See the (large) comment in solenv/gbuild/static.mk trying to explain, why this implementation was chosen (spoiler: seems there is no other way) and what is actually implemented. This will collect all libraries, statics and externals of executables. If the executable uses components, it will get linked to all static components. While it works with any Executable, it just makes sense for soffice.bin, because the static component map sucks every dependency in, bloating most other binaries. In theory on could generate the dependencies based on the list of used components (see gb_CppunitTest_use_components), then generate a specific static constructor map, directly include it in the exe's cxx code and then link the minimal dependencies. The static LO should build on Linux with: --enable-customtarget-components --disable-dynamic-loading Tested VCL plugin config is: --disable-gtk3 --disable-gen --enable-qt5 The partial build support is split into a 2nd patch. Change-Id: Iafc95752fae9e88095f54a21f1e30a4f080815e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126790 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12CppunitTest_sw_odfexport: rework to avoid preTest()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ie7187c7a843a191475688a4a6390514199c6a1c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128298 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-12Fix typosAndrea Gelmini
Change-Id: Ib132f2582fce1fb62755926d3f55987ea474ec74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128297 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-11sw: fix swapped inner vs outer border for Word-style left table bordersMiklos Vajna
The minimal DOCX bugdoc has a single cell, the left border style is thinThickMediumGap, the right border style is thickThinMediumGap, which means the doc model already has the left/right mirroring, don't have to do it at layout time. The normal Writer way is to have a single border style and mirror the right/bottom border line. But then looking at the Writer vs Word output, inner vs outer is swapped, so at the end we have to mirror the left border line for Word-style table borders to get compatible output. Change-Id: I10fb95dfac67e466188cfc9ecf35efde806c14b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128289 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-11tdf#146605 sw: try to fix SwSectionFormat notificationsMichael Stahl
SwSectionFormat no longer notifies via its SwModify to SwClient listeners, but only via SvtBroadcaster, so SwSection and SwSectionFrame need to be SvtListeners. This can be seen when changing the footnote-at-end setting in the section dialog, if the SwSection doesn't get the event the footnote numbers aren't adapted to a new restart value, if the SwSectionFrame doesn't get the event the footnote container isn't moved. This is of course not pretty but hopefully it will be refactored further in the future. (regression from commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a) Change-Id: I93c616e209a01fc5d4c8eba701a6ddce5d5b432e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128257 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-01-01 10:23:26 +0000