summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-08RTF filter: add URW testcaseMiklos Vajna
lcov points out this was uncovered previously. Change-Id: I831b7e6c2b475d2b3ddd64fb21714c3b6667832a Reviewed-on: https://gerrit.libreoffice.org/65944 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-08Unfloat: FloatingTableButton -> UnfloatTableButtonTamás Zolnai
It explains better, what this button is. Change-Id: I93b78c7907686179ec4fe6b3f45daa15c846c316 Reviewed-on: https://gerrit.libreoffice.org/65942 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-07tdf#122429/tdf#122431 ww8export: export H/F to default sectionJustin Luth
Just like bug 121374 for DOCX, which was just fixed in LO62, DOC apparently also sometimes can miss out on headers and footers. It wouldn't be terrible to duplicate headers/footers unnecessarily, but it is terrible to have them disappear. If the last SectPr has no idea about the section start, it can't know whether it is continuous or started with a page break. In that case, just ensure that the header and footer are explicitly written out. RTF continues to work without this in all known cases. Change-Id: I93f2b08535a3548c0a9e9bcdb6ee2cd965dc8367 Reviewed-on: https://gerrit.libreoffice.org/65840 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-07Unfloat: Add documentation for new classesTamás Zolnai
Change-Id: Id7c8d5eb7f865db5db82beffe96dab605d8ae36f Reviewed-on: https://gerrit.libreoffice.org/65941 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-07related tdf#100074: prepare group shapes text input via writerfilterThorsten Behrens
Put various preps into place, that enable us to read txbxContent from group shape children via the writerfilter parser, which gets us much more features Also: - store shapecontexthandler on wrapper class in writerfilter - move adding children shapes to ctor, not dtor - remove RuntimeException in Writer's XShapes::add(), aligns this with Draw/Impress API semantics, and helps here when trying to add the same shape a 2nd time (which we then simply ignore) - make oox's Shape notion of 'inside group' less ad-hoc - make SwTextBoxHelper::getTextRectangle() cope with more than CustomShape - so passing in a group shape will also yield some sensible bounding box - have SwTextBoxHelper handle group content, too - derive WpsContext from ShapeContext, so we can later substitute it for that inside WpgContext - keep WpgContext::onCreateContext() _for the moment_ with the old delegation to ShapeContext (needs to use WpsContext to enable writerfilter text input) Change-Id: I2b0f0583e21137f3321a8dc13823058b14d19773 Reviewed-on: https://gerrit.libreoffice.org/65914 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-07Need <vcl/settings.hxx>Tor Lillqvist
Change-Id: I5c6e27d210efad26cfa0f4f67cfc51dfb07f577e
2019-01-07Fix typo and file permissionAndrea Gelmini
Change-Id: I9fe2a1267f05bcf1dd5bb6f1a553a45b14cee079 Reviewed-on: https://gerrit.libreoffice.org/65849 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-07sw: prefix members of SwSmartTagMgr, SwFormatPageDesc and SwTabColsMiklos Vajna
Change-Id: I0bb794f500793f6d248186b683e0adb88b3e5a33 Reviewed-on: https://gerrit.libreoffice.org/65922 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-06sw: DocumentIndexTest - "fix" the commentTomaž Vajngerl
Change-Id: I735a0a4e2c273dcdc271d39ec141ead28d6b0493 Reviewed-on: https://gerrit.libreoffice.org/65910 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-06tdf#82504 writer table cell background color SvxColorItem uno functionJim Raykowski
Current background color function only sets table cell background when multiple table cells are selected. Paragraph background is otherwise set. This gives expected results for use in sidebar Paragraph panel when multiple table cells are not selected but unexpected results when multiple table cells are selected. For background setting from the table tool bar unexpected paragraph background color is set when multiple cells are not selected. This fix creates a table cell background color uno command specific for setting table cell background color. Change-Id: Ic56723b635252415d932c5499f996c3e46eee13b Reviewed-on: https://gerrit.libreoffice.org/65591 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-06tdf#122425: explicitly remove borders for newly created flysMike Kaganski
After commit d398e9248c183cf988b6d985b342b0cbff93ea02, it's necessary to make sure that each created floating object has proper default border and spacing values (empty and 0), to not inherit frame style's non-0 values unintentionally. This fixes two places for objects in headers/footers. Change-Id: I2632bcd4066609c97aa15e39d69e9089ac691ff2 Reviewed-on: https://gerrit.libreoffice.org/65906 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-05Fix typo in method nameAndrea Gelmini
Change-Id: I6d4a0dfa1eed5da0efdac7553d73fc3ae681f5f9 Reviewed-on: https://gerrit.libreoffice.org/65883 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-05Fix typoAndrea Gelmini
Change-Id: I8737a10d0751133cac7d825721dfebd7ca2f2222 Reviewed-on: https://gerrit.libreoffice.org/65881 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-04tdf#122424 RTF import: ignore table row text outside the cellsLászló Németh
instead of extending the next row with them. Change-Id: I09941e977d0036fcea07885ccc7b745d396619c2 Reviewed-on: https://gerrit.libreoffice.org/65852 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-04Unfloat: Test layout change of unfloat operationTamás Zolnai
Change-Id: I75298a392de6a10861ac96e1bc58a30173cd2dd2 Reviewed-on: https://gerrit.libreoffice.org/65823 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-04svtools: expose document position in DocumentToGraphicRendererMiklos Vajna
Writer pages always have an offset inside the root frame, and this is visible in the generated metafile as well. The offset is minimal for a small window and a single page, but the vertical offset increases with every page. Make this information visible, so sfx2 can compensate this. This is somewhat similar to what SfxObjectShell::DoDraw_Impl() does, but that works for the first page only (use case is thumbnail generation), while this is 0 offset for Calc/Impress and a proper offset for all Writer pages. Change-Id: I1075c98faf74f9e77c916572b4d63d40fbd80ab1 Reviewed-on: https://gerrit.libreoffice.org/65850 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-04Removed executable permission on source filesAndrea Gelmini
Change-Id: Icac69c9084d0e7afc8bd371237fa08910231380e Reviewed-on: https://gerrit.libreoffice.org/65845 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-04Unfloat: Disable undoing of unfloat operationTamás Zolnai
I tested to use undo events for unfloat operations: moving a table outside of the text frame and removing the text frame, but sometimes it just crashed. So now we handle unfloating similar to the reverse operation (table is moved into a text frame(MakeFlyAndMove). Change-Id: I4eaeda550ccc51252abd4abde6cee45c76a8483e Reviewed-on: https://gerrit.libreoffice.org/65822 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Jenkins
2019-01-04Unfloat: Implement unfloating of a floating tableTamás Zolnai
Triggered by the unfloat button. Change-Id: I863f0ec481480343c184b0b5fa94b9ba1aa9276c Reviewed-on: https://gerrit.libreoffice.org/65821 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-04Unfloat: Add some tests about the visibility of the unfloat buttonTamás Zolnai
Change-Id: Id0bc6e5be5a55480233afeae44eccac24fa01434 Reviewed-on: https://gerrit.libreoffice.org/65820 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-04Fix up file permissionsTamás Zolnai
Change-Id: Icfc994cec2fff87e79de3d8e38a51b038e817940
2019-01-04Unfloat: Handle unfloat button visibilityTamás Zolnai
We need to update the state of the button every time when the frame's layout changes or when the selection changes. Show the button if the text frame is selected and it's a floating table which would hang out of the actual page after unfloating. Change-Id: I6b64affb063f552921915a0735e80889e5fd8124 Reviewed-on: https://gerrit.libreoffice.org/65819 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-03Unfloat: Introduce Unfloat table button as a frame controlTamás Zolnai
Use the same button style and color what LO uses for header/footer button. Later it might be a good idea to have a separate configurable color for this button, but for now it's seems unneeded to introduce a new configure option for this. Change-Id: Idf86aaa44e29846a2ee211a81fe5376b4335bb05 Reviewed-on: https://gerrit.libreoffice.org/65818 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-03tdf#122442: use Timer to detect single-clicks vs double-clicksMike Kaganski
Regression from commit 821ae0fb9fa63e0171f987d5ec210ec121978b8f which appeared after commits changing scheduler/main loop in the range e6e8a060ecc6e4fd51cfe88e00d841d546ed5915..9b4abcd1c45a646a1ac9120fe1c489ba6bb44e95 Change-Id: I6cf58c1e83aa9621bdd4b5c14f8565d5c69e20c1 Reviewed-on: https://gerrit.libreoffice.org/65837 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-03sw: paragraph-sign: process signatures in one pass on loadingAshod Nakashian
This combines the metadata field restoration logic with validation/update of said field in one pass upon loading docs. This cuts down overheads and makes the code more readable. In addition, now that paragraph signature validation is quite cheap (separate commits), esp. when no signatures exist, we validate and update signatures (where applicable) when fields are updated. Change-Id: I4adcea579c591f9be457ed742d2cf54fa308163d Reviewed-on: https://gerrit.libreoffice.org/63008 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-01-03svm xml dumper: move this from test to vclMiklos Vajna
This is very useful functionality, this way it can be invoked from the debugger and/or nested into an outer xml dump (sw/sd doc model dump) more easily. Change-Id: If6c83b11d0f3e65fcce71e8d820c6bc354f64d68 Reviewed-on: https://gerrit.libreoffice.org/65834 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-03sw: paragraph-sign: avoid re-validating paragraphs when classifyingAshod Nakashian
When setting the classification watermark, every edit to the document is triggering a re-validation of signatures, which is excessive and excessively expensive. Change-Id: I7808877263f553a871f2c31856da1a2f9e50c4bb Reviewed-on: https://gerrit.libreoffice.org/63007 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-01-03sw: paragraph-sign: skip invalid graph namesAshod Nakashian
Change-Id: Iaff61723497466521eddb2333656981f976d3fa6 Reviewed-on: https://gerrit.libreoffice.org/63006 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-01-03Move FindBodyFrame from SwTextFrame to SwFrameTamás Zolnai
So we can call it on other type of frames too. Change-Id: I74e80eb831ba1fc00abb8db1ffa3728758e68376 Reviewed-on: https://gerrit.libreoffice.org/65817 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-03Related: tdf#121664 RTF filter: fix line numbering start value handlingMiklos Vajna
Writer and RTF is 1-based, OOXML is 0-based. So it means we do an offset roundtrip during import, and no offsets are needed on export. Change-Id: I52cf65f268940d1d43ae76e58d0c7e6de3a54073 Reviewed-on: https://gerrit.libreoffice.org/65827 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-02tdf#117480 fix crash in mailmergeSzymon Kłos
Catch exceptions and hide progress dialog. Change-Id: Ie63c8d7e001c90f40cf7504fd8248a6742e9d244 Reviewed-on: https://gerrit.libreoffice.org/65815 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-01-02Remove SwModify/SwClient for UNO BookmarksBjoern Michaelsen
- introduce sw::BroadcastingModify for migration * still receives .SwModify signals * broadcasts those to old SwClients and new SvtListeners * add tests - remove SwClient/SwModify for UNO bookmarks Change-Id: Icefca478472820b93f4bb59e670e59b60eddfe2b Reviewed-on: https://gerrit.libreoffice.org/65806 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-01-02sw: prefix members of SwHashTable, SwSbxValue and SwServerObjectMiklos Vajna
Change-Id: Ibd99ef57d1e80b14e8b2e3ed73dbbab7755a2ea8 Reviewed-on: https://gerrit.libreoffice.org/65802 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-31tdf#64242 unit test addedJustin Luth
TableColumns must be much different from rows, because I couldn't get the properties/width of those, and even MRI just threw a VOID message when trying to getByIndex. So I couldn't do any specific column-width tests, just table-width. Similarly, I couldn't do simple table-height tests. Change-Id: I4c1deaf6a4f6beb7325467ac9940f4328cfc1d44 Reviewed-on: https://gerrit.libreoffice.org/65768 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-31Revert "tdf#70195 docx export: default header/footer at 720"Justin Luth
This reverts LO6.2 commit 7413216e02be9b2f8eb39d550c297021e92ef299 which thought it was only affecting MSWord, but as this unit test shows, it also can affect LO. When we manufacture an empty footnote, then we want the original default of 0. Change-Id: Ibba0d48ee24997c51b81b37c2750960e7a0ab5b5 Reviewed-on: https://gerrit.libreoffice.org/65700 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-31tdf#81782 new unit test: title/subject check in sub docsSerge Krot
Change-Id: I9ff154191feeeed54d3f0549ab16f24ee60015a5 Reviewed-on: https://gerrit.libreoffice.org/65718 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-30tdf#121623 RTF import: keep table in multicolumn sectionLászló Németh
instead of losing columns when the section starts with that table. Change-Id: I1c9d4eb03d24e54600956cb41b835c5e37bfdd8b Reviewed-on: https://gerrit.libreoffice.org/65730 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-12-29tdf#120511 writerfilter: track inserted frame per sectionJustin Luth
The logic using IsTextFrameInserted is worried about whether a frame has been inserted before a table *in this section*, so track frame's existence per section, not per document. Change-Id: I8aa8a695b89727832e65535adae3fc3c94f95be5 Reviewed-on: https://gerrit.libreoffice.org/65720 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-29tdf#113849 ooxmlexport: even headers/footers for both or none.Justin Luth
For DOCX, there is a single setting to indicate the use of even headers/footers. So, if either one of these has a separate even, then create an even for both. In 2017, nBreakCode was used to write an empty footer to prevent inheriting any previously defined footer. So I also removed the obsolete debug. Change-Id: I3ec4a399103679092e6a6ec3a7ae9b1ae303cc3e Reviewed-on: https://gerrit.libreoffice.org/65699 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-29tdf#47471 odfexport: use stylename if autostyle missing.Justin Luth
My guess is the autoStylePool can be invalidated by some events (like clearing all attributes), and if nothing is done that re-creates the autostyle, then Find() returns an empty string. The normal case when all attributes are reset is that since there are no attributes, it doesn't bother looking for the AutoStyle, and just sticks with the given "parent" style. However, some attributes (like lists) aren't reset, and in those cases the autoPool didn't exist, and yet it still looked for something, returning an empty string when nothing was found. If there is a style, but autostyle returns nothing, then it should be safe to always use the given style. There are two more areas with similar coding that I will change in separate commits. (However, note that bug 90221 shows that an empty autostyle might not be exactly like the given style). Change-Id: I6a3d7b1608160f555004ca9cf1c93ec301177288 Reviewed-on: https://gerrit.libreoffice.org/65616 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-28Fix typo in codeAndrea Gelmini
Change-Id: I3a4bfbd84735ddcc8d2d0754973f73a98e06c303 Reviewed-on: https://gerrit.libreoffice.org/65652 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-28NFC sw flowfrm HasParaSpaceAtPages: simplify logic.Justin Luth
double negatives with an AND; that really confuses me. Simply with an equivalent function. There are two reasons to Use the upper value: -it is the first one (no prev) -or there is a pagebreak. is much easier to understand than Use the upper value unless -there is a previous frame -and this one doesn't have a pagebreak. (I can't even review this commit message without getting confused by the original logic.) Change-Id: Iddfbe63b0abcb11f96e323e8a28d0ed335c09133 Reviewed-on: https://gerrit.libreoffice.org/65647 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-27Fix typoAndrea Gelmini
Change-Id: Ic95456c08fa941bd3f4f1b52251c609b3e9efea8 Reviewed-on: https://gerrit.libreoffice.org/65639 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-26sw txtnode: code cleanup - triplicated code -> functionJustin Luth
Since before if an invalid nWhich2 was given, it just checked the value in nWhich1, just set nWhich2 to nWhich1 in that case, which really simplifies the logic. Change-Id: I75f52566aa5260f629398076e817d778e0fd545a Reviewed-on: https://gerrit.libreoffice.org/65599 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-25sw ooxmlimport: landscape <-> portrait ? not a continuous sectionJustin Luth
If one section has a portrait page layout, and the next section has a landscape orientation, then LO cannot consider them to be continuous sections, but a page-break must occur. Change-Id: I4e2229f36919cce4f15ad727378c76480117d7c5 Reviewed-on: https://gerrit.libreoffice.org/65156 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-25sw filter ww8: code cleanup - value already setJustin Luth
Due to a partial revert, the boolean variable is being set to the value it was guaranteed to already be. Change-Id: Iae0e5461a2cc6552e973bd6b46803dc17167380a Reviewed-on: https://gerrit.libreoffice.org/65598 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-12-24Fix CppunitTest_chart2_xshape failing with Display Scaling on WindowsMike Kaganski
See thread starting at https://lists.freedesktop.org/archives/libreoffice/2018-December/081589.html Regression from commit 7263d223ddf42cc39d10a501159c7b04ef48df96. That change has made unit tests DPI-aware; and then some tests started failing on systems with resolutions other than 96 DPI. It has been suggested that the proper fix would be to do for Windows what commit ada20402efa81273e03e46cbedc21f25b9daeeac did for macOS. Another approach would be to fix all the tests to be DPI-aware. I cannot do the first mentioned fix; so I have fixed testFDO74215 test in sw_ooxmlexport4; and added DPI checks to the other failing tests in chart2_xshape and sc_subsequent_filters_test to skip testing when using non-default DPI. This is not ideal, of course, and conditionally skipped tests need to be re-enabled unconditionally once a proper fix arrives. Change-Id: I5c92cfe93ae65f53a8a180fcaec49231df377b8a Reviewed-on: https://gerrit.libreoffice.org/65595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-24tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I5ca32214bab4b26208aecaa98eecc2a6297d9093 Reviewed-on: https://gerrit.libreoffice.org/65592 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-13 17:26:12 +0000