summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2024-07-05fix asan buildNoel Grandin
after commit 85fd526fc681a994415bb422090d1d23aa7d54f6 "fix and simplify the ItemInstanceManager mechanism" The problem is that some *Item classes in sw/ and sc/ share WhichIds, and a whole bunch of SfxBoolItem subclasses share the same SfxItemType enum value. So we ended up mixing and matching objects of different concrete subclasses in a given *ItemManager collection. Add some asserts to the global pool code to catch issues like this earlier on. Add unique value of the SfxItemType enum for all the SfxBoolItem subclasses Change-Id: I3c8d4e02be1cd412b0292e973a6498df5f8e7102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-04cid#1557397 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I9c33fe01e6f48b61df4130b548d9a6c793aa7e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-04cid#1555756 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I07acff7c5e3cba4afa144843bfeb44c99de81ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-03tdf#160817 related: fix tooltip-text translatable context assignmentsJim Raykowski
Fixes copy-paste oversights in commit 94891dce760817686600f3a8d25e5eb735a1a133 Change-Id: Ibe8ea0e7d58ea748ac90732f09af0e5bee0dff45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169892 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-03cid#1607629 Uninitialized scalar fieldCaolán McNamara
Change-Id: Iaaef519741b6cec7aabe0e4b9b58ebe1a858e03e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169926 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-03cid#1606556 Overflowed constantCaolán McNamara
Change-Id: I7748094d226b8201cfbdf43d6ae7df0cd776f9e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169923 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-03tdf#161646 sw page number wizard: fit into existing marginsJustin Luth
Often page numbers are inserted when a document is finished, and at that point it would be annoying to repaginate everything, so offer this option of trying to fit the page number into the existing margins. I was tempted to enable it by default, except that it would then mismatch any pages that had header/footers created via other methods. Problem: -how to know which font is really needed: western, CTL, CJK? This patch depends on NFC b7fce2b26ee4ba585544457adc742807a2129d2c Change-Id: I285a99f8e2f12c87a8bdee20a9c86a1d79f80dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169349 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-07-03cid#1266442 Dereference after null checkCaolán McNamara
Change-Id: I07df88d2593b7887ec87ac4aca1c46c7dfb556cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169919 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-03cid#1555210 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I0a863bc4e9726a4f4ffb348576abd0ae0c812de1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169917 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-03fix and simplify the ItemInstanceManager mechanismNoel Grandin
The mechanism is currently broken because it uses hash values as keys, in two different places. But hash values are not required to be unique, and as soon as there are enough items of a given type, a collision is inevitable. So just simplify this whole mechanism. There is no reason we need type-specific item managers. Stuff everything into a single global pool, that uses hashing correctly. Notes (*) Performance, as far as I can tell, is the same or slightly better. (*) I removed the NUMBER_OF_UNSHARED_INSTANCES thing, in favour of just having a simpler mechanism Change-Id: I9068baf9bf6fae2500ae5748c6d1aabe6c3a18a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169709 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-03disable most of tdf159102 UITest againNoel Grandin
because it fails reliably on my machine and on the ASAN box Change-Id: I4eddbcc04f96837783a41fb30e4d003d11c14aad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169890 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-02sw fmtcol.cxx: fix copy/paste errorJustin Luth
I don't think it makes any functional difference, except that the wrong which ID would be returned. Otherwise they are all identical AFAIK. From commit fcb6e076d9004ef907a2616d04bf9c39908e6e8a Author: Bjoern Michaelsen on Sat Jan 9 21:49:51 2021 +0100 SfxPoolItem: introduce StaticWhichCast and DynamicWhichCast case RES_CHRATR_FONTSIZE: - aFontSizeArr[0] = static_cast<const SvxFontHeightItem*>(pNew); + aFontSizeArr[0] = &pNew->StaticWhichCast(RES_CHRATR_CJK_FONTSIZE); break; case RES_CHRATR_CJK_FONTSIZE: - aFontSizeArr[1] = static_cast<const SvxFontHeightItem*>(pNew); + aFontSizeArr[1] = &pNew->StaticWhichCast(RES_CHRATR_CJK_FONTSIZE); Change-Id: Ie85aacb8d28cadaa509cd9bc050cb9cf98b9967a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169747 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-07-02BootstrapFixture: get rid of mxComponentContextXisco Fauli
Change-Id: I0318485c3c0159277e47096e0c7e0df8ed109ea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169865 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-02cid#1608558 Use of auto that causes a copyCaolán McNamara
Change-Id: Ie09084cdd9060db28905cb693c5b010a760876d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-02cid#1608155 Argument cannot be negativeCaolán McNamara
Change-Id: I60ca191631f3874e2c7f1d037272189db140f25b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169855 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-02tdf#159102 sw: add missing get_url_for_data_file to the unit testLászló Németh
Partial revert of commit 5fa3abd3b28b7c30d015dc058f7719112003f51e "tdf#158803 Remove unused imports from uitest". Follow-up to commit c6d7b7fa686b742c6ffef42aa6cc280358babe0d "tdf#159102 sw: enable unit test again with extended test document". Change-Id: Id6397d322f25f1b3e981d8e206a54bb79a54b831 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169848 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-07-01tdf#159102 sw: enable unit test again with extended test documentLászló Németh
It seems, incomplete document settings resulted broken unit testing on some platforms, so complete the test document with the removed document settings, and enable the test again. This reverts also commit 1b83ebf42c535528b73baac2407b347f19070d07 "disabling UITest tdf159102". Change-Id: I53f008a096aa209fb2c634e7e2464a1a4acbab71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169842 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-07-01tdf#160170 sw: test for fix overshrank lines with hyphenationLászló Németh
Follow-up to commit ca540209a8c20a2734f180d4706d5153bdf64523 "tdf#160170 sw: fix overshrunk justified lines at hyphenation". Change-Id: Ia983e7f560b996f9b11b679d346186ad39e85598 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169840 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-07-01tdf#160817 SwNavigator expose main functions for selected entryJim Raykowski
Replaces the headings/outline move action buttons in the tools area with a toolbar to expose the main functions for the selected entry in the content tree. Change-Id: Iedb5b53375088a159d640fb986bfcf9376fa2072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168174 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-01SwNavigator: Add a function to delete all content of a content typeJim Raykowski
and use it to delete all footnote/endnote content Done in preparation of following patches that provide the ability to delete all content of a content type. Change-Id: Ie329e60033ea10e936049d70c4654f4c6473e55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168173 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-01doc: Don't export notes author/date when in privacy modeSamuel Mehrbrodt
Change-Id: I54459ed5f556f2dbe88d149ea859105db35f1cd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169647 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-07-01doc: Don't export changes author/date when in privacy modeSamuel Mehrbrodt
Change-Id: I48c5688b76d895eac3850bf69ff1a08cf6c0879f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169650 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-07-01Use correct config option to keep changes infoSamuel Mehrbrodt
copy/paste error Change-Id: Iaccd96aced4ac0aa9bd93265aee34b66b6e23a77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169648 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-30tdf#161310 Translate My AutoText in Insert toolbarAron Budea
Use same pattern as 42e6e26255b21c1bfde893f5aaf23d4a37ecee91 and dffdc0b1995e2b24304ce0651ca886bbf9cf4f95 Change-Id: If36ecdcbb771bfcde9836203e84586045d039c8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169693 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-29tdf#161563 sw: fix invisible light gray underline for No BreakLászló Németh
Light gray underline visualization depended on IsShowHiddenChar() instead of the correct IsViewMetaChar() (Show Formatting Marks). Follow-up to commit 2f0c7d5691acd4010443856788a54b0abc03098b "tdf#161563 tdf#161565 sw: add No Break to word context menu & visualize" and commit 41916d9fb045654fa19b4eac90a3099550a890f7 "tdf#161563 sw: show "No Break" context menu only on a whole word". Change-Id: I3d10011962732ab3730e5f833e95252e9fe6bfee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169721 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-06-29Fix VBA Table's *Padding properties typeMike Kaganski
In VBA, it is Single, not Double. See VBA documentation: https://learn.microsoft.com/en-us/office/vba/api/word.table.bottompadding https://learn.microsoft.com/en-us/office/vba/api/word.table.leftpadding https://learn.microsoft.com/en-us/office/vba/api/word.table.rightpadding https://learn.microsoft.com/en-us/office/vba/api/word.table.toppadding Change-Id: I9262462424fc11b5c062a61754ab0fab9103f549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169763 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29Fix VBA get*Padding, which returns a floating-point valueMike Kaganski
Introduced in commit f3234f4f14702da71528561418f07ee6670a8c2a (VBA Add Padding properties to XTable, 2022-08-05). The unit test is edited to test that the value returned by the methods is equal to the initially set value, with precision of 0.1 pt. Change-Id: I24144cd0e3c1e72bd2664a2a052ac3c7006595ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169762 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29Rename some ConversionHelper functionsMike Kaganski
Make their names more explicit. This avoids ambiguity; previously, convertTwipToMM100 was very similar to tools' convertTwipToMm100, provoking the former function's use where the latter is better. Drop convertTwipToMM100WithoutLimit, and use the unconstrained function from tools directly instead. Change-Id: Icdd1a67721cdd8a578bc786fda67c341b07ec84a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169759 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29Fix "lets" -> "let's"Andrea Gelmini
Change-Id: I01968fc18b093dbbc27213f01c3da38ae151c62c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169748 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-06-29Use a matching type hereMike Kaganski
Change-Id: I23dbadd27838a3cacad51a6b67aef10faed71640 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169757 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29Simplify a use of convertTwipToMm100 a bitMike Kaganski
For some reason, MSVC fails to find the o3tl::convert overload for Size defined in <tools/gen.hxx>, unless the call to convert is unqualified, accompanied by a 'using namespace o3tl' in convertTwipToMm100. Change-Id: I7100ef55156b6944b5adc5aefa52eee38b3fe69e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169751 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29warning C6011: Dereferencing NULL pointer 'pArgs'Mike Kaganski
C:\lo\core\sw\source\uibase\uiview\viewsrch.cxx(237) : warning C6011: Dereferencing NULL pointer 'pArgs'. : Lines: 132, 134, 135, 136, 137, 140, 141, 149, 151, 196, 198, 200, 204, 205, 219, 228, 229, 237 Change-Id: Id06d08b310dffa15823b1d40996467888ff4ea7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169750 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-29Simplify WrapPolygonMike Kaganski
Use doubles instead of fractions. Simplify correctWordWrapPolygon, which used redundant arithmetics (it scaled by a fraction with nWrap100Percent in multiplier, then by another fraction with nWrap100Percent in divisor). Change-Id: I69a38ac7e3afda33a1e7725cab711d50dc80eed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169746 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-28Resolves tdf#115665 Format in the CTRL+H search affectsJim Raykowski
the CTRL+F search Change-Id: I51ccd2186c47a91958c262efac9a1514b9c3b138 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169606 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-06-28Simplify solar.h a bitMike Kaganski
Use std::copy / std::reverse_copy for double serialization. Also remove __cplusplus conditions, because the header is not included in any C files. And simplify the functions uses, where casts were unneeded. Change-Id: I1d8375e601851231fdffcf52e3f3e3bdcbcbde7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169706 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-28Fix "lets see" -> "let's see"Andrea Gelmini
Change-Id: I7aa939681720bc0dc81c8f114a3608a8cdfb4f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169722 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-28tdf#92029: sw_autocorrect: Add unittestXisco Fauli
Change-Id: I7ac855ac826353869c3a905ea70448d0c8dc1b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169711 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-28use more ASSERT_CHANGE_REFCOUNTED_ITEMNoel Grandin
which did I not see when I did commit cb3c65fb706cb1c7c9224222fd16875e924a9759 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Jun 27 19:24:28 2024 +0200 assert when SfxObjectItems are modified while in a pool Change-Id: I16e2ee72eda4b3ca69f83eb70ad4f4b0a14748a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169696 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-28Fix autotext shortcut generationSamuel Mehrbrodt
The first character was replaced with a number. Fallout from 1f93816dd5d75aca98f210017d0b58b7ef1d08da Change-Id: I3b9a39336d5f6f3c10c85231f86fd196a29e3644 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169621 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-06-28Related: tdf#161708 sw content controls: fix custom default of dropdown to PDFMiklos Vajna
Export the bugdoc to PDF without noticing that there is a content control around some of the content and notice how the PDF export lacks some words from the body text. What happens is that content controls are exported to PDF as PDF forms by default, and the selected option of a dropdown has to be an index, so in case the text of the dropdown content control is not one of the options, then the PDF will miss those words. Fix the problem by inserting the text of the dropdown at the start if there would be no valid index for it. Also add a bit of padding around the rectangle of the content controls, it turns out there is a default 1pt border in PDF, and this would lead to a cut-off text at the end if we don't compensate for that border. Change-Id: I99447894b320b42ad9ffe0d54d0190000621616b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169694 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-06-28item-specific instance managers for SwFormatFrameSize and SwFormatVertOrientNoel Grandin
and add some asserts to catch if we modify these things when they inside a pool, which now that they are in hash-based container, will cause trouble. Change-Id: I2779f25cbcf056fbf71e417731d9b1f09ae33dd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169629 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-28Resave with newer Glade versionBogdan Buzea
Change-Id: I7524659a266204a470f2fd407112a2d8fc47c99d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169422 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-28tdf#43767 mso-format layout: no smallcaps applied to numberingJustin Luth
If the paragraph marker is formatted as Uppercase, then Uppercase is applied to that line's numbering as well. However, if the marker is formatted as SmallCaps, it MUST NOT be applied for MSO formats. Apparently MSO only supports Uppercase and SmallCaps, not Lowercase or Titlease. I don't like these adhoc exceptions, so I didn't attempt to apply them to ODF formats. Let's keep it simple for ODF - any char format that applies to the entire paragraph should apply to numbering as well (except for the existing underline/overline exceptions). - if you don't like that char attributes apply at all, blame MSO. - if you don't like that DOCX is missing your goofy formatting, blame MSO for being inconsistent. ooxmlexport12's tdf143384_tableInFoot_negativeMargins.docx is almost interesting because it applies superscript and small caps. However, the list is already uppercase, so it can't be used for the test. make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf43767_caseMapNumbering Change-Id: I273baebc996adfd001e1c591dbb9aef9272a42f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169476 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-06-27avoid OUString temporaryNoel Grandin
in a hotspot Change-Id: I9fc3abc90c73e17b82fc7a4b197a91557c2ac6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169610 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-27tdf#159777 - A11Y sidebar: Add warning about ParaTopMarginBalazs Varga
and ParaBottomMargin direct formats. Change-Id: Ifac19eba9d3c2e3631ebede1a5f9f172bbaf8927 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169541 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-06-27tdf#159925 - A11Y sidebar: Check for missing hyperlink nameBalazs Varga
Check if the hyperlink have missing name and add a fix button to fix the warning. Change-Id: I3a69490aa81cf0ed9d0edb04eaa3401e4b47eb7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169508 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-06-27sw: simplify SwShellCursor::Show()Miklos Vajna
If we carefully dereference the shell and its sfx view shell, then no need to do this again, as pointed out at <https://gerrit.libreoffice.org/c/core/+/169509/2#message-087d761946aeeb8e6a25ed46dafa10adc5dacc67>. Change-Id: I4da444d1f4001849c7fe70ac0acd5e8af26b3415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169636 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-27Related: tdf#161652 sw, RTF paste: avoid duplicated numbering stylesMiklos Vajna
Open the DOCX bugdoc from <https://bugs.documentfoundation.org/show_bug.cgi?id=161652#c6>, select-all, copy, open a second document, paste as RTF, paste as RTF again, the number of char styles in the document change from 27 to 55, then to 73. That is surprising, paragraph styles work by first creating them then a 2nd paste just refers to them. It seems what happens is that paragraph styles are handled in StyleSheetTable::ApplyStyleSheetsImpl(), and we have an explicit "When pasting, don't update existing styles" code there; on the other hand ListDef::GetStyleName() solves the style name collision by appending enough "a" characters at the end of the style name till there is no collision. Fix the inconsistency by adapting the list style behavior to match what paragraph styles do: if we don't open an RTF file but paste into an existing document, then try to use the existing style on collision. Fixing this on the RTF producing side would be less effective, also one could argue that in case a numbering uses e.g. 3 levels, then it still makes sense to emit the definition for all levels to help the editor once numbering levels are increased in the pasted content. Change-Id: Ia211cb4300c3c41dae8c815ddfaf30cc2f0de8b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169609 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-06-27Resave with newer Glade versionBogdan Buzea
Change-Id: Iee7c65b65d545224fe4518e9c91d97dc3352eef2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169504 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-26tdf#156724 sw: layout: ignore footnotes when splitting float table rowMichael Stahl
(regression from commit 534d3818aedfa95ad73935235462f5ec2817f5da) Change-Id: I169d88375a93c288604a89ef89f7e895830446c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169570 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-01-29 00:16:45 +0000