summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2023-06-08tdf#155505 Group issues by type in a11y sidebar panelSamuel Mehrbrodt
Change-Id: I87349e9d3f5680751a91264e055e4579c97fa93e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152617 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-08sw: use ThemeExport instead of grab bagTomaž Vajngerl
Change-Id: I68d300d58aaa1e5da374a8ddea4ff37e9a1e1819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152723 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-08sw: remove char color GrabBag and fix export, fix tint/shade calc.Tomaž Vajngerl
Don't store values from grab bag when exporting character theme colors and tint/shade values. The values could be wrong now and aren't needed anyway as we support the values in the model. Add proper export support for char color theme information with correct conversion of values into tint/shade values in 0-255 inverted interval. This also fixes the import of tint/shade values whcih calculation was slightly off. We divided by 256 instead of 255, which introduced an error. In addition introduce ThemeColorUsage enum, which marks if the theme color type has a specific "usage" - text or background. This is determined on import if the theme type is background{1,2} or text{1,2}. This is then taken into account on export, so the exact type is preserved. Change-Id: I0022a159397fd0c3d39a118a7149bb2488dfc149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152705 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-07tdf#155685: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I13bde9aec9455d38435e6fd0d17d24544d9d0952 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152701 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-07tdf#155376 partially convert SvCTLOptions to officecfgNoel Grandin
When accessibility is enabled, Calc will add tens of thousands of listeners. We then spend a significant chunk of time creating SvCTLOptions objects (attached to ImpEditEngine) and adding and removing those objects from the related listener lists. But the required information is already globally cached by the officecfg module, so we can avoid that overhead and just fetch it directly from officecfg. Change-Id: I7ff55fd7c4926866eb7086812275ba8bd6e84c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152645 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-07CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfOle2OdgMiklos Vajna
Set the filter options explicitly, rather than inferring it from the test name. Change-Id: I2fad91a968940ebfd908dde5f312c81535f01599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152686 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-06tdf#155344 sw tracked table column: 1-click Accept/RejectLászló Németh
Now context menu of a changed table column shows Accept Change/ Reject Change menu items, which accept or reject the deletion or insertion of the table column(s). Also Accept Change/Reject Change icons of the Track Changes toolbar are enabled, and do the same, if the cursor is not before or in a tracked change. Add the following labels to the Undo actions: "Accept change: Column Inserted" "Accept change: Column Deleted" "Reject change: Column Inserted" "Reject change: Column Deleted" Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7 "tdf#150673 sw xmloff: import/export tracked table column". Change-Id: Idff570dfcf8c3ce35b6223f801608779bf1cd28e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152626 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-06tdf#135710 doc import: force page center on inline imagesJustin Luth
Relative anchoring is irrelevant for inline images, so it is safe to do this in terms of writer layout. The benefit is clearly seen when the user changes from inline to anchored. In ODT format, that results in a centered image in the paragraph, while in DOC it was anchored somehow to a character and didn't lay out nicely at all after the transition. So this is mainly just side-stepping a layout issue in Writer (because checking the properties and hitting OK shifted the image). Change-Id: I6ff7a191d78bc1597ee9f053e02f161565a27174 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152683 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-06tdf#135709 doc import: force dynamic wrap on inline imagesJustin Luth
Wrapping is irrelevant for inline images, so it is safe to do this in terms of writer layout. The benefit is clearly seen when the user changes from inline to anchored. In all other formats, that results in Parallel wrapping, but in DOC format the text "disappears" behind the image since it wraps through. Change-Id: Ia4827814f9c9a3b8865bf8d0d72552b2b44a0207 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152682 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-06convert SvtAccessibilityOptions to officecfg where possibleNoel Grandin
Change-Id: Ia530086fe35e64379e55135d392020304b466325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06SvtCommandOptions only supports CMDOPTION_DISABLEDNoel Grandin
CMDOPTION_NONE is just ignored, so remove this parameter Change-Id: If9de22a6b0522620a267cbc92b118f79e200d999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06convert ColorConfig to officecfg where possibleNoel Grandin
Change-Id: I14f0ada21d328b3b6637709e403bfe973a7035b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152670 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06tdf#140066 sw: fix bad position of textbox after anchor type change + undoMiklos Vajna
The bugdoc has a to-char anchored textbox. Changing the ancor type + undo resulted in a new textbox position, which is not expected. This is a problem since 7596e26fd259ce5445212949403e7cd32303b2bd (Add SwTextBoxHelper::findShapes, 2014-06-24), previously the codepath was not hit, since shape + content from DOCX was a fly format, not a draw format + fly format. Looking at the undo item implementation, in SwUndoFormatAttr::RestoreFlyAnchor(), aDrawSavePt is initialized from the old format (that we try to restore on undo), so in case that already matches aFormatPos (which is initialized from the new format / doc model), then adjusting the same position looks safe to skip, and that solves our problem as well. The whole problem area could be avoided if the draw layer would store absolute positions in its undo actions, because then it would be harder to get the abs Writer and the rel Draw undo actions out of sync, but that would a larger rework. Change-Id: Ia1c9f486e54f5967a34a1a269f8d234ae96d5bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152627 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-06tdf#155685 sw: fix crash on undo of ExtendedSelectAll with table at endMichael Stahl
While the selection with table at the end works for Copy, unfortunately it doesn't work for Delete, because SwUndoDelete can't handle it, and an empty SwTableNode+SwEndNode pair remains. This needs some extra code, extract a SwDoc::DelTable() out of SwDoc::DeleteRowCol() and call it from SwEditShell::DeleteSel() to create separate SwUndoDelete objects per table, which appears to work. (regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda) Change-Id: I1534b100d31bc279bce298d3c2bd235cffc1f9d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152628 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-06tdf#153040: unit testJustin Luth
make CppunitTest_sw_core_text \ CPPUNIT_TEST_NAME=testDropdownContentControlPDF2 Still wrong/poor with this unit test: -wrong font for rich/plain text content -slightly offset (shifted right/shifted down) placement (tested in Linux Evince anyway). Change-Id: I586d46eaf5cdf9fbf44a6913f295c440240d180a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152634 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-06-05tdf#152431 Fix line count resets to zero after 65535Bogdan B
GetLineCount was a sal_uInt16 value, that allows only 65535 lines to be counted. This is changed to sal_Int32 and also the underlying data type for the lines number is changed from sal_uLong to sal_Int32, but not for pages number. With this change, the maximum possible line number is now increased to 2^31-1 = 2,147,483,647. Change-Id: Ibee2d24e638204133f0ef085564016543f73d351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143173 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-06-05lok: callback to send the updated theme palette when theme changesTomaž Vajngerl
The callback sends the updated theme color palette when the theme changes or initially when the view is registered, so the client should always have the up-to-date theme color palette stored, so it can just show the color picker with the theme at any time without the need to call the server. Change-Id: I7cceccc46c2fad23ba89e6d3f3643e37f8dab292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152589 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-05svx: extract theme color generation into ThemeColorPaletteManagerTomaž Vajngerl
The generation of theme colors generation code is moved to the ThemeColorPaletteManager class, so it can be reused. Also change the GetThemeColors return type from std::vector<Color> to std::shared_ptr<theme::ColorSet> as we can now safely do that and simplifies things. Change-Id: I4a54bff889a1f97cb1e30467188dc69e07e8c518 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152588 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-05Update a11y check after quick fix actionsSamuel Mehrbrodt
Change-Id: Ie2f9a38ece130bc0cdafedf2c188c4c755233eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152501 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-05tdf#155504 Add "Fix" function to shapesSamuel Mehrbrodt
Change-Id: I9494207b0bcdf121034f79d936aeadd95cecdf23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152494 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-05Fix typo in codeAndrea Gelmini
Change-Id: Ie25dfed8d3178f71256b19d9ec3247dff6d0c704 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152593 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-04sw: border and background theme color support for multiple props.Tomaž Vajngerl
This adds support for theme colors for multiple properties that are stored in SvxBoxItem and SvxBrushItem / XFillColorItem. For those items the ComplexColor member variable was introduced. The UNO properties for the colors are added. The properties with the added support includes paragraph border and background + styles, page border and background, frame border and background + styles. The ThemeColorChanges has been extended to support changing the colors for those propertes. Color picker and tab pages have been fixed so they pass or set the theme color properties to the items. Change-Id: Id27272f5c4a448703a62a759d829e8a9540066e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152397 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-04Fix typoAndrea Gelmini
Change-Id: I224ba72073d77a0c16ed0669252af7b16fb99d03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152582 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-03tdf#153721 SwNavigator: fix chapter moveJim Raykowski
Fixes move chapter up/down regressions introduced by commit e27b936fe864cdd2753470e0fef1e3cb1f891555. For regression details please see comments 14 and 16 in the bug report. Change-Id: I0a57483fae51656c89e8b4f3711d8057174517e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152347 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-06-03tdf#134114 writerfilter: pass on AllowOverlap to graphicsJustin Luth
make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf134114_allowOverlap The unit test has terrible layout after a round-trip... Change-Id: I448af1c6b0c5135eb6d41dd6aa0c4bf00506ebbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152572 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-03tdf#153040 sw content controls PDF export: output listbox entryJustin Luth
This fixes a 7.5 regression/wrong implementation. Prior to 7.5, content controls were just exported as plain text to PDF. Now that the content control is exported, the selected entry in the list box was not being printed - just a big hole in the text. Fixed by informing PDF of the selected entry. TODO: the content control starts too late (a somewhat wide space at the front), and ends too soon (the last portion of the text is cut off). The unit test for the TODO will cover this case, so skipping that for now since I found no examples to follow. Change-Id: I1412a57efc070010c6d0d0a37f48d63699b085b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152566 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-02tdf#152983 sw: layout: fix crash in SwContentFrame::Cut()Michael Stahl
Surprisingly, SwContentFrame::Cut() is called in a situation where the frame is not connected to any SwPageFrame yet - it is in a follow fly of a fly chain that is anchored in a footer, and SwFlyFrame::ChainFrames() removes it. (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: Iad84b7b422126e050493dc3b181d47c4dca2fae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152510 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-02tdf#145538,tdf#147021: qa: range based loopsDr. David Alan Gilbert
A bunch of range based loop changes in various qa sections that also take out about 1% of SAL_N_ELEMENTS Change-Id: I8ef000e9aa400cd8363b48f6175f6ab258cefbd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152422 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-02sw floattable: ignore keep-with-next for anchors of non-last split flysMiklos Vajna
The bugdoc has a floating table that could split between page 1 and page 2, but we used to put the entire table to page 2. What happens is that the anchor of the floating table had <w:keepNext>, which means the layout tried to keep the paragraph on a single page, and also with the next paragraph (but in this case there is no next paragraph, it's the last one in the document). Fix the problem ignoring the "keep with next" request, in case the paragraph is an anchor for a split floating table; unless we're the last anchor in the chain. This is probably consistent with the intent that "keep with next" is meant to control the anchor text and not the anchored floating tables. Change-Id: I387a2db5f5db013da7055686ae6b9d032b467266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152525 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-06-02tdf#90507: Prevent changing default style in AutoCorrectBaole Fang
Change-Id: I3bc7d99daf49ff32d9d80fcbbb7538cc036bc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151213 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-02CppunitTest_sw_uiwriter5: fix buildMiklos Vajna
See <https://gerrit.libreoffice.org/c/core/+/152336/3#message-c6562aa5808e9430d518bb145015ed6260296312>. Change-Id: I8c45a5457fedbd3b9fecb6cef255f07655798d07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152524 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-06-02sw layout xml dump: extract SwCellFrame::dumpAsXml() from SwFrameMiklos Vajna
Ideally SwFrame should not really know anything about cell frames. Change-Id: I01c7af5a4ded579a38e78ca9c8218871e0a1d325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152509 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-02tdf#154751 writerfilter: last enabled strikethrough winsJustin Luth
The problem is that multiple strikeout character properties can be defined for DOCX, but it is implemented using a single property in LO. If the last definition was "not *strike" then all strikeouts were disabled. Instead, if any strikeout is enabled, the last one overrides the others, but cancelling doesn't negate a previously defined strikeout. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf154751_dualStrikethrough Change-Id: Iaf17380061a0b37db4bc7a87c703e81f0181bcc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152514 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-02tdf#155341 sw tracked table column: add insertionLászló Németh
All the inserted cells get a dummy redline to store the change tracking metadata, setting also the HasTextChangesOnly bit of the table box to FALSE. Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7 "tdf#150673 sw xmloff: import/export tracked table column". Change-Id: I55f5a44ac0ec040993a100156665f116355c235a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152336 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-02Related: tdf#122081 null-deref of SwFootnoteFrameCaolán McNamara
load doc, ctrl+end, ctrl+home, ctrl+6 enter 29, return, wheel scroll down 7 or 8 times and this null-deref Change-Id: I1963a89e3223de89f3414e435accd8d8ebfe80a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152511 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-01tdf#150606 sw: layout: leave follow SwTabFrame invalid in columnsMichael Stahl
With the minimised bugdoc, on Undo, some 12 or so pages are created, and the end of the deleted table is shown in the document view. So first the last pages are layouted, and then once those are done layout proceeds from page 1. The problem is that on page 9, a table remains in the 2nd column of the section, and there is nothing in the 1st column and on pages 5-8. This is because ::CalcContent() is the last thing that formats the table on page 9, and it explicitly disables MoveBwd() for follow tables via m_bLockBackMove. That appears to be intentional but because it's already been there since initial CVS import it's unclear why; it might be based on the assumption that a previous column would have moved over rows from the follow table already. Try to encourage the table to try to MoveBwd() at a later time, when it's being formatted from the SwLayAction::FormatContent_() loop, which appears to help. (somehow regression from commit 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I421525269948aa58888f5302e6db234c89230f00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152485 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-01WaE: -Wmaybe-uninitialized with GCC 13Caolán McNamara
Change-Id: I69e0f28ab6f6a8a2c7181876735b128d39394b52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152503 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-01take a copy of SwAccessibleParagraph::GetString()Caolán McNamara
take a copy of this a11y and not a reference it is not guaranteed that listeners to the a11y events called by FireAccessibleEvent will themselves not call anything which could end up calling ClearPortionData which would leave rText pointing to old released memory seen in the wild with: ==15145==ERROR: AddressSanitizer: heap-use-after-free program/../program/libswlo.so rtl::OUString::equals(rtl::OUString const&) const builddir/libreoffice/include/rtl/ustring.hxx:952 program/../program/libswlo.so rtl::operator==(rtl::OUString const&, rtl::OUString const&) builddir/libreoffice/include/rtl/ustring.hxx:1713 program/../program/libswlo.so SwAccessibleContext::InvalidatePosOrSize(SwRect const&) builddir/libreoffice/sw/source/core/access/acccontext.cxx:1196 and previously allocated by thread T0 here: program/../program/libswlo.so SwAccessibleParagraph::UpdatePortionData() builddir/libreoffice/sw/source/core/access/accpara.cxx:442 with free of: program/../program/libswlo.so std::default_delete<SwAccessiblePortionData>::operator()(SwAccessiblePortionData*) const gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:78 program/../program/libswlo.so SwAccessibleParagraph::ClearPortionData() builddir/libreoffice/sw/source/core/access/accpara.cxx:451 program/../program/libswlo.so SwAccessibleParagraph::getCaretPosition() builddir/libreoffice/sw/source/core/access/accpara.cxx:1016 program/libmergedlo.so LOKDocumentFocusListener::updateParagraphInfo(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleText> const&, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) builddir/libreoffice/sfx2/source/view/viewsh.cxx:685 Change-Id: I72c9894ca842b8f040b27481f0fd8d56542eb530 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152486 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-01tdf#155504 Add "Go to" function to shapesSamuel Mehrbrodt
Change-Id: Ic1f39c65565f92ceb86e3b19d45aed7014b88e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152487 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-01tdf#155623: Revert "tdf#155557: Fix drawing mixed direction underlined text"Khaled Hosny
This reverts commit 99d22fd79c5532fd6c1b167996e1c27216b92469. Lets revert and figure out a less radical fix for the original issue. Change-Id: If3025d32019e953b7946ebe4209daf74efc5e15a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152490 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-01Revert "Convert XFastParser into a normal C++ interface"Noel Grandin
This reverts commit 5e68d6cfade45f40b1ad46025a81afe4cb8dd337. Reason for revert: Seems like outside users have been using this API Change-Id: I8814cf1eb4f000eeb4cbbb5db9c282d001465993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-01WaE: SwNodeIndex GCC12 spurious -Werror=dangling-pointer=Caolán McNamara
I see this with gcc 13 too Change-Id: I63aed9a3bdc5bec7f96474145fd2ba30156741cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-01SwModelTestBase: simplify code a bitXisco Fauli
and rename reload method to saveAndReload to unify code and use it everywhere Change-Id: I7c0f4e8d2feb7a0f9ca28df4b6dddd7a11b2e57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152455 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-01CppunitTest_sw_htmlexport: fix test after my previous commitXisco Fauli
In 6aec73de12a56a56b3ffd9bb86b559bf0609bf58 "SwModelTestBase: drop mustCalcLayoutOf", I misread the code and thought that loadAndReload wasn't calling calcLayout anymore. Obviously I was wrong. adapt the code to do load and save without calling calcLayout and without reintroducing the mustCalcLayoutOf complexity Change-Id: I4d5619a0443e70bbec89c4513ab86a93d968646c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152477 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-01Convert XFastParser into a normal C++ interfaceNoel Grandin
There is no need for it to be an UNO interface anymore (ever since we started supporting dynamic_cast on UNO objects). Which means that XImportFilter2 also needs become a C++ interface. Change-Id: Ice2db0f098271bba32b199bd083b08cb8410ce93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-01Use OUString for filterMike Kaganski
Change-Id: I45c809cfd4ee9b1c6f479db1ad0a6bf2d479fed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152473 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-01tdf#155557: Fix drawing mixed direction underlined textKhaled Hosny
The code here first unsets the underline style, draws the text, then measures the text size, change the text to two blank spaces, sets the measured width back and tries to guess how much space was added by justification, sets the underline style back and then draws again. I have no idea why it is doing it in this highly convoluted way, but this code goes all way back to the initial import. However, it currently fails to account for Arabic justification when the Arabic text does not have any space characters. Instead of trying to guess more how much width the Arabic justification adds, I’m removing this code altogether to let the normal drawing code handle the underline drawing. Lets see what will break. Update text expectation because we now do one-less drawing. Change-Id: I8158bd15370005a78b866c8192414e4b46af2727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152452 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-01tdf#104704 tdf#145998 doc/rtf import: don't lose section page breakJustin Luth
This fixes a LO 7.5 regression from commit c37f62b71fa59917ef85ff98480dff18aa936e41 That 7.5 fix focused on DOCX, and didn't realize that the doc/rtf path couldn't handle the same logic. Just reverting to previous behaviour for DOC/RTF for now. (It is too hard to find relevant documents because any document starting with a section break on the first paragraph [and there are MANY of these - an ODT default], and that scenario harmlessly matches this code path.) Change-Id: I82cfe10e217269448d38df0ca03ce6cae3536e56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152467 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-05-31tdf#155611: SwFrame::FindNext sometimes returns a sub-frame of this frameMike Kaganski
This resulted in wrong split of the section frame, when the table frame was the last in the section, the split needed to happen after that table (i.e., at the very end of the section), and passing the table frame as pFrameStartAfter gave its last cell's subtable as pSav (i.e., the frame to move after the split). The first frame of the last cell (the one prior to pSav) got lost from the layout, and wasn't destroyed when SwRootFrame was destroyed, and then it crashed referencing destroyed root frame and view shell. Change-Id: I1a539818aa890f65e961f4185ce50916ce7e4e4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152454 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-31Simplify a bitMike Kaganski
Change-Id: I3ba0187e46e57650e26faaf798c1e9f2864373c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152431 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-04-27 15:34:06 +0000