summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2014-08-22QueryBox DLG_CHANGE_AUTH_ENTRY -> MessageDialog + stringCaolán McNamara
Change-Id: I836381f710e4f36b977284f6996bb135fc328049
2014-08-22DOCX import: list styles don't support automatic updatesMiklos Vajna
The problem was the following: setPropertyValue("IsAutoUpdate") on the style failed -> a number of styles was not imported in StyleSheetTable::ApplyStyleSheets() due to the exception, then when we tried to use one of the not imported styles, we also got an exception in DomainMapper_Impl::finishParagraph(), which resulted in not calling DomainMapperTableManager::handle(), so multiple cells of the same table wanted the same range for cell contents, and that resulted in a crash. Regression from cf33af732ed0d3d553bb74636e3b14c55d44c153 (handle w:gridBefore by faking cells (fdo#38414), 2014-04-23), but that commit just made the previously hidden problem visible. Change-Id: I788cb6b4a2c7b7efbfa48297c658bb26450bf583
2014-08-22SwXParagraph::Impl::GetTxtNode: fix indenetationMiklos Vajna
Change-Id: Iac9e2883067b6cf4fdc259110642002b4ef6e48c
2014-08-22The bLastBoxInChain fields are unusedTor Lillqvist
Change-Id: I741733a053c8b0123be8efbcb9fde39f53f6d83c
2014-08-22bHasUDefProp is unusedTor Lillqvist
Change-Id: I8eae6f1ed791ba92c3b4679d1b9f8041f16678d1
2014-08-22The comment apparently pertained to the following lineStephan Bergmann
...cf. 75400111a50ce0b4026e7eb73a896ac3c28d6155 "INTEGRATION: CWS swqbf64: #i65250# <SwFrm::mnFrmId> now in general available," but is rather useless nowadays anyway Change-Id: I1e9d6c289fad021764f7e1b1af0d7b9dca67bf53
2014-08-22Open the right tab for the More... commandMaxim Monastirsky
Partially fixed by Caolán in 3ac80237f310366afef0f7b6c427889d652bd369. Remaining issues are the paragraph submenu, and the top menu for both selection and paragraph. Also fixed for the drawing text and annotations shells (including the regression created by the above commit, that the dialog didn't show at all). Change-Id: I1ba4c825ad48af23ad5c07c8c5f25380952c0be1
2014-08-22QueryBox STR_QUERY_DELETE -> MessageDialog + stringCaolán McNamara
Change-Id: I570fe82f3207e8b40a0e4727c6641fdf59113978
2014-08-22QueryBox QB_CONNECT -> MessageDialog + stringCaolán McNamara
Change-Id: I593527c365ad6925229a3dd7d9e1c589fc4e34a5
2014-08-22QueryBox DLG_SPECIAL_FORCED -> MessageDialog + stringCaolán McNamara
Change-Id: I461bdb31e7a088a2aa5200614479c8578e717b23
2014-08-21sw: _one_ unit test with use_library_objects sw ought to be enoughMichael Stahl
Linking those things takes a lot of RAM. Change-Id: I4db9ee3f07f97601d526ab3f905ecadbf4c552ca
2014-08-21RES_PARATR_ORPHANS comes before RES_PARATR_WIDOWSStephan Bergmann
Change-Id: Iaf1891738fb3673c41b3af724f8494306578c512
2014-08-21Fix *_component_getFactory function typeStephan Bergmann
Change-Id: I0f2fedc544349a69f29df5e83bec30ea510125f5
2014-08-21DOCX export: prevent multiple paragraphs in some SDT containersMiklos Vajna
E.g. Word doesn't do anything if you hit return in the middle of a title; if that's so, then we should handle this situation on export as well. Change-Id: Ib5b52a59250b09c97023b53906b8046f530d0e31
2014-08-21Avoid invalid downcasts to SwFmtHeader instead of SwFmtFooterStephan Bergmann
...which only happened to work because the two classes have very similar layout Change-Id: Ie4bde807a2442a95ff515b065d4f45f257a32f34
2014-08-21avoid crash on document ending before contained table endsCaolán McNamara
Change-Id: I003b7e00673cd5a4b4f0ed5218e2d30cfef04ffb
2014-08-21Check pTmpFrm->GetType(), not nFrmType, for FRM_FLYStephan Bergmann
...as nFrmType need not match pTmpFrm->GetType() exactly, but can e.g. be USHORT_MAX when GetFrmOfModify is called from SwFrmFmt::FindLayoutRect (sw/source/core/layout/atrfrm.cxx). It is probably good luck that the two comparisons against FAR_AWAY made it too unlikely for the if's true branch to ever be taken for a pTmpFrm that is not actually a SwFlyFrm. Found the bug when running CppunitTest_sw_ooxmlexport2 under -fsanitize=undefined, where ((SwFlyFrm*)pTmpFrm)->GetAnchorFrm() was called for a pTmpFrm of type SwTabFrm. Change-Id: Ia886a809bdb82488c3f410be66cf827b3f723c55
2014-08-21DOCX export: handle anchored TextFrames inside shapesMiklos Vajna
The exporter already handled TextFrames inside TextFrames, a feature supported by Writer, and not by Word. Similarly, if DocxSdrExport::writeDMLAndVMLDrawing() starts a shape, then anchored TextFrames should be posponed till the end of that shape. Change-Id: I597a8a46b1cf2348a8ccb9af668ea5afab27541b
2014-08-20C++ name lookup is hard, especially for clang tinderboxMichael Stahl
Change-Id: I50a25e5cfa219bbdcf0a23c03b8e6a2cff72c3d6
2014-08-20i#107771: sw: burn, UnoCallBack, burn!Michael Stahl
Change-Id: Ifdb6d4b2e404bd160e6fcec3229691e750bdf698
2014-08-20fdo#72695: avoid double-free race condition for SwXFootnoteMichael Stahl
Change-Id: Id7832d8e65723ae30ad2b5ce95d145def53998f0
2014-08-20i#107771: sw: implement thread-safe instance caching for SwXFootnoteMichael Stahl
Change-Id: I3fffb321877168dfa9844b4ad75a9a9efc9602a6
2014-08-20i#107771: sw: make SwXFootnote a client of its format poolitemMichael Stahl
In other words, stop registering at SwDoc's "UnoCallBack". Change-Id: Ie73c707b0f43559cc78717c0879d5e9a9335a7ac
2014-08-20SwWrtShell::StartInputFldDlg() can be called with RES_SETEXPFLD tooMichael Stahl
... and there's no way to get the SwFmtFld from a SwSetExpField, so add a member for it like SwInputField has. That's still better than the UnoCallBack nonsense. Change-Id: I59c82e95414dbae284432b8a318a6ce1a34256c7
2014-08-20i#107771: sw: make SwXTextField a client of its format poolitemMichael Stahl
In other words, stop registering at SwDoc's "UnoCallBack" Change-Id: Ieb2639497fe5e8d71aa1c47952c007da76fcee84
2014-08-20better error handing in SwXTextField::attach()Michael Stahl
Change-Id: I4b8b4ef1f34ba5662bd56bfbb335b87fb5aa4b51
2014-08-20fdo#72695: avoid double-free race condition for SwXReferenceMarkMichael Stahl
Change-Id: I66a988f17adebba72a71af5b770abbebfa4e12b2
2014-08-20i#107771: sw: implement thread-safe instance caching for SwXReferenceMarkMichael Stahl
Change-Id: I4f3b6789dde053ca913e12233b20d45dfe50c7ec
2014-08-20SwXReferenceMarks::GetObject() has no need for a mutex guardMichael Stahl
Change-Id: Icc6b0eebf57b07f06bccc9a57036f0611a67c4a3
2014-08-20i#107771: sw: make SwXReferenceMark a client of its format poolitemMichael Stahl
In other words, stop registering at SwDoc's "UnoCallBack" Change-Id: I9e08966cf8e2d2a373867d81549c8887f73993c8
2014-08-20sw: RES_TOXMARK_DELETED is unused since swunolocking1Michael Stahl
Change-Id: I98b21573ebbc8543609bd63eee30bc5b4cbdfb2c
2014-08-20SwXDocumentIndexMark::CreateXDocumentIndexMark does not need SwTOXTypeMichael Stahl
... passed in as parameter since it's always the one from pMark. Change-Id: Ia5981b0f281c8cac70cbb305c82bb6785918168a
2014-08-20RegisterToTOXType has a silly parameter nameMichael Stahl
Change-Id: I1cfd5c077f4b1ac809ace91fe76308f0e1892e09
2014-08-20fdo#72695: avoid double-free race condition for SwXParagraphMichael Stahl
Change-Id: Ie207d9400bc3a55e17497b309dfbc263e7b12e30
2014-08-20fdo#72695: avoid double-free race condition for SwXTextSectionMichael Stahl
Change-Id: I6a4cd076deef63f172c42dcc22cc44c47a4aa293
2014-08-20fdo#72695: avoid double-free race condition for SwXDocumentIndexMichael Stahl
Change-Id: I9264ea023ee12b24561e86d893b1f7abb2765621
2014-08-20fdo#72695: avoid double-free race condition for SwXDocumentIndexMarkMichael Stahl
Change-Id: I08fef7f1de4cce468a4936e33d3684f847e1aa5b
2014-08-20fdo#72695: avoid double-free race condition for SwXFieldMasterMichael Stahl
Change-Id: Id3dfe1c68f00964200ad53922a0f41ebdbc4c3f8
2014-08-20fdo#72695: avoid double-free race condition for SwXTextFieldMichael Stahl
Change-Id: I6adfcb1bdd5e8e1525568a4bcd93a8e0e97359be
2014-08-20SwXBookmark: m_rThis now unusedMichael Stahl
Change-Id: I686a5383a6b42872bd6945780c661d1a2a49cad7
2014-08-20fdo#72695: avoid double-free race condition for SwXBookmark/SwXFieldmarkMichael Stahl
Change-Id: I92838d75f5573e4b626b94ef446f464be1b39b67
2014-08-20SwXMetaText::GetXMeta() now unusedMichael Stahl
Change-Id: I832b4b544050c2105ed40fb6421318e8b59313d1
2014-08-20fdo#72695: avoid double-free race condition for SwXMeta/SwXMetaFieldMichael Stahl
Change-Id: Ic5754dc479d7d55ce4e0f2713c5545db75a300c2
2014-08-20fdo#72695: avoid double-free race condition for SwXTextTableMichael Stahl
Change-Id: Ibd27e8d61ccbe7d1cdeb72d310acea54198ecd77
2014-08-20remove bogus mutex guard in SwXTextTables::GetObject()Michael Stahl
Change-Id: I97e1eef0d364b18a2a7151558e1f7cd17bade160
2014-08-20i#105557: thread-safe caching of SwXTextTable instancesMichael Stahl
Add factory function SwXTextTable::CreateXTextTable that uses the WeakReference SwFrmFmt::m_wXObject to cache the instance in a thread-safe way. Change-Id: I88939e2586d104193184eea43b466f2cbeb71d6f
2014-08-20fdo#72695: avoid double-free race condition for SwXFrameMichael Stahl
The problem is that Modify() may be called from ~SwFmt while another thread is waiting on SolarMutex in the ~SwXFrame or derived class destructor, so the ref-count is 0 and the uno::Reference in Modify() will cause a double-free. Since ClientModify() does some re-parenting of listeners, it is at first glance better to call Modify() in this situation (although it is quite possible that it actually doesn't matter), so don't avoid the call in ~SwFrmFmt by adding a SwClient* member there, but put a weak reference to itself into SwXFrame so it can check if it's still alive... Change-Id: I492bb8a8557af5fc725fdb7f8b21013e0886f63b
2014-08-20make SwXFrame derived constructors privateMichael Stahl
... so that new instances have to be created by the factory functions. Change-Id: I643a154609b1a277d5cbc22d739ef8e357028f56
2014-08-20i#105557: even more thread-safe caching of SwXFrame instancesMichael Stahl
Change-Id: If5cc29e75a35326a933fed70e2f39d92c9e09cde
2014-08-20i#105557: more thread-safe caching of SwXFrame instancesMichael Stahl
There's another over-engineered factory function to convert... Change-Id: I4a51ea197f1a550f712f6542a4ebaf305e293f3f