summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2016-05-30Fix tools/date.hxx Date vs. css::uno::Date mismatchStephan Bergmann
...that was there ever since at least 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import". None of the "make check" code appears to trigger this code path. Change-Id: Ic85b2ef4cf0a0ad06b467558e823cfa4ee31a08c
2016-05-30Convert FontRelief to scoped enumNoel Grandin
Change-Id: I545c83d742db27f1a004b66e5eb1ef768f62e011 Reviewed-on: https://gerrit.libreoffice.org/25626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30loplugin:unusedmethodsNoel Grandin
Change-Id: I08e9bb65b2530148b80c67f01d51e594fc698acb Reviewed-on: https://gerrit.libreoffice.org/25543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#99870 writer: don't delete selection with delete-commentJustin Luth
When using the keyboard to select text and then deleting a comment, all the text between the cursor and the comment would also be deleted. (Not necessarily the selected text, but everything from the point or the mark would be included in the delete.) Change-Id: Id15a00d112d118227bc4a34b5102bb09d8d167b0 Reviewed-on: https://gerrit.libreoffice.org/25216 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-29coverity#1362175 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia2da9cc6a2e2f6c5f3f85c2ad3d95fb1adad6225
2016-05-28LOK: ensure KeyInput is handled with the correct MapModeAshod Nakashian
The MapMode is set explicitly to make sure the coordinates of the comment widget is in absolute terms. However PostItMgr::MakeVisible invalidates it. This is to ensure that the MapMode is restored after MakeVisible is called when LOK is active. Change-Id: I2adf749488e6eb46d29a0b29c4dfd644606c92ab Reviewed-on: https://gerrit.libreoffice.org/25015 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 0b223bac012fae1af2d2bf1fe9c038cbe88846ed) Reviewed-on: https://gerrit.libreoffice.org/25426 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: invalidate annotation window upon showingAshod Nakashian
Change-Id: Ib2624c55759c8ac81986bf3b516fd17cbde19ec9 Reviewed-on: https://gerrit.libreoffice.org/25014 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 4523f78312bd07449fa205301d99a81ef0f69420) Reviewed-on: https://gerrit.libreoffice.org/25425 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28notebookbar: sw ui adjustmentSzymon Kłos
Change-Id: I89d1a1fe20a617155a11dc59c49454bcd24e3e3d
2016-05-28Improve alignment and use of space in Document Properties dialogAdolfo Jayme Barrientos
Change-Id: Id4da1138931ef1601541b7108a4e90b3656a5ccb
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27sw: these all look like intended fall-throughsMichael Stahl
Change-Id: Idfea426b69d07dc6d8eb8d0edb59b0ec0f4ecdf9
2016-05-27tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16)Noel Grandin
and put an assert in SfxPoolItem::SetWhich() so nothing new creeps in. Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df Reviewed-on: https://gerrit.libreoffice.org/24324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27improve exception throwing in java class util.utilsNoel Grandin
so that we get nice stack traces in our test error logs instead of just the title of the exception Change-Id: I47f30d80b9efbc7dbeff7f4456755e416e577b5a Reviewed-on: https://gerrit.libreoffice.org/25510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26Sw UNO API TableStyles getByNameJakub Trzebiatowski
Implementing TableStyle family getByName, hasByName, getByIndex Implementing SwXTextTableStyle Implementing basic tests Change-Id: I256189db8631a713c4aae6b449409bbfaa776f24 Reviewed-on: https://gerrit.libreoffice.org/25410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-26Various loplugin warningsStephan Bergmann
Change-Id: I27101eb92a5ce6665c6dfaf761c06a33c7646dcb
2016-05-26loplugin:overrideStephan Bergmann
Change-Id: Id9ffc0d790006638584792cd7a0d1c798e686a22
2016-05-26VclPtr in container warningsCaolán McNamara
Change-Id: I653aad3a88438faa985466e091e22be1c23ca953
2016-05-26loplugin:nullptrTor Lillqvist
Change-Id: Ic0802a92e857b427bd95840b16078f8f3c308a52
2016-05-26tdf#83830: Writer page sidebar deckRishabh Kumar
Change-Id: I6eb16a5a721fad28aa7822b0ca8d7c06a0c08541 Reviewed-on: https://gerrit.libreoffice.org/17904 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-26loplugin:unusedmethodsNoel Grandin
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedreturntypesNoel Grandin
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#100051 Partially revert "loplugin:constantparam in sw"Miklos Vajna
This partially reverts commit 9585c8b8c8d8724cc1bad4a2060c828c15599929. Instead of removing the nCount parameters, make use of them in SwXTextViewCursor::go{Left,Right,Down,Up}. For the following testcase: a document with 1000 lines, and calling goDown(1000, true) the spent time goes from 4 secs to 1.8 secs with this for me. Change-Id: I10351a6dbaa6d3fff883520c85701f60b05b4873 Reviewed-on: https://gerrit.libreoffice.org/25450 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-25sw: replace boost::shared_array with std::shared_ptrMichael Stahl
Change-Id: I99eec60db7f6d586b3b424661e03a7891422ab2e
2016-05-25sw: boost::numeric_cast not really ideal in core codeMichael Stahl
... since that can't handle exceptions particularly well anyway. Negative position would be a bug anyway, so assert() is appropriate. Change-Id: Ib246200b3c64ec049fa39835d922092d5a660f55
2016-05-25Resolves: tdf#97879 loop in style hierarchy on odt loopCaolán McNamara
Change-Id: I0098c434b89b6a57e8b888a4d4f643e4d0865d29
2016-05-25Resolves: rhbz#89554 Dragging table to other page causes crashCaolán McNamara
Setting the Cursor pos causes a Calc which deletes the current page and everything blows up, so try a CalcLayout before setting cursor to avoid that. Change-Id: Ia7d132532f19e0164e125a240877caa9cf8bdc04
2016-05-25Window::SetData and Window::GetData are nearly unused nowCaolán McNamara
except for.. a) one use in sw which we can replace with a map b) one use in svx which didn't do anything c) one amusing piece of crazy in cui Change-Id: If66d9f7eab1eaddfb2bdab7815c3a6f22f4d7745
2016-05-25tdf#74795 RTF import: handle row-level default cell marginsMiklos Vajna
Change-Id: I5bdd7b8624a9e2ac1aef963ccc5ed457ebda3f84 Reviewed-on: https://gerrit.libreoffice.org/25443 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-25Convert XmlReader::Result to scoped enumNoel Grandin
Change-Id: I6a0d1dcf5ae51d2ac08aacdfec50865f93e51c21 Reviewed-on: https://gerrit.libreoffice.org/25365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Resolves: tdf#96244 get the right Writer window view for Formula windowCaolán McNamara
if you hit F1 and F2 together, then the help window is a writer window too (in disguise) so asking for the "active view" on processing the F2 in the real writer will get the help window as the active view, which doesn't match expectations. Take the view from the bindings, where its correct from when the event has been dispatched. Investigating a bit further, the F2 formula window only works correctly when its in an "active" window. So get the correct view from the dispatcher but only accept that view if its the active one. Change-Id: I2fd52ca6b68e887d34b07b70b830722f1d00b37a
2016-05-25Fix typosAndrea Gelmini
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24sw: prefix members of SwColumnMiklos Vajna
Change-Id: I5f7f0ae87a94e7bdb012bd73dea5cbb5115df448 Reviewed-on: https://gerrit.libreoffice.org/25399 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-24Implement basic TableStyle FamilyJakub Trzebiatowski
Change-Id: I3da13d26ced05e1948d483d432d6268b10c208b5 Implementing: getCount, getElementNames Reviewed-on: https://gerrit.libreoffice.org/25351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-24Convert XMLTextType to scoped enumNoel Grandin
Change-Id: Iac147e57784e11d29f2b34e60dc3c624d6090c8b Reviewed-on: https://gerrit.libreoffice.org/25367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert XmlReader::Text to scoped enumNoel Grandin
Change-Id: I4741b13fcf887a95b85886cb41f8236e128e81a2 Reviewed-on: https://gerrit.libreoffice.org/25364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Ia30ad12d63423252c527de096cd1ae0ba3fd6aa5
2016-05-23loplugin:unusedmethods in swNoel Grandin
Change-Id: I05e224bcc7d2b08cf1349c14e3acf274d422e109 Reviewed-on: https://gerrit.libreoffice.org/25145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Convert GradientStyle to scoped enumNoel Grandin
Change-Id: I1da151dd25648e363ba88bf88caa3e820f0ee424 Reviewed-on: https://gerrit.libreoffice.org/25270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23loplugin:stringconstantNoel Grandin
Change-Id: I4600970fc1eb288aeb6fd5fb55947d936981f491
2016-05-23Add a test for comparing table cells and table cell rangesslideon
Also add the method sw_CompareCellsByRowFirst into unotbl.hxx so that it can be used elsewhere, just like sw_CompareCellsByColFirst can. Change-Id: I4a88455ba73356013f9f630d07610825568c263c Reviewed-on: https://gerrit.libreoffice.org/25260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-23tdf#89329: use unique_ptr for pImpl in newXisco Fauli
Fix "error: declaration of ‘pImpl’ shadows a member of 'this' [-Werror=shadow]" too Change-Id: Ib0fc66375ed7d9ae700d5a81a2adb5975fcae592 Reviewed-on: https://gerrit.libreoffice.org/25319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: I7113a13ac36db5beef3a17e9849c1f5506df2374 Reviewed-on: https://gerrit.libreoffice.org/25194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert HYPERDLG_EVENT to scoped enumNoel Grandin
Change-Id: I8a0248bb91ee67596aa44d11ca862d2e127a65ad Reviewed-on: https://gerrit.libreoffice.org/25197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert XOUTBMP to scoped enumNoel Grandin
Change-Id: I8d10cdc78ca73d86bdc9aa08fca591f6eb85eb9e Reviewed-on: https://gerrit.libreoffice.org/25196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20Add test for checking the color of characters and paragraphsslideon
check_change_color.py only checked for page-related colors previously. Change-Id: I3b188db34c1f43ed6ed977f792615bb6646fbcce Reviewed-on: https://gerrit.libreoffice.org/25183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-19tdf#75757: remove inheritance on vector (SwTableBoxes)Bjoern Michaelsen
- move SwTableBoxes::GetPos(..) up to SwTableLine::GetBoxPos(..) - SwTableBoxes is empty over plain vector then, make it an alias Change-Id: I72420d4fe1042a713d3e82f3df66f18ccbfca3f6 Reviewed-on: https://gerrit.libreoffice.org/25166 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19tdf#98985 create merge results at the right timeOliver Specht
When using mail merge toolbar the resulting documents are now created on OK in Save/Print and Send dialogs. Additionally the 'To' is set in the save dialog and the MailMergeConfigItem ist not deleted twice anymore. Change-Id: I21f1f49d8bbd40c11b6f771e15b89e0f6c4bc87a Reviewed-on: https://gerrit.libreoffice.org/25104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>