summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I342465eb02709a7e07d3088ecbb427a7ae900d30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121472 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01tdf#42982 RuntimeException msg for SwXFrame::setName()Olivier Hallot
Change-Id: I1d92730d93e71403b6d0ad97eedef4e6ba00a642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121394 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-01tdf#143574 sw: textboxes in group shapes - part 1Attila Bakos (NISZ)
Introduce SwTextBoxNode class to support grouped textboxes, fixing the crash when entering a group shape, trying to add a textbox to one of the shapes. Test of crash fix: right click on a group shape. Select the menu item "Enter group". Select one of the shapes, and right click on it, and choose "Add Text Box". Note: textboxes in Writer are linked in SwFrameFormat class. Each textbox consists of a text frame and a shape. This object pair makes it possible to have complex content inside any kind of shape (pictures, tables etc. Group shapes have only one SwFrameFormat, but can have many shapes so that means they can only have one textbox. From now, each shape could have a textbox in a group. Please note this is only a preparation for that. Filter implementation and handlers are under development. Change-Id: Iae35c118f0e67697b289c30d0fad4f5e16501c02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120452 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
surely a lookup of i equal to rTable.size() is bogus ==75288== Conditional jump or move depends on uninitialised value(s) ==75288== at 0x1EC68C45: DelFlyInRange(SwNodeIndex const&, SwNodeIndex const&, SwIndex const*, SwIndex const*) (docedt.cxx:246) ==75288== by 0x1EDE68D4: sw::DocumentContentOperationsManager::DeleteSection(SwNode*) (DocumentContentOperationsManager.cxx:2096) ==75288== by 0x1FC27F2C: SwHTMLParser::DeleteSection(SwStartNode*) (htmltab.cxx:4945) ==75288== by 0x1FC231EF: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5219) ==75288== by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589) ==75288== by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020) ==75288== by 0x1FC25B38: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4189) ==75288== by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055) ==75288== by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589) ==75288== by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020) ==75288== by 0x1FC25B38: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4189) ==75288== by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055) ==75288== by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589) ==75288== by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020) ==75288== by 0x1FC25B38: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4189) ==75288== by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055) ==75288== by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589) ==75288== by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020) ==75288== by 0x1FC25BC5: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4194) ==75288== by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055) ==75288== by 0x1FC79B2C: SwHTMLParser::NextToken(HtmlTokenId) (swhtml.cxx:1787) ==75288== by 0x22060E6A: HTMLParser::Continue(HtmlTokenId) (parhtml.cxx:295) ==75288== by 0x1FC745AC: SwHTMLParser::Continue(HtmlTokenId) (swhtml.cxx:683) ==75288== by 0x22060CF5: HTMLParser::CallParser() (parhtml.cxx:279) ==75288== by 0x1FC73F7F: SwHTMLParser::CallParser() (swhtml.cxx:607) ==75288== by 0x1FC6FF90: HTMLReader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) (swhtml.cxx:238) Change-Id: I9583e5be41fe76f19c699394961ed2717a990cc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121351 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01Resolves tdf#142116 - Respect field shading color on dark backgroundHeiko Tietze
This reverts #100366# commit ce057f404b7b39df4a9259eecd90e28cf9a75fbd Change-Id: I50872e38a154f5d24bcfaafd11488508e3c52356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121359 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-01CppunitTest_sw_ooxmlexport7: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id6b673d744d5eb1249d9466feb7a4f3758802b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121393 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-31fix crash in select-allNoel Grandin
<vmiklos> noelgrandin: hmm, when simply typing "a\nb\nc\d" into writer and trying to select-all, i get a crash from the new SwFrame::DynCastTextFrame(). is that something you see? https://pastebin.com/raw/v00ncxXP is the backtrace <vmiklos> sounds like the old code invoked dynamic_cast<> on nullptr fine, but the new pFoo->DynCastTextFrame() won't work if pFoo is nullptr <noelgrandin> vmiklos, doh!, thanks, will fix Change-Id: I58966512551e90ded3d3ecd65fef9f083dc6d852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31uitest: sw: move find and replace tests to their own folderXisco Fauli
No need to have sw_findSimilarity for just one test Change-Id: Ifec7ee9cbc81492dcae95f330a697e03875ac3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121044 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-31tdf#143793 preemptive unit test for USE_FORMER_TEXT_WRAPPINGJustin Luth
Ensure that any efforts to sort out the back-and-forth issue of honouring wrapping in headers, footnotes, etc won't break old documents without even a whimper. Change-Id: Ic12595a8e25aff176e89adfaba51991d38db516c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121377 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
no idea why its like this in the first place, but I'm not going to change it decades later, just zero out the uninit bytes Change-Id: Ie5d875523999d465dc167ac4fedcb99d3825ae99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31tdf#135683 speed up writer layout cache accessNoel Grandin
can be hot, so use a std::unordered_map Change-Id: I70e34e80cad67536414c71facbe0222dd88c65a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-30tdf#144105 crash after closing edit address block dialogCaolán McNamara
use RemoveView to call RemoveDragAndDropListeners before shutdown to avoid RemoveDragAndDropListeners getting called during dtor and calling EditViewCallbacks::GetDropTarget on the destroyed host widget controller Change-Id: I63841b893d37d45cc44a0ffbaa534cf87c407615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30Removed executable bits on docx fileAndrea Gelmini
Change-Id: I811055f7fc5b05c9123a1fca4118bd469515239b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121269 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9dd1d0179e6d3096bbb1030341a731c2896392e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30tdf#103612 sw: fix confusing inheritance of section hidden flagMichael Stahl
SwSectionData has 3 confusing boolean members for hiding: * m_bHidden corresponds to the Hide checkbox in the UI * m_bCondHiddenFlag stores the result of evaluating the hide condition * m_bHiddenFlag is the final computed result that indicates that this section is hidden Now, the first 2 flags determine m_bHiddenFlag = true, but there's another possibility: m_bHiddenFlag is also true if there is a parent section for which m_bHiddenFlag is true (because of course this hides all section content including nested sections)... the latter situation is apparently handled in SwSectionFormat::UpdateParent(). The code in SwSection::SwSection() checks the parent's m_bHiddenFlag but then sets the child's m_bHidden, which looks very wrong, so remove this. Also adapt 2 other places that look like they should be checking a different flag. Change-Id: I58d9c878b58ad6cd878f450072178006b4c7ebb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121314 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-30tdf#142847 sw: fix textbox layout at wrap settingAttila Bakos (NISZ)
Setting wrap spacing of a textbox via its Wrap->Edit... dialog window, the textbox had fallen apart, if it was anchored as character. Change-Id: I6c48c7a631a93a874129f64e1bdc6b3e2051e64f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118281 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5f5cb10e7e1792caa39644fc973ba34c27d85eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9c75cc5581c3babe0d56d04ced3398925fa5151c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30tdf#144173 sw track changes: keep format of hintsLászló Németh
When a text has multiple character formatting settings enabled and a new one is applied with tracked changes, only one of the former settings is restored upon rejecting the changes. Follow-up to commit ee3171adb24a3d720466fa43bec869910333f892 "tdf#143918 sw: fix reject of multiple changes". Change-Id: I6f3fb52dbd536efaf084b1fc5b8032658353af91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121012 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-30flatten DocumentRedlineManager::AppendRedline a littleNoel Grandin
Change-Id: I2801aad45f11bd9b8a97fc63c2f005f946a02bf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-30sw: prefix members of SwGlossaryHdlMiklos Vajna
See tdf#94879 for motivation. Change-Id: I5f03b6646b77242f31a8c0c0510fe88f6f2af522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121262 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-30vcl: move TextLayoutCache into vcl::text namespaceChris Sherlock
Placed TextLayoutCache function into own source file and moved it into the new vcl::text namespace. With this patch we will have these vcl::* namespaces: namespace vcl::bitmap namespace vcl::CommandInfoProvider namespace vcl::detail namespace vcl::drawmode namespace vcl::fileregistration namespace vcl::filter namespace vcl::font namespace vcl::graphic namespace vcl::lok namespace vcl::pdf namespace vcl::table namespace vcl::test namespace vcl::text namespace vcl::unohelper namespace vcl::unotools Change-Id: Ia38c2d73715676a924cdbb0de6308a72a40ec3b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121206 Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-29tdf#135683 speed up large writer table loadNoel Grandin
no need to do this reregister check during import Change-Id: I254ad24f1802e9cee51786ce5e3253d62c74829f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-29no need for a vector hereNoel Grandin
Change-Id: Ie456abf9afeda887366b5be2f0161e3ec464e36e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-29micro-opt: prevent some vector re-allocsNoel Grandin
Change-Id: I183af9765f5afe6c552a83e8f4fd4d7edafe0427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-28speedup dynamic_cast to SwTextFrameNoel Grandin
which is a hotspot in loading some documents Change-Id: I7f1c48305cd40bcd9bee4baf219228f10cc297b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-28tdf#135683 speed up layout of large writer tablesNoel Grandin
by making dynamic_cast to some SwTable* types faster Change-Id: I5c5b2525ecfcdf3c0f648f32b4ccc21ba5ac40fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-27tdf#128106 sw: copy bookmarks at start if whole node is copiedMichael Stahl
The CrossRefHeadingBookmarks are always at index 0 so copy them if the selection also starts at index 0. This happens in SwDoc::SplitDoc() for the 2nd etc. chapter. Change-Id: I4765d497e65d3c8257f7eab59b8ba2088688967e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121147 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-27tdf#128106 sw: copy bookmarks in SwDoc::SplitDoc()Michael Stahl
Change-Id: Id35b8771b456b162ca653423d02788275a79443f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121146 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-27tdf#137363 DOCX filter: don't loose <w:ilvl w:val="..."> of paragraph stylesMiklos Vajna
This adds doc model, UNO API and DOCX import/export for this feature. The rest is not yet implemented (i.e. no layout, UI, etc.) An alternative would be to grab-bag the list level of paragraph styles, putting it to the doc model directly has the benefit that this is a step in the right direction. Change-Id: Idf7157e8a4177b4c2286d3cfb3d5acf2df845076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121141 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-27tdf#116315: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I29aa953d8541d45b003703ba91c143fc9760ceac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121135 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-27tdf#143904 fix direct character formatting copied into paragraph levelBalazs Santha
Currently, Writer copied the direct character formattings, and applied them on paragraph level, when inserting a new row in a table. This bug is a regression from 498d2b82187ec3ff58f076e0d15741e64c0505ba . Explanation, why this regression happened: MSO Word uses a paragraph mark symbol (i.e the control character than can be configured to be shown), which is imported in Writer as a 0-length hint. To fasten up the import of DOCX tables, the core applies the formattings from this 0-length attribute on paragraph level, directly before inserting a new row. All in all, to solve this bug, we needed to make sure, that we only copy the formattings, if it is from a 0-length hint. Change-Id: Iba52e9318cc588feda559339e42897568d009806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120624 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-27Resolves tdf#142115 - Make color of NotesPane customizableHeiko Tietze
* Color follows not Writer's section color and General's object boundary color for the separator line * Section color adjusted to Gray 1 for Dark scheme Change-Id: I5748c1ac3c0a4997edfffac786e3d247641fc637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121122 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-08-27sw: remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I7082c51ce73b69f27154fe7308df913a38973100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121129 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-26tdf#125743 sw: fix rendering of graphics bullet with linked imagesMiklos Vajna
Regression from commit d72145f9307c732ced4a546ac1e5093ec7c1a982 (Move BackGraphicURL property & friends to BackGraphic + fixes, 2018-03-01), the problem was that now SvXMLImport::loadGraphicByURL() produces a Graphic that has its type set to GraphicType::Default, but when paintGraphicUsingPrimitivesHelper() consumes this graphic, it expects that the type is either a bitmap or a metafile. Fix the problem by explicitly loading the image when the default-type, origin-url-set case happens: this is rendering, so no problem to load the URL and that will give us the expected graphic type. This is also meant to keep the original problem fixed, since we only load images when painting, not during import. Change-Id: I951bc92d05bb8ec57d2ba6958c47947f8f9b5c78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121082 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-26tdf#135164 add unit testJustin Luth
fixed by tdf#143605, but that was a bit different, so adding a specific docx unit test. Change-Id: I9f5a6b225277f1c1fdbfed7759919b3fd6e5dea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121008 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-08-26crashtesting: crash on re-export of tdf137357-1.docx to docxCaolán McNamara
#0 SfxPoolItem::Which() const (this=0xffffffffffffffff) at include/svl/poolitem.hxx:148 #1 0x00007fff9d0454a5 in sw::util::GetPoolItems(SfxItemSet const&, std::__debug::map<unsigned short, SfxPoolItem const*, sw::util::ItemSort, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> > >&, bool) (rSet=SfxItemSet of pool 0x5368720 with parent 0x0 and Which ranges: [(1, 55), (153, 153)] = {...}, rItems=std::__debug::map with 0 elements, bExportParentItemSet=false) at sw/source/filter/ww8/writerhelper.cxx:411 #2 0x00007fff9d1ceae4 in MSWordExportBase::OutputItemSet(SfxItemSet const&, bool, bool, unsigned short, bool) (this=0x7fffffff5348, rSet=SfxItemSet of pool 0x5368720 with parent 0x0 and Which ranges: [(1, 55), (153, 153)] = {...}, bPapFormat=false, bChpFormat=true, nScript=1, bExportParentItemSet=false) at sw/source/filter/ww8/ww8atr.cxx:351 #3 0x00007fff9ce92a66 in DocxAttributeOutput::Redline(SwRedlineData const*) (this=0x59e44e0, pRedlineData=0x68110d0) at sw/source/filter/ww8/docxattributeoutput.cxx:3199 starting happening at: commit 5e891c2ee82f2d7566ddb4e15b9c03cecb9fc1f8 Date: Thu Aug 19 11:47:53 2021 +0200 tdf#143939 sw: track format changes of the actual word Change-Id: Idb2b07368233152db519e70627b43847c7392128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#144089: sw: Add UItestXisco Fauli
Change-Id: I6ffa476180a58ba47268b4f4a8bc59f75738be29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121046 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-26Fix crash when drawing shapeSamuel Mehrbrodt
Fallout from 75cd2b0fa71c73ae815b80d8e42328024ea63555 Change-Id: I455519126d11bee1b809f9fd9476b2fdd0f1a524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121034 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-08-26CppunitTest_sw_ooxmlexport6: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I3f5dbe43d94eba90a44b39180239e7aed8242b05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121045 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-26indexing: move xml parsing into SearchResultLocatorTomaž Vajngerl
Let's keep unneeded complexity out of SwXTextDocument, so move parsing into SearchResultLocator. As a bonus we can now test parsing. Change-Id: I944bfc43e6953523eee19b26b7f483aa401809aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121032 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26tdf#144089: Revert "tdf#137737 i18n search: don't expand start/end with ↵Xisco Fauli
regex ^ or $" This reverts commit a511bffd67a9cebfdc878766581ac08c79d7ff51. Reason for revert: See https://gerrit.libreoffice.org/c/core/+/120981 Change-Id: If8a445448976a9963f76623d3d968b8d5e3d74dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120990 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-25Fix typosAndrea Gelmini
Change-Id: I13c41a077cd54102010c8253dee2455f235087c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121033 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-25tdf#143384 DOCX import: fix SAXException at header with tableAttila Szűcs
Regression from commit d656191ec308d4280b93c7169372e543a255d108 "tdf#119952 DOCX import: fix negative page margins". Add SwXHeadFootText::CreateTextCursor(bool bIgnoreTables = false) (modeled after SwXBodyText::CreateTextCursor) to create text cursor for copying the header/footer also started with table during fly frame creation in convertoToTextFrame(). Note: add hidden property PROP_CURSOR_NOT_IGNORE_TABLES_IN_HF to use the new feature in domainmapper (followed commit af4e5ee0f93c1ff442d08caed5c875f2b2c1fd43 "tdf#97128 DOCX import: fix frame direction"). Co-authored-by: Tibor Nagy (NISZ) Change-Id: I96e2cf2dddcecd146c53c12d7fdb44fc4d90fa0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119549 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-25tdf#64991 speed up loading large RTL documentsNoel Grandin
takes load time from 3min49 to 2min59 for me Use std::vector<bool> for RsidOnlyAutoFormatFlagMap, we only add values to the end so it is easy to correctly size this; and std::vectior<bool> is way more cache-dense Change-Id: Ia607c6a4d80a49a25d487d9ddde5041c166e966c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-25tdf#137737 i18n search: don't expand start/end with regex ^ or $Justin Luth
If the regex starts with ^, that means that it matches only at the beginning of the content. So don't expand the beginning of the content or else it won't match anymore. Similarly, $ indicates matching at the end of the content. For the unit test I just randomly guessed at SearchItem.AlgorithmType, and it kinda worked. I love black boxes... I hope I remember what i learned about TransformParameters() which was parsed in sfx2/source/appl/appuno.cxx, splitting the "variable" into Item.PropName = PropValue. That is definite black magic. Change-Id: Ie1640821a7a430e78dbe72c57a92aeaa9b5272a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120410 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-08-25tdf#143938 sw test: track format changes of the paragraphLászló Németh
Character formatting changes of the wholly selected paragraph weren't tracked before the following fix: commit 5e891c2ee82f2d7566ddb4e15b9c03cecb9fc1f8 "tdf#143939 sw: track format changes of the actual word". This is only an unit test to cover both fixed problems. Change-Id: Ia8ee15895fc309f4c57c54ac8e6b4265969b5256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120957 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-24tdf#127978 - Don't URL encode filename for navigator's tooltip (D&D)Andreas Heinisch
Change-Id: I3a5d6404755698be81818c4636fcc505992e1a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120936 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-24Resolves tdf#143633 - Image size wrong after disabling relative image widthHeiko Tietze
Adjustments added back, missing from 3cbecf3d0d9d68de286589e153ee31f8f709be03 Change-Id: Ia2f64fbf0792bd0916052c01e79b37d8820f8b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120940 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-08-24reduce cost of dynamic casting to SwFlyFrameNoel Grandin
which is often hot on doing document layout Change-Id: Ie78b6a6da4dba38b4ab682f4e1b9d86cc8171918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-22 10:44:19 +0000