summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-08-08forcepoint#69 ditch any unclosed m_pPosAfterTOC before dropping cursorCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/58498 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 71aae473c9c3cf15f75e2722afc7153a3af76d44) Change-Id: I6b56a48f5449b25fe3bdc2e02d3885388b0da74f
2018-08-08forcepoint#48 null derefCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/56463 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 6725491ce8ef2e41feb9b732ad7ac366ba545ca9) Change-Id: I790fc6dafc0d8c9783b9dddc266b313af2a046d7
2018-07-20tdf#101534 sw: fix lost indent attributes when copying into numbered paragraphMiklos Vajna
Commit aa91dc0ccbe53ffcec9dbfec2265de057775d4e3 (CWS-TOOLING: integrate CWS sw32numbf01, 2009-09-08) replaced the SwDoc::ReplaceNumRule() call with SwDoc::SetNumRule(), as the later handles list ids. This required a decision if resetting of the indent attributes is needed or not, but it did not document why resetting was chosen. On the other hand, the current bugdoc shows why resetting is a bad idea: this way if you paste into a numbered paragraph which has a non-zero paragraph indent inherited from the numbering + zero indent as direct formatting, then this later is lost during paste. Conflicts: sw/qa/extras/uiwriter/uiwriter2.cxx (cherry picked from commit 340eaa6aa15c18cc2696a4a304350810cb36565c) Change-Id: Ie5dcf6ed86c240fd61c4d5bfed886910aea3648f Reviewed-on: https://gerrit.libreoffice.org/57770 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-09tdf#118540: LO6.1b2: DOCX crashes when properties...Henry Castro
are opened in print preview mode Change-Id: Idc64d2b98dff157d28813dd3f90a276f8cacd11f Reviewed-on: https://gerrit.libreoffice.org/57024 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/57059 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-06-28lok: Don't even try to paint the ruler via LibreOfficeKit.cp-5.3-51Jan Holesovsky
But we need to have it behind the scenes, otherwise the Online's ruler does not get notifications. Change-Id: I72bef28cb15c462572b511449d538b067f7cb141 Reviewed-on: https://gerrit.libreoffice.org/56598 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-06-28sw lok: delay processing idle jobs to let LOK finish initializationAshod Nakashian
When loading document, LOK needs to setup the client view, register callbacks, get document size and type, etc. All of these need to take SolarMutex, which is taken by the idle jobs immediately after loading, blocking LOK from finishing initialization and rendering the first tiles for the user. This gives the user the impression that the document is loading for far longer than it actually is, due to lack of interactivity (or indeed any activity on the screen besides the spinning wheel). By delaying the idle jobs, we allow time for LOK to finish initialization and render the first tiles before the idle jobs kick in and hog SolarMutex. Change-Id: Ic6f437bfd6f43dfed2aaa1a9d3510d43f5ec30ae Reviewed-on: https://gerrit.libreoffice.org/56572 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-23Return correct length for Authority tokenMatteo Casalin
Regression from f4fd558ac9d61fe06aa0f56d829916ef9e5ee7b9 Take the chance to calculate token prefix just once. Change-Id: I19ce5cb037198cb918e79c760a92b285f9b725f1 (cherry picked from commit 34b98af8e5a4e568d8316700bea1ce604d825ce8) Reviewed-on: https://gerrit.libreoffice.org/52621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit c6e8460a5b47fa6fa971dde2a89e80662b6e97ae) Reviewed-on: https://gerrit.libreoffice.org/52626 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit df041d902eafb1e273eb360103252994bbd2cde2) (cherry picked from commit f2dd38e8aeb7501a5855950d40ddc1818725ff92)
2018-05-22tdf#116976 DOCX import: fix rel size of shape after bitmapMiklos Vajna
We have a queue of these odd relative sizes (which are not XML attributes but text inside the XML element), if the bitmap doesn't pop the queue, the following shape won't get its size. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport11.cxx Change-Id: I1602208c9509d8889bf0be254f3b25fb25fafca2 Reviewed-on: https://gerrit.libreoffice.org/54669 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-05-22Use vcl::DeleteOnDeinit for resource managers.Michael Meeks
Change-Id: I305c2dfd407f2606331a5950a3b36ee58e1d74d6 Reviewed-on: https://gerrit.libreoffice.org/54676 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-05-19Adapt writer translations dynamically for multiple users.Michael Meeks
Change-Id: Id152cc2a3e12acf4850b035f3b5dba7b54fa455d Reviewed-on: https://gerrit.libreoffice.org/53661 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-05-04set Referer on link mediadescriptorCaolán McNamara
to allow determining if the source document is from a trusted/untrusted location Reviewed-on: https://gerrit.libreoffice.org/53693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit cd25a97bbadc0a5c1fd6b0e8603c8b6ebd051926) Change-Id: I780568652d2ef0cc8543c27ba26289277b5d9d0c Reviewed-on: https://gerrit.libreoffice.org/53803 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2d87c267267530077a94c894bc619831b01d1c04)
2018-04-27tdf#117246 RTF import: don't loose page breaks inside nested groupsMiklos Vajna
Regression from e3f254ab8211fbab7541cde2100a35c875b0c240 (RTF import: fix spurious page breaks at doc end (related: rhbz#1065629), 2014-02-27), the problem was that now we update the parser state to remember the next section break should set the break type of the current section to "next page", but this state should be remembered once the RTF group ends ("}" character), otherwise \page will be represented with a continuous break, i.e. lost. (cherry picked from commit 4a93b46e4652e73ed3460e4c66999d94e50db4b7) Conflicts: sw/qa/extras/rtfimport/rtfimport.cxx Change-Id: I69a8413f45e17e11d6d676c7bfd13ca7560b4d43 Reviewed-on: https://gerrit.libreoffice.org/53510 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-04-27Fix OSL_ENSURE invocations.Michael Meeks
Change-Id: Ic217a75276956f200eaa539da0f5c06475106d0a Reviewed-on: https://gerrit.libreoffice.org/53540 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-04-26Use async dialog path for format columns.Michael Meeks
Change-Id: I7097abd68b5921697d1d5f39f5e81ac961b61226 Reviewed-on: https://gerrit.libreoffice.org/53539 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-04-20sw lok: Accept / reject change is always enabled in the context menuTamás Zolnai
Use conditional fastcall for allow executing these two uno commands even if there is no tracked changes at the cursor position instead of enable the menu slots unconditionally. See also: b6011f07254f8003929320ad842d8d09daca0e09 Reviewed-on: https://gerrit.libreoffice.org/53148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 67919621cb0b95074c4401bdfced9d87b230cc2f) Change-Id: Iaf8a8082961cd174c038fc021d2c41fb7cb97bff Reviewed-on: https://gerrit.libreoffice.org/53181 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-04-11sw lok: followup commit for change about scrolling to visible cursorTamás Zolnai
Revert small part of this commit: 83b7bfc0efefb3c77e5c59553320e98539250c62 Thanks Jan Holesovsky to catching it. Reviewed-on: https://gerrit.libreoffice.org/52684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 508013d799358bb1c92b5cfea5257fe53c695cee) Change-Id: I885c9f3da622052685d1e46f6358783fc7f8cb9a Reviewed-on: https://gerrit.libreoffice.org/52702 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-04-10sw lok: View jumps to cursor position even if it is moved by an other view.Tamás Zolnai
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling if the cursor is move by an other user. The second instance in the LO online code, for it we need to pass the viewid identifying the view which moved the cursor. Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52 Reviewed-on: https://gerrit.libreoffice.org/52220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/52675 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-04-07forcepoint #28 missing cell on abw importCaolán McNamara
Change-Id: I7633a17afab5aa2eb9e47a552bd5d92c87d383c7 Reviewed-on: https://gerrit.libreoffice.org/51853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 671e9453ed07f1cf537ee507d63976f54be8e465)
2018-04-07forcepoint#36 avoid dangling SvTextShapeImportHelper in case of exceptionsCaolán McNamara
Change-Id: Ibdbc047029c31d2b06d2349d68e1cbd9b15fd514 Reviewed-on: https://gerrit.libreoffice.org/52137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit c4674e8a1b04314fc45f6a8269cf6519b5fc012b)
2018-04-07ofz#6999 check available data lenCaolán McNamara
Change-Id: I89a7913d35706ee5797beee654ef99be088431b8 Reviewed-on: https://gerrit.libreoffice.org/51499 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit de7d754e8706eb9187ddfb9e87c4f00faa98ca17)
2018-04-07ofz#6827 Bad-castCaolán McNamara
Change-Id: I856d781f122c21c02a0a8cd01369d49f50b8a555 Reviewed-on: https://gerrit.libreoffice.org/51365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 19f0b25acc2a23b790301755a9fee2629eb667b0)
2018-04-07forcepoint #24 back() on empty vectorCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: Idb6723b53a1ae8aaca80847bfe643bc4abaedd21 Reviewed-on: https://gerrit.libreoffice.org/51123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 13468a3a667c6719ccbc44c913c194fc77d8e7cf)
2018-04-07ofz#6827 drop last anchor pos if it will be joinedCaolán McNamara
Change-Id: Ib36b74b455f741d9dcccbdf244d21453837bda3c Reviewed-on: https://gerrit.libreoffice.org/51100 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f79c3fbd8a9c4e89346e042cc31397bd6e277e09)
2018-04-06sw lok: Don't try to open TOC marks in a new window, jump instead.Jan Holesovsky
Change-Id: I1ecae82c4b1e08383f6957c38cb70b91fc3549d4 Reviewed-on: https://gerrit.libreoffice.org/52504 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-04-03tdf#116472: import "auto" border color as blackMike Kaganski
Since commit fe6da2feb57c3d5e355a36f6b8ac09b48412ff39, "auto" color is supported in OOXML import. Since ODF doesn't support "auto" color as border color, just convert "auto" border color to black on import, like is done in GetLineIndex in ww8par6.cxx. Incidentally, this also fixes a problem in RTF import, where we used to import black borders ("\red0\green0\blue0;" entries in color table) as 0x000001 ("\red0\green0\blue1;") - see fixed tests in rtfimport.cxx. Change-Id: I4f5e720d215b51c8a43dc7c58f338741bd608efc Reviewed-on: https://gerrit.libreoffice.org/51519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51585 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/52272 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-04-02tdf#116179 Support reading "auto" colour from docxLuke Deller
In docx a colour value is represented as a 6-digit hex RGB value, or alternatively the word "auto" to represent automatic colour. - Add support for reading the value "auto" as COL_AUTO. Previously this would be read as if it were a hex value, stopping at the letter 'u' which is not a valid hex digit, resulting in the colour 0x00000A - a very dark blue, which looks close enough to black that it went unnoticed for a long time :-) - Remove code which tried to handle this wrong 0x00000A value, including the constant OOXML_COLOR_AUTO, as it is no longer needed and will cause surprises for anyone who really wanted this exact shade of dark blue - Fix unit tests that were checking for 0x00000A Reviewed-on: https://gerrit.libreoffice.org/50995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/51461 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 3967aebca94be9ceea3e36b43f7f53589473ad4e) Change-Id: I6000070341931147ff9341ad6281cd3b53c02b46
2018-04-02tdf#107035 Fix field character style DOCX importLuke Deller
Reinstate a call to DontExpandFormat which was removed from appendTextContent in commit 232ad2f2588beff50cb5c1f3b689c581ba317583 This ensures that direct character formatting which ended immediately before the insertion point will not be expanded to cover the inserted content. Reviewed-on: https://gerrit.libreoffice.org/50729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 18cbb8fe699131a234355e1d00fa917fede6ac46) Change-Id: Ie5fa6b5c5acee4f885f9e67535e98801af23661a
2018-03-29Remove second part of these redlining related tests.Tamás Zolnai
These parts seems to be unstable. The first assertion also tests the main use case, so we don't loose to much with removing this code. Change-Id: Ic3372ae43f1c6d5c3d342f3428cce514c0cd3dc1 Reviewed-on: https://gerrit.libreoffice.org/52037 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-03-23lok: don't post events on disposed windowPranav Kant
Change-Id: I7721380b1bb6e9ec21338a72523326d0cae6729e Reviewed-on: https://gerrit.libreoffice.org/51778 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-23tdf#115861 DOCX import: avoid last-paragraph removal when discarding footerMiklos Vajna
Discarding header/footer is necessary when the document or section settings request to ignore first or even headers/footers. In the bugdoc case settings.xml didn't opt-in for different even/odd footers, but there was an even footer to be ignored. Handle this state at two more places, so we don't end up in a situation where we ignore the footer but not its "remove last (empty) paragraph at the end of the footer" action. Also make the debug dumper for text ranges more robust to have a working token dump when we try to get the string for a table. (cherry picked from commit 49cf733effc56c09c5e2eb023120c2d3532b5b3d) Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport11.cxx Change-Id: I6395f37aa40c42304e2c918d87dadecb21e9d378 Reviewed-on: https://gerrit.libreoffice.org/51763 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-03-19tdf#112118: Use correct border when calculating marginMike Kaganski
This is a longstanding (at least since 2000: already present in commit 7b0b5cdf) error where left border linespace was used when calculating right margin. It was copypasted from ww8 import to ooxml code verbatim. The problem only manifests itself when left and right border spacings are not the same; and since we had other errors in the borders import, that additional problem simply wasn't apparent. Also use scaled border width in border distance/margin calculations. Unit tests updated. Change-Id: I70961e1bde29471def69e1ef944ba2779cffe307 Reviewed-on: https://gerrit.libreoffice.org/51474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51489 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-19tdf#116403: consider borders when updating right-aligned tab in indexMike Kaganski
Change-Id: I415d8fcfdd75e6d608ec2e3ba228146cf8139278 Reviewed-on: https://gerrit.libreoffice.org/51388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51488 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-19tdf#112118: DOC: properly import/export border distanceMike Kaganski
DOCX part was done in fb959e581c900b392efd0bb329b7cf30c8ed56a5. This commit fixes DOC part. Line width wasn't taken into account on import; and export was done only with "from text" distance, which gave poor interoperability with Word, where the borders were close to page edge. The common code is moved to editeng/source/items/frmitems.cxx and include/editeng/boxitem.hxx. Change-Id: I3d1d1312cb9dc9a9e00d9847ec11234cd787df60 Reviewed-on: https://gerrit.libreoffice.org/51366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51487 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-19tdf#112118: DOCX: properly import/export border distanceMike Kaganski
https://wiki.openoffice.org/wiki/Writer/MSInteroperability/PageBorder discusses implementation differences between ODF model and MS formats wrt dealing with page margins and distances to borders. This patch corrects import from DOCX, so that the border distance and width doesn't add to the margin size imported from file anymore. It takes care to preserve size from page edge to text (the most important size that affects document layout). When borders go outside of range valid for ODF, the margin is set to keep text area intact, and the border is placed as close to intended position as possible. Export code now also properly handles border width. Also, an improved heuristic implemented to better export cases unsupported by Word, so that the result would look closer to ODF original. We still write correct sizes to OOXML, so that when reopened by LO, the borders will be in correct places; but as Word cannot handle sizes more than 31 pt, it will show borders shifted. This prevents from adding border widths and distances to page margins at each opening of DOCX, saving back the changed value, increasing the margins each time. Change-Id: Ia978ab119dd661949d6c321aea91397f28d205b0 Reviewed-on: https://gerrit.libreoffice.org/51267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51399 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-19lokdialog: Set parent for AutoCorrect Options... so that it can be tunneled.Jan Holesovsky
To get this dialog: Right-click on a mis-spelled word, and it's in the tunneled context menu. Still it should be converted to async though. Change-Id: Ia8f2aaf0d04f144c74999107de98e52cd51876e7 Reviewed-on: https://gerrit.libreoffice.org/51441 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-16coverity#1427648 Dereference after null checkCaolán McNamara
Change-Id: Ib4be7b819a5ba68d78d98d8ae05d755898f3cad1 Reviewed-on: https://gerrit.libreoffice.org/48136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 432f4369cdb62fd05abbde50804ff4e1d5011f39) Reviewed-on: https://gerrit.libreoffice.org/51444 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-14sw: remove duplicate "MsWordCompTrailingBlanks" view settingMichael Stahl
This is already a document setting, no point in writing it twice into settings.xml. (cherry picked from commit 7667675397c98bb38cdd14dd689a32e9f8a986d3) Change-Id: Idcc99a194df321e11e091a2388b919e11fe94316
2018-03-14tdf#104349, tdf#104668 MS Word compatibility trailing blanks optionVitaliy Anderson
The commits: 1c1747ac13a9d895df0fcba2fbb1bd266dccd74b and 4a410dd147f7160c1d62e3e0b67388a178d5136c make trailing spaces and their highlighting compatible with the Ms Word. The option is enabled by default for imported MS Word formats: .doc, .docx, .rtf For the ODF files the option is disabled by default Also it allows saving and loading the option state to the ODF UserData. It may be manually set in Tools->Options->LibreOffice Writer->Compatibility Reviewed-on: https://gerrit.libreoffice.org/33046 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 7fa20da88a4778bdf20d6ca0491fe97ae03ab554) Change-Id: I5a86359c52d18e50bbb54b9f37c79b672591c369
2018-03-14avoid crash in 130+ odt export testsCaolán McNamara
e.g. fdo44181-1.ott to odt Change-Id: I23403415378ddf50ff007fb4b5d88b4009668bf6 (cherry picked from commit 2085d8203b0ff49b6e43ff900f497fb5343708d8)
2018-03-14tdf#104349 remove the difference between MSO and LO highlight charsVitaliy Anderson
Change-Id: I5daadef359260ea74b828567197228633bb972ca Reviewed-on: https://gerrit.libreoffice.org/31783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 4a410dd147f7160c1d62e3e0b67388a178d5136c)
2018-03-14tdf#104668 remove the difference between MSO and LO text alignmentVitaliy Anderson
Change-Id: Id1964d87f6f4ec3dbcd617af2251a321c50ec428 Reviewed-on: https://gerrit.libreoffice.org/32213 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 1c1747ac13a9d895df0fcba2fbb1bd266dccd74b)
2018-03-14lokdialog: more, convert the dialog to async execHenry Castro
ClassificationDialog -> To trigger this dialog: enable TSCP Classification toolbar click toolbar item "Classification Dialog" SwWatermarkDialog -> To trigger this dialog: Format -> Watermark... SwWatermarkDialog --- Obs: the ClassificationDialog is not implemented in cp-5.3 branch Change-Id: I835648df8df5ad3ee5a404a582c2179e5b3b276a Reviewed-on: https://gerrit.libreoffice.org/50771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50784 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13bccu#3100: Writer: Change tracking boxes aren't repositioned with editingTamás Zolnai
Emit a notification related to the node position change, so the track changes comment box is repositioned when the text node changes it's position. Reviewed-on: https://gerrit.libreoffice.org/50640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit b687cebfb1488341853824de1a15c06175c94258) Change-Id: I34b5ec453b3dc43895865f15d71aaead46ae6f24 Reviewed-on: https://gerrit.libreoffice.org/50766 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13lokdialog: Guard the SetLOKNotifier to be used only with LibreOfficeKit.Jan Holesovsky
Change-Id: Ia15a3d7a36ad280270ed066392f6b67b3f32f234 Reviewed-on: https://gerrit.libreoffice.org/51199 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-12lokdialog: Tunnel the spell-checking context menu with recommendations.Jan Holesovsky
Change-Id: I1a7952e88a3f89346c97d2516628b4a7a0423de6 Reviewed-on: https://gerrit.libreoffice.org/51062 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-12Revert "lok: Don't freeze the LibreOfficeKit via the spell-checking popup..."Jan Holesovsky
We want to re-introduce the spell-checking context menu, and use dialog tunneling for that. This reverts commit eb5e45782b0e805455d383e9d020aae5bb70d619. Change-Id: I068585b9e70409fe3e64f2d7039fb4a23af08738 Reviewed-on: https://gerrit.libreoffice.org/51061 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-08oox customXml: Don't write the Relationship to DOCX files twice.Jan Holesovsky
Change-Id: Id3da40138e86c142707e377aa897df372aacb704 Reviewed-on: https://gerrit.libreoffice.org/50943 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-07oox: unit-tests for custom package preservationAshod Nakashian
Change-Id: I69d0d7d6bdc8804d0e56be19cd86a699200fc85f Reviewed-on: https://gerrit.libreoffice.org/50895 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-06forcepoint #17 nTextBreak is an index into pKernArray of len rInf.GetLen()Caolán McNamara
Change-Id: I3afeaf987cc5e75362560165fea7230904530933 Reviewed-on: https://gerrit.libreoffice.org/50630 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c21fbf68da2b1ac0da3668f9494f9a8f5c4322c8)
2018-03-06forcepoint #10 pop empty stackCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/50359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit befd67bcd0607bf2f0116a5418f3c7278e471631) Change-Id: I96452a86187a6b03251614625445d1b18a5ee218