summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2022-01-12tdf#144270 sw: manage tracked table (row) deletion/insertionLászló Németh
in Manage Changes dialog window, where deleted/inserted tables and table rows were shown as multiple cell changes, as a regression. Now a single table deletion/insertion or deleted/inserted consecutive table rows are shown with a single tree item in the dialog window instead of showing multiple cell changes. Add new Action icons to the tracked table row insertion/deletion tree items (re-using table row deletion/insertion icons). Show cell changes as children of the single parent item tracked table row change. Accept/Reject and Accept/Reject All support 1-click acceptance or rejection of table (row) changes, instead of clicking on all cell changes of a single table (row) deletion/insertion. Regression from commit c4cf85766453982f1aa94a7f2cb22af19ed100be "sw: fix crash due to redlines on tables on ooo121112-2.docx". Change-Id: Id03a8075cc6849b70a8d32e1a955b79e7d3a3246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128314 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-12gbuild: build static LO / link static executablesJan-Marek Glogowski
This allows to build a complete static LibreOffice on Linux, except for linked externals. Since LO's static build implies disabled dynamic loading, one must select one VCL backend to be compiled in. See the (large) comment in solenv/gbuild/static.mk trying to explain, why this implementation was chosen (spoiler: seems there is no other way) and what is actually implemented. This will collect all libraries, statics and externals of executables. If the executable uses components, it will get linked to all static components. While it works with any Executable, it just makes sense for soffice.bin, because the static component map sucks every dependency in, bloating most other binaries. In theory on could generate the dependencies based on the list of used components (see gb_CppunitTest_use_components), then generate a specific static constructor map, directly include it in the exe's cxx code and then link the minimal dependencies. The static LO should build on Linux with: --enable-customtarget-components --disable-dynamic-loading Tested VCL plugin config is: --disable-gtk3 --disable-gen --enable-qt5 The partial build support is split into a 2nd patch. Change-Id: Iafc95752fae9e88095f54a21f1e30a4f080815e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126790 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12CppunitTest_sw_odfexport: rework to avoid preTest()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ie7187c7a843a191475688a4a6390514199c6a1c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128298 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-12Fix typosAndrea Gelmini
Change-Id: Ib132f2582fce1fb62755926d3f55987ea474ec74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128297 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-11sw: fix swapped inner vs outer border for Word-style left table bordersMiklos Vajna
The minimal DOCX bugdoc has a single cell, the left border style is thinThickMediumGap, the right border style is thickThinMediumGap, which means the doc model already has the left/right mirroring, don't have to do it at layout time. The normal Writer way is to have a single border style and mirror the right/bottom border line. But then looking at the Writer vs Word output, inner vs outer is swapped, so at the end we have to mirror the left border line for Word-style table borders to get compatible output. Change-Id: I10fb95dfac67e466188cfc9ecf35efde806c14b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128289 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-11tdf#146605 sw: try to fix SwSectionFormat notificationsMichael Stahl
SwSectionFormat no longer notifies via its SwModify to SwClient listeners, but only via SvtBroadcaster, so SwSection and SwSectionFrame need to be SvtListeners. This can be seen when changing the footnote-at-end setting in the section dialog, if the SwSection doesn't get the event the footnote numbers aren't adapted to a new restart value, if the SwSectionFrame doesn't get the event the footnote container isn't moved. This is of course not pretty but hopefully it will be refactored further in the future. (regression from commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a) Change-Id: I93c616e209a01fc5d4c8eba701a6ddce5d5b432e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128257 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-11sw: document SwPagePreviewWinMiklos Vajna
SwPagePreviewWin is just a widget, owned by SwPagePreview, which is a view shell (more or less an opened window). Change-Id: I8f93ef354412273f85e9d4a5b375a3e2b7412221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-10uitest: executeCommand doesn't return anythingXisco Fauli
Change-Id: Ie59ed6926c42b96471f3b74a9547f7f1f2cd175a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10sw: stop inheriting SwSectionData::m_bProtectFlag from parent sectionMichael Stahl
This is actually no longer inherited by accident since commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a because it replaced the SwSectionFormat::Modify()->ModifyBroadcast()->CallSwClientNotify()->CallSwClientNotify() with a call to GetNotifier()->Broadcast(), and apparently SwSection is a SwClient of SwSectionFormat but not a SvtListener. But some consider the new behaviour useful, as previously there was no way to un-protect a section inside an outer protected section at all, while in this way every section can have its own independent protection flag. (The m_bEditInReadonlyFlag is not used for this purpose, as it is only for the case when the document was loaded ReadOnly.) So make it more explicit by removing the SwSection inheritance code. A similar change was made for hidden flag in commit 91b0024965908c692bea40f47c58ea9d1bf8a596 Change-Id: I29d3c84309a84267573950775f2a1c6353623724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128221 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-10use less SvStream::Flush()Noel Grandin
Flush() turns into a sync() on the device, which is pretty slow. Most of the time all we actually want to do is to flush the internal buffers from the SvStream. So expose the FlushBuffer method and use that where possible. And also means we don't need the mbDontFlushOnClose flag on SvStream any more. Change-Id: Ibe089b88b325f0fdc565200a97ce72cd26b7fcfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-10sw: prefix members of ConstRectangle, SwBaseShell, ...Miklos Vajna
... SwJumpToSpecificBox_Impl and SwZoomBox_Impl See tdf#94879 for motivation. Change-Id: I5daf3f0a2c0c712a554aa32a6a219acb07d64a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128201 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-10document GenericCheckDialog, GraphicSizeCheck and related classesTomaž Vajngerl
Change-Id: If3f8c33601f7823c87b75d601e0b8620d4bfe197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128205 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-10Move HAVE_MORE_FONTS into an extra config headerJan-Marek Glogowski
No need to recompile most of LibreOffice, because the --with-fonts configure flag changed. This preprocessor define is just used by unit tests anyway. Change-Id: Ia2eae7d0c74e59e034fdd8513504a34e51ab428e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128197 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-09tdf#90497 Replace Open Sans -> Noto SansOlivier Hallot
See comment #19 of tdf#90497. Change-Id: Ic102e2155ae97cb191b13f883d7c2fcec6b9a38a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128139 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-09Try a different approach to fix ofz#39303Jan-Marek Glogowski
... to get rid of all the "unused, assigned variable" compiler warnings. Reverts commit 619dcf67c1f770685c6b40477f15657f70c05865. Change-Id: I5a8bf190f00e7698f806b807b2cbfeb8fb63c766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128182 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-09Replace single sw.level2 log area user with area swJan-Marek Glogowski
Change-Id: I3df5c5f937361a7a0283a05a7b9c6669bb404c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128183 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-09SwNavigator: Fix outline select when table is the only contentJim Raykowski
Prior to this patch for outline content having only a table(s), right- click on an outline entry without the cursor and choosing 'Select' from the context menu only selects the outline paragraph when the current cursor position in the document is after the outline to be selected. The solution given here is to move the document cursor to the outline being selected before the outline selection is made. Change-Id: Ie25bfc81306dfb10a8ced8369e0ee7de0f3eacff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127884 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-08Fix typoAndrea Gelmini
Change-Id: I4d16867dece00154161fef0344d521aae24be288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128130 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-08tdf#144890 Invalid selection area when text in LTR runNoel Grandin
In commit ec50b9e5eaec7c94df35617676077ef0d65cecc7 no need to allocate Sw2LinesPos separately on heap I made this change, // If there's no doubleline portion involved or start and end are both // in the same doubleline portion, all works fine, but otherwise // we need the following... - if( pSt2Pos != pEnd2Pos && ( !pSt2Pos || !pEnd2Pos || + if( (pSt2Pos || pEnd2Pos) && ( !pSt2Pos || !pEnd2Pos || pSt2Pos->aPortion != pEnd2Pos->aPortion ) ) I tried to follow the explanation in the comment, since the existing comparison of pointers made no sense, since the two objects would always be distinct. However, that appears to have caused this bug, so change the comparison to directly represent the original logic. Change-Id: I95d6d870cecd762d4eb809d371e4a61b6641c85e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07tdf#146084 Don't warn for languages without hyphenationHossein
Upon opening a Writer document containing some languages that do not use hyphen, an alert is created with the text: 'Missing hyphenation data Please install the hyphenation package for locale "ab_CD".' in which 'ab_CD' is the locale. This patch removes the warning for these languages, that do not use hyphenation: * Arabic script languages (except Uighur) + Persian (Farsi) + Kashmiri + Kurdish (Central Kurdish and Southern Kurdish with Arabic script) + Punjabi + Sindhi + Malai + Somali + Swahili + Urdu "Words are not hyphenated in Arabic language text, however hyphenation is possible for Uighur text written in the Arabic script" https://www.w3.org/International/i18n-tests/results/word-break-shaping The list from MS documents is lenghty, but some of the languages are were not available in LibreOffice, so they are ommited: https://docs.microsoft.com/en-us/typography/script-development/arabic There were languages like Hausa and Kanuri from Nigeria that use both Latin and Arabic script, but only Latin script was listed in the LibreOffice languages, so they were also ommited. * CJK languages + Japanese + Korean + Chinese + Yue Chinese "CJK languages differ from European languages in that there are no hyphenation rules" https://tug.org/TUGboat/tb25-0/cho.pdf * Vietnamese "In Vietnamese all words consist of single syllables, so they are often very short; hyphenation is not allowed at all." https://tug.org/TUGboat/tb29-1/tb91thanh-vntex.pdf Hyphenation is declined in Vietnamese orthography since 1975 https://www.quora.com/When-did-hyphenation-decline-in-Vietnamese-orthography The fix for Japanese (tdf#143422) was previously done in: 53d5555f13371252874ec962dee4643168d26780 and the functionality is preserverd with the current patch. An alternate approach would be adding all the unicode scripts, specifying the script for each langauge, and decide upon the script (mostly) and not (only) the language. More information about the hyphenation usage of many scripts can be found in: https://r12a.github.io/scripts/ This is the list of Unicode scripts: https://unicode.org/standard/supported.html https://en.wikipedia.org/wiki/Script_(Unicode)#List_of_scripts_in_Unicode Change-Id: I7d2b4ee55a0893d1f0d1f9cd3b7cc037a49589b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126435 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07Resolves: tdf#146342 spelling menu doesn't appearCaolán McNamara
the XPopupMenu from CreateMenuInterface owns the vcl menu after it's created. Change-Id: I0959b3359a4683ce8ca50912136f829b8bbee859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07Resolves: tdf#146285 the "edit" button should be insensitiveCaolán McNamara
for this case Change-Id: Ib60577d10bd4a91ea01c5aa6fcf3d50b38fbe24d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07sw: remove debug code that doesn't build anymore in ww::SortedArrayMiklos Vajna
It also claimed "You will not see this message again", but I don't see how the matching flag would be static. Change-Id: Ia003dc9c6326d44ad4f4409bed6aca490bfc964e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128064 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-07remove debug codeNoel Grandin
accidtionally committed with commit 302b44125aa0c1d5216f986ecf8e341cd6e57418 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Dec 9 11:45:36 2021 +0200 use background XShapeGroup for bar-chart area Change-Id: Id9fd82a94fd2bb046901fcd4373aac71586d0d13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06sw: fix too long inner borders intersecting with outer borders for Word cellsMiklos Vajna
This is similar to commit 66ac8e60896f6306bed8fbb34606fd14474f19ce (sw: fix unwanted long vertical border around vertically merged Word cell, 2021-03-04), but this one is about how we handle table border painting when an inner border intersects with an outer border. Previously we used to paint the full outer border and the full inner border, which looks silly in case you have e.g. double border outside and a single border inside -- the inner line stops at the edge of the thick outer border in Word. Do the same by limiting the start of a horizontal line if its start would match the X coordinate of a vertical line (and the remaining 3 combinations of hori/vert line start/end). We always limit the inner line, so this needs extending SwLineEntry if the line is an outer one or not. Change-Id: I669a271ce3a4c3c69916779d4f3167208e999f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128053 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-06tdf146491 Revert "tdf121374 ooxmlexport: export H/F to def...Justin Luth
...default section" This reverts LO 6.3 commit e6f5dec3250b4d26bc4bb485fad2100ee29a3528. Something else must have changed because it doesn't seem to be needed anymore. It wouldn't be terrible to duplicate headers/footers unnecessarily, One side effect is that page styles could be duplicated multiple times if there were many non-overlapping sections. If the H/F contained images, that could bloat the filesize, or in this specific bug, it was duplicating fields. Since it doesn't appear to be necessary anymore, let's just revert it. Change-Id: Id95a4f162fb2ecbf6ce0f97db056071db9ebad3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128041 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-01-06use background XShapeGroup for bar-chart areaNoel Grandin
which means we don't have to set the Z-order, which is expensive for large charts. Shaves 5% off the load time Change-Id: I8c73df6ddc17a3cfedaa18dbe8ec3aeb768e3e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapesAttila Bakos (NISZ)
Text boxes in group shapes were imported as shapes, losing complex text content: tables (tdf#66039), colors (tdf#73022), images (tdf#81958), lists, paragraph styles, hyperlinks (tdf#122960) and track changes. Note: a few unit tests have been deactivated temporarily. Test document "groupshape-trackedchanges.docx" of testGroupshapeTrackedchanges is imported correctly now: with track changes, and the test was modified accordingly. Follow-up to commit 2951cbdf3a6e2b62461665546b47e1d253fcb834 "tdf#143574 OOXML export/import of textboxes in group shapes". Change-Id: I6eb918dbf64393fd723fe43f798f93b5b9a12575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125051 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-06sw textbox: pShape -> pFormat for frame formatsMiklos Vajna
A frame format can be a fly or a draw frame format. Only the later is a shape. Also this way the parameter name in the definition matches the declaration, improving readability. Change-Id: I69e51bfaceba925002d23cdfb5fa6d60afa3c550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128023 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-05Fixed tdf#143142 when unable to scroll table column width properties.alt
Fixed the issue when unable to scroll table column width properties on some occasions. Change-Id: Id0a89d248d2a4effc0cb08ca0dc60aa23f66d70e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127938 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-05tdf#146489 writerfilter: ensure only character propertiesJustin Luth
This is another RTF regression found against LO 6.0's commit fdfdea4d5af51a68f2d497cc5c3359d74c385fd5 tdf#82173 writerfilter: apply char properties to footnote The original commit in LO 6.0 intended that only character properties were used. A follow-up commit for RTF tried to ensure that these would be on the top of the stack. However, in this case, it seems like somehow the table is getting involved in putting the paragraph context on the top. (Actually, there is no GetTopContextOfType(CONTEXT_CHARACTER) at all.) In any case, aFontProperties should only contain character properties, so ensure that. The unit test shows that there is still some kind of import problem, because the footnote marker should be a large, red character, but it is just normal text. See tdf#108949. Change-Id: I1ea7256891b198046f79f0d3a36e43d6c2ae3383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127943 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-01-05CppunitTest_sw_rtfexport5: rework to avoid mustTestImportOf()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id694d789fdf68dbce4e323b74455798f48be53c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127972 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-05tdf#134960 tdf#146419 use sorted array to list hyperlinks in NavigatorJim Raykowski
in document order The current approach of using layout position to list hyperlinks in document order works for single-page view but not for multiple-page or book view. This patch makes the list order layout independent by using SwPositions to sort the hyperlinks in document order. Change-Id: Ie09ac362aa0e8db813430de50c7f06f3072179f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127856 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-05Fix typoAndrea Gelmini
Change-Id: I1fa74a81f30e8e20aea60f5954d7a6a37080bcab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127977 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-04tdf#146264: Add unit testTor Lillqvist
Make sure the text is not duplicated in the output. Change-Id: I1600d18f0921d2ab2cb67898bc02b68f0f9b36c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127935 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-01-04Drop all commented SAL_DEBUG callsJan-Marek Glogowski
Change-Id: I3be7153d27b83766303519e73d1a355ba327871a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127929 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-04sw: document SwDrawTextShellMiklos Vajna
It's only for shape text, not everything editeng-based (e.g. comment text is not handled here). Change-Id: If76bf16c16e6cbf6f9f4c31f234e2d10f6bc9dd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127911 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-04Outline folding: Check frame area is valid before using pointer toJim Raykowski
saved outline frame It seems when a frame is removed it is not immediately destroyed, so a pointer to the removed frame may not be a null pointer. This patch checks for valid frame area definition before using the save outline frame pointer with intention to fix an intermittent crash occurrence when an outline paragraph is removed. Change-Id: I4f9b55acc6aeb83553a3f26c2701159c2ba439a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127717 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-04tdf#134960 SwNavigator: Improve table content member list orderingJim Raykowski
by sorting by table node index in the document model This has advantage over sorting by frame layout top position because it always shows the tables in the order they appear from start to end in the document independent of single-view, muliple-page, or book view. Change-Id: I9103c32bbb32afd44e0528b1c7744812075b2339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127828 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-03tdf#143574 OOXML export/import of textboxes in group shapesAttila Bakos (NISZ)
In this part, oox module has been modified in order to prepare for WPG handling during OOXML import. Note: Wpg is the drawingML equivalent of v:group, supporting text boxes in the group. 1) Added new parameter for WpgContext to support nested Wpg shapes, and WPS enabled for the WPG member shapes. 2) A bug has fixed, where group member line shape and connector shapes have wrong positions before in the group. 3) Unit tests had to be modified, and 3 of them disabled temporarily due to missing Writerfilter implementation (what will be the next commit) Now group shapes can have textboxes and the text is imported for that, but complex content is still missing (this will be fixed in writerfilter by the next commit). Known issue: WPG shapes with textboxes in floating table have issues during import at floating table conversion, so until this is not fixed this function is disabled for shapes in tables (will be fixed a follow-up commit later). Follow-up to commit 19394a924fdc486202ca27e318385287eb0df26f "tdf#143574 sw: textboxes in group shapes -- part 4". Change-Id: I71032187697807087bd8f27f7c3a7b052e174bd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124964 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-03tdf#98736 OOXML export: keep CaptionShape as TextShapeTünde Tóth
Caption shapes were lost during OOXML export. As a workaround, export them as text shapes, losing only the leader lines, but not their text shapes and text content. Change-Id: I372708fa4c9356c807a0a239c722691fd88ec1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126123 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-03sw: prefix members of ConstCustomShape, SwXAutoTextContainer, ...Miklos Vajna
... SwXAutoTextEntry and SwXAutoTextGroup See tdf#94879 for motivation. Change-Id: Ie09cd100e1ecc29a7e5e4b68d566785ba63e5da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127881 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-03tdf#129448: Auto first-line indent should not be effected by line spaceKevin Suo
Previously, if you set the first line indent to auto, then if you change the line height, the first line indent will also change. I do not see a reason to change the first line indent value in case of change in line spacing, even for English language. Some languages (e.g. Chinese) may have set the auto first line indent to be 2 characters of the current font, but if the first line indent changes when line height changes, then this 2-character rule is not possible. For compatibility with old documents, a compatability flag 'AutoFirstLineIndentDisregardLineSpace' is added in this patch, thus this patch only has effect to new ODF documents. DOC/DOCX documents will also benefit from this patch, no matter old or new, because, as Miklos Vajna has pointed out, Word does not have the auto first line height feature. Change-Id: I1e2ddc33cce4ff9b3b2b4122445894f724d5bcd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125627 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-02ofz#43052 crash in WW8TabDesc::MergeCellsCaolán McNamara
Change-Id: I4d7acc006458598ad43033fa8e35b2f422d76ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-02Introduce OUString::unacquired(const OUStringBuffer&)Mike Kaganski
... and avoid OUStringBuffer::toString when the temporary is used for checking current buffer content Change-Id: I114178f3e74ca3e4a3e517763f9eaab4797b7deb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-02Fix typoAndrea Gelmini
Change-Id: I01e9575dd37d9e15538ea7e4d6d5d0f382840730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127850 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-01osl::Mutex->std::mutex in ThreadManagerNoel Grandin
Change-Id: I9a7ad88b77222c3419ab5eee0859ecc931d6b0aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-01osl::Mutex->std::mutex in SwRetrievedInputStreamDataManagerNoel Grandin
drop the locking call in IMPL_LINK( SwRetrievedInputStreamDataManager, LinkedInputStreamReady because it doesn't actually touch any related data and the lock is taken in the call to PopData. Change-Id: I2e679b97a1ce36e7d39a9a2818a9d62fd53009a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127812 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-01osl::Mutex->std::mutex in SwChartDataNoel Grandin
Change-Id: I1bc85e4c8ac4945e13063793203fd308526263a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-11 21:02:36 +0000