summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2022-03-25sw layout xml dump: handle hole portionsMiklos Vajna
Show their blank width. Change-Id: I8753c9ea4c861eae4618472f8ea24ea86576f251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132089 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-24uitest: add prints to see the current dialogXisco Fauli
See https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/36931/consoleFull#-156104958948ce9c26-9d0a-43a8-83d8-c44f54920d59 I suspect it might fail because there is a dialog displayed Change-Id: Ia68b780d5a3881a6e555e6a4bc3086c6c9644749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130793 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-24loplugin:constantparamNoel Grandin
Change-Id: Ic5fe48315ed86d72371191df75866b8a1d72b249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-24loplugin:constantparamNoel Grandin
Change-Id: I48abe56cc6be52b2a3cd0998e79e6643f65bbbf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-24loplugin:constantparamNoel Grandin
Change-Id: Ib863ea852792635e521050019a3a190b3eeb681e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-24sw fields: add Title uno propertyMiklos Vajna
The use-case is user fields, which are kind of variables in the document. They have a name and a value, but the name might be only readable to an extension or macro, not to the user. In this case, it makes sense to have a way to specify a user-readable tooltip. Be consistent with TextFrames which already have a Title property. Change-Id: I986792f5e55e0b96489347be482d640d155113cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132077 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-24forcepoint#86 RES_TXTATR_UNKNOWN_CONTAINER item put at invalid indexCaolán McNamara
RES_CHRATR_BEGIN is 1, presumably RES_TXTATR_UNKNOWN_CONTAINER should be stored in the last index Change-Id: Id37fff41cbbccbc26fe5ccce6027014af7362729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-24Resolves tdf#140439 - AutoFormat Table preview not using DOCCOLORHeiko Tietze
WYSIWYG preview should use the actual document color instead the dialog/window background Change-Id: Ifff07b2f754ed88cb7e60e0494092e266d3c7cf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132023 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-03-24loplugin:constantparamNoel Grandin
Change-Id: I86592be0717c062a918108bf4437074b0f70b372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-24tdf#141671 fix destroyed pargraph style in exported RTF in MSO.Mark Hung
Do not call MoveCharacterProperties() in RtfAttributeOutput ::EndParagraphProperties(). RtfAttributeOutput::ParagraphStyle() has emited run associated properties defined in paragraph style. Calling MoveCharacterProperties() again overwrites them. As this bug is only visible in MS Word, no unit test case is added. Change-Id: I6e5bfd12e8afa7dc286ca54448c1ff022aade31d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131848 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-03-24tdf#147861 ww8import: solve TODO: not fixed-field if equalJustin Luth
Do not mark the field as "fixed" if the displayed string matches the internal variable. This allows changing the variable within LO and having the field update to reflect that change, which is the way that these fields are supposed to work (although in MS Word they only update manually via F9 which is why some needed to be fixed in the first place). Change-Id: Id359cbf0b48e63bddab3e45871326988467d7ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131414 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-24sw clearing breaks: add insert UIMiklos Vajna
Expose SwLineBreakClear in SwBreakDlg and extend SwWrtShell::InsertLineBreak() to be able to insert clearing breaks as well. Change-Id: I17a4c34cb74f1c72d8e208bace25597de0367e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132024 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-24loplugin:constantparamNoel Grandin
Change-Id: Ib65abd0546f1219387fe3fd7ad4f6ba0eb029bd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-24tdf#147807 SwNavigator: relate Navigate By control to Content treeJim Raykowski
Change-Id: I4f74999b88d425f6d36b03bc5ee88f996f6844c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131874 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-03-23tdf#147641 default font size for captions always resetNoel Grandin
regression from commit 65d2d2647ead42e5bbb7800f14c047f383fe450b Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Nov 8 16:10:51 2018 +0200 loplugin:singlevalfields in sw where I incorrectly reduced a boolean expression Change-Id: I7f3b4552dc27dcd5e118233b5c0ca75e4eb06fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-23forcepoint#82 back() called on empty vectorCaolán McNamara
Change-Id: I8017777a58f1fef41d1545899868e333c2184c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-23CppunitTest_sw_ww8export*: use getProperty<Color> when possibleXisco Fauli
Change-Id: I099467a1682af692ca41031a3f1ee947de942a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131963 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-23loplugin:unusedfieldsNoel Grandin
Change-Id: Ifa2e2b35b725a877ef43526ad243cbfd02148807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-23sw clearing breaks: add plain text exportMiklos Vajna
No need to care about the clearing, but make sure that RES_TXTATR_LINEBREAK gets downgraded to a plain CH_TXTATR_NEWLINE. Change-Id: Ia4f6b45f60a414d856db41fd09d06c902dffd908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131958 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-23tdf#147861 ww8export: DI_CUSTOM write fixed field, not plain txtJustin Luth
It looks like we just punt on fields, and try to avoid round-tripping them as much as possible. And for good reason since they are tough and poorly handled. But since import of DI_CUSTOM has improved for DOC, it would be nice to be able to round-trip it as well, so that is what this allows. It also opens the door to round-trip more field situations as well. This patch depends on the earlier related patch that removes " (fixed)" from the FieldName. RTF and DOCX also export OK, but import needs some love. Change-Id: I32d9aa1fea12763cc30a79bcfa6d1d1e19d2c619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131238 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-23tdf#111851: rtf import: fifty shades of greyVasily Melenchuk
Unlike in DOCX in RTF token \clshdngN can represent much more transitional cell shade values from 0 (white) to 10000 (black). So we should not match these values strictly but use ranges instead. Change-Id: I4e0066e2b79e73cf6fbc3dd773047be8dab2b907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131931 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-23CppunitTest_sw_ooxmlexport5: avoid mustTestImportOf()Miklos Vajna
Can use CPPUNIT_TEST_FIXTURE() instead. See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ia6d99af8989e32cfe5e5c5ebf9f55e6844ed149f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131949 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-23Fix typoAndrea Gelmini
Change-Id: I6508daf621dcc0f0d7441d2e962f6a0da6e2a4d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131954 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-22sw clearing breaks: add HTML filterMiklos Vajna
Map between SwLineBreakClear and <br clear="...">. The import-time workaround with the anchor-only wrapping is no longer needed, the layout is now capable of doing this. Change-Id: I53fa49f11e13fc3338b3cf70d8f87f3633c414c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131924 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-22tdf#147861 ww8import: use GetFieldResult, not current DocPropertyJustin Luth
In all the testing I could think of on DOCX and DOC examples (and only a very few exist in the unit tests) the actual value of the DocProperty was irrelevant to what Word shows as the document loads. It always takes the in-document, as-last-seen static text. As a way to hack a fix using existing capabilities, I marked as FIXEDFLD the unknown custom fields that weren't handled separately. That fixes what is displayed as the import value, (which of course means that F9 will no longer return a modification back to the DocProperty value). It also means the (fixed) field is lost on export, but a follow-up patch handles that for DOC/RTF/DOCX. There were NO DI_CUSTOM examples in existing ww8 tests, but: -ooxmlexport8: fdo74745.docx, fdo81486.docx -ooxmlexport10: tdf92157.docx and in these cases the plain text matched the variable anyway, but a manual manipulation showed that LO is importing DOCX wrong as well, so a similar import fix needs to happen for RTF/DOCX. My fear is that there are some special-magic-associations that worked properly the old way by accident that I will break by marking them as fixed. No backporting please since obviously very few people report bugs about fields. Change-Id: I3f167eb3bd570b66ee829241bf9d31d557fc8749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131237 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-03-22tdf#104390: rtf import: init default font for entire state stackVasily Melenchuk
If first document element is buried deep in destinations and thus deep in state stack (m_aStates) initialization of default font is very local and will be lost after closing these destinations. So let's initialize entire states stack with default font if none is provided istead of initialization just a top element. Change-Id: I966c282f43b84baece909a4c3cd359cbcd317e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131906 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-22sw: document SwXTableRowsMiklos Vajna
Which has a backing core C++ class, unlike table columns. Change-Id: Iebc546b8c3424f976043deceee8307eae764bbb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131914 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-21Removed duplicated includesAndrea Gelmini
Change-Id: I22b71580a79500e169ed9cab775501583975d67f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131911 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-21Fix typoAndrea Gelmini
Change-Id: Iba19e41fcc9277d428476e876b6a0bf50e7f18d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131912 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-21tdf#118047: RTF import: better deduplication for header/footerVasily Melenchuk
Here are two related fixes in one patch: 1. By default current style index is 0, not -1. Due to this we can assume usage of default "Normal" style during deduplication. Seems there is no difference in case of no style mentioning in run or mentioning "Normal" one (\s0), so value -1 looks unnesesary. 2. During header/footer "substreams" processing StyleTableEntires was not reused in new domain mapper impl instance. So deduplication did not work well. 2a. To avoid copying of whole StyleTableEntries between instances it is stored as pointer in domain mapper impl. Change-Id: Id003d35554e9b43186238920d9a6373452095121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131899 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-21sw clearing breaks: add RTF filterMiklos Vajna
Map between SwLineBreakClear and \lbr<N>. Change-Id: Ibed94ad74157a08787212a34176590a1dc4d5547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131886 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-21related tdf#147861: cleanup + a function provides the nameJustin Luth
This is not quite a NonFunctionalChange because it avoids adding " (fixed)" to the name. But that is what I want anyway for bug 147861, so this is an all-around good simplification. Plus, the writerfilter loop doesn't need to run if an inside clause will never be true anyway. Putting this cleanup separately helps highlight the actual fix and not clutter the real patches. Change-Id: I12f345cc92627398ad00fe32b64b98b54e5ed14b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131413 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-21tdf#141908 Replaced usage of sal_Int32 and sal_uInt32 with Color in unit tests.Siddhant Chaudhary
Change-Id: Ieb8b6b3c3bfab0ab49bc55cf42db7be4f08e964b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131408 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-21sw: prefix members of SwWW8WrGrf, WW8Export, WW8PLCF and WW8PLCF_HdFtMiklos Vajna
See tdf#94879 for motivation. Change-Id: I86c9fd2c634b2f5422b0820dd5423008b1c0360c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131884 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-21tdf#131234: RTF import: extend default char props listVasily Melenchuk
There are much more character attributes should be applied wth default values if style contain them, but they were not mentioned in current run. These are obviously not a complete set yet, but most common ones are included. Change-Id: Ide52245bc98628febc2f3bd2e25166f0dcdf35cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131853 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-21Don't display search wrapped message when nothing is foundJim Raykowski
by a search for Frames, Images, and OLE objects Fixes the search wrapped message being unnoticeably shown before the search not found message when nothing is found by a search for Frames, Images, and OLE objects. Also fixes a possible search wrapped message being shown when SwFEShell::GetBestObject is used by SwTextShell::ExecMoveMisc for SID_FM_TOGGLECONTROLFOCUS case. Change-Id: I57e518163d9b61dcf9838e5552a0de53f48faa0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131638 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-03-20simplify some calls to RtfStringBuffer::appendNoel Grandin
Change-Id: I68ad11d19fb0c0a20a336cb0888a1229ce12b995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-18Fix typosAndrea Gelmini
Change-Id: If006b66919dcc7f409e9f9a30e1fe09fa592e698 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131838 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-03-18WeldEditView: Just pass new Size object as paramMichael Weghorn
Just pass `aOutputSize` as parameter instead of assigning that to `aSize` again and then passing that one as parameter in `WeldEditView::SetDrawingArea` and overrides in derived classes. `aSize.setHeight(aSize.Height())` can just be dropped as an overly complicated way of keeping the height as it is. In `SidebarTextControl::SetDrawingArea`, `aOutputSize` was already passed as param, so the new value of `aSize` was ignored anyway. Change-Id: I23192d3c5c85e4371a48774b3b8f854beb751b82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131741 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-18sw clearing breaks: add DOC exportMiklos Vajna
Map SwLineBreakClear to sprmCLbcCRJ's LBCOperand. And most importantly, write the newline character: a clearing break was not "downgraded" to a plain line break previously. Change-Id: I3bc11a120af09d5c774df992cb17cfc5ee251e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131732 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-18sw layout xml dump: handle expand portionsMiklos Vajna
Towards adding dumpAsXml() for all portions that have a HandlePortion(). Change-Id: I9cb1f4c1f966e5cfd7ca27e21bf8aa022979f3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131724 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-17Related: tdf#148053 fix a crash in out of range dx arrayCaolán McNamara
also seen with tdf#124116 Change-Id: I211c5b9d58ee5857c8286b2009e4159b35a9e047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131713 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-17sw image dialog: fix fallback width/height for images with relative sizesMiklos Vajna
Make sure that we work with the up to date layout size of the image in the dialog, otherwise 80% shows up as 237%. Also fix SfxMacroTabPage::FillItemSet() to not put anything to the output item set when the macro table is empty, this way clicking OK in the image dialog results in an unmodified document when the user doesn't change anything. Change-Id: I4b987bd3e3818ee737e37ea10861f9043c25bc93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131714 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-17tdf#147347 sw: hide deleted table at deletion in Hide ChangesLászló Németh
Last deleted row of a table frame was visible in Hide Changes mode, if it is deleted in Hide Changes mode. Fix also missing immediate update of the table layout during deleting only rows in the table. Follow-up to commit a74c51025fa4519caaf461492e4ed8e68bd34885 "tdf#146962 sw: hide deleted row at deletion in Hide Changes" Change-Id: Ic0bf09ac68dd336bd53e84e58f52ebe88ca56238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131701 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-03-17sw clearing breaks: add DOC importMiklos Vajna
Map sprmCLbcCRJ's LBCOperand to SwLineBreakClear. Change-Id: Ie6a114bcd90a9442295815da68f6b0a9616c3210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131697 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-17sw: document SwXViewSettingsMiklos Vajna
Which is a bit confusing: there is separation between the views while running, but only one view saves its config to the user profile, it seems. Change-Id: Ie5c5ae782860e1b93dc9096be893acff7e555aac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131674 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-17tdf#148013 speed up loading large file with lots of redlinesNoel Grandin
We can skip lots of the table by using the binary search. Change-Id: I8c85cd4700bd1859cdc61a08159c61b1ab632163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-17tdf#119298 sw: keep automatic position on trivial width changeJustin Luth
The issue here was that simply moving the border around (which shouldn't change the table size at all) triggered a miniscule difference in reported table width. Well, that is not enough reason to change away from automatic positioning now is it? Change-Id: Ib40c50a1069d88fa22f4791366eb0a50b4e9b11d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131633 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-03-17Notify Navigator when outline content visibility changesJim Raykowski
Change-Id: I1db018216eb37517192f87c5c22cd0b9e6319687 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130472 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-03-16tdf#141908:CppUnittests: replace usage of sal_Int32 with ColorTushar Jham
Change-Id: I8ce73250da932d2c308a93a9268170ba9a120301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131125 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-17 23:31:24 +0000