summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2014-05-09warning C4389: '==' : signed/unsigned mismatchMichael Stahl
Change-Id: Ie8bb8a422c2fdda85d2478dd029c2091267212c2
2014-05-09ooxml: Preserve shape 3d effects: top and bottom bevelJacobo Aragunde Pérez
Shapes 3D effects can specify top and bottom bevels like in the following example: <a:sp3d z="488950" extrusionH="63500" contourW="50800"> <a:bevelT w="139700" h="88900" prst="cross"/> <a:bevelB h="88900" prst="relaxedInset"/> </a:sp3d> This patch preserves the a:bevel* tags and their attributes using the shape grab bag and modifies an existing unit test to add this check. Change-Id: I4762111e4d2f75ba2fd3721a126aa324a28a853c
2014-05-09ooxml: Preserve shape 3d effects: z, contour and extrusionJacobo Aragunde Pérez
Shapes can contain 3D effects like in the following example: <a:sp3d z="488950" extrusionH="63500" contourW="50800"/> This patch preserves the a:sp3d tag and its attributes using the shape grab bag and modifies an existing unit test to add this check. Change-Id: Ice3cae39c71784be0f6c7f2700b07c21a5e1fb6e
2014-05-09oox: preserve scene3d/lightRig effects on shapes.Jacobo Aragunde Pérez
Shapes can contain 3D effects like in the following example: <a:scene3d> <a:camera prst="isometricLeftDown" zoom="150000"/> <a:lightRig rig="threePt" dir="t"> <a:rot lat="0" lon="0" rev="4800000"/> </a:lightRig> </a:scene3d> This patch preserves the a:lightRig tag, its attributes and the child element a:rot using the shape grab bag. It also adds a unit test for this case. Change-Id: I66b6de3c2b5ef89223b10da54006e28113b8ba5f
2014-05-09fdo#78292: Tags related to checkbox r being written in text tag for sdt cntnt.umeshkadam
- The parent node for checked, checkedState, uncheckedState is getting overwritten by "text" - text node is a leaf node, and should not have any children. Change-Id: Ic269525001e914adc1aa328c92be5fe4d5d1b3e7 Reviewed-on: https://gerrit.libreoffice.org/9278 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2014-05-09Resolves: fdo#78150 Ctrl+Backspace does not erase first characterJulien Nabet
See https://bugs.freedesktop.org/show_bug.cgi?id=78150#c1 and https://bugs.freedesktop.org/show_bug.cgi?id=78150#c2 1) there's a wrong conversion with negative number given to a xub_StrLen parameter, anyway it works on 4.2 2) The existing code can be simplified since we don't need to remove spaces before the word to delete Change-Id: I7e2510038666018059a54ac09c1a599154084b48 Reviewed-on: https://gerrit.libreoffice.org/9245 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-05-09fdo#77720: Mail Merge: reset cursors after clearing documentMichael Stahl
The root cause for the crash is that the shell has an invalid cursor that does not point at a paragraph; this is because first the document is filled and the cursor is pointed at the content of a frame, then the document is cleared from SwFrmCtrlWindow::Resize() [not sure why?] and at that point the cursor remains on an SwEndNode (which is invalid). Change-Id: I47c1e2a34d5579953c1896ff0895568978e72bc7
2014-05-09coverity#735545 Logically dead codeCaolán McNamara
Change-Id: Ifa1bc627da203575b36e7e944c66b945f813016d
2014-05-09coverity#735546 Logically dead codeCaolán McNamara
Change-Id: Ibe25db9809ffc9a91e938fd5e02811492b03afc5
2014-05-09coverity#735523 Logically dead codeCaolán McNamara
Change-Id: I3a8ee3de5862d4d3862f3511e1716f0e4f786150
2014-05-09coverity#1209783 Dereference before null checkCaolán McNamara
Change-Id: Idac50085b04a2520b87bb4912e24fe59eae0a372
2014-05-09coverity#1209804 Dereference before null checkCaolán McNamara
Change-Id: Ie32f71b0f089c0687807f1ef2329f41b35ecf076
2014-05-09coverity#1209816 Dereference before null checkCaolán McNamara
Change-Id: I125daf37f07c7b84289625d046abe8257c82e8d4
2014-05-09fdo#71834 make reproducer document more minimalMiklos Vajna
1,5M -> 21K without loosing anything interesting. Change-Id: I145612b9242dd6570e0b4e90f85171b177214500
2014-05-09fdo#77890: page break exported as section break if different 1st page is setumeshkadam
- Page break was getting exported as section break in case if the different first page was set. - Fixed this issue and added a UT. - For additional details regarding the issue please check the following https://www.libreoffice.org/bugzilla/show_bug.cgi?id=77890#c2 Reviewed on: https://gerrit.libreoffice.org/9234 Change-Id: I6799b204c0d1c80a7e07119e2e3aac337520cb08
2014-05-08Fix 'outset' and 'inset' table border type import in DOCX and RTFAdam Co
In the past, LO did not support 'outset' and 'inset' border types for tables, so when encountering them - LO converted them to other types of border. Now that LO supports it - DOCX and RTF filters were changed to import these border types correctly. DOC filter was not changed, because creating a proper DOC sample file that has these border types (needed for the 'bordertest.hxx' file) was not possible right now. So at least DOCX and RTF filters are fixed. Change-Id: Ida2449d45a0ac138388f3cbfeb41657db1d4cda9 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-05-08fdo#78444 sw: avoid incorrect right shrinking of repaint rectangleMiklos Vajna
The old condition was: set the right edge of the repaint rectangle, in case the result would be wider than the original (if we repaint more, that can't hurt regarding the end result) or in case the left edge was set. But that's problematic, the reproducer situation described in the bug triggers a case when the right edge is shrunk too much, so part of the painted letter is missing. Fix that by only setting the right edge of the repaint rectangle when we know that it won't shrink. Change-Id: I33b78a929021b284d5283fc2c35e0b3c999fa224
2014-05-08Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part6Julien Nabet
Change-Id: Ib523206d67ad13416557be1b37a58ba7a9791ca5
2014-05-08Resolves: #i27364# set line count of dropdown to 9...Tsutomu Uchino
for document list of navigator on Writer (cherry picked from commit c104272ea1274dea87cd66cfaa61b34806708521) Change-Id: Iac9644d513dd1195b3986d79607f336dc6ed9884
2014-05-08use new VCL IsValueChangedFromSaved methodNoel Grandin
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963 "RFC: add IsValueChangedFromSaved to VCL button and listbox" Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08Related: fdo#77720 Writer crashes when running Mail Merge WizardJulien Nabet
Change-Id: I02695420ff4f54ad15b077ab1d16f27ff684e5da Reviewed-on: https://gerrit.libreoffice.org/9111 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-08various: sal_Bool->boolNoel Grandin
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-05-08coverity#1209298 Logically dead codeCaolán McNamara
Change-Id: I370f1ff7df1c19e23560599b86b2274649bd5f73
2014-05-08coverity#1209146 Logically dead codeCaolán McNamara
Change-Id: I6777dffb436471b5df69d40a15bd32b473dcfc40
2014-05-08coverity#736155 Dereference null return valueCaolán McNamara
Change-Id: I781a949abb47b6e845a222a4fa8f685e9a620693
2014-05-08coverity#736152 Dereference null return valueCaolán McNamara
Change-Id: I5582d0481c0b99f92e7a3a07fbe7a904a1696442
2014-05-08coverity#735960 Explicit null dereferencedCaolán McNamara
Change-Id: I04ef56efe1e6e164de5ceaa2840a43271102d108
2014-05-08coverity#735959 Explicit null dereferencedCaolán McNamara
Change-Id: I9ba5a7ab1938174f083fdc81c046b286fc73a4e9
2014-05-08coverity#735958 Explicit null dereferencedCaolán McNamara
Change-Id: I78e3e2cce461b098dd3f56289bf5e30c977fca2f
2014-05-08coverity#735957 Explicit null dereferencedCaolán McNamara
Change-Id: I70a46f251faa6a1d6e52bc816473a29416953ded
2014-05-08coverity#735956 Explicit null dereferencedCaolán McNamara
Change-Id: Ic55ef095bb4867c9e5e98bc4c2ded3e9b0c95253
2014-05-08coverity#735955 Explicit null dereferencedCaolán McNamara
Change-Id: Ice64f610901ae9a5ee103fa1e4fec46a1142158d
2014-05-08coverity#735943 Explicit null dereferencedCaolán McNamara
Change-Id: I268ec2db2e8ec4a40dd8537989d2afe767207d40
2014-05-08coverity#735938 Explicit null dereferencedCaolán McNamara
Change-Id: Ia95f3ec5817035a596a8d64b0a7e9dc4445ec648
2014-05-08coverity#735937 Explicit null dereferencedCaolán McNamara
Change-Id: Ic8d177dcf565fca8cf1f238c12b16c5cea2066a6
2014-05-08coverity#735936 Explicit null dereferencedCaolán McNamara
Change-Id: If85ed1e4c9aa4e1d816515264f21154d5661051c
2014-05-08coverity#735935 Explicit null dereferencedCaolán McNamara
Change-Id: Ic67e0d06402ae28d4cffb817262a5adb23afc3ee
2014-05-08fdo#78284 Content-type of ".png" images in Smart ArtVinaya Mandke
Content-type for 'png' images was not getting added in [Content_Types].xml. This was as only 'jpeg' and 'wmf' extensions were handled. Modified DocxSdrExport::writeDiagramRels to handle all types of extensions. Added UT for the same. Reviewed on: https://gerrit.libreoffice.org/9252 Change-Id: I5e068d4db14f3a43be08a4b7c9bf265f388bf356
2014-05-08Handle bad SwWW8ImplReader::GetCol inputStephan Bergmann
With previously found offenders out of the way, looks like sw/qa/core/data/ww8/pass/CVE-2009-3302-2.doc is the only case that triggers this, and that is likely deliberately malformed input. As the whole ww8 parser appears not to be build around robust eager input validation and error signalling, there is little more we can do here than throw up our hands in despair. Change-Id: Idf61fcf14a784cef1539654f2825c013c218987f
2014-05-07sw: fix indentation in rtfstringbufferMiklos Vajna
Change-Id: Ie1029a03e614aceaeda10a762183cb06e93c1639
2014-05-07coverity#735892 Unchecked dynamic_castMiklos Vajna
Change-Id: I0624dd7d50cc82ddfe76ce5d8219b2fa1c10f002
2014-05-07unused SwAccessibleMap::FireSectionChangeEventMiklos Vajna
Change-Id: Iabf50f68d06684d36eaf5793251361ccd771ae8d
2014-05-07SwTxtNode::CopyText(): actually check hints of destination node tooMichael Stahl
Change-Id: I1bb883502ccd4c6fb5bdfd93f2fa5a04de0b2701
2014-05-07fdo#74790: sw: Compare Document: fix assertions about RSID-only hintsMichael Stahl
For ordinary documents the SwTxtNode::MakeFrm() would set the m_bFormatIgnoreStart/End flags of the RSID-only hints, but the document loaded by Compare Document (and Merge Document) is special because it is loaded, there are editing operations on it, but it has no layout, so the assertions about these flags trigger. (regression from 6db39dbd7378351f6476f6db25eb7110c9cfb291) Change-Id: I8a6e02b68f22e609640adbe93ff194e4081d9856
2014-05-07coverity#735932 Explicit null dereferencedCaolán McNamara
Change-Id: I35ccc5ba619f7e861fca2c5e78de86d88480017d
2014-05-07coverity#735924 Explicit null dereferencedCaolán McNamara
Change-Id: I77044f6f9e99ddaa64cf69ba22205d6536a90b1b
2014-05-07coverity#1209588 Explicit null dereferencedCaolán McNamara
Change-Id: I6abb408c91c9d6ea2d60c328be221c7608a7906c
2014-05-07coverity#1209587 Explicit null dereferencedCaolán McNamara
Change-Id: I51b3e9bccbe54686fbe869ce5ba669d000530572
2014-05-07coverity#1209549 Unchecked dynamic_castCaolán McNamara
Change-Id: I118771b78d83441202c15d3b08b9055ba5e63623
2014-05-07coverity#1209527 Dereference after null checkCaolán McNamara
Change-Id: I8a829ee5d36281098f2788a704b203e6b777d371