summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-04-26Related: tdf#124919 assert on ctrl+[ on four selected cells in tableCaolán McNamara
since... commit a91992e7b3e7f59e9116aef859696d517a93dab7 Date: Fri Nov 16 16:26:38 2018 +0100 sw: SwTextNode::GetAttr() inconsistency Change-Id: I45a89a83332f964fc813f8083e09d816965d2658 Reviewed-on: https://gerrit.libreoffice.org/71313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26sw: trivial OSL_FAIL to assert in nodes.cxxMichael Stahl
Change-Id: I6c034310ffcc5eacf7db0064d739a9796d66d6e4 Reviewed-on: https://gerrit.libreoffice.org/71325 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-26sw btlr writing mode: implement DOCX shape import for tbrlMiklos Vajna
Now that the btlr writing mode works reasonably well in table cells, the next context is shape text. But turns out that DOCX shape text lacked support in the easier tbrl case, so add that first. Also remove the char-level text rotation code in oox, that is effectively dead code since we import drawingML shapes as shape + Writer TextBox. Change-Id: I30c7793221cc3aceedfcfd9e4e1725634ebb3309 Reviewed-on: https://gerrit.libreoffice.org/71329 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-26Resolves: tdf#124919 fontsize grow/shrink unable to use SwShellTableCursorCaolán McNamara
so if that's active fallback to creating a vector of simple pams Change-Id: I282bd9f9675985ddbd88ba088aee81609e14d101 Reviewed-on: https://gerrit.libreoffice.org/71318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26tdf#124796 Fix chart primary Y axis scalingBalazs Varga
Re-scale the primary Y axis if the secondary axis is deleted and the dataseries still attached to the secondary axis. Change-Id: I6e7958766d23a74569ce8529ddf1bdafa89f1870 Reviewed-on: https://gerrit.libreoffice.org/71302 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-26tdf#67207 DOCX mail merge: fix export/import of database fieldsLászló Németh
to support the registered databases (containing ODS, XLSX sheet or ODT text table data sources). Now database fields don't lose their database connection, and File->Print can merge mails after DOCX export/import, if the LO instance has got a registered database with the same name and table, as in saved in w:settings/w:mailMerge/w:query element of the DOCX document in the form of SELECT * FROM [databaseName].dbo.[tableName]$ query. Notes: – This fix supports only single table usage. – The exported DOCX document is editable in MSO, too, without losing the database connection in LO later. Change-Id: I97826b7ee7defd0243dbaffa0325c5b11dd2c0d1 Reviewed-on: https://gerrit.libreoffice.org/71228 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-25UITest_writer_tests5: disable flaky print preview testMiklos Vajna
Change-Id: I22431e026c1802e33064aa60267de0edbdf856ca Reviewed-on: https://gerrit.libreoffice.org/71253 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-25LibreLogo: fix RANGE with a single function argumentLászló Németh
in a FOR loop, by removing the range(x,,)-like double commas in this case, too, during program compilation. Previous empty (missing) argument of RANGE was checked by the terminating comma, but it can be a white space after it, as in the following example: FOR i IN RANGE COUNT 'letter' [ PRINT i ] Change-Id: I67d0a4f089be06f30003d1b979b8f1801dbfa2e9 Reviewed-on: https://gerrit.libreoffice.org/71263 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-25WIP: Further preparations for deeper Item changesArmin Le Grand
(1) Migrated all still existing binary load/save stuff in SfxPoolItem to legacy files. Isolated from Item implementations. Adapted all usages. No more methods Create/Store needed, also GetVersion removed (2) Removed operator= for SfxPoolItem. Adapted all usages. Goal ist to handle Items more as Objects ('Object-Oriented') in the sense to move/handle instances, not to copy one instance over another one (which is more and more problematic with hard to copy content as UNO API stuff or similar). This lead to much more usages of std::shared_ptr which correlates well with future plans fr Items (see dev branch). Next logic step will be to also remove copy constructor Linux build and corrections done Fixed Writer test and removed unused defines Fixed another unused m,acro Started to unify the AutoFormat stuff Changes to OUString constructor usages, tests completely No idea why, but SfxStringItem constructor which takes a OUString& now insists of not getting ::OUString's handed in - changed all 'SfxStringItem.*OUString.*".*"' accordingly Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29 Reviewed-on: https://gerrit.libreoffice.org/71075 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-25ofz#14422 null derefCaolán McNamara
Change-Id: Icd00e2aaa5932564668cd12ce4ee63aecc34419a Reviewed-on: https://gerrit.libreoffice.org/71226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-25Blind fix for flaky print preview testXisco Fauli
I faced the same problem in https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/commit/?id=f631db9e5e83706ed2678fb4db737700dd623a1b Change-Id: I1adcc418e0efa7e77e1dda5b9dccd7c55cb5267f Reviewed-on: https://gerrit.libreoffice.org/71280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-25related tdf#123636: fix unit test for tinderboxJustin Luth
Change-Id: Ia7dc9879aeaa978d1cb1b0573fb69bd63bd5d4e0 Reviewed-on: https://gerrit.libreoffice.org/71278 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-25ubsan: use after freeCaolán McNamara
Change-Id: I1a3396d434f6cc5bb615bcb2fe06a819bc11c013 Reviewed-on: https://gerrit.libreoffice.org/71256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-25Fix typoAndrea Gelmini
Change-Id: I02e84f888950c85e19f50ffe7ace52e71a24e397 Reviewed-on: https://gerrit.libreoffice.org/71266 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-25related tdf#123636 writerfilter: split newline also if PAGE_BREAKJustin Luth
...but only with old MSWord compat flag SplitPgBreakAndParaMark. All of the other cases (COLUMN_BREAK and non-empty runs) split the paragraph, so why not here? This document shows it is needed, but only for SplitPgBreakAndParaMark documents. Note: Word 2003 doesn't display "modern" docx well in this regard. It adds extra paragraphs where it shouldn't. There are already example unit tests that ensure that extra paragraphs aren't written for SplitPgBreakAndParaMark == false. The actual bug's document is not related to the compatibility flag. That will be handled in separate commit. Change-Id: I27399780c909663f9a2b21974a5b385bea67f9ec Reviewed-on: https://gerrit.libreoffice.org/70835 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-04-24crashtesting: imported junk as form field textCaolán McNamara
spec says "An unsigned integer that MUST be 0xFFFFFFFF" for version so at least insist on that Change-Id: I8c11659d86fe122b1c8f61b1bf99e7b4b53ff306 Reviewed-on: https://gerrit.libreoffice.org/71227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-24simplify call sites of SfxItemPool::PutNoel Grandin
use template to make return type match input type, so we don't need to cast at the call sites Change-Id: I1e65f362c67f74c9a230cdbc1db12545b28eb499 Reviewed-on: https://gerrit.libreoffice.org/71216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24Fix typosAndrea Gelmini
Change-Id: I9cc5e13681b047fe772704b42796e210ad070601 Reviewed-on: https://gerrit.libreoffice.org/71148 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-23multiple concatted AcceptChgDatCaolán McNamara
Change-Id: I4ab78f35cb5a6ea31235662b6fad8d1e6c5d33b5 Reviewed-on: https://gerrit.libreoffice.org/71140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-23sw: prefix members of SwAttrCheckArrMiklos Vajna
Change-Id: I3b1929d591fb3c44504b4818330a4e59aa3d587f Reviewed-on: https://gerrit.libreoffice.org/71125 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-23tdf#113266 slow opening XLS with 45 MB drawingNoel Grandin
Some hot-spots around dynamic_cast of SdrHint, so avoid that by creating special SfxHintId::ThisIsAnSdrHint The most common CPU hot-spot was in SvxShape::Notify, the other changes are just for consistency. Also remove some dead code in ScShapeChildren, the Notify method was doing nothing useful. Change-Id: I696db1fcafc09bb10bf23ac673de292746141491 Reviewed-on: https://gerrit.libreoffice.org/71108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-23tdf#42949 Fix IWYU warnings in include/editeng/[f-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic14d2e66434817bcb7bd1e2b707f81d720d596b6 Reviewed-on: https://gerrit.libreoffice.org/71007 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-23tdf#123968 Test that imported field is editableSamuel Mehrbrodt
Change-Id: I2dbcc6fa8ee9c469cfc038a2622962b8939ec174 Reviewed-on: https://gerrit.libreoffice.org/70921 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-22Resolves: tdf#122487 take groups into accountCaolán McNamara
interate and recurse through their contents for name collision check Change-Id: Ide7d1d051f6b9420b7ef7b3f6bed669dbde5697a Reviewed-on: https://gerrit.libreoffice.org/71077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-21Fix typosAndrea Gelmini
Change-Id: I926fa0c4345ff0acb9b9bc870243f4f007aac660 Reviewed-on: https://gerrit.libreoffice.org/71032 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-20simplify SfxPoolItemArray_Impl (tdf#81765 related)Noel Grandin
Since we want to look up items by pointer, just store them in a std::unordered_set, which allows fast find(). This dramatically simplifies most operations on this data structure. Fix a dodgy sd test that was relying on items with the same whichid being in the pool being in a certain order. Change-Id: I4d79fc718f95e3083a20788be1050fbe9fca7263 Reviewed-on: https://gerrit.libreoffice.org/70881 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-20tdf#124099 add Chapter Numbering to Home drop down tabandreas kainz
Change-Id: I9f287cd9ded8f2c377cdb7fe6b338f984829d2b6 Reviewed-on: https://gerrit.libreoffice.org/70989 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-04-19Further cleanup of FastSerializerHelper's startElement/singleElement[NS]Mike Kaganski
Drop FSEND_t: C-style varargs code was replaced since version 6.0 in commit d43fc40718217d89cc95cc3c0bc0b8e7926abcc0, so it's time to remove the last bits. Drop int-to-string macros that are simple wrappers over OString::number. Avoid unnecessary string type conversions. Change-Id: I86478577b8e469f99b5a90619e5f78a61f4f23fb Reviewed-on: https://gerrit.libreoffice.org/70964 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19Add XWordBasic.FileSaveAs() and implementTor Lillqvist
Factor out the setFilterPropsFromFormat() also used by SwVbaDocument::SaveAs2000() to a header file of its own. Change-Id: I4bc9e1e420719a115036beb7e82a4ac3feac05f0 Reviewed-on: https://gerrit.libreoffice.org/70980 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-04-19Change XWordBasic methods to return anyTor Lillqvist
Possibly this is more in line with what callers expect. Change-Id: Ie84b05a0bdb5ef1cb3e1f9fb7df6772831ff4980 Reviewed-on: https://gerrit.libreoffice.org/70975 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-04-19drop some unneeded includesCaolán McNamara
Change-Id: Idde1f747f500d94b3191a97e7d502794cc2b8450 Reviewed-on: https://gerrit.libreoffice.org/70972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19optimise find/insert patternNoel Grandin
if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-19crashtesting: tdf#122599 NSS_CMSMessage_CreateFromDER assertsCaolán McNamara
because NSS_Init wasn't called first Change-Id: Ib1b4c950dc2773af1fea7b64339b86566ee412e7 Reviewed-on: https://gerrit.libreoffice.org/70947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18don't use SwSectionFormats hereNoel Grandin
since SwSectionFormats wants to own the things it points to, and we don't want to own here. The only reason it was working is because we call clear() on the horrible SwVectorModifyBase base class here, which removes the pointers without deleting the pointed-to objects. Change-Id: I8aba61e74ce1463ff4be439c0feb830d1aa8988e Reviewed-on: https://gerrit.libreoffice.org/70940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18forcepoint#80 avoid crashCaolán McNamara
Change-Id: I7a96d2951fbcd5f53a2f7e65e8c07926fc035a11 Reviewed-on: https://gerrit.libreoffice.org/70936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18forcepoint#79 FindStartEndOfRowSpanCell returning nullCaolán McNamara
Change-Id: I85f5b17b7dc2d3c4dfef92f64451fab451f58112 Reviewed-on: https://gerrit.libreoffice.org/70927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18sw: fix missing includeMiklos Vajna
Change-Id: If6a50542e8e2c4899b1d89ba6456e0f39b4cf39a
2019-04-18tdf#42949 Fix IWYU warnings in sw/qa/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia0c79c2455a3b40384332c8c35215671e257a07f Reviewed-on: https://gerrit.libreoffice.org/70847 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-18CppunitTest_sw_uiwriter2: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I169612264ef713027b38d1218ba71c86732da7f5 Reviewed-on: https://gerrit.libreoffice.org/70900 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-18tdf#115600 Display not found message for Navigate by SelectionJim Raykowski
...if there is no selection found Change-Id: Ie4857e8d1bb98e41565aef47d3a794dcbe9bbd66 Reviewed-on: https://gerrit.libreoffice.org/70645 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-04-17uitest for bug tdf#118540Zdeněk Crhonek
Change-Id: I71f479c00e47c277fe08329b4abd20dba8d68224 Reviewed-on: https://gerrit.libreoffice.org/70840 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-17Better fix for 6340daac7b99c65249363a4bb61c492de31ef5d6Stephan Bergmann
..."Revert broken loplugin:sequentialassign change" Change-Id: Icb6f27be6bab35db02fc67ce5478e47bb8faa68b Reviewed-on: https://gerrit.libreoffice.org/70883 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-17Wait for async events to be deliveredSamuel Mehrbrodt
Follow-up fix for 6f43902b12dd36fa2b69401065df198ef9ffdb09 Also remove calling to super class (doesn't work and those methods return void anyway) Change-Id: I1aa927e373e6d19e4060daba1f34ef72428ead59 Reviewed-on: https://gerrit.libreoffice.org/70878 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-17sw lok: add unit test for deselect custom shapeHenry Castro
Change-Id: I41a9ff0d281d9032ddaafbbcb55352254a809efe Reviewed-on: https://gerrit.libreoffice.org/70824 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-04-17tdf#109376 sw: fix redline SwUndoDelete with end pos on SwTableNode crashMichael Stahl
... that happens when you accept a delete redline (or reject an insert redline) with such end pos. The problem is that first a DeleteRange() will move the anchor position onto the table node (because check in SwUndoSaveContent::DelContentIndex() is surprisingly asymmetric and so the fly not deleted by the previous bugfix), then DelFullPara() creates a second SwUndoDelete then deleting the fly crashes because its anchors was moved. The code in lcl_AcceptRedline() / lcl_RejectRedline() doesn't make much sense (but always was like this), if we just call DeleteFullPara() once instead, the problem is avoided, and we don't even have to worry about why DelContentIndex() is so asymmetric (is "selection direction" really a meaningful concept?). Reportedly this started to crash with commit e07feb9457f2ffb373ae69b73dda290140e4005f, previously it was just wrong. Change-Id: Ib3d4b31e0255a6f4e7b49b40f204dec168ea3006 Reviewed-on: https://gerrit.libreoffice.org/70836 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-17tdf#122920 Send UNO mouse events to parent window listeners as wellSamuel Mehrbrodt
When user registers a mouse listener to a window, he expects to receive mouse events when a user clicks in somewhere in that window, even if it's technically a widget inside that window Change-Id: Ie6d3f8b140e4a5b516051014282b43775ecec59e Reviewed-on: https://gerrit.libreoffice.org/70512 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-17tdf#115600 Turn design mode on to Navigate by ControlJim Raykowski
Navigate by Control only works in design mode so turn design mode on when Navigate by Previous or Next Control button is pressed. Change-Id: I26a565758672c8dd1ec8bf979b199e8b240424e3 Reviewed-on: https://gerrit.libreoffice.org/70644 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-04-16uitest for bug tdf#121591Zdeněk Crhonek
Change-Id: I374748da8d53045c411db35edbe4ddd65037456c Reviewed-on: https://gerrit.libreoffice.org/70838 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-16uitest for bug tdf#117039Zdeněk Crhonek
Change-Id: I80dc602db648c56edb895360188dfd0d43398b8c Reviewed-on: https://gerrit.libreoffice.org/70837 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-16Use prewin.h/postwin.h to not define DELETEStephan Bergmann
...as used as an identifier in sw/inc/swundo.hxx (broke Windows --disable-pch builds) Change-Id: I4de0232bcf17c4149cc31ec235f1275648a6d73e Reviewed-on: https://gerrit.libreoffice.org/70820 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-11 10:34:54 +0000