summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-07-03Fix typoAndrea Gelmini
Change-Id: I8f2692a7f917b53c28783599b589fd0a39e3b880 Reviewed-on: https://gerrit.libreoffice.org/56835 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-03use std::unique_ptr for CreateObjectSpecificViewContactNoel Grandin
Change-Id: I0fed54d345a43fe0bc21ebbe424e6fdc7eac9523 Reviewed-on: https://gerrit.libreoffice.org/56823 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwDropPortionPartNoel Grandin
Change-Id: I9aaaeb2b5cb05d350059554555ecb0c195c51a74 Reviewed-on: https://gerrit.libreoffice.org/56830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwWrongListNoel Grandin
and simplify, just use copy constructors and operator=, instead of special-case CopyFrom methods Change-Id: I3e14fa08e820cf7ae2c5424ae22ae95516933773 Reviewed-on: https://gerrit.libreoffice.org/56831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwGrfNumPortionNoel Grandin
Change-Id: I87f60bc3b6dc11246202801f39cbc7cf464e1890 Reviewed-on: https://gerrit.libreoffice.org/56829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwLayActionNoel Grandin
Change-Id: I0552a113a3eaf1265e65d32b2b04cc768571d9ff Reviewed-on: https://gerrit.libreoffice.org/56827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02tdf106792 Get rid of SvxShapePolyPolygonBezierArmin Le Grand
SvxShapePolyPolygonBezier was an implementation for the UNO Shape group of polygons with bezier parts (filled/unfilled/ closed/open), e.g. com.sun.star.drawing.OpenBezierShape. It was differing from SvxShapePolyPolygon just by supporting drawing::PolyPolygonBezierCoords instead of the simple drawing::PointSequenceSequence and some details. This leads to problems - the ShapeType *does change* e.g. when you edit a non-bezier Shape in Draw/Impress and change parts to curve (also when closing, see ShapeTypes above). This is why SvxShape::getShapeType() already detects this identifier by using thze internal ShapePolyType (e.g. OBJ_PATHLINE). So there is no reason to have two separate UNO API imple- mentations for sthe same type of SvxShape at all. Get rid of the extra one and unify this implementation detail. Also cleaned up double basegfx tooling for conversions of UNO API Poly/bezier data and B2DPolygon. Adapted test for "tdf113946.docx", see comment there. Adapted test for "tdf90097.rtf", see comment there. Also needed to use the Linux values, also check comment there. Adapted test for "tdf105127.docx", see comment there. Adapted test for "tdf85232.docx", see comment there. Had to fic a problem with test for "tdf96674.docx"- the adaption of the RotateAngle for line objects goes havoc together with the UNO API when scaling is involved. That old aGeo rotate stuff just kills the existing rotation due to numerical inprecise stuff. The UNP API - in trying not just to apply a rptation, but manipulate the existing one then goes wrong in not re-getting the current rotation value anymore. ARGH! This is the original reason for the ols tdf#96674 task - i doubt that the additional code to make a line not exactly hor/ver is needed. Checked and it is not needed, thus removed the change from tdf#96674 in shape.cxx. Change-Id: I2bb8d4cfe33fee3671f3dad60e5c18609a394f9d Reviewed-on: https://gerrit.libreoffice.org/56614 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-02tdf#117923: handle direct formatting for numbering in .docMike Kaganski
Since commit df07d6cb9f62c0a2c4b29bd850d4efb4fcd4790b, we do for DOCX. DOC also has this problem, so set the relevant compatibility flag on import for this format, too. Change-Id: I3aef593341edffa878a06566da815cb72aa38004 Reviewed-on: https://gerrit.libreoffice.org/56812 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-02sw: prefix members of SwAccSingleTableSelHander_ImplMiklos Vajna
Also use the 's_' prefix in sw::ClientIteratorBase, like it's done almost everywhere else. Change-Id: Id2c28037eb4f69ce1f27e0365e2b078ffc300935 Reviewed-on: https://gerrit.libreoffice.org/56798 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-02tdf#51223 can now undo auto-capitalise with enterNickson Thanda
Change-Id: I1ff1bd0137415349d1eb89bef0947453f72a8ef5 Reviewed-on: https://gerrit.libreoffice.org/56267 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-02loplugin:unusedmethodsNoel Grandin
Change-Id: I92665f577bfe39497905063da517a05b8008c3cc Reviewed-on: https://gerrit.libreoffice.org/56743 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02pass OutlinerParaObject around by std::unique_ptrNoel Grandin
SdrText::SetOutlinerParaObject was modified to not check for self-assign, and instead assert because the existing check was no longer possible. Fix bug in SdrUndoObjSetText::Undo(), where it was calling SdrText::SetOutlinerParaObject unnecessarily, because NbcSetOutlinerParaObjectForText already does that. Optimise Outliner::GetEmptyParaObject by creating a new constructor for OutlinerParaObject, so we don't need to copy the new object we get back from GetEmptyTextObject, unnecessarily. Change-Id: I57c475583d6c31658c154e24992b3d587bad9841 Reviewed-on: https://gerrit.libreoffice.org/56730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02tdf#108000 sw layout: ignore emulated keep on large tablesJustin Luth
There is no point in a very large (multipage) table keeping with the following content and it just makes the layout more complex. This is especially true when we are emulating this using MSWord's convention, and not LO's native table-keep option. This patch only affects my earlier code for emulated tables. Otherwise, something about the general logic could loop forever in certain huge tables. This seemed like a very reasonable compromise. Change-Id: Ic1bde12b266e71fc9f608ec4d1223277108750fa Reviewed-on: https://gerrit.libreoffice.org/56314 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: Ia56f125151aa96d014e348b6d022b45138f732c9
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: Ia878affbdcb9674675619f34a423ac6c9a90b16d
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: I2a1b034ba6b587664ce94560e88af5acb860788d
2018-06-30Not empty OUString has at least one tokenMatteo Casalin
Change-Id: I02dd1c045af1367ae56eeb60dad23912111dcd6f
2018-06-30Avoid getTokenCountMatteo Casalin
Change-Id: I9bbfa1280857e3aaaac78402432001d4b48cd73a
2018-06-30Normalize Writer style "Text Body" in UIOlivier Hallot
In all UI, the text body style is labeled "Text Body" except in Format - Paragraph - Numbering tab outilne level listbox where it is named "Body text". The patch fixes the difference. Change-Id: Ic9b9db4ce70ddef35fed4124ae47abc28dcff380 Reviewed-on: https://gerrit.libreoffice.org/56502 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-30schema,sw: enable ODF validation in all sw testsMichael Stahl
Validate every ODT file that is exported via "reload" or "save". Change-Id: I010965191159605924b89fe21b0b3d47123c13bd Reviewed-on: https://gerrit.libreoffice.org/56607 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-29Improved loplugin:redundantcast (const-qualified typedefs): swStephan Bergmann
Change-Id: Ib99c4a8f9d90e23a3083c74e72044a2b705a409d Reviewed-on: https://gerrit.libreoffice.org/56704 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-29sw: fix crash on F2 while drawing a polygonMiklos Vajna
The first hunk is probably a regression from my earlier TextBox work, the other is inherited from OOo, I think. Change-Id: If87d135c84c483d7a39f90e9edcf00594204fab8 Reviewed-on: https://gerrit.libreoffice.org/56689 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-06-29loplugin:useuniqueptr in SwFieldPortionNoel Grandin
Change-Id: I2ce38d46798627f808dd539a7d74f5c6cf7f509a Reviewed-on: https://gerrit.libreoffice.org/56631 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwImplProtocolNoel Grandin
Change-Id: I7db3da4ed86ec919e7cf6dbe6e109b59c3a6751d Reviewed-on: https://gerrit.libreoffice.org/56630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwRootFrameNoel Grandin
Change-Id: I165c3df9392e1171770af02e12dda8e3257b72c5 Reviewed-on: https://gerrit.libreoffice.org/56629 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwLineLayoutNoel Grandin
Change-Id: I000e73a1c932e00c626e2f613e3154748e341fe8 Reviewed-on: https://gerrit.libreoffice.org/56628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwPostItFieldNoel Grandin
Change-Id: I1d048ac400d6a929a840bcb8f0df52be528c0a5b Reviewed-on: https://gerrit.libreoffice.org/56623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwOLEObjNoel Grandin
Change-Id: I36b14c31bfdf66b158dd2cf8f6a7a125d52cddb5 Reviewed-on: https://gerrit.libreoffice.org/56627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwGrfNodeNoel Grandin
Change-Id: I9f0993f7fbbdaf7552fe0b0c19d3fca691471fa8 Reviewed-on: https://gerrit.libreoffice.org/56626 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwEnterLeaveNoel Grandin
Change-Id: I948c146f675675c1902c158be4d97b6d19679a51 Reviewed-on: https://gerrit.libreoffice.org/56625 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwTextAPIObjectNoel Grandin
Change-Id: Ied235aefe2cc2ce5e88487503c17e1a54d25ac52 Reviewed-on: https://gerrit.libreoffice.org/56624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwTableNodeNoel Grandin
Change-Id: I28bca27b6841ba9b263392b2e30f8684a8e2c4e5 Reviewed-on: https://gerrit.libreoffice.org/56622 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29Menubar: move InsertDoc in ObjectMenu Subsection like in calcandreas kainz
Insert section in writer is very long and when move InsertDoc into the Object Subgroup it will be on the same level than in calc Change-Id: Ie34b5853dd462ed17df02f645a1e6953beaf3f13 Reviewed-on: https://gerrit.libreoffice.org/56584 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-29tdf#118421 ww8export: rotate vertically: not Lines or groupsJustin Luth
Lines and Groups often are exceptions. Normally, the import code swaps vertical rotations also. In the case of lines (from the tests that I observed) lines don't have a rotation value at that point during import, so no correction is made. Grouping always messes things up. Change-Id: I344c5a29f887294b751ffc87c01b30e472cfb4c2 Reviewed-on: https://gerrit.libreoffice.org/56595 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-06-29uitest for bug tdf#116474Zdeněk Crhonek
Change-Id: I6b19626bf872c2eff61c57342579ec682a1c37d0 Reviewed-on: https://gerrit.libreoffice.org/56632 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-28lok: Don't even try to paint the ruler via LibreOfficeKit.Jan Holesovsky
But we need to have it behind the scenes, otherwise the Online's ruler does not get notifications. Change-Id: I72bef28cb15c462572b511449d538b067f7cb141 Reviewed-on: https://gerrit.libreoffice.org/56598 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit ee6e6bd5b853aa68c9721f53b5892384e7403eec) Reviewed-on: https://gerrit.libreoffice.org/56601 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-28tdf#107690 DOCX, XLSX and PPTX unit tests for "Open as read-only"László Németh
ie. OOXML export/import of "_MarkAsFinal" MSO document property. Change-Id: I01f0702d5467e78eb93ce8dce8ba25874839c3e3 Reviewed-on: https://gerrit.libreoffice.org/56475 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28tdf#107690 OOXML import/export of setting "Open as read-only"László Németh
Import custom document property _MarkAsFinal as LoadReadonly setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX and PPTX documents. Before this fix, LibreOffice opened read-only OOXML documents as editable, also saved and exported _MarkAsFinal=true silently, resulting unintented read-only warning info bar in MSO. This commit improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. Note: LoadReadonly (on File->Properties...->Security, property "Open file read-only") doesn't show "Edit read-only" info bar from commit 630186ff4e0eba7317e542f8c3eca39ebd068721, but it's still possible to switch on editing by Edit->Edit Mode. MSO shows info bar for _MarkAsFinal. (There is an advantage to hide the info bar in LibreOffice in a mixed environment, to avoid overwriting of press-ready MSO files by LibreOffice.) Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal in MSO: (1) Switching on editing doesn't remove the LoadReadonly property automatically in LO. (2) Saving with LoadReadonly doesn't switch off editing of the actual (still opened) document in LO. Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216 Reviewed-on: https://gerrit.libreoffice.org/56180 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28tdf#42949 Fix IWYU warnings in include/osl/*hGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7 Reviewed-on: https://gerrit.libreoffice.org/56491 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-27tdf#114425 add Page Settings to writer and calc NBandreas kainz
add to NB grouped (full and compact) in Edit group cause Format is only Format selected text but not Format page. Edit group is most generic group that fit's for page selection Change-Id: I49af8ff5b560655d43c55818da391a768d26ef04 Reviewed-on: https://gerrit.libreoffice.org/56430 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-27tdf#96099 Remove some trivial std::deque typedefsArkadiy Illarionov
Change-Id: I101c8a39344ab007640aec9ddad6f82d4fe64296 Reviewed-on: https://gerrit.libreoffice.org/56504 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-27Initialise the spelling and grammar thing when Writer startsTor Lillqvist
We want to avoid the phenomenon where right after typing the first character into a Writer documnent in a LibreOffice instance, spell and grammar checking stuff is initialised which can take a quite long time, especially the LightProof one. Even after my recent change that made the Lightproof initialisation clearly faster (by avoiding the import of the large lightproof_impl_pt_BR.py module before actually doing Brazilian Portuguese proofreading), there still was a 0.3 second delay on my relatively fast machine. This change moves that delay into Writer start instead, before any document window is ready to accept input. At least then the user is not entering text and wondering why it doesn't show up right away. Change-Id: Ie578c310dc9cb9bfc964e2986eec177fb1d4e666 Reviewed-on: https://gerrit.libreoffice.org/56473 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-27loplugin:useuniqueptr in DocumentDrawModelManagerNoel Grandin
Change-Id: Id7a50d5379f8d2f8ecd39a75a520b1501600adcb Reviewed-on: https://gerrit.libreoffice.org/56501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-27loplugin:useuniqueptr in SwSelPaintRectsNoel Grandin
Change-Id: I34411e00d67ab29eb0796207d17f77a4f767c0b0 Reviewed-on: https://gerrit.libreoffice.org/56500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-27loplugin:useuniqueptr in SwDocNoel Grandin
Change-Id: Ic895c7b79a25a0766cc6d352c5ed75873004fddb Reviewed-on: https://gerrit.libreoffice.org/56496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-27sw: prefix members of SwInterHyphInfoTextFrameMiklos Vajna
Change-Id: Idc99dfd6e5ee7bc999088f4657d77613d0029b97 Reviewed-on: https://gerrit.libreoffice.org/56489 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-26forcepoint#49 survive more kashidas than expectedCaolán McNamara
Change-Id: I66aa5389b3d80d1fe2f6898e8920eb37ca064381 Reviewed-on: https://gerrit.libreoffice.org/56468 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-26pass vector as arg, rather than raw pointerCaolán McNamara
Change-Id: Id97df4cce7a2ce28f1a5e7cc30e27cf4ce9261d1 Reviewed-on: https://gerrit.libreoffice.org/56467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-26can use simple vector hereCaolán McNamara
Change-Id: Ia1565a946f9ac6d607fb6802b19e561fc9afc66d Reviewed-on: https://gerrit.libreoffice.org/56466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-29 11:26:41 +0000