summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-03-13tdf#124035 LibreLogo: support starting colon in variable namesLászló Németh
Regression from the commit 740b99783b5480fcd1e5fce7c1beb5967d015041 "tdf#120413 LibreLogo: handle complex Logo expressions". Change-Id: Iaae54efacf86a03a6611c154a40068ed058d43e7 Reviewed-on: https://gerrit.libreoffice.org/69138 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-13Revert "tdf#41202 allow decrease selection with shift-click in writer"Xisco Faulí
Reverted as suggested in https://bugs.documentfoundation.org/show_bug.cgi?id=123582#c4 This reverts commit 31ba2a6bdecb81545d9b871a1a9394e5d7a3f2c4. Change-Id: I574bacd227bdd6b0364251b060327a3e5f820965 Reviewed-on: https://gerrit.libreoffice.org/69132 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-13NB grouped writer: update styles commands to show icons in dropdownandreas kainz
Change-Id: Iaa16fd2c04f5168bcb58d71d48f563ae1856a901 Reviewed-on: https://gerrit.libreoffice.org/69145 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-12sw HTML export, field shadings: give text portion background priorityMiklos Vajna
If the user explicitly gives a background color to the field portion, then respect that, don't overwrite with the field shading (the UI does the same). Change-Id: I7c35618f82a37ef1dd16c03b82651268767813af Reviewed-on: https://gerrit.libreoffice.org/69127 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-12weld SwAddrDlgCaolán McNamara
Change-Id: I6d8b5ffa4b9db27335e771153119264216c0b8f7 Reviewed-on: https://gerrit.libreoffice.org/69084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12UNO SwTextTable: uso SvtListener instead of SwClientBjoern Michaelsen
Change-Id: I672ea969efccf660d9a23847b26535031144e3da Reviewed-on: https://gerrit.libreoffice.org/68473 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-12Beautification to tdf#123395heiko tietze
Separator added before the popup menu Extends patch 9ccdb944a6bfde317febbf7cfc37ae8e6e6df8c9 Change-Id: Ie7d0beb45004985b25ae41458399ec979ca474ce Reviewed-on: https://gerrit.libreoffice.org/69078 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-03-12sw HTML export: handle field shadings view optionMiklos Vajna
Regardless of the value of the View -> Field Shadings option, shadings were always lost when saving to HTML. Implement handling of this in the HTML conditionally, so in case that UI option is on, then shadings are preserved in the HTML result; disabling that option results in the old behavior, though. Change-Id: I1bd19f4c6e22aff2f84fac25f0a506ad0127cc3c Reviewed-on: https://gerrit.libreoffice.org/69081 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-12tdf#119253 sw: fix layout loop with row-span tableMichael Stahl
This table has style:row-height="2.014cm" on its 2nd row (1142 twips). In the 1st call of FormatLayoutTab(), the 1st row of the table is split and the 2nd row moves to the next page. In the 2nd call of FormatLayoutTab(), the 1st row grows from 400 to 454 twips, presumably due to the style:min-row-height="0.801cm" on it. In the 3rd call of FormatLayoutTab(), the GetFollow()->ShouldBwdMoved() returns true and the 2nd row moves back again, because SwTabFrame::CalcHeightOfFirstContentLine() determines the height of the 2nd row as the maximum height of cells with rowspan=1 (400 twips), which fits on the 1st page, ignoring the style:row-height="2.014cm" on the row (1142 twips), which does not fit on the 1st page. This loops until "LoopControl_1 in SwLayAction::InternalAction" is triggered, and then eventually stops in 5.4 but loops even more since commit 18765b9fa739337d2d891513f6e2fb7c3ce23b50, for unknown reasons. Change-Id: I1a5c50d21c241e593419e63644ee758cdd9ed319 Reviewed-on: https://gerrit.libreoffice.org/69061 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-12tdf#42949 Fix IWYU warnings in include/connectivity/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221 Reviewed-on: https://gerrit.libreoffice.org/68893 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-12tdf#123898 Fix frame content misalignedSamuel Mehrbrodt
Frame was correctly formatted until spellchecker comes and calls GetCharRect which somehow reformats the frame causes the misalignment. So instead of calling GetCharRect, just call GetPaintArea as the frame is already formatted at this point. Change-Id: I31df9140174c40cf4cf39891490301cbe4c5806a Reviewed-on: https://gerrit.libreoffice.org/68927 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-12tdf#123104 DOCX import: fix lack of vertical merge due to roundingMiklos Vajna
Regression from commit 29cbbad64088354425c606f9eb6c267bdf7731dc (DOCX import: fix rounding error in table cell widths, 2014-11-07), which changed truncation to rounding for the twips -> 1/10000th of relative width conversion during import, but left export unchanged. But adapting the export is not that easy: one part would be the std::unique() call in WW8TableNodeInfoInner::getColumnWidthsBasedOnAllRows() to not require exact comparison, but doing so has it own side effects (multiple failing tests). So just revert the mentioned commit, as a minor rounding error is much better than a broken vertical merge. And once it's clear how to adapt export at the same time, this rounding on the import side can be re-introduced. Change-Id: I9e01ea5cc2c2f8aabe1e21cb8118c9c0e2c45494 Reviewed-on: https://gerrit.libreoffice.org/69065 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-11sw doc model xml dump: show text node's field hintsMiklos Vajna
Change-Id: I17927231da389ce54d2fb8ade0091c7e7033a808 Reviewed-on: https://gerrit.libreoffice.org/69049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-11tdf#123395 Add "Send Outline to Clipboard" to Navigator->Context menuWenzhe Pei
Change-Id: Ice8f6a99e437e99c7e169e230e034a04f42eea0d Reviewed-on: https://gerrit.libreoffice.org/69026 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-11MSForms: Fix removal of all items on the drop-down form field dialog 2Tamás Zolnai
Change-Id: I37ffbbe48a8b08cc10c83d4bb68946908475776d Reviewed-on: https://gerrit.libreoffice.org/69038 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-11sw: prefix members of SwCalendarWrapper, SwDoc and SwFntAccessMiklos Vajna
Change-Id: Ia233670c8cc01442aa91588fd7aa5d65443af077 Reviewed-on: https://gerrit.libreoffice.org/69033 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-11Fix typoAndrea Gelmini
Change-Id: Ifcd15fe961f9e797b22845fcebdffe6b3684888e Reviewed-on: https://gerrit.libreoffice.org/69027 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-11tdf#123054 track changes: fix paragraph style regressionLászló Németh
caused by the commit 173069a1f6ac060a06f04908a94a1a8420461795 "fix paragraph join with change tracking" and commit 1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49 "change tracking: show layout changes at paragraph join". Change-Id: I05203255b04094ae118fd4967398045d6e0ad9fa Reviewed-on: https://gerrit.libreoffice.org/68947 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-11weld SvxMenuConfigPage/SvxToolbarConfigPageCaolán McNamara
Change-Id: I166ac6c0be8461ea38db711796d1e14fc5b78998 Reviewed-on: https://gerrit.libreoffice.org/68889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-10MSForms: Fix removal of all items on the drop-down form field dialogTamás Zolnai
Change-Id: Idbb9cb80fd842bc01ee857709a825821c2bcffd2 Reviewed-on: https://gerrit.libreoffice.org/69009 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-10MSForms: UITest for drop-down form field's propertis dialogTamás Zolnai
Also changed the dialog's code a bit to work correctly with the UI test too. Change-Id: Idec85746f5ada979518d1fb0e09dc1c8e22ba7c1 Reviewed-on: https://gerrit.libreoffice.org/68967 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-10Resolves: tdf#123950 'standard' buttons missingCaolán McNamara
Change-Id: I44d25156c647e28c0b82f1c6da0de90a5a76261c Reviewed-on: https://gerrit.libreoffice.org/68980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-10MSForms: Add some extra comments for the new codeTamás Zolnai
Change-Id: I4b70eb2164032623a12f9e703c660eca1d6768ec Reviewed-on: https://gerrit.libreoffice.org/68965 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-10MSForms: Test insertion of form fields and undo / redo of this insertion.Tamás Zolnai
Change-Id: I526faceab8eb1ce2f16d41ab1bed8cfb1bfcca24 Reviewed-on: https://gerrit.libreoffice.org/68966 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-10MSForms: Test legacy form field import / export for the supported formats.Tamás Zolnai
Change-Id: Idbb80d097b21386e7d2673290a318d98b92125d5 Reviewed-on: https://gerrit.libreoffice.org/68964 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-10MSForms: Fix handling of drop-down form field after DOC importTamás Zolnai
In the properties dialog, code expected that the ODF_FORMDROPDOWN_RESULT is not set in case of an empty list. This caused a crash. The field popup window code expected that the list is not specified when it is empty, but DOC import code sets ODF_FORMDROPDOWN_LISTENTRY even if the list is empty. Change-Id: If4c86fc5a08cdc578150afaa42ad7e86bdba9150 Reviewed-on: https://gerrit.libreoffice.org/68963 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-10MSForms: Open Control Properties dialog by double click for drop-down fieldTamás Zolnai
Change-Id: I66c0a7bad63d929ae346afe9d328d87dfa2c24ae Reviewed-on: https://gerrit.libreoffice.org/68962 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09MSForms: Add a drop-down button for drop-down form fieldTamás Zolnai
* Introduce a editing frame with a button for drop-down form field. ** The frame is mouse transparent. ** Pushing the button opens the popup window with the items of the field. * The button is visible when the cursor is inside the field. Change-Id: I5c7db138d14380899fee046c95a5afe14cfea213 Reviewed-on: https://gerrit.libreoffice.org/68961 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09tdf#98620 filter\ww8 export: spam bidi=LTR alsoJustin Luth
If the AppLanguage is RTL, then it is likely that paragraph styles inheriting from the environment will export as RTL. So, if the paragraph is LTR (from a page style for example), then it needs to be specified in order to override the paragraph style. So, this is not just for RTL, even if it is a default value. Exactly what the paragraph style will become is complicated, and not necessarily the same across the different formats. Thus it is safest to just spam the bidi attributes across any questionable paragraphs. A followup commit will similarly spam Justify in these situations, and again the difference between doc and docx suggests it is better to spam more, rather than less. Change-Id: Id184a983675b147f051821e828583a4bf98b3211 Reviewed-on: https://gerrit.libreoffice.org/66922 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-03-09MSForms: Introduce a new IFieldMark for drop-down form fieldTamás Zolnai
* It was weird anyway that a drop-down form field was represented as an CheckboxFieldmark. * It will be useful for later commits, to have a separate field type for drop-down field. * Needed to fix-up the API a bit because it was designed to specify the field type after initialization. I solved it in a way to not break the API behavior. Hopefully it's not very slow. Change-Id: I3103e6b1c36289b27b62ab9ca7dfeebc14901c8a Reviewed-on: https://gerrit.libreoffice.org/68960 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09MSForms: Update cursor position after the drop down form field was changedTamás Zolnai
Change-Id: I0e9e8a0e9212cdf539caa163f9071bc2f21e4c9f Reviewed-on: https://gerrit.libreoffice.org/68959 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09MSForms: Disable legacy field menu slots if the cursor is inside a text fieldTamás Zolnai
Insertion of fields inside fields is not an allowed operation. Change-Id: Icfdbc1add9c828227201b70cd545a83b6dcbc3e6 Reviewed-on: https://gerrit.libreoffice.org/68957 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09Fix typoTamás Zolnai
Change-Id: I2b09bf30c3769f6b987409cabf24735647d3c31d Reviewed-on: https://gerrit.libreoffice.org/68958 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-03-09MSForms: Implement undo / redo for insertion of legacy form fieldsTamás Zolnai
Need to handle undo / redo explicitely for form fields, because there is no a general working undo / redo mechanism for fieldmarks. During the insertion of the fieldmark, text insertion also happens which generates an interfering undo action, so we need to disable undoing temporary. Also need to invalidta SID_UNDO slot to make the undo toolbar item updated after we insert a form field. Change-Id: I358c2704cb30212a38f8a998888a36f72fa404e5 Reviewed-on: https://gerrit.libreoffice.org/68956 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09MSForms: Fix drop-down form field properties dialog to work with vcl backendTamás Zolnai
Change-Id: I28a8d96d3ff31a53512af6d61c58594da7b9f73e Reviewed-on: https://gerrit.libreoffice.org/68008 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-09loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f9ff0fc58adf51eae7fef5ce925b91b8d1f4922 Reviewed-on: https://gerrit.libreoffice.org/68940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb2c9a2d1d7dcc0ed3e8458c1a13933ccababd4c Reviewed-on: https://gerrit.libreoffice.org/68939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unusedmethodsNoel Grandin
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I1fcde14b66ce80157cbebe7f3ec8c5ced1e13143 Reviewed-on: https://gerrit.libreoffice.org/68937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09uitest for bug tdf#123547Zdeněk Crhonek
Change-Id: I89bea33e3a07655a25f1951109679188532001dd Reviewed-on: https://gerrit.libreoffice.org/68943 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-03-08set empty text for GtkMenuButtons which will later have textCaolán McNamara
Change-Id: Ib08cca8faf2822e5a62f745c4213cf0ca2cc09d7 Reviewed-on: https://gerrit.libreoffice.org/68923 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-08Use pragma once instead of header guardSamuel Mehrbrodt
This is a test on a random file to see if all compilers accept this. Change-Id: I412aef57730d07c8e6e2710fee71d5eded326d48 Reviewed-on: https://gerrit.libreoffice.org/68896 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-08sw: replace long lists of components with services.rdbMichael Stahl
This should be more maintainable. Change-Id: I60ee68cd79f7a0627bcaf8fd34d3036124ea0f9e Reviewed-on: https://gerrit.libreoffice.org/68914 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-08tdf#123259 sw_redlinehide: fix reanchoring of drawing objectsMichael Stahl
... in SplitNode. The problem is that first the new anchor position is set in the SwFrameFormat, then SwDrawContact::DisconnectFromLayout() is called (implicitly from its SwClientNotify()). This then cause the a11y wrapper to be disposed and an event to be sent, which then ATKListener::notifyEvent() immediately processes by retrieving all of the children of the anchor SwTextFrame. At this point, we get an assert from SwTextFrame::MapModelToView, because the layout anchor frame is still the old one, but the model format already has the new position, so the frame can't map the anchor position. Avoid this by explicitly disconnecting from the layout before setting the anchor on the SwFrameFormat. Change-Id: Iba8960729dd041e13de4963d1b2ab6b223c8a427 Reviewed-on: https://gerrit.libreoffice.org/68880 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-08sw: ODF import: try to fix aExcludeWhenNotLoadingUserSettingsMichael Stahl
In SwXMLImport::SetConfigurationSettings() there is a list of settings that will be ignored/not loaded form the file if IsLoadUserSettings() is false, which is presumably not the default. The beginning of this list is obviously settings that can be set via Tools->Options, but the end is mostly a bunch of Word-compat layout settings that cannot be set in the UI. Let's assume some cargo-culting happened there (this function is tricky and underdocumented anyway), and replace the end of the list with those settings that have been added to Tools->Options->Writer->Compatibility in the last years, since those can be called "user settings". Change-Id: I6ea4a5da4033ca3512d71e4123b47d46e20bf596 Reviewed-on: https://gerrit.libreoffice.org/68803 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-08tdf#116195 sw: remove DisableOffPagePositioning handling from ODF importMichael Stahl
SwXMLImport::SetConfigurationSettings() needs to handle only those settings for which the default is different vs. old OOo/LO versions; DisableOffPagePositioning however defaults to false, so we can just rely on that default. The inverted bDisableOffPagePositioning check is wrong. (regression from fe3d5766fa3c42f6cf8d1ea47af820e0b1c1cf48) Change-Id: I300fa597f58b586b49089bb555a00a6923862abe Reviewed-on: https://gerrit.libreoffice.org/68801 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-08sw btlr writing mode shell: left/right cursor travelling, fix vert posMiklos Vajna
By implementing BTLR support in SwTextFrame::SwitchVerticalToHorizontal() (Point version). Cursor traveling now looks good: all of up/down/left/right direction have the correct paragraph and character position for all the lrtb, tbrl and btlr cases. As a side effect this also fixes mouse click, where clicking above the paragraph positioned the cursor at the bottom of the paragraph. Explicitly add a test for the mouse case as well, given that I initially planned to fix the keyboard part directly in SwCursor::UpDown(), where the keyboard test would pass, but not the mouse one. Change-Id: Iabeded3f03a64416cfcaf58e0438c4a1a793e662 Reviewed-on: https://gerrit.libreoffice.org/68886 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-08Make variable name more descriptiveSamuel Mehrbrodt
Change-Id: I8791d0f2cc33813c6034b771fa1f699143c3cfac Reviewed-on: https://gerrit.libreoffice.org/68877 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-08Add some commentsSamuel Mehrbrodt
Change-Id: Ic6d8082251246f3ca8c00b090679a0e590b0a8d0 Reviewed-on: https://gerrit.libreoffice.org/68876 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-15 04:47:28 +0000