summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-01-14rework PageColumnPopup to be a PopupWindowControllerCaolán McNamara
Change-Id: I00d0ce6001f2eb3076c699bca7c64a72b94716c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14weld PageSizePopupCaolán McNamara
Change-Id: I989e2a6337f368ec388290f1e4af329865af9ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86749 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework PageSizePopup to be a PopupWindowControllerCaolán McNamara
Change-Id: Ib8a0acbceca607b0820437d66e18c7cd8c16904e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14remove some unneeded includesCaolán McNamara
Change-Id: Ic7add88f04fb53960c4d76414fb655cb4e5040b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework SfxCharmapCtrl to be a PopupWindowControllerCaolán McNamara
With MSVC, the changes to include/sfx2/charmappopup.hxx would cause spurious > isvt.lib(svtlo.dll) : error LNK2005: "public: virtual class com::sun::star::uno::Any __cdecl cppu::ImplInheritanceHelper<class svt::ToolboxController,class com::sun::star::lang::XServiceInfo>::queryInterface(class com::sun::star::uno::Type const &)" (?queryInterface@?$ImplInheritanceHelper@VToolboxController@svt@@VXServiceInfo@lang@star@sun@com@@@cppu@@UAA?AVAny@uno@star@sun@com@@ABVType@4567@@Z) already defined in classificationcontroller.o > isvt.lib(svtlo.dll) : error LNK2005: "public: virtual void __cdecl cppu::ImplInheritanceHelper<class svt::ToolboxController,class com::sun::star::lang::XServiceInfo>::acquire(void)" (?acquire@?$ImplInheritanceHelper@VToolboxController@svt@@VXServiceInfo@lang@star@sun@com@@@cppu@@UAAXXZ) already defined in classificationcontroller.o > isvt.lib(svtlo.dll) : error LNK2005: "public: virtual void __cdecl cppu::ImplInheritanceHelper<class svt::ToolboxController,class com::sun::star::lang::XServiceInfo>::release(void)" (?release@?$ImplInheritanceHelper@VToolboxController@svt@@VXServiceInfo@lang@star@sun@com@@@cppu@@UAAXXZ) already defined in classificationcontroller.o when linking Library_sfx (and which appears to be unrelated to the (implicit) /INCREMENTAL since 9739c37d8ad7c6fca269709674a6975fa7ebd191 "enable incremental linking on windows"), which requires the HACK in include/svtools/popupwindowcontroller.hxx. Change-Id: I74c4318e6216001f18d0cf5ed63e78ba2ab13cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86664 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14tdf#128304 export TB_RL writing mode as eaVirtMark Hung
and import eaVirt to TextWritingMode instead of TextPreRotateAngle (-90) degree of CustomShapeGeometry. CJK text in TB_RL writing mode are upright in Writer. It corresponds to eaVirt by its defintion. Change-Id: I2a8bc6676ad6af06b06e023adaa2f201a028d426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86637 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-14tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMesut Çifci
Change-Id: I42b59c9d22edb987c55aace700934fdab95f83f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86719 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-14Related tdf#129836 - Alphabetize styles in the footnotes/endnotes dialogHeiko Tietze
Page and paragraph dropdowns were missing in Ie9bc4f63412dabd6032f0a9b7225384823f2f39a Change-Id: Ied25eeb1360718315190104213172da594e4b05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86666 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-13sw reqif-xhtml export: fix non-well-formed output on Chinese textMiklos Vajna
And also search for the '"<" OOO_something' pattern, and fix up all cases where we forgot to call GetNamespace() when opening an element. Change-Id: I015e807c1ad0f96c7c4aaa97f7f61ae134cf3754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86701 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-13rework TextUnderlinePopup to be a PopupWindowControllerCaolán McNamara
Change-Id: I149777b827dd00e00e62b461836122861864f829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-13rework TextCharacterSpacingPopup to be a PopupWindowControllerCaolán McNamara
Change-Id: I3db8f93b99157f7ee8d6095f7dfc5c2b2e6890e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-13tdf#129655 Sync TextWritingMode to frame direction.Mark Hung
Sync the text writing mode of a shape to the frame direction of the attached text box ( a text frame ). Change-Id: Ied9ff1a1d0f53d7ef78a83a086af0a2c1ca5eb36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86638 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-13tdf#90834: Turn in-line version control history comments into good commentsMesut Çifci
Change-Id: Ia04b7d4ed5876db8f2f5bed2c8f28af2c203877b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86039 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-13sw: prefix members of SwGrfNode and SwChartLabeledDataSequenceMiklos Vajna
See tdf#94879 for motivation. Change-Id: I6a752a952e41302620463682c3361fad7e639df4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86656 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-13tdf#115600 Fix navigate by reminder wrap messagesJim Raykowski
Navigating by reminders is done in the order which reminders are set. This patch corrects wrap messages displayed when first and last reminders are reached and continued from the last and first reminder. Change-Id: Iaea1965df149a029b4b1e2df059a8d73306f901c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86629 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-12tdf#129423: Make export tests export-only where applicableayhanyalcinsoy
Change-Id: I71d7e23dfdccd508ab0c12776296886c4bd028a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85880 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-11cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: Ib8b988f0308d8d438e0f093594a179c84731ab3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-10Fix typoAndrea Gelmini
Change-Id: I867d8466f44934757be103f1dae7544cb1981a55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86585 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-10DOCX import: fix lost objects anchored to an empty linked headerMiklos Vajna
This is really similar to commit 04b2310aaa094794ceedaa1bb6ff1823a2d29d3e (DOCX import: fix lost objects anchored to the single para of a linked header, 2020-01-10), except here the header is not just a single-paragraph one, but has no text portions. Update text-copy.docx to have a header which is not only a single paragraph, but also has no character content. This keeps testing the original case, but now also tests the more strict case (single paragraph -> single empty paragraph). Change-Id: I11bb062e77af1a83f717225ea5b4daef39e5a672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86552 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-10tdf#120344 DOCX: fix font style of numberingSzabolcs Toth
(numbers and letters) when list items use different font type by direct formatting, solving also the mixed and changing numbering style during editing. Change-Id: I7ebf125bb1b67cbb33078a4e218798e7ffc06260 Co-Author: Balázs Nádasdy (NISZ) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86277 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-10DOCX import: fix lost objects anchored to the single para of a linked headerMiklos Vajna
Regression from commit 08f13ab85b5c65b5dc8adfa15918fb3e426fcc3c (tdf#112202 writerfilter,sw: fix loss of headers, 2019-12-16), the problem is that on one hand, copyText() is meant to copy a complete XText (header, table cell, footnote, etc), OTOH the internal API use used only copies at-para anchored objects for complete text nodes, so a one-paragraph header will loose its anchored objects when a linked header is copied. Introduce a new "CopyText" flag that provides the expected copyText() behavior and use that when the copyText() UNO API is invoked, but leave the selection behavior unchanged. Perform the inclusive check in IsSelectFrameAnchoredAtPara(), opt in for that from SwXText::copyText(), the rest is just passing the flag around. Change-Id: Id727f7ca4f6121a7050340359716a52ecb4886f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86529 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-10tdf#128207: DOCX import: fix chart positioningBakos Attila
Embedded graphic objects had got 0 values for vertical and horizontal positioning before, resulting overlapping, hidden charts, but now they are positioned according to the values in the document. Change-Id: Ia5403ac65ff7192d61072e8a9d8a7f80c7178b9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86521 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-10use more std::make_sharedNoel Grandin
found using 'git grep', I tried using clang-tidy, but it only successfully found a tiny fraction of these Change-Id: I61c7d85105ff7a911722750e759d6641d578da33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-10tdf#88713 Fix navigating navigator remindersJim Raykowski
Change-Id: I65be92eda086af2f98da723828ff965047e87227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09tdf#115026: Add uitestXisco Fauli
Change-Id: Iaac2a1065c0c1c28e56db8a121cb28453e27d529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86497 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-09Improve loplugin:redundantcast for sal_Int... vs. ::sal_Int...Stephan Bergmann
Change-Id: I1548a76fdc03afee68f1e5c01bc665e616f2edf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86501 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-09tdf#90069 DOCX: fix character style of new table rowsLászló Németh
DOCX table import didn't set paragraph level character styles on paragraph level, only on text portions, resulting default character style in the newly inserted table rows instead of copying the style of the previous table row. Change-Id: Idb4438c767bdc7e0026fc6e0f0a795d8efdda3c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86429 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-09sw: fix confusing comment in CopyFlyInFlyImpl()Miklos Vajna
Change-Id: I7b9da4aecc7dce4b2a539455182e5a3f6a75a497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86494 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-09sw: tolerate null ShadowOverlay object as the rest of the code does.Michael Meeks
Change-Id: I552c0f11b22212d36bcaee33432e2a10d4df58ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86473 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-09tdf#45636: test for no-alt and table split/merge access. checkTomaž Vajngerl
Change-Id: I6474b5e0db90143efa1ea066142961c2fe250ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-09tdf#45636 trigger accessibility check when exporting as PDF/UATomaž Vajngerl
This triggers the accessibility check, when we want to export the PDF with PDF/UA functionallity. If issues are found, it will show the issues. OK will continue with export despite the issues and cancel will cancel the whole PDF export. Change-Id: I2fde97381e08e9c2c79473888caa36e8dd828979 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86387 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-09Resolves tdf#129836 - Alphabetize styles in the footnotes/endnotes dialogHeiko Tietze
List is sorted now Change-Id: Ie9bc4f63412dabd6032f0a9b7225384823f2f39a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86490 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-09acc. check: move AccessibilityIssue from svx to sfx2Tomaž Vajngerl
Move AccessibilityIssue and AccessibilityIssueCollection from svx to sfx2 because we need to use them in sfx2, but svx is dependent on sfx2 so this creates a circular dependency. Change-Id: Ie71d12a018ddc65797f5115eb545f499b927ab40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86444 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-09Use FastParser in SwXMLTextBlocksNoel Grandin
the underlying SvXMLImport subclass already has a FastParser inside it Change-Id: I4c33508fc28eac2c119361506158c1f4520162ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09flatten SwXMLTextBlocks::GetMacroTableNoel Grandin
Change-Id: Ie3fcb4bb350796b10d0e10aadc58d57b71d480a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09cleanup tdf#129522: indentingJustin Luth
It is much easier to see what has changed if a commit does not include formatting changes. Since there were a couple of them, I separated it out into a separate patch. I don't normally do this, but it seems like a good idea, so I'm trying out the best way to do it. The bad-side would be an extra patch to backport, but I'm not expecting much desire to backport here. Change-Id: Icc0eae1a881af80c0b8230697b235d1901b55fe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85871 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-09tdf#129522 ooxmlexport: allow char shadow_NONE overrideJustin Luth
Normally we would NOT want to write out nil borders or shadows. However, if these would be inherited, NILs needs to be written out. This already worked for paragraphs, so it was just a matter of identifying the character styles and testing against them. I couldn't find anything that clearly stated that ChpIter is the CharStyle properties, but it appears to act that way, since the first check is for ISet (which seems to be direct properties) and the second check is usually for styles, and the Internet also suggests Fkp's are for styles. This is the last patch in a series, and provides the unit test for a previous import fix. import depends on commit ccfccf4365362b5ba1d82b5816d5fc81a67de548 which depends on commit 4ca73073a0d7c62b12a7354f76f8f80adc5d98c1 and for export depends on commit f84b33275f6cce21e93e5dd20f3de5df84df0276. Change-Id: I5230adc52196b9b610d7863397bf33143682370c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85870 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-09tdf#129468 Add uno command .uno:SetReminder to set a reminder bookmarkJim Raykowski
Replaces code in SwNavigationPI to set a reminder with call to uno command Change-Id: I2f14d88c99488b1dbfdecb9831f6716c95da7438 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86389 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-08DOCX import: fix lost page break when footer ends with a tableMiklos Vajna
Regression from commit 7d3778e0ef9f54f3c8988f1b84d58e7002d6c625 (bnc#816593 DOCX import: ignore page breaks in tables, 2013-09-02), the page break was ignored because the preceding footer ended with a table (no empty paragraph at the end of the footer stream). Fix the problem by saving/loading the table state around header/footers, that way the page break is not ignored. Adjust testTdf102466 to test the page number from Word. Change-Id: Ia4c22452ee2c37f7f941dfd922db04c851644d0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86435 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-08rework ParaLineSpacingPopup to be a PopupWindowControllerCaolán McNamara
Change-Id: I8b43e0345d8d3c38a7ef21f31655b578a8dc8ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08Missing include (Windows --disable-pch; for std::min)Stephan Bergmann
Change-Id: Ie6951257a94ae004e1a51f46e908917a07d137f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86417 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I76be5d73d9acfe0c3f5525b251bb3feffb1e4c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86380 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I211fb36e9ad16b8ed468ce8dec5c95e7f5ab9391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86381 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I4e4a1b24d6b19ab62d9f0d73bcd74492bc955beb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86379 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I29fcf584404acf9302e261721bb6c255e4701918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86382 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typosAndrea Gelmini
Change-Id: I2f498d16882e2aa6e75d6fc0a1073f094869a2b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/77765 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Options Dialog Compatibility options update first global than fileandreas kainz
Change-Id: Ibd906476eb9a798b1ef290a35545e0b22c10b892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86407 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-08Options Dialog AutoCaption fix label alignment to follow HIGandreas kainz
Change-Id: Ia1e6370ba2c15d9ef6c940b60ebe8ada846622c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86411 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-08Grammar fixesAndrea Gelmini
Change-Id: I6ac6f6abb601aa254e94612e6826488393de8e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86383 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-08Options Dialog Formating Aid update to fulfill HIGandreas kainz
Change-Id: Ic42946e661f2e7e8f31a0520d895c2fa07d6a387 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86401 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-27 03:57:55 +0000