summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-07-03tdf#134463 DOCX import: fix other "half" of contextualSpacingLászló Németh
Always ignore own bottom margin setting of the previous paragraph with contextual spacing, if the actual paragraph is identical. I.e. in that case, too, when the actual paragraph has no contextual spacing, like MSO does. Note: PARA_SPACE_MAX mode hasn't included this modification, yet, so only ODT documents converted from DOCX use it at the default setting. See also commit e318d5d8146d18e2c76e23f2e3c39527f2af9f36 (tdf#125893 DOCX import: fix "half" contextual paragraph spacing). Change-Id: I83fab2a2d85eeb9d48a8546d5a4e6423988d642c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97874 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-03Css1FrameSize::AnyHeight is deadNoel Grandin
ever since initial import Change-Id: Ifa8346b4f603afde84a1e61fc251137c189e674f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03tdf#112312 DOCX legacy shape export: keep fixed sizeRegényi Balázs
Classical/legacy shapes lost their fixed size when exporting them with the option "Resize shape to fit text" because they do not have the ability to resize to content. Co-authored-by: Szabolcs Tóth Change-Id: Idd84dea040f9607d0d498e591601a8648a605a2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97127 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-03uitest : Add demo for SvxNumValueSet supportAhmed ElShreif
The demo is just a test case added to BulletsAndNumbering Dialog test cases . The BulletsAndNumbering Dialog has 4 SvxNumValueSet so The test case works with each one of them . We now have support for "Writer: Format-Bullets and numbering dialog- Selection" item . Change-Id: I3a0827991a5fd004489459feb7c49214c9e2b766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97341 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-03Added tree view for Inspector and support for PSShivam Kumar Singh
-> The support for PS has been added. -> The UI for Inspector has been updated with expand/collapse buttons for PS and CS. -> Any property is listed only once at the Inspector either at PS or at CS -> Hide any property having default value (only modified properties are of interest) -> Hide Asian and Complex Properties Change-Id: I3b519eef7a5699339608fdb8c29d6f04498f4346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97263 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-03tdf#133944 writer image shadow incorrectNoel Grandin
regression from commit 1f59cbe36c9899f6fa9a869331c9be454abd4606 Date: Fri Apr 17 15:38:05 2020 +0200 simplify some SwRect code - use the SwRect Add* variants Change-Id: I435b1153f272b08a2bfe7d90145de1ee5a702b08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97720 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03SwTOXMark::InsertTOXMarks: SwIterator no more ...Bjoern Michaelsen
- remove manual SwIterator usage - moved SwTOXMark from ::Modify to ::SwClientNotify - replaced static InsertTOXMarks() with SwTOXType::CollectTextMarks() where it belongs Change-Id: Ib8289c07882a61278dedb1bc1fadc1a9237fea4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97663 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-07-02tdf#133735 DOCX: fix paragraph settings of nested tablesLászló Németh
First row of a nested tables lost its paragraph settings, by dropping the collected paragraph data of the unfinished row. Regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c (tdf#132514 DOCX import: fix lost table style with footer) Change-Id: I17d81d0906f424fe35237ac285e8ad27090bcab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97645 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-02notebookbar: insert styles preview widgetSzymon Kłos
Change-Id: I9a9baed9bc6b769a83295f05fd17133b12965398 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96916 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97417 Tested-by: Jenkins
2020-07-02Getting styles info shouldnt set document modification stateSzymon Kłos
Getter function modified document's 'is modified' state and broadcasted it due to internal styles creation/delete That caused spam of SwCursorShell::UpdateCursor calls when styles preview widget was used in the notebookbar. Change-Id: I22ee4e820adf79f6e816cb35161cb21f26abb2b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96921 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97733 Tested-by: Jenkins
2020-07-02disable testTdf122225 with --without-fontsRene Engelhard
Change-Id: I498da0b45b281005c72bfe47c822b0a4798e884b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97652 Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2020-07-02tdf#123324 DOCX import: fix shape height relative to top page marginRegényi Balázs
using UNO API RelativeHeightRelation and the associated lo-ext attribute for OpenDocument export. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). Co-authored-by: Szabolcs Tóth Change-Id: Ibaba4b3762de5a70506dacd85a818b8972b18144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96869 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-02tdf#127680 Add the option to print even or odd values from a particular rangeSrijan Bhatia
Added a box besides the pages option that lets the user choose between left and right pages/left pages/right pages. Change-Id: Iee0386f4f3cfd2dac3fcf898a3fefb5434cb27a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96612 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-02tdf#134112 sw: Test access of text field master objectOleg Schelykalnov
Change-Id: I793528faa6d73f7a97ddd4409ae8a1a3e611cea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96674 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-02Upcoming improved loplugin:staticanonymous -> redundantstatic: swStephan Bergmann
Change-Id: Id4e6e18b1fce848972e67ca519cbf23eab7cd109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97701 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01reorder parameters of SvXMLExport::SvXMLExportNoel Grandin
so they all have similar order Change-Id: Id8baef058d52f6cce9d9be41b0341eec8ad648b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01tdf#133863 tdf#133864 DOCX shape import: width relative to insideRegényi Balázs
and outside margins. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). commit b46f4bc9760267ac5e45d43b77b5d2721ee4c386 (tdf#133070 DOCX import: fix shape height relative to bottom page margin) commit 330ed8120e9881656716d70d87b9f49f861f0bfa (tdf#133670 DOCX import: fix shape width relative to right margin) commit 7380905abc0833d9e4c4fe731d76174db8a8724c (tdf#132976 DOCX import: fix shape width relative to left margin) Co-authored-by: Szabolcs Tóth Change-Id: If81b7c80732141be1491ca82770cf6eee99f5656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97627 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01weld EditControl for browseboxCaolán McNamara
Change-Id: I8f21c12f7ee10e1b9ba883a8ff01bb5252429f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01tdf#126504: sw: Add unittestXisco Fauli
Change-Id: Iceca8bc3ae2dcad04040498565200361157f83e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97613 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01sw doc model xml dump: show SdrModel of embedded chartsMiklos Vajna
Change-Id: Iae9daefb9b2173736c039d6177d7356c27eb7a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97605 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-01Related: tdf#134360 table row/height widgets can get stuck insensitiveCaolán McNamara
Change-Id: I1be53f33f60c510757c67f1da8f863539ecbffdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97547 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01tdf#133070 DOCX import: fix shape height relative to bottom page marginRegényi Balázs
using UNO API RelativeHeightRelation and the associated lo-ext attribute for OpenDocument export. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). Co-authored-by: Szabolcs Tóth Change-Id: I31db99fac5ad24971fa427671198b47906e9c057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95451 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01tdf#134404: sw: Add unittestXisco Fauli
Change-Id: I81e46e06ad7964e52b45ce3433a25758cc7d19fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97534 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01Remove some unused includesMiklos Vajna
Change-Id: I44c9ad2511d484e3c7fb1c33f25fcb343eabd232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97548 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-01change n777345.docx to check bitmap content instead of checksumLuboš Luňák
Bitmap checksums are unreliable, they often depend on underlying implementation and whatnot. Change-Id: Ifc13285d6eb7d6d050a1ec26b270e0533eaae8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30tdf#134043 DOCX import: new unit tests: ComboBox to DropDownSerge Krot
Change-Id: I513933b508ca531e17271a3cc821a6aef2244868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97531 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30tdf#134277 sw table: fix lagging shape at page breakBakos Attila
Shapes anchored to characters in table cells didn't follow their cells at page break, resulting lonely shapes at the end of the previous page. Co-authored-by: Attila Bánhegyi (NISZ) Change-Id: I2149ef58696a8f5dc6f41959060d2d57f938d025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97209 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30dont (ab-)use typeless GetInfo() interfaceBjoern Michaelsen
Change-Id: I73ab1e0efcb3559dfe37f3f408b3ec4862a408e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97472 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-06-30tdf#134021: sw: Add unittestXisco Fauli
Change-Id: I789adaf699a857e28416132d253c04128def5984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97481 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#134414 Variables page doesn't need expandersCaolán McNamara
Change-Id: I5a38e1e8052c96970f9701f776f7675fda5f21c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30tdf#134404 sw: another subtlety with start/end of section (at-para flys)Michael Stahl
fix this problem by comparing the start/end of the selection instead of the anchor position, which always has an index of 0: 1. new document with image anchored to paragraph 2. insert one letter 3. press Enter 4. Backspace -> Image gone (regression from cc4b5091e739116a7ec83513fa1cd856f0130330) Change-Id: I1219a9f58ce19ea88d697c90c862fe9005318177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97511 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-30tdf#134243: sw: Add UItestXisco Fauli
Change-Id: I59376419048ddddff3e4fbbd6d3eb7436ee87747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97029 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#126425 Chart: fix missing legend with exceeding textTünde Tóth
Ellipsize legend box contents, if the custom size of the chart legend is too small to contain the text. Change-Id: I91ef913f509b233912a8bfb878a1c80d577e2a88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96437 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30tdf#134099 sw: fix textbox anchors on copy-paste and undoMiklos Vajna
Regression from commit c7307c77254557646f33017af915f6808a861e29 (fdo#82191 sw::DocumentLayoutManager: copy textbox content of draw formats, 2014-08-15), without which this problem gets hidden, as copy breaks the textbox into 2 pieces, so the textbox codepaths are no longer hit. The direct problem is that SwHistorySetFormat::SetInDoc() uses a raw node index into the nodes array, which is past the end of the nodes array. Root cause is that we have this invariant that actions and their undo has to be in sync, otherwise raw node indexes no longer work. In this case, SwUndoSaveContent::DelContentIndex() did not delete a fly frame format, because it was out of range, as it had a wrong anchor. Fix this in SwTextFlyCnt::SetAnchor(), so that whenever the anchor of a draw format is set via that function, we update its textbox as well. Also fix a related problem when fly formats were copied twice. Change-Id: I0d6c9069544c405eb20c5fed65fb40423b0adc84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97457 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30tdf#130151 Fix toc pointing to wrong pageSamuel Mehrbrodt
Change-Id: I26c1027722613f751bd39fde97f1e14d3238eefa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97413 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins
2020-06-29OOXML/ODF Support for Shadow blur radiusA_GAN
Adding export support for OOXML. Adding import/export support for ODF Changing some values in test cases as convertEMUtoHmm round the fraction. Add two test functions for OOXML and ODF export. Change-Id: Ie5d862b46b5264ead4954f407fee2837b5151cd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96907 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29tdf#134235 Chart OOXML import: fix long chart titleTünde Tóth
Workaround to handle long (sub)titles which resulted broken charts. See commit 96a29c12a9d8734c9d2a812f38fc6654b5df9c48 (tdf#101322 Chart OOXML Export: fix missing subtitle). Change-Id: I22bb4699bdda8dea5f31c715cc1f439085a0718f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97092 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-29tdf#134247 Chart OOXML import: fix order of legend entriesTünde Tóth
The order of legend entries was reversed in stacked column, line and area charts. Change-Id: Ia4a439aa6cee0619ad323c3fb728ff358cf28537 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96941 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-29tdf#122225 Chart OOXML import: fix missing legend textTünde Tóth
resulted by inaccurate calculation of nMaxTextWidth. Change-Id: Ie41bbc30074c6bbccacbc58adda5d9f2cfdfeba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96926 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-29sw: prefix members of CompareNodeContent, SwDDEFieldType, ...Miklos Vajna
... SwDropDownField and SwRangeRedline See tdf#94879 for motivation. Change-Id: Ic38825413d5725a143a2a7f81f0d464984e231e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97360 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-27tdf#134326 allow 2 decimal places for asian grid point sizesCaolán McNamara
possibly a regression since... commit 1f622157d10b15c7d9496e3887f493de0f0f94c8 Date: Sun Apr 7 18:04:11 2013 -0300 Convert Writer asian text grid page to Widget UI and use the same step increments found before that conversion Change-Id: Ifbbc847a487e0b7d33704e6cac74a6c1c6012ed4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1401342 Uncaught exceptionCaolán McNamara
Change-Id: Ia22ed8541f1148355d71cd5b90ad13e64c1b50c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464973 & cid#1464975 Resource leakCaolán McNamara
Change-Id: I4df8fefa7f875e0a25585c4fef22f077dcd0b83d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464971 Dereference null return valueCaolán McNamara
Change-Id: Id0f6aec4552e551d3ba697bb4a3c9b0e498fdf24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464968 Logically dead codeCaolán McNamara
added in... commit 99c4fefdbb6129a58421b9c7f4a005f868a0e701 Date: Wed Apr 22 11:43:22 2020 +0300 tdf#98409 doc export: export (non-default) cell margins Change-Id: Ie6bf4f16f73eb4d6b604e7c98ee61b388e9acd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464963: Null pointer dereferences (sw/wrtww8)Julien Nabet
Change-Id: Iea4b91b440c87a8a193a3c6b683a017d0948399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464967: RESOURCE_LEAK (sw/wrtww8)Julien Nabet
Change-Id: Ic1aa0d42f174808c7700875cb31f1c726b3160e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464974: Null pointer dereferences (sw/unosett)Julien Nabet
Change-Id: I4ea6de59ce1d1cb3133b0fb57176caee5497878f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27Colibre: tdf#133538: icons for Show White SpaceRizal Muttaqin
Change-Id: I757696ece0b06cdd91358ea8944ba5cc49a644d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97274 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-26update some pchesCaolán McNamara
Change-Id: I54b734062d94a59c2651827c02349d9562ac6cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>