summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-08-03tdf#134560 tdf#135107 make inspector contents human readableShivam Kumar Singh
This patch adds a dedicated hrc file for RID's of all the properties that can be displayed in the Inspector Change-Id: I258ca060508e28b7b66e96393fcef4fd104bb781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99983 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-03Validate SELECT rangeStephan Bergmann
63049e98a659290229d3356e76d49cea44575011 "Reliably set up controls of hyperlink dialog in constructor" fixed an issue that could cause Python UITest code to issue a bogus SELECT request that would fire an assert in rtl_uString_newFromSubString. Even if that issue is fixed now, it is probably a good idea to validate the requested range here. (An alternative would be to validate it in the underlying shell's SelectText, but that function is also called from internal code (which presumably already ensures that it is passing valid arguments), so it is probably better to stay with that function's narrow interface.) It would probably be nice if this function reported failure (by throwing a css::lang::IllegalArgumentException, say) instead of silently (modulo SAL_WARN) clamping the range, but it is called from Scheduler::ProcessTaskScheduling (vcl/source/app/scheduler.cxx) in a try/catch block that prohibits all exceptions. Change-Id: I5b7b4255861766a81a81501e391b1ff4e09b7db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99933 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-03sw: SwFlyInContentFrame, SwHTMLTableLayoutCnts, SwHTMLTableLayoutColumn ...Miklos Vajna
... and SwTextFly See tdf#94879 for motivation. Change-Id: I833b563a03824ae14014cdd418dcfd3b832a9a94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99984 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-03Remove pointless checkMaxim Monastirsky
This check was originally introduced by me for a few toolbar controllers (save, underline, currency), as an attempt to reuse the same controllers also for non-split buttons (see tdf#98745 and tdf#101672). But since then it was copy-pasted to other places where it probably makes no sense. Change-Id: I7af2a3f5864ced88c91f330e87f32046d0c21383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99960 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-03Fix radio buttons in context menus for non-gtk3Maxim Monastirsky
The vcl implementation expects menu item attributes to be set on the sub menu they appear in, not on the parent menu. Change-Id: I7d6553126ed1dd5c1434529342b776aee01409a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99954 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-03tdf#134971 Don't overwrite default styles when inserting docThorsten Behrens
Seems code never really bothered not to touch default style info, when inserting from file. Original commit is: Author: Sascha Ballach <sab@openoffice.org> Date: Wed Feb 28 08:24:41 2001 +0000 import of default styles added Change-Id: Ibb639a585bedabdcc5987900ecca1e04f4bb593a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99015 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-02tdf#135098 assert/crash on checking IsSelected on cell being disposedCaolán McNamara
Change-Id: I32ce9fcca86de4608939d385f42c43afc46bfb7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99956 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02Fix typosAndrea Gelmini
Change-Id: I90c9ecdaf262fe4e2d84af78b575a00c16634a7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99890 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-01Implement VBA's ListFormat.ConvertNumbersToTextMike Kaganski
This only handles lists with PositionAndSpaceMode::LABEL_ALIGNMENT. TODO: handle PositionAndSpaceMode::LABEL_WIDTH_AND_POSITION. TODO: handle NumberingType::BITMAP. It doesn't align number according to Adjust, since that requires to use a tab stop at the number position with appropriate alignment, and it's unclear how would that interact with LabelFollowedBy modes other than LISTTAB. When first tab stop position is greater than ParaLeftMargin, Writer uses left margin as implicit tab stop position, thus in this case list appearance is different from processed text appearance. In case of justified paragraphs, space after number (which does not participate in justification when part of numbering) becomes part of justification after conversion to text. Change-Id: I88ad6617f8a09307ecad9d28edee92a59c68a4d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99939 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-01loplugin:flatten in sw/core/accessNoel Grandin
Change-Id: I0116fe288b97d22c3f170f139fe95cfd06d89d8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-01Use a more conventional START/END_POS rangeStephan Bergmann
For the content of the selection it should not make a difference if that range is "backward" or "forward", but the latter looks cleaner. Change-Id: Ibc27ac257c9338f9b17ace10fbec938b1db394eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99932 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-01Remove the wait_until_property_is_updated calls againStephan Bergmann
They had been added with 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" and 1cdda798def040fe778348061c0e18b28aa0e6bd "Further timing issues with test_insert_hyperlink", but 63049e98a659290229d3356e76d49cea44575011 "Reliably set up controls of hyperlink dialog in constructor" now argues that they are probably not necessary after all: For one, they had presumably been added as blind fixes, without actually understanding what's going on (that's at least true for the second, monkey-see-monkey-do one by me). And for another, after I had seen their failures frequently with my local ASan+UBSan Linux build, I haven't seen them at all in lots of executions of that test with the 63049e98a659290229d3356e76d49cea44575011 fix included. So lets assume that those "magic" calls are indeed not necessary after all. If we run into trouble again, they can be added back. Change-Id: I6f4417c9fd243758a03a4de05270f342e7147d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99931 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-01loplugin:flatten in sw/core/access..sc/core/crsrNoel Grandin
Change-Id: I073545c11e2261703e5255abefaf82a2bbea5211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-01loplugin:flatten in sw/core/layoutNoel Grandin
Change-Id: I67fd1a269d960174b88c57da4a0588f5d9252660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-01loplugin:flatten in sw/core/docNoel Grandin
Change-Id: If7738d47ec0273f24eee99b7336380cfa78c1243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99896 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-01loplugin:flatten in sw/core/draw..sw/core/editNoel Grandin
Change-Id: I8d62f001f3a13463d25b8ec16e3cabd43e3abd70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99898 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-01loplugin:flatten in sw/core/docnodeNoel Grandin
Change-Id: Id0b37a9060ab77ecfd8c4aa2b340ab7b958ba109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99897 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-01loplugin:flatten in sw/core/fieldsNoel Grandin
Change-Id: I42f9dd59300f215b6d8ff9f73a9f6893dbb9a8be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99899 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31tdf#134931: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I737296f1a0646065288be2cb0be3ef7f939fb536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99878 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-31loplugin:flatten in sw/core/ole..sw/core/tableNoel Grandin
Change-Id: If74f1cfca114d52566164656c34a0764cfbaad43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99886 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/frmedtNoel Grandin
Change-Id: I64f743d6f696584ff4c3c9185ae1e8fa42451677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/textNoel Grandin
Change-Id: I086860cefe9f26c3728fe0d8266c35dae37b9570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99887 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31tdf#134965 sw: avoid RemoveFollowFlowLine() SNAFUMichael Stahl
A follow-flow-line SwRowFrame is deleted in RemoveFollowFlowLine() while it is being iterated in stack frame #18. 0 SwRowFrame::~SwRowFrame() (this=0xaa035b0, __in_chrg=<optimized out>) at sw/source/core/layout/tabfrm.cxx:3807 1 SwFrame::DestroyFrame(SwFrame*) (pFrame=0xaa035b0) at sw/source/core/layout/ssfrm.cxx:389 2 SwTabFrame::RemoveFollowFlowLine() (this=0x9c16790) at sw/source/core/layout/tabfrm.cxx:945 3 SwTabFrame::MakeAll(OutputDevice*) (this=0x9c16790, pRenderContext=0x72afaf0) at sw/source/core/layout/tabfrm.cxx:2203 4 SwFrame::PrepareMake(OutputDevice*) (this=0x9c16790, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:370 5 SwFrame::Calc(OutputDevice*) const (this=0x9c16790, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 6 SwFrame::PrepareMake(OutputDevice*) (this=0x925b740, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:248 7 SwFrame::Calc(OutputDevice*) const (this=0x925b740, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 8 SwFrame::PrepareMake(OutputDevice*) (this=0x925b8e0, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:248 9 SwFrame::Calc(OutputDevice*) const (this=0x925b8e0, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 10 SwFrame::PrepareMake(OutputDevice*) (this=0x925ba70, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:248 11 SwFrame::Calc(OutputDevice*) const (this=0x925ba70, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 12 SwFrame::MakePos() (this=0x925bc20) at sw/source/core/layout/calcmove.cxx:552 13 SwTextFrame::MakePos() (this=0x925bc20) at sw/source/core/text/frmform.cxx:339 14 SwContentFrame::MakeAll(OutputDevice*) (this=0x925bc20) at sw/source/core/layout/calcmove.cxx:1408 15 SwFrame::PrepareMake(OutputDevice*) (this=0x925bc20, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:370 16 SwFrame::Calc(OutputDevice*) const (this=0x925bc20, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 17 SwContentFrame::CalcLowers(SwLayoutFrame&, SwLayoutFrame const&, long, bool) (rLay=..., rDontLeave=..., nBottom=168478, bSkipRowSpanCells=true) at sw/source/core/layout/tabfrm.cxx:1521 18 lcl_RecalcRow(SwRowFrame&, long) (rRow=..., nBottom=168478) at sw/source/core/layout/tabfrm.cxx:1651 19 SwTabFrame::MakeAll(OutputDevice*) (this=0x93ec7e0, pRenderContext=0x72afaf0) at sw/source/core/layout/tabfrm.cxx:2421 20 SwFrame::PrepareMake(OutputDevice*) (this=0x3df3cc0, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:316 21 SwFrame::Calc(OutputDevice*) const (this=0x3df3cc0, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 22 GetFrameOfModify(SwRootFrame const*, SwModify const&, SwFrameType, SwPosition const*, std::pair<Point, bool> const*) (pLayout=0x72aa850, rMod=..., nFrameType=(SwFrameType::Txt | SwFrameType::NoTxt), pPos=0x71f35e0, pViewPosAndCalcFrame=0x7ffc99f591a0) at sw/source/core/layout/frmtool.cxx:3697 23 SwContentNode::getLayoutFrame(SwRootFrame const*, SwPosition const*, std::pair<Point, bool> const*) const (this=0x6fcfb50, _pRoot=0x72aa850, pPos=0x71f35e0, pViewPosAndCalcFrame=0x7ffc99f591a0) at sw/source/core/docnode/node.cxx:1194 24 SwCursorShell::GetCurrFrame(bool) const (this=0x72a9730, bCalcFrame=true) at sw/source/core/crsr/crsrsh.cxx:2455 25 SwFEShell::GetAnyCurRect(CurRectType, Point const*, com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> const&) const (this=0x72a9730, eType=CurRectType::PageCalc, pPt=0x0, xObj=empty uno::Reference) at sw/source/core/frmedt/fews.cxx:113 26 SwView::StateStatusLine(SfxItemSet&) (this=0x72af430, rSet=SfxItemSet of pool 0x6fa3d50 with parent 0x0 and Which ranges: [(10000, 10000), (10221, 10221), (10223, 10225), (11064, 11065), (21182, 21182), (21185, 21185), (21189, 21189)] = {...}) at sw/source/uibase/uiview/view2.cxx:1517 Not obvious why this changed with calling MakeFrames() instead of SwNodes::CopyNodes(bNewFrames=true) or how to best prevent it; adding another FrameDeleteGuard avoids the crash at least. (regression from 166b5010b402a41b192b1659093a25acf9065fd9) Change-Id: Ifd5a0c93064c9536429dda30a2c4ebc7a31b7e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99870 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-31tdf#134931 sw_redlinehide: fix layout following paste of tableMichael Stahl
The pasted table does get a SwTabFrame but the problem is that TurboAction() is called and formats the pre-existing SwTextFrame and somehow that just sets all the valid flags on the new SwTabFrame without doing any formatting. Previously, SwNodes::CopyNodes(bNewFrames=true) would call SwTabFrame::Paste() which invalidates the page. In InsertCnt_(), for new SwSectionFrames InvalidatePage() is already called so do the same for SwTabFrame which gets rid of the "turbo". (regression from 166b5010b402a41b192b1659093a25acf9065fd9) Change-Id: I970a04bd8e76f5418bddb66af915ac466f44daf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99867 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-31loplugin:flatten in sw/core/txtnodeNoel Grandin
Change-Id: I0003a190cbc42845274d71f8f157977e598a3fd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/view..sw/core/htmlNoel Grandin
Change-Id: I793811af353fe61b12e5e89da2056fb58108e9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/undoNoel Grandin
Change-Id: I34662fd439578fc6f446c5216c5c1b735b79718d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99860 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/filter/ww8Noel Grandin
Change-Id: Ia296fc6e6c8f78edf533dedf52996560ae62d143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31tdf#134436 sw: fix SwUndoDelete::RedoImpl() with section at end...Michael Stahl
... of document; the root cause is that in some intermediate delete operation, the delete will remove a section start/end node pair that surrounds the last text node in the document, but SwUndoDelete::RedoImpl() will not remove it, thus for subsequent Undo actions the indexes are messed up and weird things happen. Fix this in DocumentContentOperationsManager::DeleteRangeImplImpl(), with the same weird "is point at the end" check as SwUndoDelete. Change-Id: Iebf20d3c129c69692df8d57e3c5b9e6fec281e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99810 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-31loplugin:flatten in sw/core/unocoreNoel Grandin
Change-Id: If96b2484426f0d09119ca89943729c149675156f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31tdf#81567 : sw_ooxmlexport14: Add unittestXisco Fauli
Change-Id: Ib1584b8599b65c9a122768b7c00d7891efc6e920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99824 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-31sw: introduce a Library_swqahelperMiklos Vajna
So it is no longer necessary to define all SwModelTestBase functions inline. Change-Id: Ia1055ff967b3614102275ec92607c85ec063fce7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99820 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-30loplugin:flatten in sw/ui/dbuiNoel Grandin
Change-Id: Iab627f306a1caf52237369471393753bf2c736f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/filter/xmlNoel Grandin
Change-Id: If018f8b03816d8110bd3ba9eec3f26373e6c5a6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/ui/dialog..sw/ui/tableNoel Grandin
Change-Id: I2350c1d3f5fab727b0d47b6f3684804b77e68122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:unusedmethodsNoel Grandin
and tweak the plugin a little to speed it up Change-Id: Ia59456232602184c4f1b5d1d75ad94a9a2e2d0be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/dbui..sw/uibase/envelpNoel Grandin
Change-Id: I20dc75b75e999ed82d221072d6ecaf2c02c834eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/app..sw/uibase/configNoel Grandin
Change-Id: I903631568cc5285bf167ba3f0dadb95dbcd43a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/fldui..sw/uibase/ribbarNoel Grandin
Change-Id: Iff2bd302c3a6cc23be462e5a59aee0d12e7e7c09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99794 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/shellsNoel Grandin
Change-Id: I003c2c4e48bb59590ba952c74e3ee4733ce1051f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30Resolves: tdf#134831 reorg to expand inspector to fit full panel sizeCaolán McNamara
Change-Id: I73e37dff01d67f04ea5a2a82e4083ffd5bd46440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99774 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-30tdf#134252 sw_redlinehide: fix SwUndoDelete for table before end of sectionMichael Stahl
In this funny case, the SwPaM starts inside a section, and ends in the first text node following the end of the section, which happens to be in a different section (but that doesn't matter)... this is because IsSelOvr() moves the end of the selection resulting in the 3rd SelAll off of the table end node (as the section ends with a table), but then it's on the section end node and moves forward again. SwUndoDelete::UndoImpl() must first create the outer section frames, skip over the start text node which has frames handled by RecreateStartTextFrames() and then create the frames following the start text node, where the end node of the outer section now finds its expected outer section frame. This relies on the code from 55576842ec72a748d0bad123d41fa03c89fc136d to move the existing text frame below the new section frame(s). (regression from 6c7245e789f973cf6dad03f7008ab3f9d12d350c) Change-Id: I9f39b09e603e75ef813d5c855d828ec9bd5fdd95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99723 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-30loplugin:flatten in sw/uibase/utl..sw/uibase/wrtshNoel Grandin
Change-Id: I9010524952ce3b99a62e53dbf715a72c86a89b01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/sidebar..sw/uibase/unoNoel Grandin
Change-Id: Ifc9c838ffc94e89d2049969ef28d66fed853548b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99765 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30tdf#38093 Writer outline folding - persistenceJim Raykowski
Patch 6/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds persistence attribute loext:outline-content-visible Change-Id: Ide3eeee0f127a05def4d4f493bb4b469e0877b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99657 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - Navigator UIJim Raykowski
Patch 5/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds submenu 'Outline Content Visibilty' and action handling for submenu items to Navigator Headings context menu. Change-Id: Iccdcbc7518a83cc1b2e2e75f3052f8dbbffb1338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99656 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - .uno:ToggleOutlineContentVisibilityJim Raykowski
Patch 4/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Add UNO command to toggle outline content visibility Change-Id: I5365b29ab88d67a449b551b303f050b52063b977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99655 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - ctrl + click toggle visibilityJim Raykowski
Patch 3/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds ctrl + mouse-click to toggle outline content visibility. Right click includes sub levels. Outline content visibility of sub levels is set to that of the clicked outline content toggled visibility. Change-Id: I428b3c683bec48bec147385dcdb1708e1f28d791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - outline visibility and on canvas uiJim Raykowski
Patch 2/6 Outline content visibility and on canvas collapse/expand control button implementations. Change-Id: I8481125b102d2f07bfcfce91e1379d8e786a7aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-25 12:45:11 +0000