summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2014-05-08fdo#78444 sw: avoid incorrect right shrinking of repaint rectangleMiklos Vajna
The old condition was: set the right edge of the repaint rectangle, in case the result would be wider than the original (if we repaint more, that can't hurt regarding the end result) or in case the left edge was set. But that's problematic, the reproducer situation described in the bug triggers a case when the right edge is shrunk too much, so part of the painted letter is missing. Fix that by only setting the right edge of the repaint rectangle when we know that it won't shrink. Change-Id: I33b78a929021b284d5283fc2c35e0b3c999fa224
2014-05-08Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part6Julien Nabet
Change-Id: Ib523206d67ad13416557be1b37a58ba7a9791ca5
2014-05-08Resolves: #i27364# set line count of dropdown to 9...Tsutomu Uchino
for document list of navigator on Writer (cherry picked from commit c104272ea1274dea87cd66cfaa61b34806708521) Change-Id: Iac9644d513dd1195b3986d79607f336dc6ed9884
2014-05-08use new VCL IsValueChangedFromSaved methodNoel Grandin
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963 "RFC: add IsValueChangedFromSaved to VCL button and listbox" Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08Related: fdo#77720 Writer crashes when running Mail Merge WizardJulien Nabet
Change-Id: I02695420ff4f54ad15b077ab1d16f27ff684e5da Reviewed-on: https://gerrit.libreoffice.org/9111 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-08various: sal_Bool->boolNoel Grandin
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-05-08coverity#1209298 Logically dead codeCaolán McNamara
Change-Id: I370f1ff7df1c19e23560599b86b2274649bd5f73
2014-05-08coverity#1209146 Logically dead codeCaolán McNamara
Change-Id: I6777dffb436471b5df69d40a15bd32b473dcfc40
2014-05-08coverity#736155 Dereference null return valueCaolán McNamara
Change-Id: I781a949abb47b6e845a222a4fa8f685e9a620693
2014-05-08coverity#736152 Dereference null return valueCaolán McNamara
Change-Id: I5582d0481c0b99f92e7a3a07fbe7a904a1696442
2014-05-08coverity#735960 Explicit null dereferencedCaolán McNamara
Change-Id: I04ef56efe1e6e164de5ceaa2840a43271102d108
2014-05-08coverity#735959 Explicit null dereferencedCaolán McNamara
Change-Id: I9ba5a7ab1938174f083fdc81c046b286fc73a4e9
2014-05-08coverity#735958 Explicit null dereferencedCaolán McNamara
Change-Id: I78e3e2cce461b098dd3f56289bf5e30c977fca2f
2014-05-08coverity#735957 Explicit null dereferencedCaolán McNamara
Change-Id: I70a46f251faa6a1d6e52bc816473a29416953ded
2014-05-08coverity#735956 Explicit null dereferencedCaolán McNamara
Change-Id: Ic55ef095bb4867c9e5e98bc4c2ded3e9b0c95253
2014-05-08coverity#735955 Explicit null dereferencedCaolán McNamara
Change-Id: Ice64f610901ae9a5ee103fa1e4fec46a1142158d
2014-05-08coverity#735943 Explicit null dereferencedCaolán McNamara
Change-Id: I268ec2db2e8ec4a40dd8537989d2afe767207d40
2014-05-08coverity#735938 Explicit null dereferencedCaolán McNamara
Change-Id: Ia95f3ec5817035a596a8d64b0a7e9dc4445ec648
2014-05-08coverity#735937 Explicit null dereferencedCaolán McNamara
Change-Id: Ic8d177dcf565fca8cf1f238c12b16c5cea2066a6
2014-05-08coverity#735936 Explicit null dereferencedCaolán McNamara
Change-Id: If85ed1e4c9aa4e1d816515264f21154d5661051c
2014-05-08coverity#735935 Explicit null dereferencedCaolán McNamara
Change-Id: Ic67e0d06402ae28d4cffb817262a5adb23afc3ee
2014-05-08fdo#78284 Content-type of ".png" images in Smart ArtVinaya Mandke
Content-type for 'png' images was not getting added in [Content_Types].xml. This was as only 'jpeg' and 'wmf' extensions were handled. Modified DocxSdrExport::writeDiagramRels to handle all types of extensions. Added UT for the same. Reviewed on: https://gerrit.libreoffice.org/9252 Change-Id: I5e068d4db14f3a43be08a4b7c9bf265f388bf356
2014-05-08Handle bad SwWW8ImplReader::GetCol inputStephan Bergmann
With previously found offenders out of the way, looks like sw/qa/core/data/ww8/pass/CVE-2009-3302-2.doc is the only case that triggers this, and that is likely deliberately malformed input. As the whole ww8 parser appears not to be build around robust eager input validation and error signalling, there is little more we can do here than throw up our hands in despair. Change-Id: Idf61fcf14a784cef1539654f2825c013c218987f
2014-05-07sw: fix indentation in rtfstringbufferMiklos Vajna
Change-Id: Ie1029a03e614aceaeda10a762183cb06e93c1639
2014-05-07coverity#735892 Unchecked dynamic_castMiklos Vajna
Change-Id: I0624dd7d50cc82ddfe76ce5d8219b2fa1c10f002
2014-05-07unused SwAccessibleMap::FireSectionChangeEventMiklos Vajna
Change-Id: Iabf50f68d06684d36eaf5793251361ccd771ae8d
2014-05-07SwTxtNode::CopyText(): actually check hints of destination node tooMichael Stahl
Change-Id: I1bb883502ccd4c6fb5bdfd93f2fa5a04de0b2701
2014-05-07fdo#74790: sw: Compare Document: fix assertions about RSID-only hintsMichael Stahl
For ordinary documents the SwTxtNode::MakeFrm() would set the m_bFormatIgnoreStart/End flags of the RSID-only hints, but the document loaded by Compare Document (and Merge Document) is special because it is loaded, there are editing operations on it, but it has no layout, so the assertions about these flags trigger. (regression from 6db39dbd7378351f6476f6db25eb7110c9cfb291) Change-Id: I8a6e02b68f22e609640adbe93ff194e4081d9856
2014-05-07coverity#735932 Explicit null dereferencedCaolán McNamara
Change-Id: I35ccc5ba619f7e861fca2c5e78de86d88480017d
2014-05-07coverity#735924 Explicit null dereferencedCaolán McNamara
Change-Id: I77044f6f9e99ddaa64cf69ba22205d6536a90b1b
2014-05-07coverity#1209588 Explicit null dereferencedCaolán McNamara
Change-Id: I6abb408c91c9d6ea2d60c328be221c7608a7906c
2014-05-07coverity#1209587 Explicit null dereferencedCaolán McNamara
Change-Id: I51b3e9bccbe54686fbe869ce5ba669d000530572
2014-05-07coverity#1209549 Unchecked dynamic_castCaolán McNamara
Change-Id: I118771b78d83441202c15d3b08b9055ba5e63623
2014-05-07coverity#1209527 Dereference after null checkCaolán McNamara
Change-Id: I8a829ee5d36281098f2788a704b203e6b777d371
2014-05-07fdo#75519: fix chapter cross referencesMichael Stahl
It would be possible to modify the condition in SwChapterField::ChangeExpansion() to check for rTxtNd.GetNumRule() as well and make the bugdoc work again, but do we really want to use "chapter reference" to refer to plain numbering? Perhaps it would be better to add a "numbering reference" field type; without investigating what Word actually does here and what the actual problem is that was supposedly fixed here (which is not possible given there's no reproducer document) it's best for now to just revert it. (regression from commit 6319803762d051c4aa645692cde7245a1bbcf7ee) Change-Id: I7eb9ea46e42729c53c350ff450d49a1eb84ee8eb
2014-05-07loplugin:implicitboolconversionStephan Bergmann
Change-Id: I0dacaa9fb08062aba758613bd25ebcf7039f36e0
2014-05-07SwFrmFmts::dumpAsXml: dump which idMiklos Vajna
Change-Id: I66d7c8444c1a89c21ea2ce5e42fb3cd97fd39b7c
2014-05-07SwFmtCntnt::operator==: most probably bool was intended hereMiklos Vajna
The code here counted the numerical XOR of the two pointer values, but most probably the logical XOR was intended (in case only we or only they have a node index, then we are not equal). Change-Id: I261b8c4b498eb860fa0e0fa72ba5a5e0758064e6
2014-05-07The opaque PostUserEvent IDs are actually pointersStephan Bergmann
...so declare them as such. This avoids the recurring mistake of storing such IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to potentially not remove the event, it thus firing "too late" and probably causing a crash. While at it, consolidate the trivially unnecessary overloads of both Application::PostUserEvent and Window::PostUserEvent. And in each of them, it looks like deleting the mpLink member was missing from the failure branch. Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'Tor Lillqvist
Change-Id: Ia02481046640248bc8a62ab0f93bf4e0bb49cca8
2014-05-07WaE: C4389: '!=' : signed/unsigned mismatchThomas Arnhold
Change-Id: I6a2e0992077b185107f8d7190478d95f8d898e9e Reviewed-on: https://gerrit.libreoffice.org/9266 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-07fdo#77812 :FILESAVE :DOCX : Extra Section Break gets added in filePallavi Jadhav
Issue : LO was exporting DOCX containing MultiColumns with additional Section break Continuos. Implementation : 1] Added check for Column_count in MSWordExportBase::WriteText() If Column_count > 1 and Text node is empty then do not export Section Break. 2] Written Export unit test case. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/9200 Change-Id: Ibf3e6bd2d4827aa77a659b1600939cc56d65a63b
2014-05-06Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part3Julien Nabet
Change-Id: Ibabd6d2d5e84fe007364bd1a4182a01ea2352b7a
2014-05-06SwLayAction: there can be only one, so assert thatMichael Stahl
Requires tweaking the SwLayIdle code a bit, where an action is kept alive a bit after it's done, which would trigger the assertion. Change-Id: Ic5c8f90bc101b9d73cfde9691b2bbf405a001393
2014-05-06SwViewShell: try to catch errors of calling CalcLayout without actionMichael Stahl
Change-Id: I0352d543b7ce1ae6cd23d929ad5c9cbaeb1563bf
2014-05-06SwViewShell: fix brain-damaged non-virtual CalcLayout() overrideMichael Stahl
The ooxml_export test crashes on Mac, because SwModelTestBase::calcLayout() calls ViewShell::CalcLayout() and that does not do StartAction(), and inside the layout indirectly a StartAction()/EndAction() is then called, which of course trashes the still-under-construction layout. Strangely no crash on Linux, the layout is completely finished before the SwModelTestBase::calcLayout() is called, maybe because of the headless vclplug. Change-Id: I767b1e41597ce752eb8c61dc106390f2abb90257
2014-05-06sw: make CppunitTest_sw_uwriter a slowcheckMiklos Vajna
It's annoying that after touching a cxx file from Library_sw, it's not enough to wait till it relinks, it also relinks CppunitTest_sw_uwriter as well. So turn that one into a slowcheck, this way 'make sw' doesn't relink it. Change-Id: I0a8d956f57e92a9c6f1f91b727f492ca4c92c599
2014-05-06coverity#704855 Unchecked dynamic_castMiklos Vajna
Change-Id: I25f3d1f53451cd16f6fd05b1084af79fea56b803
2014-05-06remove uncompiled source filesThomas Arnhold
how to find possible candidates: find . -name *.cxx | grep -v compilerplugins > cxx.list for i in `cat cxx.list`; do basename $i .cxx; done > cxx.base.list for i in `cat cxx.base.list | sort -u`; do echo $(git grep -w $i -- '*.mk' | wc -l) $i; done > cxx.count Change-Id: I15c6cc7195e58d79967388850a0c90b915b001b7
2014-05-06Related: fdo#36815 clip overlarge comment contentsCaolán McNamara
and add an indicator that the comment won't fit in the space available Change-Id: I8dce7dfa678a606e8c4532addc4ba70c2a43644e
generated by cgit (git 2.34.1) at 2025-01-31 09:01:20 +0000