Age | Commit message (Collapse) | Author |
|
Regression from commit 866a4436d3cfac1ff42d7996250bf96fb703aeaa (oox:
handle textboxes in ShapeContextHandler::endFastElement(), 2014-06-04),
the problem was that code in ShapeContextHandler::endFastElement()
assumed that all the XShape implementation it may see provides a TextBox
UNO property (which is specific to Writer) of type bool, but this is not
true.
Fix the problem by assuming false in case it has an other type.
Testcase can be a simple "does it load" one, as in the meantime
exceptions such as trying to read a bool from an uno::Any make the DOCX
XFilter::filter() implementation return false, unlike in the originally
reported LibreOffice 4.4 version that just silently discarded the
remaining content of the document.
Change-Id: I81781a7ec28d085ceee50d386b8eda023f83c29f
|
|
Also rename nPagePrevRow/Col to nPagePreviewRow/Col, so that it's more
clear that they are about the page preview row/col, not about some
previous row/col.
Change-Id: I5f1f47edde3dbe6bcce14a654398f8a0be2fa79f
|
|
Change-Id: Idf7956c2178093bcaba3ad1093b8d0a54e46aaca
|
|
Change-Id: Iecb7cd82d88bd1ee82f074e17319e5ce095e2690
|
|
Change-Id: I0d00ca7727e0756030830cd732655b2a22b900d6
|
|
crash since
commit 664197d95becd516c3dac25a50439078ba61e051
Author: Justin Luth <justin_luth@sil.org>
Date: Thu Sep 10 11:41:11 2015 +0300
tdf#36117 .docx preserve page vertical alignment after RT
Change-Id: I225fa4dc0a7ea2eab6ef748f7c72bfad361257dd
|
|
This patch is not completed. It adds a dropdown field to toolbar.
When you click it, the page preview focuses third page (hard coded).
This patch's purpose is getting information from developers how to
add numbers to dropdown field.
--
v2: Removed unnecessary MV_SPECIFIC_PAGE case.
v3: Added dropdown field and defined new controller for new field.
v4: Implemented page focus who user want.
v5: Used NumericField instead of Combobox and added page count control
v6: Used nSlotId instead of SID_JUMP_TO_SPECIFIC_PAGE in order to fix macOs build error.
Change-Id: I722fbffcc72a1bcee70065e2e9369b73ab27f100
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/19335
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
|
|
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I61a372e297eeeb67f1dcadbfc5017b0cc157d065
|
|
Change-Id: I95ce84f7e82dc03233878de4324f2cb5c282a8aa
|
|
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Iea2094f736837f5aecde2d9ff810dffb062d2315
|
|
Change-Id: I91c1aa5149bff9c6489ad6f1a68818b502d95966
|
|
Change-Id: Ia8d44e5c8a987aa1c0cc38e885eadd595b70a898
|
|
Change-Id: I3ce33c8ea0c09948785621785d199ece6eda128a
|
|
Change-Id: I66475190cc0f18465c56b94af7bc0d5a1ca81242
|
|
when the change is made, not during exit (as did
4aab13f77e5dc218d067ca7efe3622f4ea780bf9 "tdf#93509: crash on storing auto
correction config fixed," which caused PythonTest_sw_python to crash during
exit)
Change-Id: I0e9c264ae3fee7fdb732d36f42ebbb477557a644
|
|
RTF token \dppolygon now creates a PolyPolygonShape
test included
Change-Id: I065eaac0ca1b8a59f02c3198363180ab244a3942
Reviewed-on: https://gerrit.libreoffice.org/19665
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
|
|
Change-Id: I51a8161eeaa781ccace08605b97a0092f972b3bf
|
|
Change-Id: I71c2004b411831ce869331ab7251683f78428b2b
|
|
Change-Id: I08a2c2bb8ebd8cb2adf25b23fa57a5c5441fcfea
|
|
Change-Id: Ibb3b33681f4c33794e07b40989709e8f292f2084
|
|
the fix of tdf#92732 moved the crash from pressing Close/OK to
pressing the window closer. Now the CareWindow is set in dispose
and this works for all
Change-Id: Id9c272acec48890556a5042c0f5310e69c0a67da
Reviewed-on: https://gerrit.libreoffice.org/19645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
|
|
fix of tdf#86494 removed the pAutoCorrect which is required to store the config
committing the config before fixes the crash
Change-Id: If049d5ad1e62711d4ec66ec6cca15940f7edba90
Reviewed-on: https://gerrit.libreoffice.org/19640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
|
|
Change-Id: I2b8332e8346fbbbb3270e53102e5e3a51cbd6df7
|
|
0 + (1 * 32768 * 65536 / 65537) evaluates to -32767 with 32-bit MSVC
whereas with 64-bit GCC the result is +32767.
The multiplication overflows to 0x80000000 - so do that in 64 bits.
This fixes the JunitTest_sw_unoapi_4 failure in SwXTextTable on the
TableBorder property, where the wrong result caused MakeSelUnions()
to believe that the last cell is not visible and hence setting the
TableBorder property failed.
Change-Id: Idb10535ce5342cd83d7ab6aea07782a2034469eb
|
|
dynamic atexit destructor and const static variables reportedly
cause crash, let's avoid this.
Change-Id: I24234084f810854606dde9914bee1c98ebc2e3dd
Reviewed-on: https://gerrit.libreoffice.org/19656
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I552f305e78427bdbd37e48013f5cc4b78024e8ff
Reviewed-on: https://gerrit.libreoffice.org/19631
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Id733fd3a53fe2023be20fcf7c9d93823d1697a7d
|
|
Change-Id: I1d9aa200734d264e3bc65ea39f8c2a2d03782f7b
|
|
The early return must also be taken if the anchor is neither AT_CHAR nor
AT_PARA.
(regression from a219bbb62f974020fac0799143fbc51c385bb460)
Change-Id: I4eccb1f80401ba620ef87342f40c1a896918f3d3
|
|
Change-Id: I85409838a5c44f8e76c60ff88e41c01d2bb71987
|
|
Change-Id: I2bb543ce1678140e8a6e086171a8f6b4529771d3
|
|
Change-Id: I32edfa929aa81431a1e20180f3fd8a539ad43274
|
|
Change-Id: I9adb9a445844ead91eefec8c57b879b0cc11c686
|
|
It's cleaner to let the apps do this themselves than exposing their
underlying vcl::Window.
Change-Id: Iff2442dd325fa65a0cf3ad4aa7f918542dab1e4c
|
|
Change-Id: Ifc4ec214ad7034ecf694c690c3a04e995c64fbe9
|
|
Change-Id: Id8cc41ab9af5d6fe9934f97927c7e3d1e7f6ebf3
|
|
Change-Id: I8500dda538a82a920dd6164251bf193489b12a15
|
|
Change-Id: If4c4a043f3d9c2e1e89eb4199d33cd39f502c56e
|
|
... which actually does nothing since commit
fca027b0bd76a76b50f4d6d667d2d479417a74a6 but was dutifully converted to
a boost::ptr_vector.
Change-Id: I69186d6ba7d90fb2f94b417fede3a907811c32c0
Reviewed-on: https://gerrit.libreoffice.org/19518
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...which caused
> sw/source/uibase/docvw/edtwin.cxx:4280:47: runtime error: downcast of address 0x6060015556a0 which does not point to an object of type 'SwDrawContact'
> 0x6060015556a0: note: object is of type 'SwFlyDrawContact'
> 11 07 80 2c 50 26 83 79 65 7f 00 00 d0 26 83 79 65 7f 00 00 80 63 a6 01 20 61 00 00 00 00 00 00
> ^~~~~~~~~~~~~~~~~~~~~~~
> vptr for 'SwFlyDrawContact'
> SwEditWin::MouseButtonUp(MouseEvent const&) sw/source/uibase/docvw/edtwin.cxx:4280:47
> ImplHandleMouseEvent(vcl::Window*, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) vcl/source/window/winproc.cxx:736:17
> ImplHandleSalMouseButtonUp(vcl::Window*, SalMouseEvent*) vcl/source/window/winproc.cxx:2082:12
> ImplWindowFrameProc(vcl::Window*, SalFrame*, unsigned short, void const*) vcl/source/window/winproc.cxx:2425:20
> SalFrame::CallCallback(unsigned short, void const*) const vcl/inc/salframe.hxx:255:33
> GtkSalFrame::signalButton(_GtkWidget*, _GdkEventButton*, void*) vcl/unx/gtk3/window/../../gtk/window/gtksalframe.cxx:3176:5
> [...]
Change-Id: Ib9013eb3ff7546ee6534d5148d2505608a9d70f9
|
|
SwDoc has weak_ptr list to notify UnoCrsr instances
when the doc is about to die. These were updated
when each UnoCrsr instance was destroyed.
The first performance issue is the use of a list.
This no doubt is done to avoid the overhead
of removing items at arbitrary position from a
vector. Performance tests show vector is faster
with a large document and ~10k UnoCrsr instances.
More important, there is no need to clean up
the references as frequently as when each
UnoCrsr is destroyed as they are rarely referenced
at all. Having outdated references is no issue either.
The new logic uses a vector and cleans up only
after saving a document and before saving
UnoCrsr instances.
Saving ODT files is now significantly faster for
large documents (100s of pages).
Change-Id: I3895d9d80d174cda9c94b94837e2149e9fadcb42
Reviewed-on: https://gerrit.libreoffice.org/19604
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
|
|
Change-Id: I062f1f6c5b20ca47734a9a3cd1a229d51763a206
|
|
There is no point, since it's the size of a pointer anyway
(found by temporarily making the new operator in uno::Reference
deleted).
Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34
Reviewed-on: https://gerrit.libreoffice.org/19603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I305163b691a8fa51ef5da0c940c59c3a3440a2dc
|
|
Change-Id: I962ee5dc35d5b33c751890ff9d56850897c7d080
|
|
Change-Id: Id9e18c67a4fa6e3646ac33cd616838819d1f10d8
|
|
Change-Id: I89c434ba488963fdbaa9025bdd1dd420ab255dac
|