summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2014-05-18fdo#46839 Convert line color picker to split buttonMaxim Monastirsky
Change-Id: I4987cc9ffba675009f2d2ae9f6b12ed4ee02fe13
2014-05-18fdo#78651 DOCX Incorrect export of nested TablesVinaya Mandke
As the m_oldTableReference->m_pOldTablepInner was not cleared the same tabled was incorrectly nested with itself. Another issue was that the same table was mirrored in RT file as LO was trying to export a Section break within a table cell. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewe on: https://gerrit.libreoffice.org/9361 Change-Id: I09b730a10f1a0bc4434050e0078aeab3185de817
2014-05-17Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part15Julien Nabet
Change-Id: I38e855966598342eb2352e70e04f7a5e09e54f83
2014-05-17SwFmtCol: rename member variables missing their prefixesMiklos Vajna
Change-Id: I0cf0b585a9cfcbb119c68adf51dc786bc6373e2e
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17sw: try to fix a valgrind warningMichael Stahl
Invalid read of size 1 at SwParaPortion::SetPrep(bool) (porlay.hxx:299) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1756) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1663) by SwCntntFrm::MakeAll() (calcmove.cxx:1310) by SwFrm::OptPrepareMake() (calcmove.cxx:356) by SwFrm::OptCalc() const (frame.hxx:1037) by SwLayAction::_FormatCntnt(SwCntntFrm const*, SwPageFrm const*) (layact.cxx:1829) by SwLayAction::FormatCntnt(SwPageFrm const*) (layact.cxx:1660) by SwLayAction::InternalAction() (layact.cxx:597) by SwLayAction::Action() (layact.cxx:376) by SwLayIdle::SwLayIdle(SwRootFrm*, SwViewImp*) (layact.cxx:2179) Address 0x1f9507e0 is 832 bytes inside a block of size 840 free'd by FixedMemPool::Free(void*) (mempool.cxx:48) by SwParaPortion::operator delete(void*, unsigned long) (in /work/lo/master/instdir/program/libswlo.so) by SwParaPortion::~SwParaPortion() (porlay.cxx:1972) by SwTxtFrm::ClearPara() (txtcache.cxx:102) by SwTxtFrm::Init() (txtfrm.cxx:329) by SwTxtFrm::CalcLineSpace() (txtfrm.cxx:746) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1680) by SwTxtFrm::Prepare(PrepareHint, void const*, bool) (txtfrm.cxx:1663) by SwCntntFrm::MakeAll() (calcmove.cxx:1310) by SwFrm::OptPrepareMake() (calcmove.cxx:356) by SwFrm::OptCalc() const (frame.hxx:1037) by SwLayAction::_FormatCntnt(SwCntntFrm const*, SwPageFrm const*) (layact.cxx:1829) by SwLayAction::FormatCntnt(SwPageFrm const*) (layact.cxx:1660) by SwLayAction::InternalAction() (layact.cxx:597) by SwLayAction::Action() (layact.cxx:376) by SwLayIdle::SwLayIdle(SwRootFrm*, SwViewImp*) (layact.cxx:2179) Change-Id: I64a1cc6ea301b653af951ba0e00e28d4655d2d97
2014-05-16coverity#704866 Unchecked dynamic_castMiklos Vajna
Change-Id: Ib1108a6641635bbbb0d88968754d7bb19a8c9e73
2014-05-16sw: fix indentation in rtf{export,import} testMiklos Vajna
Change-Id: Ie777de47dc70da136b145028a08ea17a0de7a87d
2014-05-16coverity#708868 Unused pointer valueCaolán McNamara
Change-Id: I5d25f7de37df6fe79bb195e1cb68876fb3b4fcca
2014-05-16coverity#708847 Unused pointer valueCaolán McNamara
Change-Id: Id16ebc576834e418a3bf2d3d6eb3e2545e0aac2b
2014-05-16DOCX import: make sure inline shapes are not in the backgroundMiklos Vajna
Change-Id: I80d684662ac3f94bff4448fcdae94f9e69fd1590
2014-05-16sw doc model dump: show SdrObject::nOrdNumMiklos Vajna
Change-Id: I4ac2c3d883dd9bb111a2d600f5a17ea96a1e219e
2014-05-16ooxml: Preserve effects on picturesJacobo Aragunde Pérez
If a picture contains some 2D (glow, shadow...) or 3D effect (rotation, extrusion...), we prevent the importer from transforming it into a XTextContent so the XShape grab bag is not removed and the effects are preserved using the existing mechanisms. Added a unit test for this issue, and modified some existing unit tests to match the new behaviour. Change-Id: I3b87069ea208604383a592d34d0a4ceb6b0f9fc7
2014-05-16ooxml: Preserve shape effects when there's more than oneJacobo Aragunde Pérez
Transformed the preservation process of shape effects to be able to store more than one effect. For that we: * Created the Effect struct and added a vector member to the EffectProperties struct. * Changed the shadow effect to use the new Effect struct, EffectShadowProperties struct is preserved because the direction field still has some use but we should remove it. * Changed the structure of the grab bag to store more than one effect. * Modified an existing unit test to check shapes with several effects. Change-Id: I0dd908fa1d9578827c02ef6272fc9e2b914391be
2014-05-16fdo#78432 : DOCX: File gets corrupt after RoundTripPallavi Jadhav
Issue : - In RT in document.xml, value of Absolute Position Offset <wp:posOffset> was going out of bounds. - <wp:posOffset> is of type Int(32-bits), hence it's value should not cross the MAX and MIN limits of Int. Implementation : - Added check for <wp:posOffset> should not cross Maximum/Minimum limit of Int. - Written Export Unit test case. Reviewed on: https://gerrit.libreoffice.org/9328 Change-Id: I22e75d7e603ebbf6a49e764fb1a3e6a4d2fd8b23
2014-05-15fdo#55582 Writer: Dont overwrite from even when selected, from writer.Lennard Wasserthal
This patch fixes the writer part, calc part is fixed long ago. Problem: it overwrites when you paste from impress or calc. This allows to keep the graphic's frame, so the text doesn't have to be rearranged. (i.e. it is desired, so I didn't change that) I was trying to give the user a choice, but I didn't succeed in keeping the frame when pasting from writer to writer. coming soon! Change-Id: I07271df9bb501779d06f332bb13edd05f0aefacb Signed-off-by: Lennard Wasserthal <Wasserthal@nefkom.net>
2014-05-15sw html test: missed one class name at renamingTomaž Vajngerl
Change-Id: I614bbda7b796a4bd57d9511a9dc68beafa398b38
2014-05-15sw test: HtmlExportTest - assert pDoc exists, rename classTomaž Vajngerl
Change-Id: I5e17b8636236c2a0f78df80c36d82a3ba16a1c5f
2014-05-15sw test: unify names of local variables and move to them to topTomaž Vajngerl
Change-Id: Iaba274f73edf4ff49d06f5dd15ab8ab2ddd043f7
2014-05-15sw test: user parent's parseXmlStream methodTomaž Vajngerl
Change-Id: I6b50172b636cd8334b5cbfd3986631c1f17dd366
2014-05-15DOCX import: fix chart size when it's inside a TextFrameMiklos Vajna
Change-Id: I3edb253238db182054b7688061916a2432b687b5
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15Resolves: fdo#78204 adjust note icons on comments-in-margins caseCaolán McNamara
the page has been scaled by 75% and vertically centered so the page positions need to be also adjusted. Change-Id: I7ab6b4956933ba444441c857e78aee8e5c1cf97a
2014-05-15coverity#705490 Dereference null return valueCaolán McNamara
Change-Id: Iac4178e7f751cba0b4a135dc9d840234d96ccfa2
2014-05-15coverity#705484 Dereference null return valueCaolán McNamara
Change-Id: I8ba236e64994c6e37e1a782cc911df57cb902f86
2014-05-15coverity#705482 Dereference null return valueCaolán McNamara
Change-Id: Id50d79c2dddc3105821703fb9773128c0cc6f2f3
2014-05-15fdo#78300 File Corrupt:drawing objects into a text box.PriyankaGaikwad
Description : Docx file corrupt after roundtrip. LO insert <w:drawing> inside the <wps:txbx> under choice after RT, if the file created in MS word 2007 and contains Word Art inside the text box. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx sw/source/filter/ww8/docxsdrexport.cxx sw/source/filter/ww8/docxsdrexport.hxx Change-Id: I7421ed353cd7e9bae17b2447122090a4113f52b5
2014-05-15Misspelled property in SwAuthenticationSettingsDialog (seperate => separate)Chris Laplante
Change-Id: I0cf29711459e5ec185b43cf28716729e659b00b4 Reviewed-on: https://gerrit.libreoffice.org/9357 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-14Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part12Julien Nabet
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7
2014-05-14fix windows buildThomas Arnhold
Change-Id: Ib2e882194087e3eb85b52921f27fafc40227c52d
2014-05-14coverity#704863 Unchecked dynamic_castMiklos Vajna
Change-Id: I0c451cb576dc1818043816390b14c32607609748
2014-05-14sw: fix indentation in sprmidsMiklos Vajna
Change-Id: Ifebb34942ab5d5e75d2ff9797c0450a825f955b8
2014-05-14sprmids is used only inside sw/source/filter/ww8Miklos Vajna
Change-Id: Iebae4a08a452117e71f72836ed686221031a61e6
2014-05-14Always remove SwModelTestBase::m_aTempFileStephan Bergmann
Change-Id: I3719d1ce64bee055a4a7248361f2d2dccaa75cdc
2014-05-14sw: remove SAL_INFO's that only mark function entryNoel Grandin
Change-Id: I7169b1fec563add36900622dd599a92792e57675
2014-05-14Unify utl::TempFile ctorsStephan Bergmann
Change-Id: I0a781a86804808cebf7756506d9299971c13e2ff
2014-05-14fdo#78599: Fixed for file corruption which contains fields and hyperlinkPriyankaGaikwad
Field inside a hyperlink closed after the ending tag of hyperlink, which corrupted the RT file. Change-Id: Ib89ead8d2f8a9eb6c8473ffd14853495ee1b2f62 Reviewed-on: https://gerrit.libreoffice.org/9330 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-05-14Keep only one class for toolbox color controlsMaxim Monastirsky
instead of 5 (mostly identical) classes. Also the following bugs were fixed: * All pickers now use split buttons. (fdo#45671) * Color palette now indicates the current color. (fdo#73891) (Previous changes related to that bug are reverted as part of this commit.) * Selecting a color from a float panel now updates the button. (fdo#77683) * For Font color/background color in Writer, the color that is shown on the button, is always the one that's actually used. (Can be a different color after hiding the toolbar.) * For Font color/background color in Writer, the button now indicates when we're in the format paintbrush mode. (Removed in 085e8a07e61ef2d3a82e11094d8773ab17cfdb3c for some reason.) Change-Id: Idb4829552240c52fb0882aca627c8177bbe2f839
2014-05-14Use transparent color directlyMaxim Monastirsky
Change-Id: I47693666b3dd218eb8a74b936038c9169b054af1
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-14fdo#78384: Fix for corruption if file contains symbols.Rohit Deshmukh
* In case of symbol, symbol character get imported first and then font of symbols. * So we are storing symbol character and when we parse symbol font then create UNO object for text. Change-Id: If5b79521c6a59aec02b165e8120dafdd472cdaeb Reviewed-on: https://gerrit.libreoffice.org/9281 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-05-13Typo: shoud -> shouldJulien Nabet
Change-Id: I44f4fb9682a56af6654e1f7462dc37557d60e735
2014-05-13sw: fix indentation in rtfattributeoutputMiklos Vajna
Change-Id: I9e9ac03a6e9eafc1aee787a95368a4b397d7375f
2014-05-13coverity#704862 Unchecked dynamic_castMiklos Vajna
Change-Id: I97ae71335fb3a2658ca1c4a48c9092cdb4ee3733
2014-05-13loplugin:literaltoboolconversionMatúš Kukan
Change-Id: I7457e47866bd327cfc32a0b2d43ebd04c3c68dbc
2014-05-13utl::TempFile::CreateTempName pParent is unusedStephan Bergmann
Change-Id: Ide12ea21104af678dc541ed0e83970e7a2f5e694
2014-05-13remove dead code in SWNoel Grandin
Change-Id: Ifda459ea8863d923b211ca3022355b5941a74bfe
2014-05-13remove dead code SwAccessibleFieldNoel Grandin
which seems to be dead since the IA2 integration Change-Id: I3a6c70f27ef0cb2ac23776ad00394a73a99bb7e8
2014-05-13remove dead codeNoel Grandin
Change-Id: Ic4fb478921714429af138ca212bd7f67f408d434
2014-05-13ooxml: Preserve shape 3d effects: extrusion and contour colorsJacobo Aragunde Pérez
Shapes 3D effects can specify colors for extrusion and contours like in the following example: <a:sp3d extrusionH="25400" prstMaterial="metal"> <a:extrusionClr> <a:schemeClr val="accent5"> <a:lumMod val="40000"/> <a:lumOff val="60000"/> </a:schemeClr> </a:extrusionClr> <a:contourClr> <a:srgbClr val="3333FF"/> </a:contourClr> </a:sp3d> Colors can be theme-defined or set in RGB and can contain transformations. This patch preserves all the color information using the shape grab bag and modifies an existing unit test to add this check. Change-Id: Ida168affd4ca2135d0bd8f97135dc1cd1e74165a