summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2016-06-06sw: prefix members of SwCacheMiklos Vajna
Change-Id: I2896dffca4d13dd95612fa463c66eb5a769d5650 Reviewed-on: https://gerrit.libreoffice.org/25952 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-06Revert "Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule ↵Noel Grandin
flag"" This reverts commit abde31a2bc68302e1afafe1fcc3f5d85369010f8. Since my analysis was completely incorrect, and the bug was elsewhere.
2016-06-06SwXDispatchProviderInterceptor: implement frame::XInterceptorInfoMiklos Vajna
With this, framework::InterceptionHelper can make a better decision what interceptor to call: it can avoid calling SwXDispatchProviderInterceptor when the sw code would just call the previous interceptor anyway. Change-Id: I92897f2c8baa264dc9ccbc11b63f415da30a910d Reviewed-on: https://gerrit.libreoffice.org/25961 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-06loplugin:sallogareasStephan Bergmann
Change-Id: I76a1ca53ea51488f1338276042e1e435ed34f602
2016-06-06tdf#83830: Page Format PanelSusobhan Ghosh
Change-Id: I16d263f07eb49eaa32a161958b48f4059fffafdf Reviewed-on: https://gerrit.libreoffice.org/25530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-06Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag"Noel Grandin
This reverts commit e319ef1171dab61fff2201f5c1470ca09894c395. Apparently, at some point, someone added a 'bool bDummy' param to SfxModule, but only updated 2 of the 5 callsites. Since we're passing in pointers here, at the other call sites, the bDummy param evaluated to 'true'.
2016-06-06fdo47267 fix import crashJakub Trzebiatowski
fixed import crash introduced in d4188f643db050c962a937547d19a9a08bd2235d Change-Id: I0bf76fd345438e3cd303ee85c770aa0515c056df Reviewed-on: https://gerrit.libreoffice.org/25887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-06Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flagMark Page
The SfxModuleArr_Impl is a static container of SfxModule, since this is private to the SfxModule class it does not require wrapping. The bDummy flag is unused, and complicates the class Change-Id: Ib03b215543a0c37d4edf20b2d0fc141a783e115e Reviewed-on: https://gerrit.libreoffice.org/25859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#81475 Minor tweaks to writer toolbarsYousuf Philips
Change-Id: Ifdc1e7305dcd3db5a77f9d9f30094031c24b9460 Reviewed-on: https://gerrit.libreoffice.org/25894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-06-06Convert DeactivePage return code to scoped enumNoel Grandin
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd Reviewed-on: https://gerrit.libreoffice.org/25918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove unused constants in HRC filesNoel Grandin
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-04tdf#96099 Remove sfx std::shared_ptr typedefsMark Page
Removed SfxItemSet_Pointer_t and SfxStyleSheetIteratorPtr Change-Id: Ibfa6a79809fdbbe2648dacc02625e620ceaf9bf0 Reviewed-on: https://gerrit.libreoffice.org/25851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert ComplexTextLayoutMode to scoped enumNoel Grandin
Change-Id: I257f8e15fec92f0701235a6fe4b6a2272498c4f1 Reviewed-on: https://gerrit.libreoffice.org/25667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03sw: replace some OSL_ENSURE with assertMichael Stahl
... and delete a couple that are obviously dead. Change-Id: I2cef18371cc57f5fd82500d0ab6d74030004a761
2016-06-03sw: convert some OSL_FAIL to assertMichael Stahl
Change-Id: Ia5244d58b8975a371c2d74809021c2332ffa496b
2016-06-03Resolves: tdf#93971 freeze on load of specific html docCaolán McNamara
this is similar to commit 6acd5c45c764d81aea1539e66adbfadb51df0aa3 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jan 21 15:25:03 2015 +0000 Resolves: fdo#87601 specific html doc hangs on load and is a consequence of the old changeover from unsigned shorts for old string class to signed int for new string class Change-Id: I47022c641cbc329d8802765927005d43211b0d88
2016-06-03loplugin:constantparamsNoel Grandin
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert FontRights to scoped enumNoel Grandin
Change-Id: Ib46fe9dbe4b41bfe2e85e9171e8dcf7a96ccb483 Reviewed-on: https://gerrit.libreoffice.org/25717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02tdf#90834 Turn in-line version control history commentskrishna keshav
cleanup in core/sw/source/core/view/viewpg.cxx Change-Id: Ie0f406db111b4418e92245a9e998e6ff99eb75fe Reviewed-on: https://gerrit.libreoffice.org/25596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-06-02coverity#1362484 Dereference after null checkCaolán McNamara
maybe this is what was wanted, still looks a bit dubious, won't crash straight away at least Change-Id: I1be934af9d7ec95f3a7079f2f34a3e3661311944
2016-06-02Invalidate the AutoText Dialog after selectionSzymon Kłos
Changes: - added invalidate call after entry selection and expand Behaviour before patch (Linux): 1. Open Writer 2. Open AutoText Dialog: Tools > AutoText 3. Expand/select entry Insert button is still disabled / entry is not expanded. To force repaint you had to use mouse scroll. Change-Id: I814db71dea02273998f675c3b140d554f2e109ba Reviewed-on: https://gerrit.libreoffice.org/25783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02STREAM_STD_READ already includes StreamMode::NOCREATETakeshi Abe
Change-Id: Ib8c81056619a383cedc828b945c1802ff1ce42ca Reviewed-on: https://gerrit.libreoffice.org/25802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02drop some more RTL_CONSTASCII_USTRINGPARAMNoel Grandin
Change-Id: I528b0ecb5282178d8e727471beb126cb7d3f2eb4
2016-06-02loplugin:unuseddefaultparamsNoel Grandin
Change-Id: I0fe173534dc2e70c3d507eae757a91e48a26acfc Reviewed-on: https://gerrit.libreoffice.org/25757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02loplugin:unusedfieldsNoel Grandin
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01sw UNO API XTextTable add TableTemplateName propertyJakub Trzebiatowski
Change-Id: I8450fd4003ad5f9b082817765a2d44fc00dea15e Reviewed-on: https://gerrit.libreoffice.org/25688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-01tdf#99827 sw: don't create AutoText dialog's preview doc ReadOnlyMichael Stahl
Since commit 5334ff287c65f028753171c7b38da7ffbcebc1cc the framework refuses to create new documents as ReadOnly, so don't do that. Change-Id: I9d94ca9859baaf5407bad88a2b4b5b2e26b99b94
2016-06-01RTF export: use auto where it improves code readabilityMiklos Vajna
for (std::vector< OUString >::const_iterator it = rStarts.begin(), end = rStarts.end(); it != end; ++it) vs for (const auto& rStart : rStarts) and so on. Change-Id: I75eff3c28fea11e78415a2183622090804d34f0e Reviewed-on: https://gerrit.libreoffice.org/25755 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-01remove unused SID constants and associated codeNoel Grandin
found with a python script that looks like: process = subprocess.Popen( "git ls-files *.hrc | xargs grep -hE '#define +SID_' | cut -d ' ' -f 2 | sort -u", shell=True, stdout=subprocess.PIPE) for line in iter(process.stdout.readline, b''): line = line.strip() if line.startswith("//"): continue if line.startswith("sfx"): continue if len(line) < 10: continue i = subprocess.check_output("git grep -nP \"#define +" + line + " \"", shell=True) if i.count("#define") < 2: continue print line + " " + i Change-Id: I40eac2569c2b5b129d9459cb723a9d6f26d09264 Reviewed-on: https://gerrit.libreoffice.org/25715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31tdf#91781 A round of minor tweaks to Writer's menusYousuf Philips
Change-Id: I0c37f9e0349af0cd9dc41c500543da7532fb9198 Reviewed-on: https://gerrit.libreoffice.org/23976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-05-31tdf#94205 Use o3tl::make_unique instead of new + std::movekrishna keshav
removed std::unique_ptr and std::move to make_unique in sw/source/uibase/dbui/dbmgr.cxx removed 'pInsert' as fixed in 9d8184b34e9e4c53f93e4d44ac53590e9231c520 Change-Id: Ief5e66f9691f81d294f6393c25d98f5301876928 Reviewed-on: https://gerrit.libreoffice.org/25621 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-31Don't use pInsert after it has been movedStephan Bergmann
Regression introduced with 38ea2d0ecc1d59844f9371ae6da7980c4e3a9e10 "sw: replace boost::ptr_vector with std::vector<std::unique_ptr>". Change-Id: I15f556319693c4728812d5ffd5002d0eba58ae82
2016-05-31tdf#77349 RTF import: automatically generate names for images if neededMiklos Vajna
The DOC/ODT import can call SwDoc::SetAllUniqueFlyNames() at the end of the process to assign unique names to fly frames which lack a name. Add a similar (but much simpler) feature to the domain mapper to avoid empty image names in the DOCX/RTF import result, so it's easier to click on the items in Writer's navigator. Change-Id: I432fc741f8d75d735e1dfe88daba50ba0797042d Reviewed-on: https://gerrit.libreoffice.org/25705 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-31Sw UNO API SwXTextCellStyle; TableStyles createInstance, XNameAccessJakub Trzebiatowski
Making createInstance("com.sun.star.style.TableStyle") possible Making SwXTextTableStyle a XNameAccess container of SwXTextCellStyles Implementing basic SwXTextCellStyle CellStyleMap based on svx/source/table/tabledesign.cxx Change-Id: I5afff1f514582a63a6eb9f9fb44667665749855a Reviewed-on: https://gerrit.libreoffice.org/25558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-31loplugin:unusedmethodsNoel Grandin
Change-Id: Ifeb818227a960cab8fd2e8e7352468efbfe1232c Reviewed-on: https://gerrit.libreoffice.org/25668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert PrinterSupport to scoped enumNoel Grandin
Change-Id: I2bde7261b8e8f31e6dd5a02cd4130156a04b8a7f Reviewed-on: https://gerrit.libreoffice.org/25657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert GfxLinkType to scoped enumNoel Grandin
Change-Id: Iae074ef0927a55f1fbf401cb66f4f183213f547c Reviewed-on: https://gerrit.libreoffice.org/25656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Move accessibility relations to .ui files tdf#87026Muhammet Kara
Change-Id: I2ce2c236d124d31aaacacb0c24ba52b3a70b489c Reviewed-on: https://gerrit.libreoffice.org/25555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-30tdf#98226: fix undo of table AutoFormatMichael Stahl
The new call to SwTable::SetTableStyleName() was not recorded in SwUndoTableAutoFormat and hence persisted even after Undo. (regression from 73f4a06c0bce51c7c8b9ae9adfdc7ffac27d06b4) Change-Id: Ia7f769dafa62f02ff8e4b0596b48266190c7a69b
2016-05-30sw: prefix members of SwLayoutModeModifierMiklos Vajna
Change-Id: I280a79f5060623c8a30ecfde99cf650ebde4e5fd Reviewed-on: https://gerrit.libreoffice.org/25653 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-30editeng: rename misleading SvxBoxItem::GetDistance()/SetDistance()Michael Stahl
Change-Id: Iea61f2de2b907974bbb05c66abf6cdaeab87b8b2
2016-05-30fdo#34362 Setting table border from toolbar resets "spacing to content"Rodolfo Ribeiro Gomes
Change-Id: Iec51c02ab389015d268849aa0dda870c11323f46 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-30Some clean up of uses of css::uno::Any::setValueStephan Bergmann
Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
2016-05-30Fix tools/date.hxx Date vs. css::uno::Date mismatchStephan Bergmann
...that was there ever since at least 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import". None of the "make check" code appears to trigger this code path. Change-Id: Ic85b2ef4cf0a0ad06b467558e823cfa4ee31a08c
2016-05-30Convert FontRelief to scoped enumNoel Grandin
Change-Id: I545c83d742db27f1a004b66e5eb1ef768f62e011 Reviewed-on: https://gerrit.libreoffice.org/25626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30loplugin:unusedmethodsNoel Grandin
Change-Id: I08e9bb65b2530148b80c67f01d51e594fc698acb Reviewed-on: https://gerrit.libreoffice.org/25543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#99870 writer: don't delete selection with delete-commentJustin Luth
When using the keyboard to select text and then deleting a comment, all the text between the cursor and the comment would also be deleted. (Not necessarily the selected text, but everything from the point or the mark would be included in the delete.) Change-Id: Id15a00d112d118227bc4a34b5102bb09d8d167b0 Reviewed-on: https://gerrit.libreoffice.org/25216 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org>