summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2015-07-17loplugin:unusedmethods filterNoel Grandin
Change-Id: Ie33a5ebda9337cf123b39ae18a8d7b4ef12b6991 Reviewed-on: https://gerrit.libreoffice.org/17131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16Added UNO test coverage for SwXTextDefaultsVarun
Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx Change-Id: I963509aae81616711726268a5b215b2ecb93898f Reviewed-on: https://gerrit.libreoffice.org/17125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-16Convert Alignment button to the generic controllerMaxim Monastirsky
Change-Id: I76ead43fa1cfe7ba1b62d2b13c4f4d7658a9f290
2015-07-16Convert FontWorkShapeTypeControl to the generic controllerMaxim Monastirsky
Change-Id: I7824136aa2780c4062a66f7a5284a342862f319a
2015-07-16oox: fix invalid mime type "image/tif"Michael Stahl
(regression from ccfc02f7691848284403d339ee17054169fbff1d) Change-Id: I29a366228bf08f29edfa4a8e963889e34aa3d2ea
2015-07-16silence warning about unknown swipe commandCaolán McNamara
and show context menu on long-press Change-Id: I6d603ebcc049b5ec2f9b23f7e400d995883324ea
2015-07-16coverity#1311944 Logically dead codeCaolán McNamara
for the record its a SwFormatChg we get here at the crash time regression from commit 7de992bcc66c973bb6b247184cac38f01cd1104a Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jul 13 12:38:18 2015 +0100 fix a11y crash seen on close of tdf#92573 its not the reported crash, which has "gone away" which might be a duplicate of tdf#90502 the switch only handled RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED so if its anything else, e.g. OBJ_DYING, then don't attempt GetNoTextNode Change-Id: I290d6e633811423c3acc198aba7a60943518ec4a
2015-07-16tdf#39468 Translate German Comments - sw/source/filter/xml/Phillip Sz
Change-Id: Ie637ef4258caf2519a77d596b76cc52570a182e8 Reviewed-on: https://gerrit.libreoffice.org/17077 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-16loplugin:unusedmethods svx(part2)Noel Grandin
Change-Id: I161360e2f3113c4814fe1c2c095e602b2c93dcd7 Reviewed-on: https://gerrit.libreoffice.org/17120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:unusedmethods svxNoel Grandin
Change-Id: I92158457b3ffaaf7c84c6f4c87708d766c8c9f61 Reviewed-on: https://gerrit.libreoffice.org/17117 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Ibdfb3a4f66513ef6844c8b7df0c07ffef6258e89
2015-07-16Working toolbar entry: Save As > Remote fileSzymon Kłos
Change-Id: I5601c7847f30a7d5fb7ede5f90b2a6a89f4c8693
2015-07-16'Save As' popup menu in the Writer's toolbarSzymon Kłos
Change-Id: I1b1cb7fcd2ae0e0f50e4d8e3900bc416435e60bf
2015-07-16open remote button in sw standard toolbarSzymon Kłos
Change-Id: I7e702da5d4ecc8c32d91e86bd209ec4b7d4f4431
2015-07-16loplugin:unusedmethods sfx2(part2)Noel Grandin
Change-Id: I82223b72ddb6a9df1ee52a300b083002234602dc Reviewed-on: https://gerrit.libreoffice.org/17075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:unusedmethods sfx2Noel Grandin
Change-Id: I98c455d89f76fbcacf74929a4e8775b4da697f62 Reviewed-on: https://gerrit.libreoffice.org/17069 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15tdf#87539 map MSO washout filter to LO's watermark colormodeJoren De Cuyper
Change-Id: Id28e301a74a729245b20ba6cd2adecf203633f0e Reviewed-on: https://gerrit.libreoffice.org/16048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15tdf#87437 exclude CR/cell break from redline deletionsJustin Luth
The marker used in Word to identify table cell division was being included in the track-changes deletion from the following cell if the deletion was the first node in the cell. This would cause the two table cells to merge into one when changes were accepted by Word. (Problem not seen in LibreOffice itself.) Change-Id: Ia98017cbba7d3a43b67764ae0fa6447b7e90ca86 Reviewed-on: https://gerrit.libreoffice.org/15340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15tdf#89007: Fix ShouldRowKeepWithNext conditionMike Kaganski
KeepWithNext shouldn't be applied to nested tables Change-Id: I6df002ae7b00afa0fcf82aab584f85d9a47315eb Reviewed-on: https://gerrit.libreoffice.org/15794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id438b987f72ae57bd4fa882e01fba17d3fa5b95b
2015-07-15svx, sd, sw: GetPoolDefaultItem() can actually return nullptrMichael Stahl
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall. Change-Id: I409484c172fb5843270aee2425844076a008b4df
2015-07-15sw: remove unused SwUnoTableCrsr::Clone()Michael Stahl
Change-Id: Ic41c9fb96bf0d3dc429f1de18b8ce93c50885827
2015-07-15loplugin:unusedmethods xmloffNoel Grandin
Change-Id: I9d15d8edcc6746c055336bf31e5b0c15cb971ffe Reviewed-on: https://gerrit.libreoffice.org/17061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15tdf#38837 Reduce power consumption by minimizing idle timersAshod Nakashian
Both the document statistics- and state-manager have their own modified flags. There is a cyclic dependency between the the two in that updating the document's statistics also marks the document as modified. Of course when a document is edited the statistics modified flag is set to trigger an update. To avoid a perpetual cycle, the statistics manager resets the document's modified state to that before setting the new statistics. However, this doesn't reset the statistics modified flag, which was set when the document was modified by setting the new statistics. Hence, the statistics thinks there are modifications in the document when there isn't. This patch is to make DocumentStateManager::ResetModified() symmetrical to DocumentStateManager::SetModified() by reseting the modified flag of the statistics manager. The idle CPU drops to nil on unmodified documents after this. However, for modified documents the statistics is recalculated perpetually until the document is saved. This will need a different patch to fix. Change-Id: Ib5936bc1acbda34fcac6a00ec46eaa31e4363885 Reviewed-on: https://gerrit.libreoffice.org/16774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-15Convert filters button to the generic controllerMaxim Monastirsky
Change-Id: I6d3c76c0aafe0ad77b597a2cb8331e6f8219e2d2
2015-07-15Convert optimize table button to the generic controllerMaxim Monastirsky
Change-Id: I6b9089daaa2bb7d0dfc1072296fc51401e5fc88a
2015-07-15Convert insert buttons to the generic controllerMaxim Monastirsky
Change-Id: If7c6c1c5000893fca4205162526b4b4035637c11
2015-07-14loplugin:salboolStephan Bergmann
Change-Id: Ia8df87e2b6803ebe4ab8d3defa147d20ca8d7422
2015-07-14Added UNO test coverage for SwXTextSearchVarun
Change-Id: Iee933f042186326ef4d8cd5da0090348de7a1aae Reviewed-on: https://gerrit.libreoffice.org/17018 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-14sw: _SaveTable::CreateNew() fix invalid cast ...Michael Stahl
... of SwTableFormat to SwTableBoxFormat for the temporary SwTableBox. Change-Id: I74118b1b028bd71561f9afe6acd1cc95991a3761
2015-07-14sw: assert _SaveTable::CreateNew() deletes everything in temp boxMichael Stahl
Change-Id: Ib668bb948a2cd557db7b8804f8a81800048f88bd
2015-07-14tdf#92471: Improve color conversion to MSO highlightingZolnai Tamás
The simple color distance on RGB color space is not good enough. It leads to a better result if we use the scheme of the primary colors. This method works well with MSO highlighting color palette, but not neccessarily in general. In highlighting palette light and dark variant of the same color type (e.g. blue and light blue) has the exactly same scheme. Change-Id: Ied08b4c388b8020326709d01d2de290afdd9d77b
2015-07-13tdf#39478 Fix custom shapes status updateMaxim Monastirsky
In sw it was still returning a string item, although the slot type was changed to boolean back in 2005 with 4cce2a2f08238e1e03055877aa89bc755ec06f59. In sc the status update was simply missing. Change-Id: I8a6dd157d1e401754b3a9a93dc83458dcdd4f089
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13swui: avoid name conflict with SwTextPortion for LTO optimisationArnaud Versini
Change-Id: Iaf6fec2e19af2cf393bc547c3ba439010819238f Reviewed-on: https://gerrit.libreoffice.org/16949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-13Introduce generic sub toolbar controllerMaxim Monastirsky
Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-13tdf#92668: Revert some implementation names, for backwards compatibilityStephan Bergmann
These implementation names of Calc, Draw, Impress, and Writer documents are the most likely to be checked by existing third-party code, so revert the corresponding parts of 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 "Fix various XServiceInfo implementations" (and instead add fixups in CppunitTest_serives). Change-Id: I1a760adbf4c89a1b4477d6e628abba8d2028ccfe
2015-07-13fix a11y crash seen on close of tdf#92573Caolán McNamara
its not the reported crash, which has "gone away" which might be a duplicate of tdf#90502 the switch only handled RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED so if its anything else, e.g. OBJ_DYING, then don't attempt GetNoTextNode Change-Id: I642beb66613481cbc7ee18647f0204a67d670a84
2015-07-13ww8: make sure we don't wrap aroundCaolán McNamara
Change-Id: I667bb264f92024b72f230c2ddbba3887471345f2
2015-07-13editeng: make Link<> usage typedNoel Grandin
Change-Id: Iec36c7e4f4fbc2ee2ee25d4d0c8488340ba7d8c4 Reviewed-on: https://gerrit.libreoffice.org/16968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13editeng, convert to typed Link<>Noel Grandin
and remove SvxBrushItem::SetDoneLink since the field it sets is unused.wq Change-Id: Ide95a295fa8004f1ddab5e560f01d36d36658a72 Reviewed-on: https://gerrit.libreoffice.org/16943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10sw: clean up SwDoc::maPatternNms nonsenseMichael Stahl
Change-Id: I0a166d1b58b23cac96ae27d446d6d8ed2442df8e
2015-07-10vcl: remove boost/signal2/signal.hpp from headerMichael Stahl
The most relevant signal member function appears to be connect(), so let's create a wrapper function for that now, without the more esoteric ordering features for now. Move the signal member itself to a new pImpl. The benefits are worth it: preprocessor input reduced by 2.8GB, that's 9% of the total (excluding system headers which are not counted because they don't generate dependencies). Change-Id: I0aaeda51a5630a348bb12c81a83f67afbd508a14
2015-07-10do not include boost/utility.hppMichael Stahl
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-10Added Test for tdf#80663 table row/column delete undo crashVarun
Change-Id: Ica62926486831f126cce54d651e230cee3360074 Reviewed-on: https://gerrit.libreoffice.org/16901 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-09SdrPaintView::AddWindowToPaintView: take a vcl::Window, tooMiklos Vajna
Change-Id: Iedb296732c0819a1d6cdc1c59b3f1718e2cd6d38
2015-07-09These functions and data can be localMatteo Casalin
Change-Id: Ife2351bc8f0a3ee261b525aeb4e8e254174a42a0
2015-07-09Do not downcast opened bookmarks, neither (and just in case)Matteo Casalin
Change-Id: I603940c64a1580a73c4f5c59b403caecd0ac75a5
2015-07-09Better support more than 65k annotationsMatteo Casalin
There isn't really a limit for the annotation count in the RTF/DOCX spec. Thanks Miklos for hints on this. Change-Id: Ib4493b518acb3cabe04312c37b5c6a9c6072cb7e
2015-07-08Avoid loplugin:unreffun in non-debug buildStephan Bergmann
Change-Id: I1fbf5a355340e20de881a030bc75ebbfce960d4f