summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-09-18tdf#124013 XLSX shape export: fix missing solidFillRegényi Balázs
of the inside of the shape (resulting for example, invisible shapes). See also commit 83c30743eaf44d8eded4a73e3ac2585b5bdbaffc (tdf#77236 DOCX shape export: fix missing solidFill). Co-authored-by: Szabolcs Toth Change-Id: I4efde86f82e22e1aa49b89dc13557ef5f238ba83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102871 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18tdf#135035 DOCX import: fix auto width of frame in columnAttila Szűcs
In compatibility mode FRAME_AUTOWIDTH_WITH_MORE_PARA no frames should be wider as the column it is anchored to, if the frame width is set to automatic. If there is a paragraph in the frame, that is longer then the parent width of frame, then the frame width will be set to the same size as its parents width. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ie5e7e94fd58219eb944ad9163b1ff2c1e7171858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102671 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18writer: handle styles in multiple languages for onlineSzymon Kłos
Use translated name when style is applied and broadcasted. Avoid using style names created by the first view. Change-Id: I18abf3388e69f76ec99eda94e0b67782a52ab23f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101831 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102962 Tested-by: Jenkins Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2020-09-18writer: translate standard styles for onlineSzymon Kłos
in online we can have multiple users with different UI language Change-Id: I8fac53391832acace29388cdbca2c18853ef1690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101830 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102961 Tested-by: Jenkins
2020-09-18tdf#123382 DOCX import: fix range IDs in column ALászló Németh
Range IDs ABOVE, BELOW, LEFT and RIGHT weren't recognized in the first table column. Also the original formula was not grab-bagged in the first table cell (A1), according to the limitation of isInTable(). Follow-up of commit 436cf6d31deb7f9594a5da52ec7883d7e3d34344 (tdf#123355 DOCX import: fix cell range ABOVE, BELOW) and commit 82189fdc93ac337e1de3379d678eca6b7654e6fc (tdf133647 tdf123386 tdf123389 fix DOCX table formula export). Change-Id: Ic7d9c63a5ca989328f7ed33e25e1eda45296b3a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102849 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18tdf#130785 Hide Insert Formula in online sidebarSzymon Kłos
Change-Id: Ifaf3fe2b7abc463ab35a6924d0d8535631cf490b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102949 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-09-17tdf#136682 set the sidebar of the menubutton as active on execute commandCaolán McNamara
so the command will be executed on the expected sidebar window Change-Id: Ic7ffe363005292edeb93c5a1220a9bcb97096c4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102914 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-17Hide InsertFormula in Writer onlineSzymon Kłos
Change-Id: I5875559b46d242434b8e47f214e7f7f7a4a3db6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102146 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102861 Tested-by: Jenkins
2020-09-17sw: fix crash in SwInputWindow::ApplyFormula()Michael Stahl
pView is null because the constructor is called from: 10 0x00007fcf1e4d5796 in SfxDispatcher::Update_Impl(bool) (this=0x70a8f40, bForce=false) at sfx2/source/control/dispatch.cxx:1112 11 0x00007fcf1e975c97 in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) (this=0x72684f0, i_eConnect=SfxBaseController::E_CONNECT) at sfx2/source/view/sfxbasecontroller.cxx:1249 but the active is set later, from: 0 SfxApplication::SetViewFrame_Impl(SfxViewFrame*) (this=0x38f32d0, pFrame=0x7255b30) at sfx2/source/appl/app.cxx:265 1 0x00007fcf1e99025c in SfxViewFrame::SetViewFrame(SfxViewFrame*) (pFrame=0x7255b30) at sfx2/source/view/viewfrm.cxx:3326 2 0x00007fcf1e989181 in SfxViewFrame::MakeActive_Impl(bool) (this=0x7255b30, bGrabFocus=true) at sfx2/source/view/viewfrm.cxx:1931 3 0x00007fcf1e975d2d in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) (this=0x72684f0, i_eConnect=SfxBaseController::E_CONNECT) at sfx2/source/view/sfxbasecontroller.cxx:1253 This can only be reproduced if the SwInputWindow is visible in the configuration, but it is closed automatically on document close, so not sure how i got into this situation; Ctrl+C while it's visible can reproduce this anyway. Change-Id: Iae2c7b6044bfea5cb627804d3b88dde2a83732bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102875 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-09-17drop dubious looking ProcessEventsToIdleCaolán McNamara
Change-Id: I8a4dec8c5b2011368808672743a862b83b0534e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-17tdf#129520 : sw_odfexport: Add unittestXisco Fauli
Change-Id: I6df242c276ceafb325d8d9fc609dae8bb449093b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102881 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-17avoid uno:Paste in testsCaolán McNamara
clipboard is a shared resource (except for svp) so interleaved tests are not guaranteed to get out what they put in Change-Id: Id3ec51417b99f3420034808f6a9fd39f6bc9a89c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uStringStephan Bergmann
...from which an OUString can cheaply be instantiated. This is the OUString equivalent of 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String". Most remarks about that commit apply here too (this commit is just substantially bigger and a bit more complicated because there were so much more uses of OUStringLiteral than of OStringLiteral): The one downside is that OUStringLiteral now needs to be a template abstracting over the string length. But any uses for which that is a problem (e.g., as the element type of a container that would no longer be homogeneous, or in the signature of a function that shall not be turned into a template for one reason or another) can be replaced with std::u16string_view, without loss of efficiency compared to the original OUStringLiteral, and without loss of expressivity. The new OUStringLiteral ctor code would probably not be very efficient if it were ever executed at runtime, but it is intended to be only executed at compile time. Where available, C++20 "consteval" is used to statically ensure that. The intended use of the new OUStringLiteral is in all cases where an object that shall itself not be an OUString (e.g., because it shall be a global static variable for which the OUString ctor/dtor would be detrimental at library load/unload) must be converted to an OUString instance in at least one place. Other string literal abstractions could use std::u16string_view (or just plain char16_t const[N]), but interestingly OUStringLiteral might be more efficient than constexpr std::u16string_view even for such cases, as it should not need any relocations at library load time. For now, no existing uses of OUStringLiteral have been changed to some other abstraction (unless technically necessary as discussed above), and no additional places that would benefit from OUStringLiteral have been changed to use it. Global constexpr OUStringLiteral variables defined in an included file would be somewhat suboptimal, as each translation unit that uses them would create its own, unshared instance. The envisioned solution is to turn them into static data members of some class (and there may be a loplugin coming to find and fix affected places). Another approach that has been taken here in a few cases where such variables were only used in one .cxx anyway is to move their definitions from the .hxx into that one .cxx (in turn causing some files to become empty and get removed completely)---which also silenced some GCC -Werror=unused-variable if a variable from a .hxx was not used in some .cxx including it. To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc. In a similar vein, comparison operators between OUString and std::u16string_view have been added to the existing plethora of comparison operator overloads. It would be nice to eventually consolidate them, esp. with the overloads taking OUStringLiteral and/or char16_t const[N] string literals, but that appears tricky to get right without introducing new ambiguities. Also, a handful of places across the code base use comparisons between OUString and OUStringNumber, which are now ambiguous (converting the OUStringNumber to either OUString or std::u16string_view). For simplicity, those few places have manually been fixed for now by adding explicit conversion to std::u16string_view. Also some compilerplugins code needed to be adapted, and some of the compilerplugins/test cases have become irrelevant (and have been removed), as the tested code would no longer compile in the first place. sal/qa/rtl/strings/test_oustring_concat.cxx documents a workaround for GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96878> "Failed class template argument deduction in unevaluated, parenthesized context". That place, as well as uses of OUStringLiteral in extensions/source/abpilot/fieldmappingimpl.cxx and i18npool/source/localedata/localedata.cxx, which have been replaced with OUString::Concat (and which is arguably a better choice, anyway), also caused failures with at least Clang 5.0.2 (but would not have caused failures with at least recent Clang 12 trunk, so appear to be bugs in Clang that have meanwhile been fixed). Change-Id: I34174462a28f2000cfeb2d219ffd533a767920b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-16sw: remove dead code in lcl_FillBookmarkArray()Michael Stahl
Change-Id: Idb9fbac5bd1c74f8ccd434a2337daea58b624e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102738 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-09-16tdf#135663 DOCX export: fix OLE distance from textDaniel Arato (NISZ)
Implements the export of the "mso-wrap-distance-*" properties of VML icons of OLE objects to the "style" property of the "object" XML tag. These properties are variously referred to as "wrap distance", "margin" or "spacing" and they control the amount of blank space to be left on each side of the object before text can appear. Follow-up of commit 8ee88230c110ae90b439a52bc2906d6c5383967f (tdf#135660 DOCX import: fix OLE icon wrap distance). Change-Id: I576b876d2dca133b0ff593ff301519c17d2a348f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102323 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-16tdf#136706 writerfilter: don't create page style for footnoteJustin Luth
Each time CloseSectionGroup is called for a non-continuous break, it wants to create a new page style. Each footnote calls CloseSectionGroup twice, so two unused ConvertedX page styles were created for each footnote. A quick glance through the code makes me wonder whether footnotes can skip CloseSectionGroup altogether, (unit tests suggest that it can...) but it might be necessary for a floating table that should be in-lined, or setting relative width (although tables aren't really supported in footnotes). In any case, the safest approach is to change as little as possible, so that is what I have done. HandleMargins...() only seems to add the margin information into the page style, so it should be safe to avoid that function, even though relative width stuff checks the margins. Comments are already excluded, and the function is not even called for isInIndexContext() || isInBibliographyContext(). I thought header/footers were also considered sections, but that does not appear to be the case. I'm not aware of any other types of non-text sections, but if there are, they may need similar treatment. Change-Id: I4325604c286ca1132e5765a56627be4b7e64ba4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102723 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-16tdf#134784 DOCX import: fix shape paragraph marginsLászló Németh
based on bad style inheritance. Regression from commit dc0300eac3b755bc207cd1fe87217f4ebaeb9f58 (tdf#118521 DOCX import: fix paragraph margin from paragraph style), revealing the problematic m_sCurrentParaStyleName, see also commit 8920d865ee148518bf71f71ce1866b24cc17c07e for more information. Change-Id: Icc7f70452d946d56dc840d39545d850f74f97ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102774 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-15Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id56c9b50540a4de1950dfc4b49ea783d164a6604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101811 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-15sw_ooxmlexport15: another OOXMLIMPORT_TEST -> OOXMLEXPORT_TESTXisco Fauli
Change-Id: Ica5febe044c978fbb40b5998ab7eb088352d151d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102713 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15tdf#103611 sw: fix vertical alignment to page bottom marginTibor Nagy
Allow to align objects to page bottom margin vertically in Position and Size settings. Fix also DOCX import of VML shapes. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I78db2553ee9d963b18a2d580b1cbb76c1917ac0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102379 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-15sw: don't throw if disposed in SwXRedlinePortion::getPropertyValue()Michael Stahl
No other SwXTextPortion method does that, so avoid it here for consistency, just return void. Change-Id: Iae9b6b12e21609e315a9f269feb0703657bbf3cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102691 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-09-15sw: additional asserts/warns to diagnose empty style namesVasily Melenchuk
Since undo/redo is using format name instead of old approach with pointers (which can point to invalid/removed style) it is a problem when we trying to use any style without name: it will be not resolved and undo/redo will work incorrectly: it can apply invalid attributes or apply style to another random objects. Change-Id: Iccba3e8ab223955ce940dfc17d0bd4858bd364f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101472 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-09-15tdf#135623: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I77bc9e22d294ecc218b1570e75742344ef1d2ea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102668 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15tdf#135682 sw: fix lost selection-all when doc starts with tableMiklos Vajna
Regression from commit c56bf1479cc71d1a2b0639f6383e90c1f7e3655b (tdf#105330 sw: fix lost cursor on undoing nested table insert, 2019-09-16), the problem was that the change reverted lcl_notifyRow() back to its original state, because it seemed the conditional notification is no longer needed. However, this broke the fix for tdf#37606 (ability to select-all when the doc starts with a table). Fix the problem by handling the starts-with-table case similar to a normal table selection, so there is still no need to restore the nested table visitor code but select-all works nicely with starts-with-table documents again. Change-Id: Icb823a39432d1774a63a0c633c172bba827ac76d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102694 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-15tdf#136667 DOCX import: fix crash of floating tablesLászló Németh
with tracked changes of table structure (not only cell text content), where text ranges of redlines aren't connected to a cell. Support also different table names of redline text ranges for sure. Regression from commit 288db6eb47fbbd2b3ca34ffea0686d8ed8ed9be9 (tdf#132271 DOCX: import change tracking in floating tables). Change-Id: I58b1b21c8016d682a292409165991dec2f8cfa3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102655 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-14tdf#135669 sw: drag and drop other files as OLEDaniel Arato (NISZ)
from file managers. Native text, PDF and image file formats were supported, but now spreadsheet and DOCX documents, too. The same feature was already implemented in e.g. Impress. Note: DOCX files inserted as OLE objects yet, and not linked files in sections, as ODTs (but it's possible saving and printing them via Save As option of the local menu of the OLE object). Change-Id: Ia2fafe4a0b79dc0c66eaec5ad073c994f98e1345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102263 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-14tdf#135623: modified generation of unique fly nameVasily Melenchuk
Modified lcl_GetUniqueFlyName() is right now always marks current fly format name number as used. Yes, this can lead to some gaps in numbering is some cases, but meanwhile guarantee that there will be no duplicates if format name does not match SdrObject name. Change-Id: If39ed993614ae1665deba21ae8d5e6bd542fb6e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102460 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-14sw: prefix members of SwConvIter, SwHyphIter, SwLinguIter and SwSpellIterMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ifc53fa1fb1416793dfee7080406762d7b25cb335 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102625 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-13fix attachnamedialog mnemonicsCaolán McNamara
Change-Id: Ibdc7e7432d7ce48473e16298fdb8eddea5241938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-13fix alreadyexistsdialog mnemonicsCaolán McNamara
Change-Id: Id9c326d28cf7049e692108cdeccef6714c142e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-13SwUndoFormatAttrHelper: tweak out some SwClient stuff ...Bjoern Michaelsen
- make it final for starters - dont use GetRegistered() variants to prepare removal of SwClient/SwModify - dont use CheckRegistration() as the observed format should never die Change-Id: I9bfb587e5e88896eb36d2da6edcf4f41a93195cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102500 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-09-13SwRegHistory: SwClient no moreBjoern Michaelsen
Change-Id: Ifd43ff792612baba104d4cf09e3ee9bb6ed1c7a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102409 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-09-13Following d52674ad92172ce67c94b5970668aeb00d1c6ac5Julien Nabet
author Noel Grandin <noelgrandin@gmail.com> 2020-09-12 08:15:30 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2020-09-12 13:35:16 +0200 commit d52674ad92172ce67c94b5970668aeb00d1c6ac5 (patch) tree e4011c86f470c710fa80b22edfe081ddd2475adf parent 286a7f3ec8976761f3e796e13b374700063dbc4b (diff) std::list->vector in SwTable Change-Id: I6c3db995750de65f2255d7a39323d9d7594d1aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102539 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-09-13std::set->o3tl::sorted_vector in SwHistorySetAttrSetNoel Grandin
Change-Id: I603ddde15c869a66b05c18815326931fbcfd9076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-12unordered_set->sorted_vector in CopyWithFlyInFlyNoel Grandin
Change-Id: I9ee4ffd9a54fc62a9fa8d8f15dc90d458d87bbc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-12std::set->o3tl::sorted_vector in CheckFlyCache_Noel Grandin
Change-Id: If4209f165912f5026d8bb2c311314dba8aaba1ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-12Replace remaining uses of sal_CharJulien Nabet
+ remove sal_Char check on compilerplugins Change-Id: I0f7da14e620f0c3d031d038aa8345ba4080fb3e9 Change-Id: Ia6dba4f27b47bc9e0c89159182ad80a5aee17166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-12std::list->vector in SwTableNoel Grandin
Change-Id: I4bd23ef011e002133c01dcfcab13b5a100926e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102507 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-12ConvertNumbersToText: handle legacy listsMike Kaganski
Handle css::text::PositionAndSpaceMode::LABEL_WIDTH_AND_POSITION Change-Id: I5024359b1a34b0ebb63165ace5e517dd90994faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102510 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-12tdf#41202 writer: allow shift+click to decrease selectionMartin van Zijl
Change-Id: I8f0f03a3ea0eafda166d19a5cd9fa24e97345a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102399 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-09-12Fix typosAndrea Gelmini
Change-Id: Ica93ad739eb32372addc01e1c72804e33d8ce819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102508 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-12sw rtfexport: add explanation comments to unit testJustin Luth
Change-Id: I6b2579c6c92f0090fe7bee732ab6c8571272e9b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102454 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-09-11tdf#135693: sw: Add UItestXisco Fauli
Change-Id: If38daeb35ae8ba09aac50490a15c66dc0650f784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102485 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-11tdf#131581: sw: Add UItestXisco Fauli
Change-Id: Ie6fd0f0e9894f2795e87580e00f4d75272bb3c68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102462 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-11tdf#135667 DOCX export: fix border line of OLE objectsAttila Bakos
which wasn't exported. Note: the enlarged monolithic export function was split in the following new functions: - WriteOLEShape() exports the replacement shape of the OLE object. - GetOLEStyle() returns the string value of the style attribute. - ExportOLESurround() handles the surround settings. Also add GetVMLShapeTypeDefinition() to reuse picture frame VML formula string used by VMLExport. Co-authored-by: Arató Dániel (NISZ) Change-Id: I29800a50c60a824a14849ac286a18e5e2f97c689 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102034 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-11tdf#77236 DOCX shape export: fix missing solidFillRegényi Balázs
(resulting for example, invisible shapes). Co-authored-by: Szabolcs Tóth Change-Id: I328514022f4a594c374d5a97db39d1cf3a954e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102195 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-11Missing test dependenciesStephan Bergmann
From-scratch `make CppunitTest_sw_core_layout` had failed for me on Linux with > warn:vcl.builder:1528301:1528301:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui xmlreader/source/xmlreader.cxx:66 and > warn:vcl.builder:1529052:1529052:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui xmlreader/source/xmlreader.cxx:66 Change-Id: I021cf45a61a894a88aee64110a9b9ea8f7a20888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102452 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-11Clean-up of commit I29af97001954ad353a386164b68cd22f6230e3e5Tibor Nagy
Change-Id: I1963a5d899da2d122e60c4d87ca32aba4fb1f32a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102449 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-11ofz#25553 Infinite loopCaolán McNamara
Change-Id: Ie0ecacb69b1e99ca52abd9038baa176be8383661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11tdf#135660 DOCX import: fix OLE icon wrap distanceDaniel Arato (NISZ)
The text wrap distance (also sometimes called "margin") of OLE VML icons used to be thrown away when a .docx file is opened. Change-Id: I79837421470dde5e68e916f87924b170ebf1d734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102159 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2025-03-06 18:17:00 +0000