summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-11-13add uitest for bug tdf#126627Zdeněk Crhonek
Change-Id: I115e014cafb9c4a85558567ccd6cd2987cabdfd6 Reviewed-on: https://gerrit.libreoffice.org/82483 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-13Add document level option to lock down edit doc commandSerge Krot
Change-Id: I431fa4cd0daa52c885030dbadcc4052b5a890d34 Reviewed-on: https://gerrit.libreoffice.org/82553 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-on: https://gerrit.libreoffice.org/82576 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-13tdf#95374 DOCX import: reset left indentation at disabled numberingLászló Németh
Paragraphs with disabled numbering using non-existent numId=0 haven't got inherited left indentation in MSO. Keeping them resulted unnecessary indentation, moreover, missing (non-visible) text in narrow table cells. Change-Id: I46003031d36f578b0b260dea74d7d45e75905261 Reviewed-on: https://gerrit.libreoffice.org/82509 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-13tdf#127925 DOCX export: fix visited hyperlink styleTünde Tóth
Custom visited hyperlink style reset to default in Word. Change-Id: I6a36c900788bb17d4f31c60048cf65960490a46b Reviewed-on: https://gerrit.libreoffice.org/80043 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-13no need to store reference to Import hereNoel Grandin
can just cast the parent member Change-Id: I990bd4da3afbd78da819038c7907c28de87faaaf Reviewed-on: https://gerrit.libreoffice.org/82567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-13jsdialogs: send table row/column size updatesSzymon Kłos
Change-Id: I1b41fe50e93dc14db60c7548a1ae0c54113da329 Reviewed-on: https://gerrit.libreoffice.org/82542 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-13table properties dialog should be modalCaolán McNamara
Change-Id: I3787f6e3a326c1f8e93fc966f890ea2c7cdacc29 Reviewed-on: https://gerrit.libreoffice.org/82549 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-13Fix OSL_ENSURE in DocumentListItemsManager::addListItem (sw)Julien Nabet
was wrong since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 Here's the root cause: const bool bAlreadyInserted( - mpListItemsList->find( &rNodeNum ) != mpListItemsList->end() ); + mpListItemsList->insert( &rNodeNum ).second ); OSL_ENSURE( !bAlreadyInserted, "<DocumentListItemsManager::addListItem(..)> - <SwNodeNum> instance already registered as numbered item!" ); - if ( !bAlreadyInserted ) - { - mpListItemsList->insert( &rNodeNum ); - } Change-Id: I0cc5786a18fe2df5fd86284c18638de90604edf9 Reviewed-on: https://gerrit.libreoffice.org/82560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-13sw: avoid partial expansion of bookmark over new fieldmarkMichael Stahl
The comment that was added with commit 71f13a801608538f56a0cb2bce07a03faa5856f6 "#i29942# SwTxtNode::Update for bookmarks fixed. Bookmarks no longer grow on either side." suggests not to expand bookmarks in any case but in case the start and end position was the same, the start position was still moved so the mark expanded anyway. Unfortunately meanwhile commit c91024891ff10c2ae01e11a28a9aecca2f36b6c3 "tdf#96479 workaround bookmark end pos handling when inserting text into a text node." added a requirement that bookmarks with start==end *are* expanded. For the case where a new field is inserted, shortcut the insertion to do only one InsertString call so that any expansion of bookmarks will expand it over the entire field, not just its CH_TXT_ATR_FIELDSTART. Change-Id: If2608c9cf34a217330156e7ea566dcf528890c45 Reviewed-on: https://gerrit.libreoffice.org/82521 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-12Options Writer General Tab updateandreas kainz
Change-Id: I8397452eae8eaf83e5f928f96f30269fc70e46b1 Reviewed-on: https://gerrit.libreoffice.org/82534 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Mailmerge Dialog updateandreas kainz
Change-Id: I160fb9e5afdf10f64bcd7422e5c4198fe8bb538d Reviewed-on: https://gerrit.libreoffice.org/82480 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Writer AutoCaption Tab updateandreas kainz
Change-Id: I189dad65e35c7947a9479885d22d066c05c25f8a Reviewed-on: https://gerrit.libreoffice.org/82538 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Writer Print Tab updateandreas kainz
Change-Id: I8a7dc4324890a69dacd271e0a689018d87e13f5a Reviewed-on: https://gerrit.libreoffice.org/82537 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Resolves: tdf#128746 crash in table properties dialogCaolán McNamara
Change-Id: I3d7d49cc225afc0dee542205690d56643a0c2e64 Reviewed-on: https://gerrit.libreoffice.org/82532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12jsdialogs: send .uno:ULSpacing updatesSzymon Kłos
Change-Id: I061868a0cf9163624026dc1ff164af3d98923aa6 Reviewed-on: https://gerrit.libreoffice.org/82531 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-12jsdialogs: send .uno:LeftRightParaMargin updatesSzymon Kłos
Change-Id: I22aef6ac57c94893bf2e73ea2901ed8bc074076e Reviewed-on: https://gerrit.libreoffice.org/82501 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit c6cf2bec7148e403e2ee9592b4410cc73bad8f46) Reviewed-on: https://gerrit.libreoffice.org/82506 Tested-by: Jenkins
2019-11-12use std::move when popping stuff off stacksNoel Grandin
Change-Id: I6ba0ee8afee1a9579045643cd0118cf19599d5b9 Reviewed-on: https://gerrit.libreoffice.org/82497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-12tdf#121239 give writer, calc and draw/impress the same underline optionsCaolán McNamara
uno:Underline is the "real" deal, and has multiple underline options uno:UnderlineSimple is "some underline on" vs no underline calc and writer had UnderlineSingle, UnderlineDouble and UnderlineDotted for that specific type of underline on vs not-on add those to draw/impress too and then use UnderlineSingle instead of Underline in the format menu so that when UnderlineDouble is applied, UnderlineSingle is not show as applied, instead of using Underline ot UnderlineSimple which would show as on if UnderlineDouble was applied Change-Id: I6f9fcf37c2c90d215ea52b536e4fa84734754850 Reviewed-on: https://gerrit.libreoffice.org/82469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11add uitest for bug tdf#128593Zdeněk Crhonek
Change-Id: Icc0b22318406a92cf19843844e857d09dd9a4ba2 Reviewed-on: https://gerrit.libreoffice.org/82466 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-11tdf#109219 MM: Decode all percent encodings in file namesMichael Weghorn
While decoding using 'INetURLObject::DecodeMechanism::Unambiguous' as introduced by commit 47708d533e1325032df55eb667ef0c47fa05e7e5 ("tdf#109219 Allow files with spaces in name as MM data source") makes sure that e.g. spaces in file names are properly decoded, 'INetURLObject::DecodeMechanism::WithCharset' is actually the more correct decoding mechanism to use here, since it also decodes some percentage encodings that 'INetURLObject::DecodeMechanism::Unambiguous' would leave unchanged. Using 'INetURLObject::DecodeMechanism::WithCharset' instead e.g. makes CSV files with '%' characters in their names work as data sources for mail merge as well. A big thanks to Stephan Bergmann for pointing this out in https://gerrit.libreoffice.org/#/c/82201/ . Change-Id: Iee50584299c82d5718e3210f048ed739818bd11b Reviewed-on: https://gerrit.libreoffice.org/82428 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-11jsdialogs: apply .uno:Color and CharBackColor to floating text framesSzymon Kłos
Change-Id: I1a6b997f1a857524c7a48434321ca10d97f5e5db Reviewed-on: https://gerrit.libreoffice.org/82311 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82317 Tested-by: Jenkins
2019-11-11Removed executable permission on fileAndrea Gelmini
Change-Id: I45174811c8e1ef80ddae97f206f2a5459540849f Reviewed-on: https://gerrit.libreoffice.org/82427 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-11tdf#127921 Revert mouse/key listeners to original stateSamuel Mehrbrodt
The changes caused several issues in the presenter console (mouse events delivered to wrong widgets). Also it turned up that parent windows got the notification about mouse events from their children, but the position was always relative to the top widget, so very unhelpful for the parent widgets. Also I found out that there are XKeyHandler and XMouseClickHandler interfaces which already do what I tried to do with the below commits (events get passed down to parent widgets, and they even can be marked as consumed). So the original issue reported can be fixed by using XKeyHandler/XMouseClickHandler instead. This reverts the following two commits: * "Related tdf#122920 Treat UNO key events the same as mouse events" 9e0e97b716ab074d4558c76a62a66bf597f332a5 * "tdf#122920 Send UNO mouse events to parent window listeners as well" 6f43902b12dd36fa2b69401065df198ef9ffdb09 Change-Id: I005d22770a7a4db9588c5bc22197dc0ae526627e Reviewed-on: https://gerrit.libreoffice.org/82423 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-11tdf#128428 RTF: clean-up for longer space sequence modeLászló Németh
Fix regressions from commit 24b04db5a63b57a74e58a7616091437ad68548ac (tdf#123703 RTF import: fix length of space character sequence). It seems, longer space sequence is an obsolete RTF-only feature, eg. new RTF documents created in MSO don't use it, but old RTF documents still keep their layout (only in RTF). - Only old-style (without \stshfdbch) or compatible (\stshfdbch31505) RTF documents get longer space sequences using a one-time conversion; - because Writer always exports old-style RTF documents, to avoid of enlargement of space sequences of new-style RTF documents later, RTF import doesn't modify the RTF documents saved in Writer (checking \generator); - text in monospaced font "Courier New" doesn't get longer space sequence (despite its \prq2 (not monospaced) font setting). Change-Id: I308ab06db57a2db5deec1d4c4573da3317cad8e9 Reviewed-on: https://gerrit.libreoffice.org/82145 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-11tdf#127579 DOCX export: fix losing color and underline of ODT hyperlinksTünde Tóth
using "InternetLink" in hyperlink/r/rPr/rStyle instead of the actual character style, and keep actual character formatting in hyperlink/r/rPr/rFonts, like MSO does. Change-Id: I13a5e1758ec5b96e647ca77736396ee2f8b22814 Reviewed-on: https://gerrit.libreoffice.org/80868 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-11tdf#128375 sw: fix copying RES_PARATR_LIST_AUTOFMT to different SwDocMichael Stahl
When copying the item to a different SwDoc, the items in the nested SfxItemSet must be copied into the target SwDoc's item pool, or a use-after-free is inevitable. (regression from 5ba30f588d6e41a13d68b1461345fca7a7ca61ac) Change-Id: I7071ff6dccf2285d96f540ac556b9fa2265ddf00 Reviewed-on: https://gerrit.libreoffice.org/81911 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-11tdf#124986: docx: remove trailing quotation marks and spaces from set fieldsbrinzing
Change-Id: I6390344b72b0148cff8e0ed5150d7abfc9490a2a Reviewed-on: https://gerrit.libreoffice.org/81892 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-11Resolves tdf#128521 - illegal char in a bookmark nameHeiko Tietze
Message box removed and warning label introduced Some alignment and accessibility issues solved too Change-Id: Icc88d489268403fa3da525aadc1c007c589fa019 Reviewed-on: https://gerrit.libreoffice.org/82231 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-11sw: prefix members of SwTableColumnPageMiklos Vajna
See tdf#94879 for motivation. Change-Id: I7337775a62709cff0d4cb54da3229353c246083a Reviewed-on: https://gerrit.libreoffice.org/82415 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-09Sync page orientation of Endnote pageMuhammet Kara
Description: When changing the default page style to have a different orientation, end-notes are placed on a page with a custom ‘Endnote’ page style. This style does not inherit its orientation from the default style. Repro: Create a blank document, insert→End Note, Format→Page in the first page, select the Page tab, and alter the Orientation to Landscape, ‘Ok’. The End-note page should update its orientation too. NB. If the Endnote page style is manually set to a different value in a document template it will remain in the selected orientation. After this patch, Default style and the Endnote style have their orientations synced after each run of the Format > Page dialog. Ideally, this should be solved by resolving tdf#41316 on master: Page styles should support hierarchical parent-child relationships (like paragraph or character styles) Change-Id: I255b470d1aebb897f50a4a74b8678b771ffbab28 Reviewed-on: https://gerrit.libreoffice.org/79869 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82173 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-09tdf124367 DOCX import: fix rounding error in table cell widthsBakos Attila
Follow-up of commit 29cbbad64088354425c606f9eb6c267bdf7731dc (DOCX import: fix rounding error in table cell widths), its revert in commit e502463fa9a601963aa9f5a8783eb1318de36c13 (tdf#123104 DOCX import: fix lack of vertical merge due to rounding) and commit 44e44239de35c1548809c96e13bfa9d64c7ca441 (tdf#120315 DOCX import: fix cells merged vertically). Change-Id: Id85e8fd25dba26af77fe2fd3024db2ae834b5052 Reviewed-on: https://gerrit.libreoffice.org/82072 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2019-11-09partial revert tdf#116071 import to XATTR_FILL not RES_BACKGROUNDJustin Luth
caused by commit 3539a1efb41a787237e4333ebc715db96ffacb5b which fixes table-related regression bug report tdf#128608. I was not able to create a unit test for this from scratch. In fact, if I use MSWord2003 to roundtrip the file, then LO opens it without problems. A real fix (to move LO away from RES_BACKGROUND in tables) should be subject to lots of testing time, so just reverting for now. Change-Id: I328741947b7ed319ff8df0ba169618f6ad0d2c75 Reviewed-on: https://gerrit.libreoffice.org/82339 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-08fix Makefile typoLuboš Luňák
Change-Id: Ibb5e9f8d2e2732b2aaa528d4cbe330041a193e7a
2019-11-08tdf#128504 save DOCX as ODT: don't color not highlighted hyperlinksTünde Tóth
During DOCX import, not highlighted hyperlinks, ie. without hyperlink character styles, set the Visited/Unvisited character style text attributes to "Default Style" to avoid saving them with the default highlighted hyperlink character styles in ODT. Regression from the commit 576611895e51186d38ddefa10ed8d66075d9de37 "tdf#127741 DOCX import: format hyperlink with Default character style". Change-Id: I5ffbb107e6704b285bc3d1546e08a324c386a0ab Reviewed-on: https://gerrit.libreoffice.org/82205 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-08Missing include (Windows --disable-pch)Stephan Bergmann
> sw/source/core/doc/docfld.cxx(558,18): error: member access into incomplete type 'const ::utl::TransliterationWrapper' > if( rSCmp.isEqual( rDBName, sName.getToken(0, ';') ) ) > ^ Change-Id: I041879acb350a2bc42133f55be5a1501ffe93c95 Reviewed-on: https://gerrit.libreoffice.org/82272 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-08loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: Icf2894f77c90aa4620910d621249947bad4be8b7 Reviewed-on: https://gerrit.libreoffice.org/82269 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-08jsdialog: consume .uno:LineWidth double valueSzymon Kłos
Change-Id: Iaf09dd11ae4fd6b3d9ebeabac790f0cfe73fec17 Reviewed-on: https://gerrit.libreoffice.org/82226 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82234 Tested-by: Jenkins
2019-11-08Revert "tdf#120734 Only enable "Remove hyperlink" when hyperlink selected"Samuel Mehrbrodt
This reverts commit cae4b4951f061a67fab779493e6992d9097f4a4d. Change-Id: I06f6a828e2766058b90dde14e8efbe5759867084 Reviewed-on: https://gerrit.libreoffice.org/82228 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-08sw: no reason why SwModelTestBase can be used only by "extras" testsMiklos Vajna
So move it one level up, this way more tests can share code in the future. Change-Id: I35300b3c88ac9a5c39916f53b1b1743aa85869a0 Reviewed-on: https://gerrit.libreoffice.org/82252 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-08Bibliography .ui file update labels are right align for beter readandreas kainz
Change-Id: I6b7edb822896ab6d600ecd0d751e5adf53fa1fb9 Reviewed-on: https://gerrit.libreoffice.org/82258 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-08Writer Property Statistic Dialog updateandreas kainz
Change-Id: I1da8500ea12581b856b276247584a37e8f18f0aa Reviewed-on: https://gerrit.libreoffice.org/82259 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-08Bibliography Insert Dialog updateandreas kainz
Change-Id: I8b0eb23660aa15254d5a84eba4a045278a7c8152 Reviewed-on: https://gerrit.libreoffice.org/82255 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07Avoid .uno: command names in the customization dialogMaxim Monastirsky
Change-Id: I37a510727dc2d5f8de1eb6ee5b60653e43ff0e4c Reviewed-on: https://gerrit.libreoffice.org/82230 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-11-07Related: tdf#128603 sw textbox: fix use-after-freeMiklos Vajna
lcl_RestoreAnchor() needs to decide if if wants to not copy the old anchor (and keep reading it via a reference) or it wants to update the item set, it can't do both at the same time. The reason for this is that the item set update works by deleting the old pool item and allocating a new one, it doesn't work by updating the old pool item. I believe this was always broken, but now sanitizers found the issue since the cppunit test for the above bug was added recently. Change-Id: Ic08d60eb522a62d78cb2b0ea6a4cda328f8fb80b Reviewed-on: https://gerrit.libreoffice.org/82245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07sw XHTML export: <blockquote> can't have character childrenMiklos Vajna
Fixes the following reqif-xhtml validation error: ERROR at 214: [XSD] cvc-complex-type.2.3: Element 'reqif-xhtml:blockquote' cannot have character [children], because the type's content type is element-only. But this is probably useful in the general xhtml case as well. [ Also add a way to not load a document when we want to cover "store" behavior in a test. ] Change-Id: I88795271475863b9560ac1cb99636c507746f1e9 Reviewed-on: https://gerrit.libreoffice.org/82239 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-07Looks like UBSan still needs various RTTI for some reasonStephan Bergmann
After 5d7af3c38b618d438e065da9d90668e7c4baa849 "make some classes module-private" various tests in my Linux ASan+UBSan build failed due to missing symbols. Identified the problematic types with > make check screenshot gb_SUPPRESS_TESTS=x && for i in $(find instdir/program workdir/LinkTarget/CppunitTest -type f); do LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}instdir/program:workdir/UnpackedTarball/cppunit/src/cppunit/.libs ldd -r "$i" 2>/dev/null | grep 'undefined symbol: _ZTI'; done and fixed the ensuing > sw/source/core/SwNumberTree/SwNodeNum.cxx:190:32: error: dynamic_cast from 'SwNumberTreeNode' with hidden type visibility to 'SwNodeNum' with default type visibility [loplugin:dyncastvisibility] > SwNodeNum* pChild( dynamic_cast<SwNodeNum*>(pNode) ); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sw/inc/SwNumberTree.hxx:114:7: note: base class 'SwNumberTreeNode' with hidden type visibility defined here [loplugin:dyncastvisibility] > class SwNumberTreeNode > ~~~~~~^~~~~~~~~~~~~~~~ > sw/inc/SwNodeNum.hxx:29:26: note: derived class 'SwNodeNum' with default type visibility defined here [loplugin:dyncastvisibility] > class SAL_DLLPUBLIC_RTTI SwNodeNum : public SwNumberTreeNode > ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fallout. Change-Id: I7abafdb4d02216e1a047f886d5e72ad3420115ce Reviewed-on: https://gerrit.libreoffice.org/82210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07tdf#109219 Allow files with spaces in name as MM data sourceMichael Weghorn
The filter needs to be the unescaped file name. Change-Id: I2b5337c184c1ce75595e129d5a87ed4d189ec1e7 Reviewed-on: https://gerrit.libreoffice.org/82201 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-07tdf#125778 docxexport: handle pageBreak before TOXJustin Luth
The pagebreak before the TOX was lost in docx (but not in .doc or .rtf). Change-Id: I280b0bd19a73db180b65a0937bd0fe809e5dfc6f Reviewed-on: https://gerrit.libreoffice.org/81979 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-07tdf#128603 sw textbox: restore shape+frame pair on undoMiklos Vajna
Undo of cut + paste restored both the shape and the frame, but the shape's content pointed to an invalid node index. Later this resulted in a crash. Make sure that in case the content of shape+frame don't match by the time the frame format pointer is set, we sync the draw format to the fly format. Change-Id: I233a504ca52698d1c514769d16c256408c29ae30 Reviewed-on: https://gerrit.libreoffice.org/82192 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-07Fix typo in codeAndrea Gelmini
Change-Id: I05657a97092a3d119d4a18535ba0f43d096530ca Reviewed-on: https://gerrit.libreoffice.org/82190 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2024-12-28 21:36:05 +0000