summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-01-22sw doc model xml dump: show all compat flagsMiklos Vajna
This is handy when they are not in the source document, e.g. DOCX or older ODT and newer compat flag. Change-Id: I62d6623bbe82fca454139ca892929b39fca68dfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87198 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-22rework line style to be a wide toolbar buttonCaolán McNamara
involves converting SvxLineStyleToolBoxControl to a PopupWindowController because chart is doing interesting things in its panel there needs to be a non-standard way to report/detect the selected line style, which is then reused to disable/enable the arrows when none is selected/deselected in non-chart sidebars SvxLineBox becomes a toolbar dropdown instead of a combobox itemwindow linectrl.cxx split into linewidthctrl.cxx and linewidthctrl because SvxLineBox is now needed in svxcore Change-Id: Icf0ef5e612b894a43d389af8a2908138c2e9c580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22tdf#77419 DOCX table import: ignore right white spaceLászló Németh
in table paragraphs in MSO 2010 compatibility mode. Change-Id: I99f11c6a9f7a5735cce06fac433d5acab704cb04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87136 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-22use fastparser in SwXMLBodyContext_ImplNoel Grandin
Change-Id: I0745fb6eb0a46b1c564cd0f1c596aed5206549b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22tdf#129382: sw: assign names to shape object stylesVasily Melenchuk
Empty style names for drawing object will cause problems with udo/redo which right now refers style names instead of style pointers. Change-Id: If2266f1db04c624dbfdd716b5599d5f6cbb5371e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86520 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-22use fastparser for XMLFontStylesContextNoel Grandin
Change-Id: I7b273cdc0f90f2a8c9527d1f19fed97672a74741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87175 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22sw: add DOCX export for semi-transparent textMiklos Vajna
This is the case when the value is not in the grab-bag, that was already supported. Change-Id: I334333ec441644229540a358d7bf8811373618c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87162 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-21use more FastParser in SvXMLStylesContextNoel Grandin
Change-Id: I05c7314739246a864b16723c13bd8fbb4ef725e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21Use FastParser in XMLDocumentSettingsContextNoel Grandin
and flatten the pImpl data Change-Id: I8d817cd2af0a3855d10dbfaa580c3379119d5067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21tdf#103983 VML import: handle <v:textbox style="mso-fit-shape-to-text:t">Miklos Vajna
We used to always always set TextAutoGrowHeight to true, only do that when the matching VML attribute is detected, default to false. This helps the exporter, so it writes the correct markup on save of the bugdoc. Also adapt testGroupshapeChildRotation, which in practice tested the automatic height of the shape. The point of "auto" is that it changes as needed, hardcoding that value in a test is not a great idea. Rather test that the height is no longer automatic (there is no explicit markup in the file, and the default is false). Change-Id: Ie39408b7da53f4923a2ade503e520c704a86bcf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87104 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-21use FastParser in XMLScriptContextNoel Grandin
Change-Id: I7c5f5b77a78307c556ee5718480346ed3dd159fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21sidebar writer table spacing fixandreas kainz
Change-Id: I3dd805f69c9357e9f2b5d773e1a2842f44af5470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87105 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-20tdf#129582 sw: fix copying of flys in header/footer in DOCX/RTF importMichael Stahl
The problem is that the exception for writerfilter in IsDestroyFrameAnchoredAtChar() and IsSelectFrameAnchoredAtPara() is wrong in the case when the header/footer content is copied via SwXText::copyText(); that is, previously the situation was that writerfilter relied on Delete not deleting such flys (for RemoveLastParagraph) but Copy copying them. (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5 and e75dd1fc992f168f24d66595265a978071cdd277) So restrict the writerfilter hack to delete; this causes a problem with ooxmlexport9 test testTdf100075: it has 2 flys anchored at the same paragraph; writerfilter will insert the content into the body and then convert to fly; when the 2nd one is converted it will copy the 1st fly and anchor it inside the 2nd fly but then unotext.cxx:1719 will reset its anchor to inside the body... Prevent this unwanted copy by relying on the new parameter bCopyText that was introduced in 04b2310aaa094794ceedaa1bb6ff1823a2d29d3e, but change things a bit so that the case that pass in the extra flag isn't the copyText() one that wants the *normal* selection semantics in writerfilter import, but the 2 known places that want the *exceptional* selection semantics in writerfilter import (hopefully there aren't more). This is not ideal and the various bool parameters to CopyRange() plus mbCopyIsMove plus mbIsRedlineMove should probably be consolidated into some flags enum passed to CopyRange(). Change-Id: I638c7fa7ad0b4ec149aa6a1485e32f2c8e29ff5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87072 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-20StoreUserCustomValues should be usedCaolán McNamara
Change-Id: I64d41d297c55d36fc14f16945fa1369be990aa3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ie5e90b3c834a1154ec49dc765a5031f6bdd35923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20tdf#128814 Make Writer Navigator context menus content specificJim Raykowski
Remove content type submenus and place submenu items in root menu Display Outline Level in Outline context menu only. Add Delete/Promote/Demote Chapter and Promote/Demote Level to Outline context menu. Add Rename... to Drawing Objects context menu. Change-Id: I39327d0ed02ab1ee88361e2d6a140ad118e069d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87053 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-20sw: fix assert in ToX update on mw00_table_of_contents_templates.docMichael Stahl
... exported to RTF and re-imported: soffice.bin: sw/source/core/txtnode/thints.cxx:1295: bool SwTextNode::InsertHint(SwTextAttr*, SetAttrMode): Assertion `!pAttr->GetEnd() || (*pAttr->GetEnd() <= Len())' failed. The problem is that the text of a HandledTextToken is all whitespace and a hint from 0 to 1 is inserted because mNewPositions.back() is erroneously 1, no idea why it was doing that. (regression from e5345f62bf525b6258736f1ce11a61b5e638e0ff) Change-Id: I6ec290abe50c0f65a3244f0f0bb07e19741e878b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86996 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-20sw: prefix members of SwEndNoteInfo and SwFootnoteInfoMiklos Vajna
Change-Id: Ie952701e6cb65cb0d5789b4f98005872286a41ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-20Simplify getting ISO 8601 date stringMike Kaganski
Change-Id: If381276990199e4459787ffea090f342241237f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87037 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-19tdf#128290 add tblLayout element to docx exportLouis Meyrat
This will disable the automatic table width feature of MS Word, which does not exist in LO. Now, tables in LO-generated docx have the same column width in MS Word Change-Id: I955c8e5667376475e7c41e3b74d88e3513fec561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86671 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-18tdf#129423: Make export tests export-only where applicableKemal Ayhan
Change-Id: I90e9c8e199ae0e7d6e8f63b3f425847b3f5779d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86574 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-18tdf#130066: reset calendar to today for word completionMike Kaganski
Change-Id: I8a9c34fb0ae9174cace0df25b6b233ae3e0a3af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87008 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2020-01-18do not reuse common PCH if switching to Objective C++Luboš Luňák
In those cases gbuild detects flags mismatch between the PCH and the source files (-x objective-c++ -fobjc-exceptions). Change-Id: I88d456f59f95afaf60e252e07151ece6667ed51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87016 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-18Fix typo in codeAndrea Gelmini
Change-Id: Ic464f818204af4d5e0d6d1a0b1c29cac620f6250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86588 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17Resolves: tdf#130045 dial control frame not hidden along with the controlCaolán McNamara
Change-Id: Idcdf3d748849fbe1ba1a6cce278373e349ba1e5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17can restore this test againCaolán McNamara
Change-Id: I82f5e8f9ce88d5662d391b0635dfc91b25d6126a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17limit table spinbuttons width for sidebarCaolán McNamara
to the same width as the paragraph sidebar spinbuttons Change-Id: I980545b4186b25cb5ada473095ece8c77f99420a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17ofz#20169 Integer-overflowCaolán McNamara
runtime error: signed integer overflow: -2147478239 * 127 cannot be represented in type 'int' 72 points in an inch, TWentyInPoint TWIPs in a point, 1440 twips in an inch, 25.4 mm in an inch Change-Id: I4ea1c524cd9a16ab6e58ccf2a19fb8e41d68ffe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86955 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17show degree symbol in DialControl linked spinbuttonsCaolán McNamara
Change-Id: I792755f043109173606a78e947d5dc01f78c6849 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#126795 docx export and TabsRelativeToIndent: added unit testSerge Krot
Change-Id: I233a40133392757978b27666853a1fcef2e00a07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86878 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-17Clean up duplicated command dispatch test functionalityMiklos Vajna
Used in both Writer and Calc at 5 different places, so host it in unotest/. Change-Id: I013e6df471deb8693cf4ae62f0958b12e16fda7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86972 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-17weld SvxFrameWindow_ImplCaolán McNamara
which makes .uno:SetBorderStyle in sidebartableedit work again Change-Id: I51faa21530171a47ee78863ddb312e1d9996326c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#129924 critical fix: use SvxColorItem instead of SvxBrushItemSerge Krot
Change-Id: I09b1e9fe53315974864c8d6947c7cb861f069a68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86953 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17tdf#129888 DOCX shape import: handle o:allowincellBakos Attila
(VML) and layoutInCell (DrawingML) attributes to fix regressions caused by commit 10f29d8bf05d44ca8bc11d34d1294ec17f8ac0f1 (tdf#87569 tdf#109411 DOCX import: fix shape anchor in tables). Position of shapes anchored to tables is calculated from the cell margin only if the previous attributes allow that. Change-Id: Ifcfcb7f4959aea522dd45dff00cefd1bb9f4edda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86922 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-17tdf#88496 DOCX: disable long repeating table headerLászló Németh
if the pages could contain only that, hiding the non-repeating table rows. This behavior is similar to MSO. See also commit 110781a3a27dffe9e6690839bdce993796a08331 (tdf#58944 DOCX import: workaround for hidden table headers). Change-Id: I646be45c6d2c5fe9e1df0badeee4583097dc79f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86928 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-17sw reqif-xhtml export: fix not needed font name/sizeMiklos Vajna
The only reason commit 4cd3c436923bfba281b1bf16d9785208a2119cea (sw reqif-xhtml export: limit values of the style attribute, 2018-04-11) missed these is because they write their css properties directly, not going via SwHTMLWriter::OutCSS1_Property(). Also adapt testReqIfWellFormed: its intention was to make sure that in case these properties are written, then inline CSS is used: that is true for XHTML, but not for ReqIF-XHTML. Change-Id: I4ceb2bb09187101baa6f4a74d65aaa4dc955511f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86962 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-17sw reqif-xhtml export: fix not needed namespace for commentsMiklos Vajna
In general, all "foo" elements should be started as "<reqif-xhtml:foo" in the reqif case, but not for comments, which stay as "<!--". Change-Id: I841c0d8e448f670b9b42cb915154e6264f7f150a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86952 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-17flush out unused Font objectsCaolán McNamara
Change-Id: Ifd6379b2cb6e5945ff509be8dc61c61bd70724c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16FirstLeft and FirstMaster not handled in CreateParentXTextBjoern Kirchhoff
FirstLeft and FirstMaster were not taken into account in CreateParentXText. Code calling getAnchor().getText().toString() on text fields failed, when they where contained in footers/headers of first left or first right pages. These cases are now implemented. Change-Id: I7fbe9eb95a3fa0d90ebd8432b8a315d186da6f64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86869 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-16drop some unneeded includesCaolán McNamara
Change-Id: I312acdd1e893e24c78df76d663e306ba6aa54cd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86920 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16sw: replace hardcoded CH_TXTATR_BREAKWORDMichael Stahl
Change-Id: I5828fa3de469b65ed84a2a00c65f309de7d54f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86861 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-16return nullptr from Create*Context methods in nullptr subclassesNoel Grandin
the calling class handles this nicely, and also tells us when we are not handling some part of the XML file Change-Id: Ic51a42b9d2dec96243e7f83b528d7455d4bc0504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86906 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-16rename a createPopupWindow so we can remove 'using createPopupWindow'Caolán McNamara
Change-Id: I6e24d3f796b4b958513166ba2fd9e63239729375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86886 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16can replace SwNavHelpToolBox with basic ToolBox nowCaolán McNamara
Change-Id: Ifcbba2b306e5c89fa970aa101df85d1b259c608d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86885 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16merge the two things listening to FN_NAV_ELEMENTCaolán McNamara
Change-Id: Ie9a36ca1eb8ec6b9cea4b1da3381e53443441696 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16m_xDialog field now unusedCaolán McNamara
Change-Id: Ic909d6b0102a9e276da2ea8efe86c20cf1aa01cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16listen to FN_NAV_ELEMENTCaolán McNamara
and update based on that broadcast Change-Id: Ide11751dcb7bd53a956df499799fe4a60ce09d65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86880 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16tdf#42949 Fix IWYU warnings in sw/source/uibase/[u-w]*/*cxxGabor Kelemen
Also backtrack a bit and introduce several fw declarations in sw/inc/hintids.hxx to get rid of TypedWhichId -based blacklist entries Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8487737f5c3327c24b105328e84661d409f381c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86873 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-16fix use of FastParser in SwXMLTextBlockImportNoel Grandin
need to override startFastElement or SvXMLImport will fall back to trying the non-fastparser stuff Change-Id: Ia38e62d529391e490807d77dd265c69beb2d8476 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15tdf#129924 docx import: set background colorSerge Krot
Change-Id: If586a7a11e375c1592253630af87772bca40b52e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86542 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-01-29 15:17:01 +0000