summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-11-17tdf#128820: improve unit test to not depend on opening bad file failingMike Kaganski
... also test exported XML directly Change-Id: I50237593dd111e7c7974452769c8d49c22012713 Reviewed-on: https://gerrit.libreoffice.org/83005 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16Also consider saved exceptions when terminating parseMike Kaganski
As with previous commit 18ae77a065cb8ae6940d4067f6ab7e99a3f74047, this will start showing parse errors on invalid files which previously just opened without warnings, silently losing the invalid stream part. Any bug bisected to this commit is not a regression from this commit! The real problem was already before, and was just disclosed by this (which is the actual goal). Also simplify unit test data for tdf#128820, which will now be enough after the change. A unit test (testN779627) revealed unexpected throws when parsing; this was fixed. Change-Id: I5a21b9001874ec6e3b8273c10043ef930bf1cc82 Reviewed-on: https://gerrit.libreoffice.org/82981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16sw: RTF export: only enable \formprot if there is actually a sectionMichael Stahl
... that is protected; Writer can also protect the content of text frames, which doesn't(?) appear to be possible in Word. Form protection has annoying side effects like disabling field UI for the whole document, even inside sections that are unprotected via \sectunlocked1. Change-Id: I2bf9503202779f5cb7c6e27ea7f533b2e3acb9d2 Reviewed-on: https://gerrit.libreoffice.org/82804 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-16cid#1448525 Dereference null return valueCaolán McNamara
Change-Id: I0dae9e73e85cef74f041535f3787e3afb45bb94d Reviewed-on: https://gerrit.libreoffice.org/82989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16tdf#128820: use wps namespace for simple text shapesMike Kaganski
Without that, simple text shapes inside groups were written in <pic:wsp> elements, with many child elements also having pic:: prefix. Change-Id: I114cf3499e03aa5ca042211d7b134aaf5b0e7fbf Reviewed-on: https://gerrit.libreoffice.org/82980 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16Simplify sequence initializationMike Kaganski
Change-Id: I332cf55883bab679c395b9643d54e558ce0c1c64 Reviewed-on: https://gerrit.libreoffice.org/82974 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16Replace some std::once with static initializersMike Kaganski
Change-Id: I6234bc252dac5b1c29e3f1ef844cf51f56aaa7ac Reviewed-on: https://gerrit.libreoffice.org/82970 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16no need to construct a parser in SwXMLSectionListNoel Grandin
the SvXMLImport superclass already constructs a parser Change-Id: I6ff53caf4329da439b590e4b581d2ece92d8f96d Reviewed-on: https://gerrit.libreoffice.org/82796 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-15no need to construct a parser in ImportStoredChapterNumberingRulesNoel Grandin
the SvXMLImport superclass already constructs a parser Change-Id: Ie99ccc4988d1daeb39e5e06ac0682f19648f3a6f Reviewed-on: https://gerrit.libreoffice.org/82788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-15tdf#128736 sw ContinuousEndnotes: fix use-after-free on text frame joinMiklos Vajna
Regression from commit 61cf196631a2a846e0d3b8b83c0805cf4d1d14b2 (sw ContinuousEndnotes: fix moving them to the previous page, 2019-10-25), the problem was that the SwFootnoteFrame::mpReference was not updated on frame split. This meant that by the time the frame was joined, SwTextFrame::JoinFrame() thought that the follow has no footnotes, so the footnote reference was not updated, resulting in a dangling pointer. Fix the problem by going back to using bEnd for endnotes (both the Word compat and the normal case), this means that SwTextFrame::ConnectFootnote() will invoke SwFootnoteBossFrame::ChangeFootnoteRef(), fixing the dangling pointer. Then fix the original problem differently: similar to the in-section endnotes, just remove + append them, this makes sure that the endnotes (in the Word compat case) move to a previous page on page delete. Change-Id: Ia1b8e54b4a0b0f385c703f8e7016011c3ac57a03 Reviewed-on: https://gerrit.libreoffice.org/82778 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-15tdf#128752 DOCX: fix partial direct paragraph spacing in tablesLászló Németh
When direct formatting of a table paragraph set only top margin, but not the bottom margin, also there was no paragraph style setting for the bottom margin, the paragraph was imported using docDefault bottom spacing instead of the table style bottom spacing. Change-Id: Ib7f5f80dd2485a0fd4ab8e0645b7d730a7ec3c5c Reviewed-on: https://gerrit.libreoffice.org/82771 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-15sw: WW8 import: instead of control character insert '?' for footnoteMichael Stahl
SwWW8ImplReader::ReadChar() inserts a U+0002 control character to temporarily mark a footnote anchor; this is then deleted and replaced with a real footnote hint by SwWW8ImplReader::End_Footnote(). The assumption is that it is necessary to insert a placeholder character to be able to apply formatting to it. But if the document is corrupted, the control character could survive the import, which sounds less than ideal. So either make this magic character more explicit by documenting it in hintids.hxx and removing any outstanding ones at the end of the import, or use a non-offensive character instead; since this should only affect invalid documents, choose the solution with the least effort. Change-Id: I76d396258b32e0f0fb6393942a58a4dc57912211 Reviewed-on: https://gerrit.libreoffice.org/82723 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15ofz#18526 sw: WW8 import: don't insert control charactersMichael Stahl
Sanitize string before calling InsertString(). This segfaults since: commit b522fc0646915d4da94df38dd249c88b28f25be7 Date: Tue Sep 24 18:11:45 2019 +0200 sw: maintain fieldmarks in DeleteRange()/DeleteAndJoin()/ReplaceRange() Change-Id: I9ef73d924420686f6838fa21900ec57b4d25c905 Reviewed-on: https://gerrit.libreoffice.org/81949 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15tdf#128700 ww8import: no relative width table if made into a flyJustin Luth
This is a partial revert for LO 6.0's bug 55528 commit e69473539a33da5450d3878999eba7f9bfb9e631 Apparently Word tables can float without a frame, but in LO they need to wrapped in a frame? The relative size is supposed to be relative to the container they are in - so floated tables must not be assigned a relative value - otherwise the tablesize becomes relative to the custom frame that was created to float it. The fix was easy to make, but then trying to figure out whether to test using InLocalApo(), or just m_xSFlyPara took a lot of time. The documentation is sparse and unclear. In the end I settled on ignoring relative width if pFlyFormat exists, since certain conditions can cancel (bNoFly) a FloatingTableConversion. I tested what happens if a real frame is created and then a relatively sized table is dropped inside. I confirmed that relative SHOULD be relative to the frame. That case still works fine since it isn't considered an x_sFlyPara - I think because it actually is a textbox that the table is anchored onto. LO round-trips frame/table as textbox/table. Conclusion: tables inside of frames/textboxes MAY be relative, but if the table itself is floating (a WORD-ONLY feature) then it should not be relatively sized. Change-Id: I2b0bd525051a33b5606b79d2b26665d3edeb5357 Reviewed-on: https://gerrit.libreoffice.org/82647 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-15make some classes module-privateNoel Grandin
Change-Id: I95845d7217fc5e77e3f8e205030e9cd761ad0cc5 Reviewed-on: https://gerrit.libreoffice.org/82116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-14jsdialogs: fix CID 1455691 & CID 1455690Szymon Kłos
Change-Id: Idbb3e70c1a09be7dd7c43747250f3a6368251cd9 Reviewed-on: https://gerrit.libreoffice.org/82662 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-14sw: RTF export: fix invalid RTF for shapes and text framesMichael Stahl
RtfAttributeOutput::OutputFlyFrame_Impl() writes SdrObject into m_aRunText buffer, but for a text frame it writes directly into m_rExport.Strm(), also writing m_aRunText into it in the middle. So if you have both SdrObject and text frame at the same anchor position, first the shape goes into the buffer and then the first part of the text frame is written to the stream before it and the last part after it, and we get this: sw/source/filter/ww8/rtfattributeoutput.cxx:1886: m_aRunText is not empty And Word refuses to open the file with a funny error message about running out of memory. Reportedly this is a regression from commit d53dd70b15f0e3f7c8a05a93f8fcd70e1147c1f7 but really it was broken already in commit a8b59ef5951fe76b0b733ecef739173c1d104f6f. Change-Id: If01465dee71b63531b46c39dd557066f804c425d Reviewed-on: https://gerrit.libreoffice.org/82702 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-11-14tdf#42949 Fix IWYU warnings in sw/source/core/[e-l]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I173b3aaca84a707799f0ee78cddcbd70524897bc Reviewed-on: https://gerrit.libreoffice.org/82561 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-14Removed duplicated includeAndrea Gelmini
Change-Id: I294c0f2092e0274839b7294be50efc00a13231fd Reviewed-on: https://gerrit.libreoffice.org/82465 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-13tdf#128776 Writer: fix Ctrl + drag and drop table copyLászló Németh
Regression from the commit 7fe64353dc9950e19182a59a486a1ecac27cf98e (tdf#84806 Writer: drag and drop selected tables, don't empty). Change-Id: I9061b80dd8fab29aa5ec74655dc6c3f7686a91ee Reviewed-on: https://gerrit.libreoffice.org/82579 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-13add uitest for bug tdf#126627Zdeněk Crhonek
Change-Id: I115e014cafb9c4a85558567ccd6cd2987cabdfd6 Reviewed-on: https://gerrit.libreoffice.org/82483 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-13Add document level option to lock down edit doc commandSerge Krot
Change-Id: I431fa4cd0daa52c885030dbadcc4052b5a890d34 Reviewed-on: https://gerrit.libreoffice.org/82553 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-on: https://gerrit.libreoffice.org/82576 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-13tdf#95374 DOCX import: reset left indentation at disabled numberingLászló Németh
Paragraphs with disabled numbering using non-existent numId=0 haven't got inherited left indentation in MSO. Keeping them resulted unnecessary indentation, moreover, missing (non-visible) text in narrow table cells. Change-Id: I46003031d36f578b0b260dea74d7d45e75905261 Reviewed-on: https://gerrit.libreoffice.org/82509 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-13tdf#127925 DOCX export: fix visited hyperlink styleTünde Tóth
Custom visited hyperlink style reset to default in Word. Change-Id: I6a36c900788bb17d4f31c60048cf65960490a46b Reviewed-on: https://gerrit.libreoffice.org/80043 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-13no need to store reference to Import hereNoel Grandin
can just cast the parent member Change-Id: I990bd4da3afbd78da819038c7907c28de87faaaf Reviewed-on: https://gerrit.libreoffice.org/82567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-13jsdialogs: send table row/column size updatesSzymon Kłos
Change-Id: I1b41fe50e93dc14db60c7548a1ae0c54113da329 Reviewed-on: https://gerrit.libreoffice.org/82542 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-13table properties dialog should be modalCaolán McNamara
Change-Id: I3787f6e3a326c1f8e93fc966f890ea2c7cdacc29 Reviewed-on: https://gerrit.libreoffice.org/82549 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-13Fix OSL_ENSURE in DocumentListItemsManager::addListItem (sw)Julien Nabet
was wrong since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 Here's the root cause: const bool bAlreadyInserted( - mpListItemsList->find( &rNodeNum ) != mpListItemsList->end() ); + mpListItemsList->insert( &rNodeNum ).second ); OSL_ENSURE( !bAlreadyInserted, "<DocumentListItemsManager::addListItem(..)> - <SwNodeNum> instance already registered as numbered item!" ); - if ( !bAlreadyInserted ) - { - mpListItemsList->insert( &rNodeNum ); - } Change-Id: I0cc5786a18fe2df5fd86284c18638de90604edf9 Reviewed-on: https://gerrit.libreoffice.org/82560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-13sw: avoid partial expansion of bookmark over new fieldmarkMichael Stahl
The comment that was added with commit 71f13a801608538f56a0cb2bce07a03faa5856f6 "#i29942# SwTxtNode::Update for bookmarks fixed. Bookmarks no longer grow on either side." suggests not to expand bookmarks in any case but in case the start and end position was the same, the start position was still moved so the mark expanded anyway. Unfortunately meanwhile commit c91024891ff10c2ae01e11a28a9aecca2f36b6c3 "tdf#96479 workaround bookmark end pos handling when inserting text into a text node." added a requirement that bookmarks with start==end *are* expanded. For the case where a new field is inserted, shortcut the insertion to do only one InsertString call so that any expansion of bookmarks will expand it over the entire field, not just its CH_TXT_ATR_FIELDSTART. Change-Id: If2608c9cf34a217330156e7ea566dcf528890c45 Reviewed-on: https://gerrit.libreoffice.org/82521 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-12Options Writer General Tab updateandreas kainz
Change-Id: I8397452eae8eaf83e5f928f96f30269fc70e46b1 Reviewed-on: https://gerrit.libreoffice.org/82534 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Mailmerge Dialog updateandreas kainz
Change-Id: I160fb9e5afdf10f64bcd7422e5c4198fe8bb538d Reviewed-on: https://gerrit.libreoffice.org/82480 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Writer AutoCaption Tab updateandreas kainz
Change-Id: I189dad65e35c7947a9479885d22d066c05c25f8a Reviewed-on: https://gerrit.libreoffice.org/82538 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Writer Print Tab updateandreas kainz
Change-Id: I8a7dc4324890a69dacd271e0a689018d87e13f5a Reviewed-on: https://gerrit.libreoffice.org/82537 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Resolves: tdf#128746 crash in table properties dialogCaolán McNamara
Change-Id: I3d7d49cc225afc0dee542205690d56643a0c2e64 Reviewed-on: https://gerrit.libreoffice.org/82532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12jsdialogs: send .uno:ULSpacing updatesSzymon Kłos
Change-Id: I061868a0cf9163624026dc1ff164af3d98923aa6 Reviewed-on: https://gerrit.libreoffice.org/82531 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-12jsdialogs: send .uno:LeftRightParaMargin updatesSzymon Kłos
Change-Id: I22aef6ac57c94893bf2e73ea2901ed8bc074076e Reviewed-on: https://gerrit.libreoffice.org/82501 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit c6cf2bec7148e403e2ee9592b4410cc73bad8f46) Reviewed-on: https://gerrit.libreoffice.org/82506 Tested-by: Jenkins
2019-11-12use std::move when popping stuff off stacksNoel Grandin
Change-Id: I6ba0ee8afee1a9579045643cd0118cf19599d5b9 Reviewed-on: https://gerrit.libreoffice.org/82497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-12tdf#121239 give writer, calc and draw/impress the same underline optionsCaolán McNamara
uno:Underline is the "real" deal, and has multiple underline options uno:UnderlineSimple is "some underline on" vs no underline calc and writer had UnderlineSingle, UnderlineDouble and UnderlineDotted for that specific type of underline on vs not-on add those to draw/impress too and then use UnderlineSingle instead of Underline in the format menu so that when UnderlineDouble is applied, UnderlineSingle is not show as applied, instead of using Underline ot UnderlineSimple which would show as on if UnderlineDouble was applied Change-Id: I6f9fcf37c2c90d215ea52b536e4fa84734754850 Reviewed-on: https://gerrit.libreoffice.org/82469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11add uitest for bug tdf#128593Zdeněk Crhonek
Change-Id: Icc0b22318406a92cf19843844e857d09dd9a4ba2 Reviewed-on: https://gerrit.libreoffice.org/82466 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-11tdf#109219 MM: Decode all percent encodings in file namesMichael Weghorn
While decoding using 'INetURLObject::DecodeMechanism::Unambiguous' as introduced by commit 47708d533e1325032df55eb667ef0c47fa05e7e5 ("tdf#109219 Allow files with spaces in name as MM data source") makes sure that e.g. spaces in file names are properly decoded, 'INetURLObject::DecodeMechanism::WithCharset' is actually the more correct decoding mechanism to use here, since it also decodes some percentage encodings that 'INetURLObject::DecodeMechanism::Unambiguous' would leave unchanged. Using 'INetURLObject::DecodeMechanism::WithCharset' instead e.g. makes CSV files with '%' characters in their names work as data sources for mail merge as well. A big thanks to Stephan Bergmann for pointing this out in https://gerrit.libreoffice.org/#/c/82201/ . Change-Id: Iee50584299c82d5718e3210f048ed739818bd11b Reviewed-on: https://gerrit.libreoffice.org/82428 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-11jsdialogs: apply .uno:Color and CharBackColor to floating text framesSzymon Kłos
Change-Id: I1a6b997f1a857524c7a48434321ca10d97f5e5db Reviewed-on: https://gerrit.libreoffice.org/82311 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82317 Tested-by: Jenkins
2019-11-11Removed executable permission on fileAndrea Gelmini
Change-Id: I45174811c8e1ef80ddae97f206f2a5459540849f Reviewed-on: https://gerrit.libreoffice.org/82427 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-11tdf#127921 Revert mouse/key listeners to original stateSamuel Mehrbrodt
The changes caused several issues in the presenter console (mouse events delivered to wrong widgets). Also it turned up that parent windows got the notification about mouse events from their children, but the position was always relative to the top widget, so very unhelpful for the parent widgets. Also I found out that there are XKeyHandler and XMouseClickHandler interfaces which already do what I tried to do with the below commits (events get passed down to parent widgets, and they even can be marked as consumed). So the original issue reported can be fixed by using XKeyHandler/XMouseClickHandler instead. This reverts the following two commits: * "Related tdf#122920 Treat UNO key events the same as mouse events" 9e0e97b716ab074d4558c76a62a66bf597f332a5 * "tdf#122920 Send UNO mouse events to parent window listeners as well" 6f43902b12dd36fa2b69401065df198ef9ffdb09 Change-Id: I005d22770a7a4db9588c5bc22197dc0ae526627e Reviewed-on: https://gerrit.libreoffice.org/82423 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-11tdf#128428 RTF: clean-up for longer space sequence modeLászló Németh
Fix regressions from commit 24b04db5a63b57a74e58a7616091437ad68548ac (tdf#123703 RTF import: fix length of space character sequence). It seems, longer space sequence is an obsolete RTF-only feature, eg. new RTF documents created in MSO don't use it, but old RTF documents still keep their layout (only in RTF). - Only old-style (without \stshfdbch) or compatible (\stshfdbch31505) RTF documents get longer space sequences using a one-time conversion; - because Writer always exports old-style RTF documents, to avoid of enlargement of space sequences of new-style RTF documents later, RTF import doesn't modify the RTF documents saved in Writer (checking \generator); - text in monospaced font "Courier New" doesn't get longer space sequence (despite its \prq2 (not monospaced) font setting). Change-Id: I308ab06db57a2db5deec1d4c4573da3317cad8e9 Reviewed-on: https://gerrit.libreoffice.org/82145 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-11tdf#127579 DOCX export: fix losing color and underline of ODT hyperlinksTünde Tóth
using "InternetLink" in hyperlink/r/rPr/rStyle instead of the actual character style, and keep actual character formatting in hyperlink/r/rPr/rFonts, like MSO does. Change-Id: I13a5e1758ec5b96e647ca77736396ee2f8b22814 Reviewed-on: https://gerrit.libreoffice.org/80868 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-11tdf#128375 sw: fix copying RES_PARATR_LIST_AUTOFMT to different SwDocMichael Stahl
When copying the item to a different SwDoc, the items in the nested SfxItemSet must be copied into the target SwDoc's item pool, or a use-after-free is inevitable. (regression from 5ba30f588d6e41a13d68b1461345fca7a7ca61ac) Change-Id: I7071ff6dccf2285d96f540ac556b9fa2265ddf00 Reviewed-on: https://gerrit.libreoffice.org/81911 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-11tdf#124986: docx: remove trailing quotation marks and spaces from set fieldsbrinzing
Change-Id: I6390344b72b0148cff8e0ed5150d7abfc9490a2a Reviewed-on: https://gerrit.libreoffice.org/81892 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-11Resolves tdf#128521 - illegal char in a bookmark nameHeiko Tietze
Message box removed and warning label introduced Some alignment and accessibility issues solved too Change-Id: Icc88d489268403fa3da525aadc1c007c589fa019 Reviewed-on: https://gerrit.libreoffice.org/82231 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-11sw: prefix members of SwTableColumnPageMiklos Vajna
See tdf#94879 for motivation. Change-Id: I7337775a62709cff0d4cb54da3229353c246083a Reviewed-on: https://gerrit.libreoffice.org/82415 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-03 02:06:40 +0000