summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2022-05-06tdf#148920 sw page-style UI: make conditional filter usableJustin Luth
In windows, and SAL_USE_VCLPLUGIN=gen ./instdir/program/soffice the style filter on the conditional tab was disabled. It worked fine in gtk3 though. This fixes a 7.2 regression from tdf#82802's commit 1f066313218449cac494a887eb209311efbaa405 Change-Id: I1e6bb8d589224e4ad51ae0057d5278e3888cc3b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133910 Tested-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-05-05loplugin:unusedvariableplusNoel Grandin
Change-Id: Id93086be1224b6f6bf0bdaa1d50b4f289099027e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133876 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05use more o3tl::getTokenNoel Grandin
found by inspecting call sites of OUString::getToken Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05Just use Any ctor instead of makeAny (Linux, sequel)Stephan Bergmann
Change-Id: Idcf537a838bb0e47cfa31db8bc09e477b277ee37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05sw content controls, drop-down: show list items on clickMiklos Vajna
- add a generic SwContentControlButton, to be used for dropdowns, but meant to be useful for other types in the future (e.g. date picker) - add a contentcontroldropdown .ui file for the welded list items - add a SwDropDownContentControlButton, which contains the drop-down-specific logic - invoke content control button from HighlightContentControl(), so list items are shown on button click Change-Id: Ib3c6765020c5b3b1dd343a40a2b1862c73feaac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133874 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-05use more string_viewNoel Grandin
found by examining the call sites of OString::getToken which means I needed to add a new o3tl::equalsAscii function Change-Id: I7dc0ea1cf5ce8090a708d44f2cf7c938fa200c5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05tdf#148299 Don't unmotivatedly mess with spaces in file namesStephan Bergmann
This conversion of double to single spaces had been done ever since 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import", but it is unclear to me why. The same conversion functionality is also used at two places in sw/source/ui/dialog/uiregionsw.cxx. Not sure if it has any motivation there, so lets keep that intact for now. Change-Id: I0558f015c53f69a9a405891b9dad21a98de3533c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133841 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05T no more...Olivier Hallot
Change-Id: Ide06d5b57ddc203f5877b1f8ea8309234da7fca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133854 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-05-04Just use Any ctor instead of makeAny (macOS)Stephan Bergmann
Change-Id: I6c185eecf943205f78567393f0ef588580ee4dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133821 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04tdf#146346 DOCX import: fix table margins in footnotesLászló Németh
Paragraph of the anchoring point of the floating table needs zero top and bottom margins, if the table was a not floating table in the footnote originally, otherwise docDefault (Standard) margins could result bigger vertical spaces around the table. Quasi regression from commit c46950fee11f5207fb8324947280cd565ae483e7 "tdf#143583 DOCX import: fix lost empty paragraphs of footnotes" (before this commit, empty paragraphs at the end of the footnotes were removed by accident, which hid the real problem fixed now). See also commit e11c51eefe8c3210cef2b5850f401ba67a401d01 "tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes" (Note: before this commit, only a single table was shown instead of the eight tables of the eight footnotes.) Change-Id: I4180a6f7d7c49faf0842637b23aa1c8c5680a76c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133752 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-04tdf#131725 use first page directionality for x-reference dialog TreeViewCaolán McNamara
Change-Id: Ib827f4e73266f6416ba8459214263545291c4727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133779 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-04use more string_view in unotoolsNoel Grandin
Change-Id: Id10d68f2eb016671be6842dfaa82909207b0708d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-04sw content controls: enable indicator on the RHS of the content control endMiklos Vajna
To be consistent with the SwTextContentControl ctor, which calls SetDontExpand(false). This way typing expands the content control exactly when the indicator is visible. Change-Id: I44dc3e0a68643bc670b75da21110914e5c4f8f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133801 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-04CppunitTest_sw_ooxmlexport11: avoid mustTestImportOf()Miklos Vajna
Can use CPPUNIT_TEST_FIXTURE() instead. See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I104989efd62758f5da862b95a4d9bbcac536b46f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133773 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-04related tdf#148312 Don't search for hyperlinks in ToxContent to trackJim Raykowski
Hyperlinks in ToxContent aren't included in the Navigator content tree Hyperlinks members list. This patch saves some cycles by not searching through the Hyperlinks members list when the hyperlink is in ToxContent. Change-Id: Icc332748f37dee02f0bc5f6fc0500fed51dd1182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133669 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-03Just use Any ctor instead of makeAny in swStephan Bergmann
Change-Id: I2c9023ba8d07314d23ae7a65e670e8748c5e9322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133766 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-03add o3tl::matchIgnoreAsciiCaseNoel Grandin
Change-Id: Iad8e1ed256d84808404bf20ed7a16b05b3db5818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-03sw content controls, drop-down: add doc model & UNO APIMiklos Vajna
Add a new property, which is a list of display-text / value pairs. If the list is non-empty, that implies that the type is a dropdown. This should be enough for the UI to be able to provide a list of choices & update dropdown state on click. Note that in contrast to dropdown field-marks, here each entry has a user-readable string and a machine-readable value. Fieldmarks only had a single value. Change-Id: I22b9f554e2e1a9e84cc7eb7e17772ea1a5775316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133742 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-03sw: document SwTOXMgrMiklos Vajna
Unlike most other managers, this is now owned by SwDoc: this can be created on the stack when there is a need for it. Then it can do its work and safe to delete when no longer needed. Change-Id: Ief2e8c1172602edada36d330a652f8fe51fc8be2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133710 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-03add o3tl::equalsAsciiNoel Grandin
Change-Id: I042b8dcadbf7581de325c161763fe35aecde5ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-03Revert "enable test for all platforms"Stephan Bergmann
This reverts commit b294a94861289c322a26edb6b83f0d329575639d, which keeps failing frequently for Gerrit Jenkins Windows builds now, e.g., <https://ci.libreoffice.org/job/gerrit_windows/125864/> C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows@2/sw/qa/extras/layout/layout2.cxx:1950:testTdf124261::TestBody equality assertion failed - Expected: 1721 - Actual : 3472 Change-Id: I681274df98f2246312539ba5d0dfcde7e7ba4826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133718 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-02tdf#146573 sw: recalculate cells with footnotesLászló Németh
Commit 915d3eebc1dc4f18d7a1992db801ee8313ee46c0 "tdf#39828 sw: fix table formula calculation at track changes" allowed to use footnotes in value cells unintentionally. The only problem was that modifying cells with footnotes didn't trigger formula recalculation in text tables, according to the incomplete SwTableBox::IsValidNumTextNd(). Instead of asking formula recalculation pressing F9, now IsValidNumTextNd was extended to skip footnotes, similar to the already skipped comments. Also clean-up to testTdf39828 (remove copy-paste code), and clean-up to commit 915d3eebc1dc4f18d7a1992db801ee8313ee46c0 "tdf#39828 sw: fix table formula calculation at track changes" to avoid of unnecessary calls of GetRedlineText(), which is an expensive call, especially when there are a lot of redlines with overlapping (see commit d467cd0dd9e9cf3b018859a592e2638527bc7add "tdf#135683 speedup DocumentRedlineManager::GetRedlinePos"). Change-Id: I00243ef0985805414723e26fe26d6e9c04ce86cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133579 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-02sw: avoid one more EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli
Seen in https://crashreport.libreoffice.org/stats/signature/SwTextFrame::PaintExtraData(SwRect%20const%20&) Change-Id: Ie6924254dca73360d384987834460a6f813e0d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-02sw content controls, checkbox: add insert UIMiklos Vajna
- extend SwWrtShell::InsertContentControl() to be able to create multiple content control types - a new checkbox content control's content is always a non-checked checkbox - expose this as a new .uno:InsertCheckboxContentControl uno command - add this new command to the bottom of the form menu -- now that we have two types of content controls, have that in a sub-menu Change-Id: I058659600b3face69b89262feb0979fff32521c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133685 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-02enable test for all platformsCaolán McNamara
Change-Id: I9af29ee1601093a2cce342e6bb8f4274f946a444 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-02move layout-dependent test to explicit layout cppunit targetCaolán McNamara
Change-Id: If1d4c6047df5a69b5cf8f9e9a970c1ecad754ce5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-02sw: prefix members of WW8_WrPlcPn, WW8_WrPlcSepx, WW8_WrPlcSubDoc and ...Miklos Vajna
... WW8_WrPlcTextBoxes See tdf#94879 for motivation. Change-Id: Id2cae0dcb328ff319607a29489231a54ad26c132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133682 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-01abort more writer layout tests if a font isn't foundCaolán McNamara
Change-Id: I4d94b60531505f2d5a493b4c51f4c9110d3a4517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-01abort writer layout tests if a font isn't foundCaolán McNamara
if (the default) of --with-fonts is enabled then additionally restrict fontconfig to those "application" fonts so the linux ci can be used to safeguard that font and glyph fallback isn't in operation during the layout tests Change-Id: Ic7fc705827c8177b8367cf41f55cdd8ae002c1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-30split comphelper::string::strip functions into String and view versionNoel Grandin
which is more obvious, from the perspective of the caller, and lets us avoid creating a new String if nothing needs to be stripped Change-Id: I66a980eaf4aa818251bec49bdb16c2dddb0745e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-30Fix typoAndrea Gelmini
Change-Id: If93c80f5c4c9d68aeeaf3c0b16d9ef234bcc6737 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133553 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2022-04-30Tw Cen MT Condensed->DejaVu Sans for repeatable layout testCaolán McNamara
Change-Id: Ibf51eeab079383b769a73ac55d6bcd22dd34d95c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133632 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-30Georgia->DejaVu Sans for repeatable layout testCaolán McNamara
Change-Id: I9d2c8023a8379178f85a8cad04ee47f7cd56e226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133631 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-30Century Gothic->DejaVu Sans for repeatable layout testCaolán McNamara
Change-Id: Ic1241247bc877a00aeaf18aa938bd8f7517c54da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133630 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-30sans-serif->DejaVu Sans for repeatable layout testCaolán McNamara
Change-Id: Icfd4fe6a728704276c720eed36361cdcf1b1c48b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-30Times->Liberation Serif for repeatable layout testCaolán McNamara
Change-Id: Iafe43e341463169a81fee0988c63b0a253374601 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133628 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-30Algerian->DejaVu Sans for repeatable layout testCaolán McNamara
Change-Id: I2efe14b4f96eaebed4e70db51c9140755d808b0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-30tdf#148432 in LTR UI override the navigator treeview direction for RTL docCaolán McNamara
based on the first page directionality Change-Id: Ifa1a67dd0db53afb125bcea29df83e776f9e65d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-30tdf#148718 Partial revert of commit 6fbc3de17cd9274dc3a09e1eeb914c45f7dfe140Seth Chaiklin
Put the "Heading" and "Heading 1.x" labels back Change-Id: I953622554c63c828f6c8353c8f3a0f5aafc61144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133488 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-29tdf#143569 SwNavigator: Make Headings entries from headings in framesJim Raykowski
be in document layout order, not alphabetical order Change-Id: I75328311a7ddbda1eb050135709da20fed5d054a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133359 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-04-29tdf#148683 sw: fix crash on deleting text with redlining enabled, but hiddenMiklos Vajna
Regression from commit 32902f66e7749b2d06d13f50416be5323a0c0ea9 (sw_redlinehide: make layout based Show/Hide mode the default, 2018-11-30), deleting some text in the middle of the paragraph with the bugdoc results in an assertion failure in the SwDrawTextInfo ctor. Normally this doesn't happen on text deletion as we already have a mechanism for truncating no longer needed lines in SwTextFrame::Format_(), though that only checks the length of the current line. Fix the problem by extending this mechanism to also check the remaining lines: if change tracking is on and the total of all line lengths is more than the string length of the text frame, then time to re-calculate. It seems this is not needed in practice when redlining is disabled, though we might want to enable this for the non-redline case as well in the future. Change-Id: Iede03e11daceb3c2b614a301e21560b075a60c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133620 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-29use "Rubik" from more_fonts instead of "System" for consistent layoutCaolán McNamara
using Rubik with trailing 0 because need to overwrite the binary fontname in the embedded wmf in this docx Change-Id: I0338d4876345b0ab13e13cc4609081b3299b981e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-29binary patch fontname from Open Sans to Carlito for repeatable layout testCaolán McNamara
Change-Id: I3b09bb193a0f507fe0a61b28458423be342101e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133615 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-29sw: avoid EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli
Seen in https://crashreport.libreoffice.org/stats/signature/SwBookmarkPortion::DoPaint(SwTextPaintInfo%20const%20&,rtl::OUString%20&,SwFont%20&,int%20&) Introduced by 4ce8120f1e53f7b81e653b01d141643013bc69ab "tdf#45589 sw: create and paint text portions for bookmarks" Change-Id: I7d025878164e1f97b86f9d129af9ba93e93b6ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133562 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-29Segoe UI->DejaVu Sans for repeatable writer layout testsCaolán McNamara
Change-Id: Id8a59b4dfca7a5075d44fab35c9e83c3d7d9321d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133585 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-29sw: ascii filter: tweak copying of numberingMichael Stahl
Add an env var to copy the numbering when selecting a whole paragraph. Change-Id: I4b9025a4a34070d6848b7788a0ca2b0b9ec01d73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133573 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-29tdf#126636 writerfilter: import USERNAME field as fixedJustin Luth
This depends on and mimics some of the fixes for tdf#148380. Microsoft Word doesn't immediately/automatically update field contents like LO does. Instead, the user needs to press F9 on each field. So, these USERNAME or USERINITIALS fields just show the when-last-updated text that was saved in the document instead of the actual current value of the field. Although LO doesn't have that ability, we can flag them as FIXED and achieve a very similar result. Doing so fixes this bug report which might be quite common since USERNAME might be mistaken for AUTHOR or LASTSAVEDBY by the user - since in practice they tend to be the same thing. We already did this for AUTHOR (which is extremely safe since that can never change). I almost hate to do it with this one because even this bug shows it is too often a case of mis-use, but that is the way it is, and this seems to be the best solution. Change-Id: I48dc6d45992aff740023e80f619b56ad01231782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133346 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-29Open Sans -> DejaVu Sans for repeatable layout in testCaolán McNamara
Change-Id: Ic349fb5a9f42244e7e3bd64f9674c4b07a12da87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-29Open Sans Light -> DejaVu Sans for repeatable layout in testCaolán McNamara
Change-Id: Ia519723347e581b90cabf88e21e048e33ba761da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-03 18:40:30 +0000