Age | Commit message (Collapse) | Author |
|
Change-Id: Ie4152d7736ae3f2ffdd3489cd7a444e5035d2422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143030
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
when possible
Fixes shape names without a number at the end of the name, having the
number 1 appended to the end of the name after cut and paste in the
same document.
When possible - because it might happen that a shape is inserted
after the cut operation and is given the same name as the cut shape
name. If so, when the shape is pasted into the same document it will
not have the same name as before it was cut.
Change-Id: I1d1ebc76d07d81da0286d1f0bb7d34ad973a43b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142983
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Old:
<SwTextAttr ptr="0x63e5db0" symbol="12SwTextFlyCnt" start="0" dont-expand="false" whichId="58" m_pAttr="0x63e57f0" which="fly content"/>
New:
<SwTextAttr ptr="0x5af3d70" symbol="12SwTextFlyCnt" start="0" dont-expand="false" whichId="58" m_pAttr="0x5a44ae0" which="fly content">
<SwFormatFlyCnt ptr="0x5a44ae0" text-attr="0x5af3d70" format="0x5af3bd0">
<SfxPoolItem whichId="58" typeName="14SwFormatFlyCnt"/>
</SwFormatFlyCnt>
</SwTextAttr>
Change-Id: Ie4f50d5ee065af920ac21a416f854ef7c7234707
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143031
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
it's already defined in include/tools/color.hxx
Change-Id: I26eaba4a1279fadd8669e9702b695e02871052d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142512
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
- The dialog needs to be async in order for multiple people to be able
to use it at once
- If we don't make the item set a shared pointer, we will crash out with
an error when we try to copy it after the OK button is pressed
- As the dialog is tabbed, we need to enable the dialog for all UI files
that the dialog uses rather than just the main dialog UI file
Change-Id: I8d684e9e9ad49b8a85ee940864d7219b4115a6e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138270
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142990
Tested-by: Jenkins
|
|
- In https://gerrit.libreoffice.org/c/core/+/138313, the insert caption
dialog was converted to an async jsdialog. It has 2 subdialogs which
it opens when you press the 'options' and 'auto' buttons
- This review converts the first of these (the options dialog) to an
async jsdialog as well, bringing it up to parity with the parent
dialog
Change-Id: I703b66d8c786d8cbb0b1285014247b38d8d70605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138442
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142989
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: If736ff669ffe24c3dd111c26285c19fc65806a3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142946
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... SwTOXButton and SwTOXEdit
See tdf#94879 for motivation.
Change-Id: I0fa3d1c6023ce42f3a1c23cc6b873ffa75516455
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143013
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
- Using StartExecuteAsync instead of Execute to execute the dialog makes
it run asyncly
- We need to add a handler for the OK button, otherwise the event won't
be fired when it's clicked. There seem to be varying names for this
throughout the codebase, I've chosen OKHdl as it's short, appears to
be relatively common and fits well with the existing OptionHdl and
CaptionHdl that the other buttons on the dialog use
- Lastly, we need to enable the JSDialog builder in
vcl/jsdialog/enabled.cxx so that the dialog becomes a JSDialog
Still TODO:
- Convert the dialogs that open when you press "auto" or "options"
buttons (will be in a followup review)
Change-Id: Ieabbc4e69c4aa065506f7dc6c823d83e4d784c2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138313
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142988
Tested-by: Jenkins
|
|
- Previously the split table dialog was not an async dialog, and it
wasn't a JSDialog either
- A non-async dialog has issues when multiple people try to change
something using the dialog at the same time. Generally the changes
from one person will not be applied until all people who opened the
dialog later than them have submitted
- This PR makes the dialog async, fixing multi-user issues with it
- This PR makes the dialog into a JSDialog, rendering it on the client
with native HTML elements
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I9254bc1b635531c8b38d1ade76f99ffdda145b35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137741
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142972
Tested-by: Jenkins
|
|
contentcontrol: fix: modify, remove, move up/down buttons doesnot work even if item is selected in jsdialog
Signed-off-by: rash419 <rashesh.padia@collabora.com>
Change-Id: Ib038ce2a3ff6f92ab7314b18f36a038991a35f3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135902
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142971
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: I50c2c0f202780d06b556ae82b51bab5c3f79d72e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142498
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Loading documents with multicol sections with flys could
freeze Writer. Add loop control for multicol sections to fix it.
Regression from commit 8feac9601cfe35ee0966776bab15d122206f154e
"tdf#138518 sw: layout: avoid moving flys forward prematurely".
Follow-up to ed12269c42f75f553bb8a8770923406f7824e473
"tdf#142080 sw: layout: fix infinite loop in CalcContent()".
Change-Id: I06eb3f5a26b2d2ac3999b98a9661112b8bf7738f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142950
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: Ia99d6aff1e7e9b90167fc535c1fc7951e7f4b2b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142954
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I18d56ac373594abca2d994c709fa4579bdfe4d62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142838
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I5dcba14a9b0dfcc5267760410f6d135fcd3b1bd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142944
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
since
commit a5e416712e9477c496ce5fd4d935133083330ddf
CppunitTest_sw_ww8export4: remove not needed mustTestImportOf()
Change-Id: I00721babc7cd1a66a5220e33567ad46b62acc681
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... and likewise DeleteWindowFromPaintView -> DeleteDeviceFromPaintView
because they add/delete output devices, not windows, ever since commit
53fd4bb47c53cbb62a542c847ed38238e7b3e148 (INTEGRATION: CWS sdwarningsbegone
(1.42.34); FILE MERGED, Dec 12 18:19:15 2006)
And use references instead of pointers, because they are dereferenced
unconditionally.
Change-Id: I67d5841babaec040aa5308e95f333948eb0dde2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142945
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: If525ba9826f5bc2d860233cbabf58d1d290be054
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142936
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id63d9cbd5c224904c852249cb5aee7509136166b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142909
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I706bf56209beebbe2987bce436536c3d9ade51f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142655
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I772f529ea4bd225701b9864ad9156c573f41484c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142715
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: Iba98a91a61955af52651348409f88244d1eed2c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142216
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I656037ef4e40e7c79daef5dd73f8f10c9818ac25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142215
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
This patch creates a new color entry in Tools - Options - Application Colors for "Grammar mistakes". Default values are also set for the "LibreOffice" and "LibreOffice dark" schemes.
This patch also applies the selected color to the document, as well as in the SpellChecker dialog.
Change-Id: I07f79da9858b675b330540cf08cf389dce39228d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142294
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
|
|
Change-Id: I2a1c82bb0590acf8f2399f2ea4b6b477600c7908
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142840
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Much easier to deal with - let compiler do the bit setting.
Change-Id: I9412e1a2f15e41c9ebf502af57b127c283fc1fa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142214
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I7c7505fb1afee750c1742a64f4b8f345a6140c38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142823
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 0c2e24594ed202f9c3dd2b3ee6646410b4eb2326)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142797
Tested-by: Jenkins
|
|
Change-Id: I86f589d6618ae80f26542cf83b6b5e3695ca35f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142193
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
This is needed because SwTableNode is not a content node, so we
need to work with the most generic SwNode and ask if the node
derives from sw::BroadcastingModify, which is required for node
tracking (SwTableNode and SwContentNode support that).
Change-Id: Idc28a5a9f1f8a250e2a28bb955ed320d02b6c1b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141787
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
it has to be smaller to fit into my mental working-RAM
Change-Id: If2225359591a070373e3a9ca0459e5c64bef7526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142776
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibcb4268697a6dd95da841dc29f7012c0801abdd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142775
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
to make it easier to comprehend
Change-Id: Ib1c8a36eea036584220636f330c4df76afcd27e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142774
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
(CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
2022-04-07) for motivation.
Change-Id: I3c5d53dc33112f7d8c46cf2baf35ba03ff7fa3fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142790
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
When the document is opened we first need to run the a11y check
on the whole document so we can report the a11y state in the
statusbar and set the a11y issues to the nodes.
Change-Id: I0573e8fd695e3b0560fa0554f4702c88e7980a13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141786
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Track all content node with a11y issues and handle when they are
deleted (with WeakContentNodeContainer). At update, recount the
number of a11y issues that are contained in the content nodes and
update the overall number.
Change-Id: I254c62aba0d73a365f011b1609bcddec4dd71615
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141785
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
And extract the identical code used in all components into
static SfxLokHelper methods.
Change-Id: I6556b1b996936835ecfc0d59e2c1dd1ef6380db2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142793
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I64295144d0fb0bd1b07d06dd7a51a670deb0a7df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142732
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Since Impress/Draw use mm100, we need to convert object area that
SfxInPlaceClient provides, which is in parent units, into twips.
TODO: how would taking the units from object shell with Calc, given
that it does not call SetMapUnit in ScDocShell ctor?
Change-Id: I8de2088a3e0e7f9070d6c3c234b40038b6e00f15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142777
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
- improve the calculation of the SwPaM that decides the start/end of the
fieldmark: with HTML import the length of the content is not the
length of the input string anymore
- use SwTranslateHelper::PasteHTMLToPaM() to accept formatted content
inside a single paragraph
- avoid unwanted last empty paragraph from the HTML import
- this builds on top of commit 6870c0c3385bf5d19e9c80bf973fca255ae38c08
(sw: add new FieldCode parameter for the .uno:TextFormField command,
2022-11-15), which introduced plain text support for FieldResult
Change-Id: I8332f6ee532ab1e844a4b94f22b1f72d2406eb3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142756
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Thanks to those who reviewed the first patch in my series.
I thought I had done so well, and yet...
-typo: 3df534a5ba01ec32590adb6c05ee6621e136b55e
-unused/std::move: 0232d4d19858f76fd63b8e525a835bd6fbcd3b8a
-const&: d9c708f78de6f6ef6621b47123a0ff164ddfee93
Kendy pointed out there are different license headers,
and new code should just use MPL. I had just copy/pasted
the header from nearby code. All the work done in these
new files was mine (composed by copy/paste as a template). Fixed.
I noticed a few stray css:: in .cxx files that I missed.
Those are unnecessary and I don't like them. Fixed
In the second round of reviews
-no need to specify virtual when override
-cleaning up ALL of them in bookmark.hxx to be internally
consistent - nothing worse than half and half in one file.
-use #pragma once for new files
-only use official documentation (but I don't like the layout
of the official documentation and didn't use it,
so the value of providing a web link seems dubious - removed.
Change-Id: I3c7aa7d647bfa91b69848258aca6d79d8e7b0edd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142556
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Assert not only that the widget is a text one, but also that it has the
correct date format.
Change-Id: If2bb8dcdfca0a8b76b5ed179ff558d351137bc06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142747
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: If2402c824e637016e3c10860810501ec60732bc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142000
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
just create a cheaper SwHeaderFooterDashedLine and only create the
"expensive" control on-demand if it becomes visible on-screen and
destroy it immediately if it goes off-screen.
Change-Id: Id876145130d394f55f54790d5e8399dca4f8c03e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142742
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5adb6a1a3987b74212b8606aef3826e7d2f77aaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142727
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
The field code/command is the input of the field expand.
Also allow setting a field result, given that the entire point of
"unhandled" fieldmarks is that Writer itself doesn't know how to compute
the field result / expanded string.
Note that a field result can be a multi-paragraph and formatted content,
so far we only allow single-paragraph plain text.
Change-Id: I1739cb985d1d4ed8e45068f15a4e0d82fd118d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142726
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
This now allows MS Word Basic legacy list box form fields
to be controlled by VBA basic.
-allows getting and setting the text string/list entry
-allows adding and deleting list entries
Change-Id: Ia772c62395c40a6aa0afae2549f15f4ea3304dbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142396
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
I.e. SwShellCursor is a cursor, while SwCursorShell is a base class of
the edit shell/UI.
Change-Id: I28e10360b2ef67ad599ec696a57f7bb30eabd33c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142719
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Icc3ff1be31a01b22242c48dec6d830e645ecb310
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141784
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
A11y check statusbar control, which reports the current status of
the online a11y check.
Change-Id: I07528f39ed84136f99bc1ce07c10aa6163649305
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141605
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|