summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2021-02-24tdf#140198: sw: Add UItestXisco Fauli
Change-Id: I0cb7286355883dc67b5bcde5ef43046dce224da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111476 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24sw: make sure g_DefaultAnchor is in sync with aPropNamesMiklos Vajna
This was already the case for one setting, but the same was not done when the default anchor setting was added, fix this now. Change-Id: Ia0cfa20468673117ff6580b270801e6605537ab6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111473 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-24tdf#140486: sw: Add UItestXisco Fauli
Change-Id: Ie4ae878beed0a298388db29cfecfa537013166c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111472 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24uitest: no need to pass the parent as a parameterXisco Fauli
Change-Id: I750b5600d3e4ef8ba5a0666133b9066904b4cbec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111450 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24tdf#134432 remove .uno:CharBackgroundExt from Writer UISeth Chaiklin
Tooltip is "Highlight Fill", but the .uno has no effect in a menu or toolbar. Remove from Customize menu. Remove from WriterCommands.xcu because no longer used in Writer UI. Change-Id: Id6447c09eb52bb9204fe4f1b4842d712ede19d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111177 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-24tdf#140397 make contenttoggle button visible again in all backendsJim Raykowski
fixes regression introduced by commit b80c2745c50d064ad9e673cf8a5b73aaf0aa1778 Change-Id: Ib93a0c1b203f399f4f64681aac8e1f76509bcc63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111439 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-02-23loplugin:unusedmethodsNoel
Change-Id: Ie0534244cc7a30ad006e65baf125c59757c90d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23loplugin:constantparamNoel
Change-Id: Ieaee9a3e3ef4aa9bc390ddb198ee1718f635bcbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111391 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23tdf#140226: use StaticWhichCastBjoern Michaelsen
Change-Id: I7f1345da0e67bfe14b119b92f32faa926b2ab603 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111356 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-02-23loplugin:unnecessaryvirtualNoel
Change-Id: I792a717306c232cf200940f9e3944f91885e426a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111387 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23sw lok: simplify SwTransferable::isComplex()Miklos Vajna
Commit 169a87563a3940299811d874b4df0ad13591771c (LOK: Implement getSelectionType, 2019-06-24) implemented detecting complex selections by copying the selection to a new SwDoc, which probably had two benefits: first, the created SwPaM instance didn't touch the document; second, this means no bounds has to be set when scanning nodes: the entire document is the selection. Later commit 7fe30d1cb00c576469d6cbe5606268a9cdf35bd3 (LOK: detect Graphics in isComplex for Writer, 2019-06-25) got rid of the SwPaM (which would register itself into text nodes), so now it's possible to not touch the document, even if we work on the original document. Instead, solve the partial scanning by iterating over the list of selections. This is meant to be faster, and also less likely to crash in case some internal document model invariant is broken. No testcase, testComplexSelection in CppunitTest_desktop_lib already covers thie behavior. Change-Id: Ia528c06a48defd06c5e34ed7d61621e5ce10bb06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111377 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-23update pchesCaolán McNamara
Change-Id: I44424081b7f55710c4db7f10d1829de1ae08be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111363 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23replace SwTemplatePopup_ImplCaolán McNamara
Change-Id: I82afec995488d388cb39c324f8f9a6684441fbe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111361 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23replace BookmarkPopup_ImplCaolán McNamara
Change-Id: I87dda264ec61bbbfd6cf4eb0cbbe636724579537 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23allow fading in/out to happen while a menu is openCaolán McNamara
I don't see an ill effects and this is happening already in the non-vcl menu case so drop the vcl-only case guard Change-Id: I6e0c7f645f9e1d2ba79215c0458659cd2a610ef2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111357 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23tdf#139667 final set of tooltip adjustments about lists and numberingSeth Chaiklin
cui/uiconfig/ui/numberingoptionspage.ui "Customize" tab one modification about numbering style. sw/uiconfig/swriter/ui/numberingnamedialog.ui "dialog for Save As" extended tooltips for the entry window and list window, loaded automatically from help page, were inappropiate. modified each to be appropriate and added tooltips. sw/uiconfig/swriter/ui/tocentriespage.ui "formatting style" -> "character style" extended tooltips could be improved, but maybe the entire dialog will be reworked (see tdf#137160), so nothing more for now. Change-Id: I21185e8fb8596e60f2e54a42456a8f262f2c31c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111173 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-23tdf#139667 "List" -> "Apply List Style" in Paragraph and PS DialogSeth Chaiklin
* change heading label for List Style + add tooltips for the two combo boxes * small corrections in recently-added tooltips Change-Id: Ie2a478e7db7cafdd3b27f1acfe024f7c72cf221a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110448 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-23tdf#140058 move "No List" position in context menu; add radio buttonSeth Chaiklin
for both text and table in Writer, Writer/Web, and forms Change-Id: I696dbcf3e027a2595e2eed7e9fb9585c352da184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111176 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-23tdf#135774, tdf#114799 Char highlight: apply to numberingJustin Luth
This is a partial revert of LO 7.0's commit 315d56582f8a56d8f2d3ea6cda63ea4832249608 The character background is exported as either w:highlight or w:shd, based on a user setting. w:shd does not affect numbering in MS Word, only the 16 color w:highlight does. (tools - options - Load/Save - Microsoft Office - Character highlighting export as: Highlight or Shading) I replaced tdf114799.docx with a version that uses w:highlight instead of w:shd. The test was doing it backwards - MS Word was NOT highlighting the numbering in the original unit test. I added another test using the original unit test to ensure that the numbering was not affected by the paragraph's char shading. There are many other "Char highlight:" patches in 7.2 that are not going to be backported. See http://wiki.documentfoundation.org/Documentation/CharHighlight for more details about this topic. Change-Id: I38b6f700895e29f634f07430f6c7a13722ffa4f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111201 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-02-22oox: VML export: write o:allowincell attribute on shapesMichael Stahl
Apparently the default is "t", which causes a fly that is anchored at-page with the first content on the page being a table to be wrongly positioned. Change-Id: Iba1b961c6e884b2a55928952937187732ef73a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111336 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-22tdf#104795: sw: Add UItestXisco Fauli
Change-Id: I6d2bff09a7aacf09900a8ce960504aa7428e8db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111333 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-22uitest: sw: re-enable test to see if it still failsXisco Fauli
it doesn't fail for me, let's see for others. Anyway, I might have an idea how to fix it if it still fails Change-Id: Ie3b60c0e652302df3d2ff0331c3df765934620c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111203 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-22tdf#115853: sw: Add UItestXisco Fauli
Change-Id: Ie7b376a2329751120a30cbf17c29b80f46b87618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111332 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-22sw: prefix members of SwFixPortion, SwFlyPortion, SwGluePortion and ...Miklos Vajna
... SwTabPortion See tdf#94879 for motivation. Change-Id: Ic3918caa922cfd99e361010b44fe9d0c95e28b1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111298 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-21Typo fix: supress -> suppressTor Lillqvist
Change-Id: I72aeaff1bc8ac67253265ea99de91b9b9906e5d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111275 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-02-21Resolves tdf#140511 - UI glitchesHeiko Tietze
Clean-up of nested grids and boxes Change-Id: Iea2aa3d03210c0bbbf15b3eed546795de972b21b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111209 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-20uitest: sw: remove duplicated testXisco Fauli
Not sure why this test was added, but the fix for tdf#49683 already contains a unittest, see 831b712d3da08f0050d2ee92c384ad8e6a2e461c Change-Id: I6c52e075118ba0e438dfdff8b0ca3be94b0dd5bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111227 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-20tdf#122780: sw: Add UItestXisco Fauli
Change-Id: I9cd0c3e25842d69ee34f40ce206c022f86fc9545 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111242 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-20drop some unneeded includesCaolán McNamara
Change-Id: I0fe18c3e535bee2213606b7189778c40403a97ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20missing labels for two menu entries in writer readonly context menuCaolán McNamara
since... commit 45d57a0dba8bb5a92150cc07bdff0b37b3041007 Date: Tue Apr 18 13:13:27 2017 +0100 convert readonly menu to .ui Change-Id: Iaa65fc38be666067a3922e716902c8112da8ddde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20loplugin:refcounting in swNoel
Change-Id: I56f2f5aa4d9105e93f28701b8352d1fb97829ead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20loplugin:refcounting in svlNoel
Change-Id: Iae192caa9d05f71ce02aae966ef1d71232d1a7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19uitest: sw: test insert/remove of custom propertiesXisco Fauli
Change-Id: I6de4c73a79e3a3ae5f9fcd4e6efcf25dc846e880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-19uitest: sw: differentiate the elements in the custompropertieslinesXisco Fauli
Change-Id: Ic61cd1655df2bcd7b89c4dfadcda801b7160253c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111226 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-19add some missing use-underline propertiesCaolán McNamara
Change-Id: Ib6cc06ccb8986e85a09335c3fa06f8c2a50eec2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19update pchesCaolán McNamara
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19foward declare NotebookBarAddonsItem instead of using includeCaolán McNamara
Change-Id: I57e5a8f28a40994b61ab0f554401e4f70c8ffc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19weld inputwinmenuCaolán McNamara
Change-Id: I84995928412ed45b4b91939b8a0b48906bb3c13b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19Related: tdf#140409 scale the menubutton like the other widgetsCaolán McNamara
Change-Id: I6b42ef958dd1625cfef5e48e45c932aef9a5960f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111211 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19rename get_vscroll_width to get_scroll_thicknessCaolán McNamara
and add split customize_scrollbars to form a separate set_scroll_thickness Change-Id: Ia4b1c85d6ae85b0fb7aeb852d3a91b36b63143db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19tdf#140409 Comment text ignoring zoom sizeCaolán McNamara
Change-Id: If48d5c1085cbc86f81ba0c92c8875ef534900c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18tdf#139667 adjust Condition tab dialog for Text Body to "list"Seth Chaiklin
- This dialog referred to "Numbering", but better to refer to "List" because the level can also apply to bullets and graphics. - adjusted tooltip accordingly. Change-Id: I5256be054f44058f44711113a85f3053bfd4c755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111041 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-18tdf#139667 Bullet and Numbering tooltips, use verbs and add missing oneSeth Chaiklin
Change-Id: Id5439fb3820db94c08d9902c859da199127fd339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110791 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-18sw bibliography: make URLs in the bibliography table clickableMiklos Vajna
- Don't reuse the <text:index-entry-link-start> / <text:index-entry-link-end> mechianism from <text:table-of-content-entry-template>, because <text:bibliography-entry-template> doesn't allow this - Use STR_POOLCHR_INET_NORMAL as a char style, so the URL looks clickable - Allow absolute URLs for ToxAuthorityField::AUTH_FIELD_URL (other URLs like ToC are always relative) - Track the new text added by FillText() between the StartNewLink() and CloseLink() to figure out what is the URL to be launched on click Change-Id: I126fa06aecfff783e62b65a548228ff781b62c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111117 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-18adapt to prefixing , even when OSL_DEBUG_LEVEL > 1Tomoyuki Kubota
Change-Id: I5fe9755eaf0cce963fda2dbc2ec27b31d0d7dc52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111045 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-18Move GIF writer from filter module into VCLTomaž Vajngerl
Change-Id: I8db3ca0f7953b44791bda47534220902931fab8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111023 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17tdf#130629: sw: Move UItest to CppUnitTestXisco Fauli
Change-Id: I80f248ec79f5bc04dc370b4c549730392110aaca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111074 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-17tdf#115965 tdf#92622 NoList default in menu,tool,sidebarAnshu
Change-Id: Icbc612b44593c5366f3e7f81112f4013884f3599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108841 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-17sw: document SwTOXAuthorityMiklos Vajna
Even if it derives from a "Tab", it's not a table, just a row in it. Change-Id: I303fdcb8719e61ca790096b8cc342af3ffb28930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-17Avoid crash in online on a document with commentsAron Budea
Crashed on a specific doc with the following backtrace: Thread 1 "kitbroker_001" received signal SIGSEGV, Segmentation fault. 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 71 const SwPostItField* GetPostItField() const { return mpField; } 0 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField() const (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 1 0x00007f4807f0641b in SwXTextDocument::getPostIts(tools::JsonWriter&) (this=0x557e1d985a10, rJsonWriter=...) at /.../libreoffice/sw/source/uibase/uno/unotxdoc.cxx:3337 2 0x00007f4823216534 in getPostIts(LibreOfficeKitDocument*) (pThis=0x557e1d93c890) at /.../libreoffice/desktop/source/lib/init.cxx:3425 ... Change-Id: Ib97fd33fda936cad0c9ed3a29564fc0a49ff20c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110958 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-02 15:00:40 +0000