summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2014-08-25Remove unnecessary invalid downcastStephan Bergmann
Change-Id: I53a9e864f01782cef10f2995ba90335f5c81077a
2014-08-25Avoid unnecessary dereferencing of potential null pointersStephan Bergmann
That pDoc can be null here and in previous 2406562733f62b96dd8e6537e1bf4bef147ef50c is somewhat fishy, but probably related to "NOTE: the sw.SwXAutoTextEntry unoapi test depends on pDoc = 0" from "fdo#72695: avoid double-free race condition for SwXTextField." As mstahl puts it: "hmm... theres some stupid unoapi test that inserts a field into an SwXAutoTextEntry which is a horribly odd class that doesn't have any way of creating SwXanything of its own SwDoc... so probably your commit is required after all." Change-Id: I2da77e1180e205eca274ce0330ee2a4d5aab29ac
2014-08-25sw HTML export: avoid loosing embedded objects when skipping imagesMiklos Vajna
Change-Id: If795af5430b319922cd8242ca82352e148dd680b
2014-08-25Avoid unnecessary dereferencing of potential null pointersStephan Bergmann
Change-Id: Iba21dd394010a162a52bb576400cbbb9a9aad537
2014-08-25set names on a bunch more threads...Michael Stahl
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25Dump table attributes and page description itemsJan-Marek Glogowski
Adds the SwPageDesc name to the dumpAsXml output of the SwFmtPageDesc / RES_PAGEDESC SfxPoolItem and dumps the tables attibutes. Adtittionally this renames the unknown field name, so it doesn't produce wrong XML output (blamed by "xmllint --format") and adds the hex node type to the start and end node XML output. Reviewed on: https://gerrit.libreoffice.org/11091 Change-Id: I3cde39d423e17909243675efdd39557a6bfffbd7
2014-08-24fdo#73151 Make better use of the sidebarSamuel Mehrbrodt
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery) Changes: * Show the sidebar by default in Writer & Impress * Remove the Gallery floating window (Gallery now always opens in the sidebar) * Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer (since they have an icon in the sidebar and the sidebar is shown by default now) * When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151 Change-Id: I3a0461d1472711da7121801000af294b432fccb1 Reviewed-on: https://gerrit.libreoffice.org/11077 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23fdo#82577, fdo#82579: Handle CursorTor Lillqvist
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor typedef and some ancient Carbon (?) Cursor typedef on OS X. Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23fdo#80534 bad default value (0) for the number of rowsThomas Arnhold
Change-Id: I39604cf13d1e5714f701dd663ab37a8aed924fa2
2014-08-22Avoid undef member function call with this == nullptrStephan Bergmann
(in which case SwFrm::FindPageFrm, sw/source/core/layout/findfrm.cxx, happened to return nullptr, so all used to go well; but still...) Change-Id: Ib513d9a157d0135ca234930bbcbeeacf814bb80e
2014-08-22CppunitTest_sw_ooxmlfieldexport: enable on WindowsMiklos Vajna
Change-Id: I768bce2398098195f4e5c7d7683f2c8b22f23cc0
2014-08-22Prevent downcast to SwTxtFrm when already in ~SwFrm superclass dtorStephan Bergmann
...as done in SwAnchoredObject::FindAnchorCharFrm (sw/source/core/layout/anchoredobject.cxx) during CppunitTest_sw_ooxmlexport5: SwAnchoredObject::FindAnchorCharFrm SwAnchoredObject::GetAnchorFrmContainingAnchPos SwAnchoredObject::FindPageFrmOfAnchor lcl_NotifyBackgroundOfObj SwDrawContact::DisconnectFromLayout SwDrawContact::DisconnectObjFromLayout SwFrm::Destroy SwFrm::~SwFrm SwCntntFrm::~SwCntntFrm SwTxtFrm::~SwTxtFrm SwTxtFrm::~SwTxtFrm SwLayoutFrm::Destroy SwLayoutFrm::~SwLayoutFrm SwCellFrm::~SwCellFrm SwCellFrm::~SwCellFrm SwLayoutFrm::Destroy SwLayoutFrm::~SwLayoutFrm SwRowFrm::~SwRowFrm SwRowFrm::~SwRowFrm SwLayoutFrm::Destroy SwLayoutFrm::~SwLayoutFrm SwTabFrm::~SwTabFrm SwTabFrm::~SwTabFrm SwFlyFrm::DeleteCnt SwFlyFrm::~SwFlyFrm SwFlyFreeFrm::~SwFlyFreeFrm SwFlyAtCntFrm::~SwFlyAtCntFrm SwFlyAtCntFrm::~SwFlyAtCntFrm SwLayoutFrm::Destroy SwLayoutFrm::~SwLayoutFrm SwBodyFrm::~SwBodyFrm SwBodyFrm::~SwBodyFrm SwLayoutFrm::Destroy SwLayoutFrm::~SwLayoutFrm SwFtnBossFrm::~SwFtnBossFrm SwPageFrm::~SwPageFrm SwPageFrm::~SwPageFrm SwLayoutFrm::Destroy SwRootFrm::~SwRootFrm SwRootFrm::~SwRootFrm boost::checked_delete<SwRootFrm> boost::detail::sp_counted_impl_p<SwRootFrm>::dispose boost::detail::sp_counted_base::release boost::detail::shared_count::~shared_count boost::shared_ptr<SwRootFrm>::~shared_ptr SwViewShell::~SwViewShell SwCrsrShell::~SwCrsrShell SwEditShell::~SwEditShell SwFEShell::~SwFEShell SwWrtShell::~SwWrtShell SwWrtShell::~SwWrtShell SwView::~SwView SwView::~SwView SfxViewFrame::ReleaseObjectShell_Impl SfxViewFrame::~SfxViewFrame SfxViewFrame::~SfxViewFrame SfxViewFrame::Close SfxFrame::DoClose_Impl SfxBaseController::dispose (anonymous namespace)::Frame::setComponent (anonymous namespace)::Frame::close SfxFrame::DoClose SfxViewFrame::Notify SfxBroadcaster::Broadcast SfxModelListener_Impl::notifyClosing SfxBaseModel::close SwXTextDocument::close SfxBaseModel::dispose SwXTextDocument::dispose SwModelTestBase::tearDown ... Change-Id: I4c00fa8eebf0346a2bad81a9e362cd901555bbf0
2014-08-22Simplify autocorrect loading - removing redundant parameter.Michael Meeks
Change-Id: Idc1ebba8d859ec79b6744228cfe3ef1f0992e41d
2014-08-22Avoid unnecessary invalid downcastsStephan Bergmann
...to SwFmtFtnAtTxtEnd instead of SwFmtEndAtTxtEnd, both derived from SwFmtFtnEndAtTxtEnd Change-Id: I4b909f136268058bedeacd6b47d3f4cd88522ad5
2014-08-22QueryBox RID_QB_SPELL_CONTINUE -> MessageDialog + stringCaolán McNamara
Change-Id: Ie08970cefccdb1339e162bb5f4d3318efc6c61a5
2014-08-22QueryBox DLG_CHANGE_AUTH_ENTRY -> MessageDialog + stringCaolán McNamara
Change-Id: I836381f710e4f36b977284f6996bb135fc328049
2014-08-22DOCX import: list styles don't support automatic updatesMiklos Vajna
The problem was the following: setPropertyValue("IsAutoUpdate") on the style failed -> a number of styles was not imported in StyleSheetTable::ApplyStyleSheets() due to the exception, then when we tried to use one of the not imported styles, we also got an exception in DomainMapper_Impl::finishParagraph(), which resulted in not calling DomainMapperTableManager::handle(), so multiple cells of the same table wanted the same range for cell contents, and that resulted in a crash. Regression from cf33af732ed0d3d553bb74636e3b14c55d44c153 (handle w:gridBefore by faking cells (fdo#38414), 2014-04-23), but that commit just made the previously hidden problem visible. Change-Id: I788cb6b4a2c7b7efbfa48297c658bb26450bf583
2014-08-22SwXParagraph::Impl::GetTxtNode: fix indenetationMiklos Vajna
Change-Id: Iac9e2883067b6cf4fdc259110642002b4ef6e48c
2014-08-22The bLastBoxInChain fields are unusedTor Lillqvist
Change-Id: I741733a053c8b0123be8efbcb9fde39f53f6d83c
2014-08-22bHasUDefProp is unusedTor Lillqvist
Change-Id: I8eae6f1ed791ba92c3b4679d1b9f8041f16678d1
2014-08-22The comment apparently pertained to the following lineStephan Bergmann
...cf. 75400111a50ce0b4026e7eb73a896ac3c28d6155 "INTEGRATION: CWS swqbf64: #i65250# <SwFrm::mnFrmId> now in general available," but is rather useless nowadays anyway Change-Id: I1e9d6c289fad021764f7e1b1af0d7b9dca67bf53
2014-08-22Open the right tab for the More... commandMaxim Monastirsky
Partially fixed by Caolán in 3ac80237f310366afef0f7b6c427889d652bd369. Remaining issues are the paragraph submenu, and the top menu for both selection and paragraph. Also fixed for the drawing text and annotations shells (including the regression created by the above commit, that the dialog didn't show at all). Change-Id: I1ba4c825ad48af23ad5c07c8c5f25380952c0be1
2014-08-22QueryBox STR_QUERY_DELETE -> MessageDialog + stringCaolán McNamara
Change-Id: I570fe82f3207e8b40a0e4727c6641fdf59113978
2014-08-22QueryBox QB_CONNECT -> MessageDialog + stringCaolán McNamara
Change-Id: I593527c365ad6925229a3dd7d9e1c589fc4e34a5
2014-08-22QueryBox DLG_SPECIAL_FORCED -> MessageDialog + stringCaolán McNamara
Change-Id: I461bdb31e7a088a2aa5200614479c8578e717b23
2014-08-21sw: _one_ unit test with use_library_objects sw ought to be enoughMichael Stahl
Linking those things takes a lot of RAM. Change-Id: I4db9ee3f07f97601d526ab3f905ecadbf4c552ca
2014-08-21RES_PARATR_ORPHANS comes before RES_PARATR_WIDOWSStephan Bergmann
Change-Id: Iaf1891738fb3673c41b3af724f8494306578c512
2014-08-21Fix *_component_getFactory function typeStephan Bergmann
Change-Id: I0f2fedc544349a69f29df5e83bec30ea510125f5
2014-08-21DOCX export: prevent multiple paragraphs in some SDT containersMiklos Vajna
E.g. Word doesn't do anything if you hit return in the middle of a title; if that's so, then we should handle this situation on export as well. Change-Id: Ib5b52a59250b09c97023b53906b8046f530d0e31
2014-08-21Avoid invalid downcasts to SwFmtHeader instead of SwFmtFooterStephan Bergmann
...which only happened to work because the two classes have very similar layout Change-Id: Ie4bde807a2442a95ff515b065d4f45f257a32f34
2014-08-21avoid crash on document ending before contained table endsCaolán McNamara
Change-Id: I003b7e00673cd5a4b4f0ed5218e2d30cfef04ffb
2014-08-21Check pTmpFrm->GetType(), not nFrmType, for FRM_FLYStephan Bergmann
...as nFrmType need not match pTmpFrm->GetType() exactly, but can e.g. be USHORT_MAX when GetFrmOfModify is called from SwFrmFmt::FindLayoutRect (sw/source/core/layout/atrfrm.cxx). It is probably good luck that the two comparisons against FAR_AWAY made it too unlikely for the if's true branch to ever be taken for a pTmpFrm that is not actually a SwFlyFrm. Found the bug when running CppunitTest_sw_ooxmlexport2 under -fsanitize=undefined, where ((SwFlyFrm*)pTmpFrm)->GetAnchorFrm() was called for a pTmpFrm of type SwTabFrm. Change-Id: Ia886a809bdb82488c3f410be66cf827b3f723c55
2014-08-21DOCX export: handle anchored TextFrames inside shapesMiklos Vajna
The exporter already handled TextFrames inside TextFrames, a feature supported by Writer, and not by Word. Similarly, if DocxSdrExport::writeDMLAndVMLDrawing() starts a shape, then anchored TextFrames should be posponed till the end of that shape. Change-Id: I597a8a46b1cf2348a8ccb9af668ea5afab27541b
2014-08-20C++ name lookup is hard, especially for clang tinderboxMichael Stahl
Change-Id: I50a25e5cfa219bbdcf0a23c03b8e6a2cff72c3d6
2014-08-20i#107771: sw: burn, UnoCallBack, burn!Michael Stahl
Change-Id: Ifdb6d4b2e404bd160e6fcec3229691e750bdf698
2014-08-20fdo#72695: avoid double-free race condition for SwXFootnoteMichael Stahl
Change-Id: Id7832d8e65723ae30ad2b5ce95d145def53998f0
2014-08-20i#107771: sw: implement thread-safe instance caching for SwXFootnoteMichael Stahl
Change-Id: I3fffb321877168dfa9844b4ad75a9a9efc9602a6
2014-08-20i#107771: sw: make SwXFootnote a client of its format poolitemMichael Stahl
In other words, stop registering at SwDoc's "UnoCallBack". Change-Id: Ie73c707b0f43559cc78717c0879d5e9a9335a7ac
2014-08-20SwWrtShell::StartInputFldDlg() can be called with RES_SETEXPFLD tooMichael Stahl
... and there's no way to get the SwFmtFld from a SwSetExpField, so add a member for it like SwInputField has. That's still better than the UnoCallBack nonsense. Change-Id: I59c82e95414dbae284432b8a318a6ce1a34256c7
2014-08-20i#107771: sw: make SwXTextField a client of its format poolitemMichael Stahl
In other words, stop registering at SwDoc's "UnoCallBack" Change-Id: Ieb2639497fe5e8d71aa1c47952c007da76fcee84
2014-08-20better error handing in SwXTextField::attach()Michael Stahl
Change-Id: I4b8b4ef1f34ba5662bd56bfbb335b87fb5aa4b51
2014-08-20fdo#72695: avoid double-free race condition for SwXReferenceMarkMichael Stahl
Change-Id: I66a988f17adebba72a71af5b770abbebfa4e12b2
2014-08-20i#107771: sw: implement thread-safe instance caching for SwXReferenceMarkMichael Stahl
Change-Id: I4f3b6789dde053ca913e12233b20d45dfe50c7ec
2014-08-20SwXReferenceMarks::GetObject() has no need for a mutex guardMichael Stahl
Change-Id: Icc6b0eebf57b07f06bccc9a57036f0611a67c4a3
2014-08-20i#107771: sw: make SwXReferenceMark a client of its format poolitemMichael Stahl
In other words, stop registering at SwDoc's "UnoCallBack" Change-Id: I9e08966cf8e2d2a373867d81549c8887f73993c8
2014-08-20sw: RES_TOXMARK_DELETED is unused since swunolocking1Michael Stahl
Change-Id: I98b21573ebbc8543609bd63eee30bc5b4cbdfb2c
2014-08-20SwXDocumentIndexMark::CreateXDocumentIndexMark does not need SwTOXTypeMichael Stahl
... passed in as parameter since it's always the one from pMark. Change-Id: Ia5981b0f281c8cac70cbb305c82bb6785918168a
2014-08-20RegisterToTOXType has a silly parameter nameMichael Stahl
Change-Id: I1cfd5c077f4b1ac809ace91fe76308f0e1892e09
2014-08-20fdo#72695: avoid double-free race condition for SwXParagraphMichael Stahl
Change-Id: Ie207d9400bc3a55e17497b309dfbc263e7b12e30
generated by cgit (git 2.34.1) at 2025-03-19 11:15:18 +0000