summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-10-15Revert "Breeze-icons update links.txt and *remote icons"Adolfo Jayme Barrientos
This reverts commit b325d69dcbafef26fa6ce098dc4c6efa9b35264e. Change-Id: I472bd264c1bb754f40d65eec2d029a2e36102bbf Reviewed-on: https://gerrit.libreoffice.org/43402 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-15Breeze-icons update links.txt and *remote iconsandreas kainz
Change-Id: Ia3fca0f5dd3ee23e26001c269a9312d60ca9a703 Reviewed-on: https://gerrit.libreoffice.org/43400 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2017-10-14tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+ekuiitr
changed OUStringBuffer::append() to op+. deleted unnecessary variable. Change-Id: Ibe27f7f587f7130e7c31e33a29a88c5ea6478740 Reviewed-on: https://gerrit.libreoffice.org/43395 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-14tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+ekuiitr
changed sfx2 module file, converted OUStringBuffer::append() with operator+ Change-Id: Ie85542358875324f9ddadffa01395aebccda9be9 Reviewed-on: https://gerrit.libreoffice.org/43357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-13sw dbg_lay: make it easer to match log entries with code locationsMiklos Vajna
Also warn when logging stops due to a limit, not because the layout finished. Change-Id: Ifd44901602edec001839ab4ee88f459b45e36da6 Reviewed-on: https://gerrit.libreoffice.org/43362 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-13tdf#66398 Enhance unit test: check permissions at content levelSerge Krot
Change-Id: I3bec3fe12e97e0063f597cd117cd5d8a7d5465a9 Reviewed-on: https://gerrit.libreoffice.org/43311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-13update notebookbar with better dropdown menuesandreas kainz
Change-Id: I1af49673e4eab35ea33d8d306773eef41c97807b Reviewed-on: https://gerrit.libreoffice.org/43356 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2017-10-13tdf#107239 make PriorityHBox working in the compact notebookbarSzymon Kłos
Change-Id: Iaf087dcf71714338718088c5265d41df7e8beef4 Reviewed-on: https://gerrit.libreoffice.org/42125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-10-12sw: resurrect dbg_lay functionalityMiklos Vajna
Example instdir/program/dbg_lay.ini: # 0x0007ffff [record] 524287 This logs all functions and all frames. To have it: 1) Don't mention hex values in the example, support for this was removed in ef513fd4b049b214a03fbe6e62a5ea43680a7a9b (remove unnecessary use of OString::getStr, 2017-05-26). 2) "all frame IDs" is represented with a nullptr, so don't clear it unconditionally. 3) Fix two other regressions from bytestring conversion in commit 778ef20d74ce499e4e0c4b0e3e4506b44938b975 (sw now ByteString free except for windows related ones, 2011-11-04). (Additionally you need a dbgutil build, dbg_lay.go has to exists in the same dir, and output goes to dbg_lay.out in the same dir.) Change-Id: Ida0f3032f11225f1d079cdcbb05ec64c42a71e5d Reviewed-on: https://gerrit.libreoffice.org/43347 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-11tdf#55528 ww8import: import table width percentJustin Luth
Change-Id: Ifab8fa2df13e16cbfbd70b62912ca2a6245e16cc Reviewed-on: https://gerrit.libreoffice.org/42918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-10-11ofz#3507: keep early failure of ofz#3110 in sync to address oomCaolán McNamara
Change-Id: Ic3bcfd684295293431d576931ef082a4ea09404a Reviewed-on: https://gerrit.libreoffice.org/43322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-11connectivity writer driver: survive merged cellsMiklos Vajna
Fow now just don't crash on them, instead give empty result for those cells. Change-Id: I9edd231b00fa00af95408a550484da74c98275da Reviewed-on: https://gerrit.libreoffice.org/43319 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-10tdf#112211 RTF import: fix unwanted direct formatting for other indentsMiklos Vajna
Commit 56a695fddb915bcba13b088b5b2b4e0841d4acbc (tdf#112211 RTF import: fix unwanted direct formatting for left indents, 2017-09-26) fixed left indents, and given that it was a regression fix, left the other indent types untouched. As it has been pointed out in the bug comment, the original bugdoc actually needs the other indent types removed as well, so let's do that. Change-Id: Ia4ea7e2214b7df27536f46b046f90bd703c107be Reviewed-on: https://gerrit.libreoffice.org/43303 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-10tdf#66398 Parse and output permissions for DOCX using bookmarksSerge Krot
Change-Id: Id08998ae775c5f383edc4bf0410d16f88c70dfd6 Reviewed-on: https://gerrit.libreoffice.org/43275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-10tdf#90789: DOCX paragraphs in shapes like frames do not belong to section.Vasily Melenchuk
Change-Id: I60644bd62e2a2ac97a97f0a492b146dc69456cd6 Reviewed-on: https://gerrit.libreoffice.org/43291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-10add path to tabbedbar compactandreas kainz
Change-Id: Ic02130f4cff72cbe209e43dbfcd216920683ad44 Reviewed-on: https://gerrit.libreoffice.org/43312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-10-10add tabbed_compact notebookbar for writerandreas kainz
Change-Id: Id8ac99507a5fa9e57cd99b8a3ff7448b71f5918a Reviewed-on: https://gerrit.libreoffice.org/43297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-10-09Revert "Revert "Fix -fsanitize=signed-integer-overflow""Stephan Bergmann
This reverts commit ce057e662b2e10e111353e9461c3c01434ddbb0f; the original 63d845dc88690b9c5c8194e1512a8e4390c7ee24 appears to be useful after all to make UBSan 'instdir/program/soffice sw/qa/extras/uiwriter/data/tdf112860.fodt' succeed after 'make -O -j12 ExternalPackage_fonts_liberation.clean', see tdf#112942.
2017-10-09update notebookbar to add ExportDirectToPDF and ExportDirectToEPUBandreas kainz
Change-Id: I6b161cc7d5e56b1a6507d6a513f1d3d70e8671c9 Reviewed-on: https://gerrit.libreoffice.org/43271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-10-09tdf#112942: Apparently, rTab.GetFollow() can change in betweenStephan Bergmann
...the calls to TableSplitRecalcLock and TableSplitRecalcUnlock Change-Id: Iacb0d88ccb323fb248129daeeeb207b25f148753
2017-10-09sw: prefix members of SwFieldPortionMiklos Vajna
Change-Id: I1093c10a903a9b028d74503560115692c50e0e9e Reviewed-on: https://gerrit.libreoffice.org/43267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-09uibase: consistently use "" and <> in include directivesMike Kaganski
Change-Id: Ib6888045cecb4bd7b3498534605d790324f1b40a Reviewed-on: https://gerrit.libreoffice.org/43265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-09tdf#90789 Anchored frames and shapes are identified by name/SdrObjectsVasily Melenchuk
Previously shapes/frames were identified either by name or by SdrObject, but in some cases name can be empty. New approach is to use names if they exist and SdrObject reference if name is empty. This is just a partial fix for mentioned TDF issue. Change-Id: I3bd53f07fdb3fe69b2898d855eda48b6534cd75d Reviewed-on: https://gerrit.libreoffice.org/43176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-08tdf#112025 add unit testManfred Blume
Change-Id: I897201d8ffa3386a13885b1e21f49ab57534039d Reviewed-on: https://gerrit.libreoffice.org/42795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-08Replace some lists by vectors (sw)Julien Nabet
Change-Id: Ie2f20b05ce987bb907c6f455da57bfc734dcb2da Reviewed-on: https://gerrit.libreoffice.org/43244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-08Replace list by vector in frmtool (sw)Julien Nabet
Change-Id: Ic29b8497227abfe1f407ad548037a8eaec318bcc Reviewed-on: https://gerrit.libreoffice.org/43243 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-07cid#1418980: Resource leakJulien Nabet
Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=2694162969cf86ef366d3ce812fccd0630acc800 Change-Id: I4a48279f3d073160041b66dbcf148118588f8712 Reviewed-on: https://gerrit.libreoffice.org/43229 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-07cid#1418978/1418979: invalidate_iterator/Copy-pasteJulien Nabet
Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=b6d6591fafb8ad2e59a27ff1ac6b234d879b4cf7 Change-Id: If7c3350d9f6e6c16ef59176006ca2bf2187b674e Reviewed-on: https://gerrit.libreoffice.org/43228 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-07sw: always use "" for includes in current source's directoryMike Kaganski
Change-Id: Ida715fad0c4587a9566184180bf159da12470dd7 Reviewed-on: https://gerrit.libreoffice.org/43207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-07Remove redundant comparisonMike Kaganski
Change-Id: I51820119f9dd6bacb852680b48f0b052ef6cb7e9 Reviewed-on: https://gerrit.libreoffice.org/43214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-07Replace a magic number with its syntactic meaningMike Kaganski
Change-Id: I535a7317f0797ef63294df05463a88e9e8d7aa10 Reviewed-on: https://gerrit.libreoffice.org/43213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-07drop use of tools::SvRef in xmloffNoel Grandin
instead of mixing and matching rtl::Reference and tools::SvRef, lets just use rtl::Reference Change-Id: I5d77c8a662e1455f97935e5f4a99e484e8cad332 Reviewed-on: https://gerrit.libreoffice.org/43205 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06sw: fix infinite grammar checking idle loopMichael Stahl
The grammar checker always wants to be started in DoIdleJobs(), even if all paragraphs are already marked as checked. This is because there is currently no call anywhere of SwRootFrame::SetNeedGrammarCheck(false) to reset the flag and prevent DoIdleJobs from trying to start the grammar checker. This call was already there before but was removed without any justification in commit 9160fe814a46e93da6907e169ce9d58e46fa37f2. This has become an infinite loop in several Junit tests with commit 53da556c600fa82ba84bc7fdce6a594b43f2b097. Change-Id: Ibe7ad93442070aac0577725d044281912307d9e8
2017-10-06tdf#66398 Do not output document protection in docx twiceSerge Krot
Change-Id: I16a5f2d3b8ef59e6edfdecd9d2bd19a2c10c80ea Reviewed-on: https://gerrit.libreoffice.org/43158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-06tdf#66398 Remove double initialization of the form protectionSerge Krot
Change-Id: I639523b55aef1914ddec62aaae44b0dc87346d0b Reviewed-on: https://gerrit.libreoffice.org/43157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-06Revert "Fix -fsanitize=signed-integer-overflow"Stephan Bergmann
This reverts commit 63d845dc88690b9c5c8194e1512a8e4390c7ee24. The immediate problem is fixed with 9dd0c0fcc141ae53cacb29cd0b144ac2b13e9f86 "Missing dependency" now. For the general issue that loading sw/qa/extras/uiwriter/data/tdf112860.fodt fails with a UBSan error or a null deref SIGSEGV when fonts are missing see <https://bugs.documentfoundation.org/show_bug.cgi?id=112942> "SwUiWriterTest::testTdf112860 crashes when Liberation fonts are missing".
2017-10-06Missing dependencyStephan Bergmann
external/more_fonts/ExternalPackage_liberation.mk not installed caused SwUiWriterTest::testTdf112860 (sw/qa/extras/uiwriter/uiwriter.cxx) to fail, see 63d845dc88690b9c5c8194e1512a8e4390c7ee24 "Fix -fsanitize=signed-integer- overflow" Change-Id: Ied4dcf9cfe167e741c3bb0c1f4fe853cb44b0d2b
2017-10-06use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin
instead of manual ref-counting Change-Id: I559ebb3871dd3dd4a160bd83a259e36dd2f7b4d6 Reviewed-on: https://gerrit.libreoffice.org/43200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06Don't schedule the Idle job for busy documentsJan-Marek Glogowski
This refactors DocumentTimerManager to export the busy status independent of the Idle function. This way it can be ignored in the Scheduler while the document is busy, Change-Id: Icec2075d3338ad8dd4440678eb0570d7fe887778 Reviewed-on: https://gerrit.libreoffice.org/43197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-06ofz#3564 Direct-leakCaolán McNamara
Change-Id: I4d816c91874f059becb3f7fdc6007618ac43e88a Reviewed-on: https://gerrit.libreoffice.org/43194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-06Fix -fsanitize=signed-integer-overflowStephan Bergmann
during CppunitTest_sw_uiwriter (see below), using o3tl::saturating_add similar to 97dcb242f5cc41216fd16503604ca2f29f147a2a "Fix -fsanitize=signed-integer- overflow". It replaces exactly the one use of SwIncrement that caused problems now. Probably other uses of those FirstMinusSecond, SecondMinusFirst, SwIncrement, and SwDecrement should be adapted, too. > sw/source/core/layout/newfrm.cxx:53:17: runtime error: signed integer overflow: 23547 + 9223372036854755850 cannot be represented in type 'long' > #0 0x7f00fe99e438 in SwIncrement(long, long) sw/source/core/layout/newfrm.cxx:53:17 > #1 0x7f00feb272bc in SwTabFrame::MakeAll(OutputDevice*) sw/source/core/layout/tabfrm.cxx:2311:44 > #2 0x7f00fe79d883 in SwFrame::PrepareMake(OutputDevice*) sw/source/core/layout/calcmove.cxx:312:29 > #3 0x7f00feb1cbff in SwContentFrame::CalcLowers(SwLayoutFrame*, SwLayoutFrame const*, long, bool) sw/source/core/layout/tabfrm.cxx:1454:19 > #4 0x7f00feb2eded in lcl_RecalcRow(SwRowFrame&, long) sw/source/core/layout/tabfrm.cxx:1581:22 > #5 0x7f00feb186d5 in lcl_RecalcSplitLine(SwRowFrame&, SwRowFrame&, long, long) sw/source/core/layout/tabfrm.cxx:682:5 > #6 0x7f00feb13900 in SwTabFrame::Split(long, bool, bool) sw/source/core/layout/tabfrm.cxx:1268:16 > #7 0x7f00feb20ed9 in SwTabFrame::MakeAll(OutputDevice*) sw/source/core/layout/tabfrm.cxx:2387:47 > #8 0x7f00fe79df2b in SwFrame::PrepareMake(OutputDevice*) sw/source/core/layout/calcmove.cxx:346:5 > #9 0x7f00fe945f70 in SwLayAction::FormatLayoutTab(SwTabFrame*, bool) sw/source/core/layout/layact.cxx:1467:15 > #10 0x7f00fe93e6ca in SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) sw/source/core/layout/layact.cxx:1360:32 > #11 0x7f00fe93e95b in SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) sw/source/core/layout/layact.cxx:1363:29 > #12 0x7f00fe9329c9 in SwLayAction::InternalAction(OutputDevice*) sw/source/core/layout/layact.cxx:550:25 > #13 0x7f00fe92f71a in SwLayAction::Action(OutputDevice*) sw/source/core/layout/layact.cxx:341:5 > #14 0x7f00ffa7bcfd in SwViewShell::ImplEndAction(bool) sw/source/core/view/viewsh.cxx:280:17 > #15 0x7f00fd6e5671 in SwViewShell::EndAction(bool) sw/inc/viewsh.hxx:605:9 > #16 0x7f00fd696865 in SwCursorShell::EndAction(bool, bool) sw/source/core/crsr/crsrsh.cxx:258:18 > #17 0x7f0100a66752 in SwView::OuterResizePixel(Point const&, Size const&) sw/source/uibase/uiview/viewport.cxx:1116:22 > #18 0x7f01177ff562 in SfxViewFrame::DoAdjustPosSizePixel(SfxViewShell*, Point const&, Size const&, bool) sfx2/source/view/viewfrm.cxx:1490:18 > #19 0x7f0117812660 in SfxViewFrame::Resize(bool) sfx2/source/view/viewfrm.cxx:2275:17 > #20 0x7f01178262e9 in SfxFrameViewWindow_Impl::Resize() sfx2/source/view/viewfrm2.cxx:73:17 > #21 0x7f01397ce063 in vcl::Window::ImplCallResize() vcl/source/window/event.cxx:522:5 > #22 0x7f0139c1458e in vcl::Window::Show(bool, ShowFlags) vcl/source/window/window.cxx:2274:13 > #23 0x7f01177b8313 in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) sfx2/source/view/sfxbasecontroller.cxx:1250:24 > #24 0x7f01177b6773 in SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/sfxbasecontroller.cxx:550:13 > #25 0x7f01177708ca in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) sfx2/source/view/frmload.cxx:599:18 > #26 0x7f011776c4dc in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/frmload.cxx:716:13 > #27 0x7f00cd09827c in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1087:37 > #28 0x7f00cd0914f3 in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:372:20 > #29 0x7f00cd08f794 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:158:14 > #30 0x7f00cd146748 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:618:12 > #31 0x7f00cd14690c in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx > #32 0x7f00f5b07b89 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) unotest/source/cpp/macros_test.cxx:50:60 > #33 0x7f011ff48982 in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:668:23 > #34 0x7f011ff49579 in SwModelTestBase::load(rtl::OUString const&, char const*, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:639:16 > #35 0x7f011fe18545 in SwUiWriterTest::createDoc(char const*) sw/qa/extras/uiwriter/uiwriter.cxx:448:9 > #36 0x7f011fffcbb2 in void std::_Bind<std::_Mem_fn<void (SwUiWriterTest::*)()> (SwUiWriterTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933:11 > #37 0x7f011fffc989 in void std::_Bind<std::_Mem_fn<void (SwUiWriterTest::*)()> (SwUiWriterTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991:17 > #38 0x7f0159d6bd20 in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #39 0x7f0159d3ceed in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #40 0x7f0159d3ceed in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #41 0x7f014e24e450 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #42 0x7f0159d3ceed in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #43 0x7f0159cd271b in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #44 0x7f0159d3ceed in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #45 0x7f0159d3652c in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #46 0x7f0159dce8f0 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 > #47 0x7f0159d6a2fc in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #48 0x7f0159d6e1f7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #49 0x7f0159d6d3e8 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #50 0x7f0159d6e1f7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #51 0x7f0159d6d3e8 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #52 0x7f0159dfcf15 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #53 0x7f0159dcd376 in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 > #54 0x7f0159dfde86 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #55 0x535621 in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:319:20 > #56 0x5336e4 in sal_main() sal/cppunittester/cppunittester.cxx:469:20 > #57 0x533112 in main sal/cppunittester/cppunittester.cxx:376:1 > #58 0x7f0158225430 in __libc_start_main /usr/src/debug/glibc-2.24-66-gd5a4092c36/csu/../csu/libc-start.c:289 > #59 0x438929 in _start (workdir/LinkTarget/Executable/cppunittester+0x438929) Change-Id: Ib3dd6317062b39625295ae0b51c30d3826918b35 Reviewed-on: https://gerrit.libreoffice.org/43191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-06Improve performance of loplugin:commaoperatorStephan Bergmann
...by avoiding calls to parentStmt, thereby also improving the precision of exactly which comma operators to ignore (which turned up a handful more finds). Also added tests. Change-Id: Ie74f824fd7f54131aab09b59086452fb4f3ff827 Reviewed-on: https://gerrit.libreoffice.org/43181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-06Fix -fsanitize=signed-integer-overflowStephan Bergmann
during CppunitTest_sw_uiwriter (see below). vmiklos suggested making that addition saturating, so I introduced o3tl::saturating_add for that. <https://ci.libreoffice.org/job/lo_ubsan/684/console>: > /sw/source/core/layout/sectfrm.cxx:1964:23: runtime error: signed integer overflow: 6203 + 9223372036854774315 cannot be represented in type 'long' > #0 0x2b65623b9a65 in SwSectionFrame::Grow_(long, bool) /sw/source/core/layout/sectfrm.cxx:1964:23 > #1 0x2b65625d6f51 in SwFrame::Grow(long, bool, bool) /sw/source/core/layout/wsfrm.cxx:1172:20 > #2 0x2b6562385999 in SwSectionFrame::MakeAll(OutputDevice*) /sw/source/core/layout/sectfrm.cxx:749:12 > #3 0x2b6561b6c728 in SwFrame::PrepareMake(OutputDevice*) /sw/source/core/layout/calcmove.cxx:346:5 > #4 0x2b656257f355 in SwFrame::Calc(OutputDevice*) const /sw/source/core/layout/trvlfrm.cxx:1769:9 > #5 0x2b656247d232 in lcl_InnerCalcLayout(SwFrame*, long, bool) /sw/source/core/layout/tabfrm.cxx:1522:13 > #6 0x2b656247d635 in lcl_InnerCalcLayout(SwFrame*, long, bool) /sw/source/core/layout/tabfrm.cxx:1524:25 > #7 0x2b656247d635 in lcl_InnerCalcLayout(SwFrame*, long, bool) /sw/source/core/layout/tabfrm.cxx:1524:25 > #8 0x2b65624b9b2e in lcl_RecalcRow(SwRowFrame&, long) /sw/source/core/layout/tabfrm.cxx:1559:16 > #9 0x2b65624b0a9f in SwTabFrame::MakeAll(OutputDevice*) /sw/source/core/layout/tabfrm.cxx:2454:29 > #10 0x2b6561b6c728 in SwFrame::PrepareMake(OutputDevice*) /sw/source/core/layout/calcmove.cxx:346:5 > #11 0x2b656257f355 in SwFrame::Calc(OutputDevice*) const /sw/source/core/layout/trvlfrm.cxx:1769:9 > #12 0x2b6561b68bf1 in SwFrame::PrepareMake(OutputDevice*) /sw/source/core/layout/calcmove.cxx:249:13 > #13 0x2b656257f355 in SwFrame::Calc(OutputDevice*) const /sw/source/core/layout/trvlfrm.cxx:1769:9 > #14 0x2b6561b68bf1 in SwFrame::PrepareMake(OutputDevice*) /sw/source/core/layout/calcmove.cxx:249:13 > #15 0x2b656257f355 in SwFrame::Calc(OutputDevice*) const /sw/source/core/layout/trvlfrm.cxx:1769:9 > #16 0x2b6561b6e7de in SwFrame::OptPrepareMake() /sw/source/core/layout/calcmove.cxx:357:13 > #17 0x2b6561fa557d in SwFrame::OptCalc() const /sw/source/core/inc/frame.hxx:889:9 > #18 0x2b6561f6f40c in SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1368:13 > #19 0x2b6561f6f04a in SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1363:29 > #20 0x2b6561f8737e in SwLayAction::FormatLayoutTab(SwTabFrame*, bool) /sw/source/core/layout/layact.cxx:1576:25 > #21 0x2b6561f6eb14 in SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1360:32 > #22 0x2b6561f6f04a in SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1363:29 > #23 0x2b6561f50723 in SwLayAction::InternalAction(OutputDevice*) /sw/source/core/layout/layact.cxx:550:25 > #24 0x2b6561f47023 in SwLayAction::Action(OutputDevice*) /sw/source/core/layout/layact.cxx:341:5 > #25 0x2b6564f03b8f in SwViewShell::ImplEndAction(bool) /sw/source/core/view/viewsh.cxx:280:9 > #26 0x2b655ee80f89 in SwViewShell::EndAction(bool) /sw/inc/viewsh.hxx:605:9 > #27 0x2b655edcccbe in SwCursorShell::EndAction(bool, bool) /sw/source/core/crsr/crsrsh.cxx:258:5 > #28 0x2b6567ac5b5b in SwView::OuterResizePixel(Point const&, Size const&) /sw/source/uibase/uiview/viewport.cxx:1116:9 > #29 0x2b65421f88c1 in SfxViewFrame::DoAdjustPosSizePixel(SfxViewShell*, Point const&, Size const&, bool) /sfx2/source/view/viewfrm.cxx:1490:13 > #30 0x2b6542228d89 in SfxViewFrame::Resize(bool) /sfx2/source/view/viewfrm.cxx:2275:17 > #31 0x2b654226038f in SfxFrameViewWindow_Impl::Resize() /sfx2/source/view/viewfrm2.cxx:73:9 > #32 0x2b650ff227aa in vcl::Window::ImplCallResize() /vcl/source/window/event.cxx:522:5 > #33 0x2b6510a8d5f6 in vcl::Window::Show(bool, ShowFlags) /vcl/source/window/window.cxx:2276:13 > #34 0x2b6542132a1e in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) /sfx2/source/view/sfxbasecontroller.cxx:1250:13 > #35 0x2b654212c985 in SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/sfxbasecontroller.cxx:550:13 > #36 0x2b6542084861 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) /sfx2/source/view/frmload.cxx:599:5 > #37 0x2b65420777e9 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:716:13 > #38 0x2b65b0ed3384 in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1087:24 > #39 0x2b65b0eb7531 in framework::LoadEnv::startLoading() /framework/source/loadenv/loadenv.cxx:372:20 > #40 0x2b65b0eb0063 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:158:9 > #41 0x2b65b10e0078 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:618:12 > #42 0x2b65b10e02fa in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:606:64 > #43 0x2b657183ee13 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:50:51 > #44 0x2b6533b674a3 in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) /sw/qa/extras/inc/swmodeltestbase.hxx:668:23 > #45 0x2b6533b69aa0 in SwModelTestBase::load(rtl::OUString const&, char const*, char const*) /sw/qa/extras/inc/swmodeltestbase.hxx:639:16 > #46 0x2b6533716c59 in SwUiWriterTest::createDoc(char const*) /sw/qa/extras/uiwriter/uiwriter.cxx:446:9 > #47 0x2b6533b50a9d in SwUiWriterTest::testTdf108524() /sw/qa/extras/uiwriter/uiwriter.cxx:5101:5 > #48 0x2b6533d7e36a in void std::_Mem_fn_base<void (SwUiWriterTest::*)(), true>::operator()<, void>(SwUiWriterTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11 > #49 0x2b6533d7e073 in void std::_Bind<std::_Mem_fn<void (SwUiWriterTest::*)()> (SwUiWriterTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11 > #50 0x2b6533d7da81 in void std::_Bind<std::_Mem_fn<void (SwUiWriterTest::*)()> (SwUiWriterTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11 > #51 0x2b6533d7c459 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SwUiWriterTest::*)()> (SwUiWriterTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2 > #52 0x2b6533d7edf0 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14 > #53 0x2b6533d7aaf5 in CppUnit::TestCaller<SwUiWriterTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 > #54 0x2b64ed1ff0ad in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #55 0x2b6508a28ea6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:39:14 > #56 0x2b64ed1bdb77 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #57 0x2b64fca7f7f6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #58 0x2b64ed1bdb77 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #59 0x2b64f8c39e73 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #60 0x2b64ed1bdb77 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #61 0x2b64ed13950f in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #62 0x2b64ed1bdb77 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #63 0x2b64ed1b3da0 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #64 0x2b64ed288efb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10 > #65 0x2b64ed1fc12d in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5 > #66 0x2b64ed2022e3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 > #67 0x2b64ed20124d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #68 0x2b64ed2022e3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 > #69 0x2b64ed20124d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #70 0x2b64ed2c88b6 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5 > #71 0x2b64ed287049 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3 > #72 0x2b64ed2c9d57 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3 > #73 0x515fdd in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:319:13 > #74 0x51098f in sal_main() /sal/cppunittester/cppunittester.cxx:469:14 > #75 0x50eaa2 in main /sal/cppunittester/cppunittester.cxx:376:1 > #76 0x2b64eeeefc04 in __libc_start_main (/lib64/libc.so.6+0x21c04) > #77 0x433704 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433704)> /sw/source/core/layout/sectfrm.cxx:1964:23: runtime error: signed integer overflow: 6203 + 9223372036854774315 cannot be represented in type 'long' Change-Id: Idda17d4f03997f9cc0555103a27f480f33e43877
2017-10-06tdf#66398 Import/export docx document protection propertiesSerge Krot
Added: + import/export of all doc protection properties + unit test Change-Id: I7b65cf4f5c7add2a96fef407c243081fcc2b6d8d Reviewed-on: https://gerrit.libreoffice.org/43156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-06filters: always use "" for includes in current source's directoryMike Kaganski
For rationale, see commit 633f405701fc5cadfa73e950f7a8c122ad01c149 Change-Id: I9a43caca12cc5755ffc5c4fdf16ac7e0660edf2e Reviewed-on: https://gerrit.libreoffice.org/43180 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-05ww8: always use "" for includes in current source's directoryMike Kaganski
For rationale, see commit 633f405701fc5cadfa73e950f7a8c122ad01c149 Change-Id: I2e251ad9ba61cd292bcbd57917e717e4ce14ae63 Reviewed-on: https://gerrit.libreoffice.org/43179 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-05tdf#96505 Get rid of cargo cult long integer literalsudareechk
Removed 0L and 1L in sw/source/ directory files Change-Id: I5c9a7c2f1ff7cc7a4d204540fd93efdc1b4859cf Reviewed-on: https://gerrit.libreoffice.org/42562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-05TSCP: include certificate usage in paragraph signaturesAshod Nakashian
Change-Id: I6f4b891a016c67051efd9033329065d7e3c8a06b Reviewed-on: https://gerrit.libreoffice.org/43022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-05TSCP: remove invalid signatures on savingAshod Nakashian
Change-Id: Ib2bc309966e802eb584fa3c6e37458b840710e81 Reviewed-on: https://gerrit.libreoffice.org/43111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-17 04:18:08 +0000