summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-01-29tdf#122079 - Document orientation is no longer changed in print dialogDaniel
Change-Id: I9d13cfd136f9b70674b3e43268525f8a6e1c0954 Reviewed-on: https://gerrit.libreoffice.org/66483 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29Grab fous from child in spell dialogSzymon Kłos
Change-Id: I8c21623f7148ab2c05fe3d4198cf12231600f88d Reviewed-on: https://gerrit.libreoffice.org/67077 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-01-29Resolves: tdf#110429 width of page number wider than traditional widthCaolán McNamara
since... commit c80ac2ba4a6486e6161e17f9118ba1563b7fc00e Date: Fri Nov 11 18:16:52 2016 +0100 Avoid -fsanitize=signed-integer-overflow Change-Id: I2ec85e854ee1547d55b43b8540c357297d3b6cce Reviewed-on: https://gerrit.libreoffice.org/67068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29tdf#122430 RTF import: fix lost font size on footnote startMiklos Vajna
This become more visible since commit 49614a9ea971ff7f370f863ce8a2735aab973cee (tdf#119599 RTF import: fix missing deduplication of font size, 2018-09-24) as now incorrect font size from style affects the rendering result. Change-Id: I5b339337f021e2fc359f6fc5f5aa2ed0bcf844b9 Reviewed-on: https://gerrit.libreoffice.org/67034 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-28tdf#122942 sw: update shape insert UI for the AddVerticalFrameOffsets optionMiklos Vajna
Regression from commit 50223ea6e212b60b7d33839c2753c5601fb50f95 (tdf#98987 sw: add AddVerticalFrameOffsets compat mode, 2016-03-31), SwFEShell::ImpEndCreate() was not adapted to call SwTextFrame::GetBaseVertOffsetForFly() when determining the vertical position of the inserted shape. The call can be unconditional, the returned value is already 0 when the DocumentSettingId::ADD_VERTICAL_FLY_OFFSETS compat setting is false. Change-Id: Iec6af5a6d1ff3466e08377853cc8ca84f33a76d1 Reviewed-on: https://gerrit.libreoffice.org/67017 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-28ofz#12729 integer-overflowCaolán McNamara
Change-Id: I78db6ab6fcc677247716f42d3c102314415c34d2 Reviewed-on: https://gerrit.libreoffice.org/66993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28sw: avoid wrong and unnecessary downcast in SwDrawView::DeleteMarked()Miklos Vajna
/sw/source/core/draw/dview.cxx:967:39: runtime error: downcast of address 0x6060006d1cc0 which does not point to an object of type 'SwDrawContact' 0x6060006d1cc0: note: object is of type 'SwFlyDrawContact' 1d 02 00 2e b0 3e 06 87 15 7f 00 00 18 3f 06 87 15 7f 00 00 50 1c 28 00 50 61 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'SwFlyDrawContact' #0 0x7f157de946d8 in SwDrawView::DeleteMarked() /sw/source/core/draw/dview.cxx:967:39 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /sw/source/core/draw/dview.cxx:967:39 in When executing testPasteListener in CppunitTest_sw_unowriter since commit 2a054445f09e8ba66e7cfb9f1d598554b555772d (sw paste listener: expose pasted images as well, 2019-01-24), though that code was added much earlier in commit 33141f999b22ce10cdbfbd76081fff211c4b5067 (SwDrawView::DeleteMarked: delete textbox of shape as well, 2014-06-23), just no testcase invoked it. Change-Id: I22a384ab7cc4b3eb00198b28de294896c2d1e3bb Reviewed-on: https://gerrit.libreoffice.org/66986 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-28sw: prefix members of SwTableAutoFormatMiklos Vajna
Change-Id: I17515ea4e444986f50d554c864540a625a521970 Reviewed-on: https://gerrit.libreoffice.org/66984 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-27Use indexed getTokenMatteo Casalin
Change-Id: I7c0bb328def955efce7b3866776e4d47a0ba32c0 Reviewed-on: https://gerrit.libreoffice.org/66947 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Use indexed getTokenMatteo Casalin
Change-Id: Icf0075e7487ea29db5f52846be531d30b231ee05 Reviewed-on: https://gerrit.libreoffice.org/66945 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Reduce OUString temporariesMatteo Casalin
Change-Id: I13777809dbee314e5b0002f8da9d5009c7fc3c5b Reviewed-on: https://gerrit.libreoffice.org/66946 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-26tdf#99573 uiwriter: clear RES_BACKGROUND -> XATTR_FILL_*Justin Luth
The paragraph background wasn't being cleared when hard formatting was removed (unless roundtripped via .ODT only) because a couple of years ago RES_BACKGROUND was aliased to XATTR_FILL, but lots of edge cases are still missed. Perhaps there is a more generic place to handle "reset attribute", but I didn't find it. SwFormat is where most of the aliasing is happening. Change-Id: I9d0a3c70f03f0a5b22155e689e27e3372535aec6 Reviewed-on: https://gerrit.libreoffice.org/65609 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-26tdf#116371: export rotation of SwGrfNodeMike Kaganski
Change-Id: I42620da798a35dfada67d9a9fb23d554cc20b16f Reviewed-on: https://gerrit.libreoffice.org/66963 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-25NFC filter\ww8 misc code cleanupsJustin Luth
comment spelling, unnecessary if statement, and clarifying that a variable that I want to use later is never changed. Change-Id: If42ee9cc036188d06ceb858a23724383e3933e18 Reviewed-on: https://gerrit.libreoffice.org/66920 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-25Assert missing SalGraphics font on GetTextLayoutJan-Marek Glogowski
Trying to layout text without a font can't work. Without a font, currently the text is simply not painted, but this is still a programming error, so warn the developer. And we can get rid of all the intermediate OutputDevice font and gpahics checks, as everything now uses Harfbuzz and there won't be any layout which can't use the cached runs, so just generate them directly. Change-Id: Iae1fab0afeefec1cb1ca82c4e5d8dcbe9919859d Reviewed-on: https://gerrit.libreoffice.org/66818 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-25tdf52391 don't accept format-only changes secretlyLászló Németh
for Reject all in Manage changes dialog window. Now clicking on Reject all keeps format-only changes instead of accepting them during the requested rejection to allow to check them before acception. Note: LibreOffice cannot reject the format-only changes. If changes are all format-only changes, the Manage changes dialog hides the Reject all button, also the Reject button for the selected format-only changes. This patch extends this workaround to avoid unintended acceptance of rejected changes. Change-Id: I7e60ae1ed2bec660dcb19d372dcf6892be61dad6 Reviewed-on: https://gerrit.libreoffice.org/66902 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-25tdf#121665 ooxmlexport: allow each para to have a column breakJustin Luth
The previous logic didn't allow adjacent paragraphs to each have a column break. For example, if this paragraph has a column break, then it would ignore writing the postponed paragraph break from the previous paragraph. In other words, only the last sequential paragraph would get the column break, and the earlier column breaks would just be lost. Introduced a new option, so that this paragraph can write its postponed break, and also pass on a postponed break to the following paragraph. Change-Id: I8afba3470804394f4e0926695e0c11c8e83dff11 Reviewed-on: https://gerrit.libreoffice.org/66878 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-25tdf#92154 limit comboBOX_TEMPLATE lengthRoman Kuznetsov
Change-Id: Ic43f70181b26c88e07445f7c90a8dadcd99b3108 Reviewed-on: https://gerrit.libreoffice.org/66653 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2019-01-25tdf#122607 Don't unnecessarily redo the layoutSamuel Mehrbrodt
Brings weird issues like out of place textboxes as described in the bug. Change-Id: I19341efc48188f0b52069401dc39ba05f4fcc7f6 Reviewed-on: https://gerrit.libreoffice.org/66874 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-01-25loplugin:unusedmethodsNoel Grandin
Change-Id: Ifb0c479e9d1aed1cd90d78ed23902fc05db556d6 Reviewed-on: https://gerrit.libreoffice.org/66862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24ofz#12660 remove flys before removing trailing parasCaolán McNamara
Change-Id: I6c706e5a2066b4fcd4546a22de0aa6327515a0a8 Reviewed-on: https://gerrit.libreoffice.org/66877 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-24Clean up dead uses of DISABLE_ATLStephan Bergmann
...after e597ef0489d9d5504721d21eefa15c65da0fb240 "No need for --disable-activex and --disable-atl any longer" Change-Id: I6ea0026fd18e0097aaaf0c1b05618e2a9ddf1a94 Reviewed-on: https://gerrit.libreoffice.org/66871 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-24sw paste listener: expose pasted images as wellMiklos Vajna
Do it similar to SwXTextView::getSelection(), so that SwView::GetShellMode() determines when an image is selected (and otherwise assume text selection). Change-Id: I717e1358428daba842309260b54f82b62a0aaec1 Reviewed-on: https://gerrit.libreoffice.org/66879 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-24tdf#86731 Don't show 'spelling complete' when dictionary is missingSzymon Kłos
To check if dictionary is missing we have to run spelling which checks used language for each text portion. When AutoSpelling or manually invoked Spelling is performed SwDoc receives notification about missing dictionaries. Then it is possible to not show 'Completed' dialog. Change-Id: I040ce6565632294796c0206d20c4cd0066ca9643 Reviewed-on: https://gerrit.libreoffice.org/66813 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-01-24sw: make it possible to listen to paste eventsMiklos Vajna
The use-case is that the user pastes content and custom postprocessing is necessary for the pasted content. This is not easy by default, since the cursor is at the end of the pasted content, so the start is not known -- even if you intercept the paste UNO command. Precisely tracking the start is possible when using the internal API, SwReader::Read() does something similar already to track the undo range. Only expose the text selection after paste (as a start), but design the API in a way so that other pasted content type (e.g. image) can be added in a backwards-compatible way later. Change-Id: If35bda4244cc417e4858124fb75f7608b95fc556 Reviewed-on: https://gerrit.libreoffice.org/66807 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-24find-unneeeded-includes: don't propose to replace o3tl/deleter.hxxGabor Kelemen
As seen while analysing sw/source/core/inc/DocumentChartDataProviderManager.hxx replacing o3tl/deleter.hxx with fw declaration does not work, it compiles only when it is transitively included. This also removes mistakenly added fw declarations and now unnecessary IwyuFilter blacklist items Change-Id: I2d631f0693dbfd0bb0e62218a525113042c9a907 Reviewed-on: https://gerrit.libreoffice.org/66750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-24loplugin:constparams in swNoel Grandin
Change-Id: I4a0f51eae28c82eca3c44b9d06c0410f9645f62f Reviewed-on: https://gerrit.libreoffice.org/66833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24tdf#122901 track changes: keep paragraph top and bottom bordersLászló Németh
applied in Show Changes mode, instead of losing them after saving the document or hiding the changes. The bug occurred in paragraphs with directly preceding tracked deletions. Change-Id: I25a84aec0159f809dd7b67d4e530e87b01070f44 Reviewed-on: https://gerrit.libreoffice.org/66800 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-01-24tdf#122893 track changes: keep paragraph alignmentLászló Németh
and preset line spaces applied in Show Changes mode, instead of losing them after saving the document or hiding the changes. The bug occurred in paragraphs with directly preceding tracked deletions. Change-Id: I33d9db8ee3522470c4f2dfdcfbea4060db8769a2 Reviewed-on: https://gerrit.libreoffice.org/66789 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-01-24Fix typosAndrea Gelmini
Change-Id: I371d987884987fab8039c3329968f7a9282455f2 Reviewed-on: https://gerrit.libreoffice.org/66829 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-24Add WordBasic.FileClose()Tor Lillqvist
Change-Id: Ifc48e5fbcc212f0e80cf6877e2781910e38e5e54
2019-01-23Related: tdf#122874 first entry is preselectedCaolán McNamara
so no select-handler called Change-Id: I0398b53b24fa8095af67706922c93bb7e8d6d8d2 Reviewed-on: https://gerrit.libreoffice.org/66799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23give email settings dialog a titleCaolán McNamara
Change-Id: Id073f9bc4ed4710ba29d7864f8d03a54fa14354c Reviewed-on: https://gerrit.libreoffice.org/66788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23Related: tdf#122889 weld SwMailConfigPageCaolán McNamara
and reweld SwMailConfigDlg Change-Id: Icf7497db0cd2e9097752414eb11498c694723646 Reviewed-on: https://gerrit.libreoffice.org/66787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23tdf#90097 rtfimport: rewrite unit test so it run reliablyJustin Luth
Already broken for windows and mac, the numbers changed for me on Ubuntu when switching from gcc5 to gcc7 or gcc8. How it still works on the tinderboxes etc I don't know. Anyway, by removing the obviously irrelevant actual numbers, the test still covers the original intent by ensuring that the top point is farther to the right than the bottom point. Change-Id: Ieeb7cd854847d47a11dc305db82371e2b8f85049 Reviewed-on: https://gerrit.libreoffice.org/66724 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-23tdf#115094 part III: DOCX export: export floating tables directlyPatrick Jaap
If a floating table was imported from docx, it will be placed in a frame. A grabBag attribute remembers the original positioning values. Restore this state when exporting to docx again and do not export the surrounding frame. This has to be done at the start of a paragraph, so remember the exported table in a std::set and skip it later in frame export. Change-Id: Ib62d4b228b306e5d1c4ce61fbbd4b6c3e1206603 Reviewed-on: https://gerrit.libreoffice.org/65982 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-23Resolves: tdf#122889 Mail config dialog is emptyCaolán McNamara
revert... commit 7ec12ce7e449d7849b3e67c443783110e2a50a17 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Sep 28 20:24:35 2018 +0100 weld SwMailConfigDlg the contained page needs to be converted first Change-Id: I9788132b0ad11cec853be7339be1829386794511 Reviewed-on: https://gerrit.libreoffice.org/66781 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23Resolves: tdf#122480 make style dialogs take their optimal sizeCaolán McNamara
and let them resize given that they add/remove tabs depending on the language settings. Leaving them unresizable will result in them too large on switching from ctl+cjk to without Change-Id: I56027b1c737822d170416ff4e2497745cb3889ff Reviewed-on: https://gerrit.libreoffice.org/66779 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23sw: prefix members of SetGetExpFieldMiklos Vajna
Change-Id: I1ad767fa4dfbf4f3055cc94778c13bfe169f79af Reviewed-on: https://gerrit.libreoffice.org/66753 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-22partially revert ofz#11275 erase via positionCaolán McNamara
partial revert of: commit e8833d4dd9322c01cf5b6d458fc86d3735cf9999 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jan 21 09:33:04 2019 +0000 because of the concerns of https://gerrit.libreoffice.org/#/c/66665/ i.e. "this looks like it reintroduces the bug fixed in 471212d464f54054f7419ef1890267d0def852d9" but continue to erase the final entry by its known index, rather than force a lookup of the index of the final entry Change-Id: Ic14aa133779b5555e8856d6c8fefe4e9b854e2fa
2019-01-22Resolves: tdf#122880 list of obj types at 0 height with gtk 3.18Caolán McNamara
Change-Id: Ib50bc94d1dd4c90cf1516110d413c480aff603ab Reviewed-on: https://gerrit.libreoffice.org/66739 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-22fix build, loplugin:stringconcatCaolán McNamara
Change-Id: Ie3cc086235591a48b8807484ed61716341d61786
2019-01-22Related: tdf#108021 Fix text break of X axis labelsBalazs Varga
Recalculate the nLimitedSpaceForText in case of 90 and 270 degree if the X axis label's text break is true. The first part of the fix: https://gerrit.libreoffice.org/65165 Change-Id: I5d78be6ed83dd195bbc34185d5f6b7e44f555d9b Reviewed-on: https://gerrit.libreoffice.org/65937 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-22Found documentation for WordBasic.ToolsOptionsView()Tor Lillqvist
Change-Id: Ic049f78fddcaabafbe6be18b92a87b56352c1a4c
2019-01-22tdf#117935 Accessible text-attributes-changed signals...Noel Grandin
... should only be emitted when the text attributes have changed [a11y] second attempt. This appears to have begin at commit 7d9bb549d498d6beed2c4050c402d09643febdfa Date: Mon Jun 2 15:00:50 2014 +0000 Related: #i124638# Second step of DrawingLayer FillAttributes... Which accidentally removed the aWhichSublist param from the SwUpdateAttr constructor in SwpHints::TryInsertHint. Change-Id: If435ea71e8d84e0d8497cd7106cfdbebcc6af7a0 Reviewed-on: https://gerrit.libreoffice.org/66719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-22tdf#42949 Fix IWYU warnings in include/xmloff/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id20e0bc42e39f868a7c5d49d756f2ad5e14a86c0 Reviewed-on: https://gerrit.libreoffice.org/66637 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-22RTF filter: add TQDEC testcaseMiklos Vajna
lcov points out this was uncovered previously. Change-Id: I8f83e811a0f1144dd7ba6a695b4856cdeb7350cf Reviewed-on: https://gerrit.libreoffice.org/66703 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-21tdf#101826 ww8import: add XATTR_* to textbox attr setJustin Luth
Somewhat magically, just adding XATTR to the FlySet makes background colors/gradients/images appear. This has been broken since XATTR was introduced in LO 4.3. Change-Id: I84554045f49618a5eb927edfebdf641c5a93b673 Reviewed-on: https://gerrit.libreoffice.org/66310 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-21Add a couple of known parameters to WordBasic.ToolsOptionsViewTor Lillqvist
Change-Id: Ifd472f4ca79ab97a1d6d5c5007537375121f6f58
2019-01-21Implement WordBasic.FileSave()Tor Lillqvist
Change-Id: Iafb5be16ebb23aa09e0300a77c2f2dbe29b85cad
generated by cgit (git 2.34.1) at 2025-01-19 16:02:39 +0000