summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-08-14Removing unused SetVersionMap from swVarun Dhall
Change-Id: I453efd9fd93941dcdf193b461de1377b76506cde Reviewed-on: https://gerrit.libreoffice.org/41099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-13cppcheck: really remove the memsetJulien Nabet
Change-Id: Ic84e5ca6175d718548e9ee4f9f406ffc899f791a Reviewed-on: https://gerrit.libreoffice.org/41121 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-13cppcheck: Using 'memset' on struct that contains a 'std::unique_ptr'Julien Nabet
+ use constructor initialization Change-Id: I52cb85bf7102dd3f8cf2105fc1c23229b76f28bc Reviewed-on: https://gerrit.libreoffice.org/41107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13cppcheck: variableScopeJochen Nitschke
Change-Id: I4dfbd80cf06acb4968556a78d3eaf394757073dc Reviewed-on: https://gerrit.libreoffice.org/41110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-12tdf#107197: Replace relationship URIChristian Barth
Replaced URIs in sw/source/filter Change-Id: If73c30e9d590742568a3009a6d593f1b3249a5a4 Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/41055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-12Removed duplicated includeAndrea Gelmini
Change-Id: I68286aaf7bce262cfc6d371490221e910a3ba7c6 Reviewed-on: https://gerrit.libreoffice.org/41040 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11tdf#89409 Render ruby inside the grid in standard mode.Mark Hung
In standard mode the text grids are rectangle and do not have dedicated space for ruby text. The ruby text either overlap with base text of the last line or clipped ( after scrolling ). Move ruby text inside the grid in standard mode as if there is no grid, and algin text to the center to keep the original text-to-text alignment behavior. Change-Id: Ia75ee016f9d492e4e73da6d7245aaeff40cbe1f3 Reviewed-on: https://gerrit.libreoffice.org/40632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-08-11m_pPostponedVMLDrawings is unused nowTamás Zolnai
Change-Id: Iec685588ef7a1d5284072ebc8fcadc07dae67364 Reviewed-on: https://gerrit.libreoffice.org/40999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-11sw: fix typo in SwXStyle::GetStylePropertyMiklos Vajna
OSL_ENSURE -> SAL_WARN_IF forgot to invert the condition in commit 6abe9cfa924236b9915888470723fec612e1a16d (refactor out to limit scope: RES_PARATR_OUTLINELEVEL, 2016-03-11). Change-Id: Ie0272e7e178e1065d4b619deafbb4e33fcd5d14d Reviewed-on: https://gerrit.libreoffice.org/41018 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-11Resolves: tdf#111571 crash on restarting writer with modeless biblio dialogCaolán McNamara
Change-Id: I2663f84c28721f61c1ed7c8d92a228cafa8f1177 Reviewed-on: https://gerrit.libreoffice.org/41036 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-11convert std::map::insert to std::map::emplace IINoel Grandin
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11tdf#105705 sw: fix another case of bookmarks becoming un-sortedMichael Stahl
The loop in SwTextNode::Update() that reassigns bookmark end positions away from the node to a temporary SwIndexReg can stop prematurely in a particular situation where there is a bookmark that is expanded and with both mark positions at the critical "rPos" insertion position, and also both their SwIndexes consecutive in the SwIndexReg::m_pFirst linked-list. What happens then is that the iteration gets to the first of the 2 consecutive positions of the bookmark, then calls GetMarkEnd() on the mark, which happens to return the other position, which is already stored in the "next" local variable. That other position is then moved to aTmpIdxReg, and in the next loop iteration GetNext() is null as it is the last one in aTmpIdxReg and the loop terminates. Thus various bookmark end positions don't get preserved, or the bAtLeastOneExpandedBookmarkAtInsertionPosition doesn't get set, either of which can cause the bookmark array to lose its sort order. This was found playing around with Zotero 4.0.29.10, while switching between different citation styles. (regression from 6a5dbe73537642b06bcde782118a34b4593d17eb) Change-Id: Ia35ce0656bcb2d6af7ea189458af3942ff83e4da
2017-08-11tdf#108494 fix regressionSzymon Kłos
* correct watermark position * insert also on left and right pages if headers are different Change-Id: Ibacfa6ea14bd8e9c1fd0d0b15de020b30d0a109f Reviewed-on: https://gerrit.libreoffice.org/40891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-11sw: fix inconsistent param naming in interface/implementationMiklos Vajna
SvxPostureItem& rWeight is confusing at best. Change-Id: I70a7e94151f49bf3539af77160cd4a68b8753464 Reviewed-on: https://gerrit.libreoffice.org/41006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-11tweak string convert table dialog to load the same with native gtk builderCaolán McNamara
Change-Id: I5f6753645452b578d30909614cb3cc36ae3d7e64 Reviewed-on: https://gerrit.libreoffice.org/40983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-10tdf#39468: Translate some german commentsChristian Barth
Change-Id: Ie9062738de26b44394d4c91b31fab99a7777813f Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/40994 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-10Fix typosAndrea Gelmini
Change-Id: Ia138abbdb81f0c324721118d487392757f779a96 Reviewed-on: https://gerrit.libreoffice.org/40971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-10editviewoverlay: EditViewSelection reorganizedArmin Le Grand
The Selection visualization in EditVierw is organized to use XOR for visualization, thus DrawSelection is used e.g. before and after changes to the Selection. Ensured athat all changers of selection have to use SetEditSelection by making return of GetEditSelection const. This allows to use a central and safe SelectionChanged which is needed for alternatives of Selection visualization. Change-Id: I994553f3be6b58fd595aa500922d8d1d8ddd36d4
2017-08-10loplugin:unusedenumconstantsNoel Grandin
Change-Id: I54c0c1fca8ea5c89e71c6cd1110fad081ed3d334 Reviewed-on: https://gerrit.libreoffice.org/40953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-10tdf#79167 Change search type through a drop down controlJames Raykowski
drop down control to change 'navigate by' search element small navigation popup relationally linked to drop down control dynamic tool tips added to previous and next 'navigate by' toolbar controls Change-Id: I4b1215b74b488f2571b529d9946f6574de6e270a Reviewed-on: https://gerrit.libreoffice.org/40776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-08-10tdf#111550: A workaround for out-of-order (in-paragraph) tbl on OOXMLMike Kaganski
Word allows <w:tbl> to be direct child of <w:p>, which is illegal according to ECMA-376-1:2016. This allows for import the data in such tables (previously, this text was simply dropped, causing dataloss) - bug-to-bug compatibility with Word. Change-Id: I19c17ab19915ea46685727c635476fe5df593212 Reviewed-on: https://gerrit.libreoffice.org/40909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-09tdf#91384: DOCX: import ActiveX controlsTamás Zolnai
Change-Id: Iebf2ff65fcec3231acfc962fb2f1abc2ed2dc67a Reviewed-on: https://gerrit.libreoffice.org/40930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-09Resolves: tdf#99286 for jpeg dpi use apis that know about MapUnit::MapPixelCaolán McNamara
move the code which can do this from sw to vcl Change-Id: I9940fb80ecdbfe8f70afc500c691288ed0993701 Reviewed-on: https://gerrit.libreoffice.org/40925 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-09tweak string input dialog to load the same with native gtk builderCaolán McNamara
Change-Id: I61d20fe998b1b393c2794e4753f8316511ff7456 Reviewed-on: https://gerrit.libreoffice.org/40920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-09tdf#111480 Circular text was imported horizontallySzymon Kłos
Change-Id: I84a6c3a30fd1dddf104ad8bf037a5e0b2a90d376 Reviewed-on: https://gerrit.libreoffice.org/40912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-09tdf#66212 - Hebrew numbering import/export supportYossi Zahn
Adds support for the new NUMBER_HEBREW numbering format to various import and export filters. Change-Id: I93f928f5d4d43d0cf569a85677df7eef7b088db8 Reviewed-on: https://gerrit.libreoffice.org/36645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-09tdf#97362: TextPortionEnumerationTest partially migrated to python (part 5)jmzambon
Convert tests: - test_range1 - test_range_hyperlink_hyperlink - test_range_hyperlink_ruby - test_range_ruby_hyperlink - test_range_ruby_ruby Change-Id: I6c26f3e0fe910ff56bf38482257340b1c3172461 Reviewed-on: https://gerrit.libreoffice.org/40775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-08SvPersistStream deadNoel Grandin
since commit 1e4b1e4a1aca3b333820b0a865997e6f62e80064 "Removing unused SfxItemPool serialisation from editeng" Change-Id: I8a3cd36a13b7d2322047c2035e0f23c70ca9cdf0 Reviewed-on: https://gerrit.libreoffice.org/40880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:unusedmethodsNoel Grandin
Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b Reviewed-on: https://gerrit.libreoffice.org/40876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I7aa23e56f2c126bf505262454408340b557f13cf Reviewed-on: https://gerrit.libreoffice.org/40865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:constantparamNoel Grandin
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07tweak insert table dialog to load the same with native gtk builderCaolán McNamara
we can't share adjustments between widgets where we just wanted to share initial settings and not subsequent changed adjustment settings and set default responses Change-Id: I9c15f97a87b0a631e414cc0d3b76f7447fc9ecd3 Reviewed-on: https://gerrit.libreoffice.org/40849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-07Fix typosAndrea Gelmini
Change-Id: I4969e9e66de602a8c79774460a0215ef9d150372 Reviewed-on: https://gerrit.libreoffice.org/40795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-07loplugin:constparams in sw part10Noel Grandin
Change-Id: I7d708c3e6157d0b8690b433d3363d2c0745b2410 Reviewed-on: https://gerrit.libreoffice.org/40832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07tdf#39468: Translate some random German comments and termsJens Carl
Change-Id: I05912b89d059256b20233a0fac244630544d5b0a Reviewed-on: https://gerrit.libreoffice.org/40800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-07loplugin:constparams in sw part9Noel Grandin
Change-Id: I2edba9cde5a5efd06815a55632703b706ca523c7 Reviewed-on: https://gerrit.libreoffice.org/40830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07loplugin:constparams in sw part8Noel Grandin
Change-Id: I0fb51270da4b8f3049f1af2c2c788e516b3641e8 Reviewed-on: https://gerrit.libreoffice.org/40821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07sw: prefix members of SwNoTextNodeMiklos Vajna
Change-Id: I6a272d1c83c58e1b6ef610eed7964309d1622a7e Reviewed-on: https://gerrit.libreoffice.org/40820 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-07Indentation fixesMiklos Vajna
These files had a consistent style before, let's keep them that way. Change-Id: If64773d8c29dee23638e4fb9b7e5b69b34d47e49
2017-08-06loplugin:constparams in sw part7Noel Grandin
Change-Id: Iaace9c024649481b2f7cdd67aaf1e86624fe0d4a Reviewed-on: https://gerrit.libreoffice.org/40811 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-06loplugin:constparams in sw part6Noel Grandin
Change-Id: Ic82946cf9be50d9d9c43338b86dfb700ce5b354c Reviewed-on: https://gerrit.libreoffice.org/40786 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-05Fix typosAndrea Gelmini
Change-Id: Ib7f43bf17ab8b9fb9d961a908d7620b50826a975 Reviewed-on: https://gerrit.libreoffice.org/40688 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-04loplugin:constparams in sw part5Noel Grandin
Change-Id: I6c33709aa407ccb3eee7026ab9b40dc4257de209 Reviewed-on: https://gerrit.libreoffice.org/40769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-04coverity#1416133 Unchecked dynamic_castCaolán McNamara
Change-Id: I6706e3f889c8c00bdc4bda56fe5f282472589a40
2017-08-04tweak insert break menu to load the same with native gtk builderCaolán McNamara
1) we can use a GtkComboBoxText for this simple case and move the liststore into the widget 2) add the response ids for the buttons Change-Id: I7b3bd10c05f35b0e34bbbebc9f7a811f87d443ac
2017-08-04loplugin:constparams in sw part4Noel Grandin
Change-Id: Ic42b2691869b61ba906222db893e284d8b9c39c1 Reviewed-on: https://gerrit.libreoffice.org/40767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-04loplugin:constparams in sw part3Noel Grandin
Change-Id: I05ad3204af4e6ec3c832b185a1b35fdb75a229b2 Reviewed-on: https://gerrit.libreoffice.org/40760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-04rename nToleranz->nToleranceNoel Grandin
Change-Id: I4a61f1cf9b94f7df98a8e9560c1384c948abf2c1 Reviewed-on: https://gerrit.libreoffice.org/40737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-04sw: store paragraph signature as rdf metadataAshod Nakashian
Change-Id: I13e6079e2aa3bee3dac10b11b0a23e9b798e02a3 Reviewed-on: https://gerrit.libreoffice.org/40722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>