summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-11-27tdf#138307 Chart import: fix lost custom shape textBalazs Varga
Do not set empty text to SdrOutliner, if it is already set. Note: Also fix the missing custom shape problem in tdf#72776 and tdf#93641. The wrong position (X:0, Y:0) of these shapes is another problem. Regression from commit 6f62a5c4ee2c1b7654c7fcaa618fb495e0d32f0a (tdf#128985: ODP: Style text directions revert to RTL on save and re-open) Change-Id: I07d8cb12836daf15db347f6bb19c17ed9373189e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104909 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-27tdf#138345 sw ms export: Char highlight: no export to char-styleJustin Luth
MS Word ignores w:highlight in a character style. It only accepts it as direct formatting or in para-styles. So never export the character background as w:highlight, but always as w:shd for character styles. Change-Id: I7c9f4f00d957a8add848746051d3c4b1522d1520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106182 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-27writer notebookbar update for 7.2andreas kainz
Change-Id: Id754c59acd5a548fb96b085e63d1e8f39805ca46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106721 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-27sw_fieldmarkhide: fix getFieldMarkFor() to return innermost fieldMichael Stahl
... like it's supposed to; if it finds the outer field and then the next field is inside but ends *before* the rPos then the loop is erroneously terminated. Change-Id: Ic5e469d1c05cecd7feca275dc1689af2c40567f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106710 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-26tdf#124176: Use pragma once instead of include guardsGül Toksöz
Change-Id: I334fee9257c83aa940b256b049d4408ab2e53a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106609 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-11-26tdf#135198 tdf#138050 sw editing: fix text box position syncDaniel Arato (NISZ)
Follow-up to commit c9eb53f200225f2ee6ca695e1326843a487aee51 (tdf#135198 sw editing: text box fell out of its shape) Every time a shape is repositioned, make sure the text box inside the shape follows the shape. The previous solution to this bug, the one implemented in SwObjectFormatterTextFrame::DoFormatObjs, was a little more cumbersome. This one should produce fewer regressions, I hope. Change-Id: I3e88eb8616cd299cabb7b74b188ab7220746ec89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106421 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-26Expose tracking changes actions in context menu for onlineSzymon Kłos
Change-Id: I127be4ed0803b8de25c6fd0dfdc6ee0f931d6922 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105551 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106692 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26tdf#131920 sw UI Char highlight: editing via Para-style highlight tabJustin Luth
Modify character highlight using paragraph style dialog's new "Highlight" tab. Extends 5.0 commit 15931deb7e4689cd885ff05439bab381f0478b2f to also work in the para-style dialog. Prior to 4.4, the background tab supported char background but that was lost when the area tab replaced it, and therefore there was no capability at the time of 5.0. This highlight tab didn't exist until 5.1: author Zolnai Tamás on 2015-06-16 22:25:38 +0200 commit 9874db206eed84616e4e232b1b56c7b7532166a0 tdf#90072: No character background (highlight) tab in paragraph styles dialog Background Tab was replaced with Area Tab on Paragraph Style Dialog. With that we lost the opportunity to set character background color. So bring back the Background tab as Highlighting. Change-Id: I916a91ea4f2ce77a8c501ecea5fd25811c5c3cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106323 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-26Check render parameters for AutoSpellCheckingMert Tumer
Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx sw/qa/extras/tiledrendering/tiledrendering.cxx Change-Id: Ife2551b4023461da26e70ac3de505adf9d7db1e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106602 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-26tdf#137503 sw ChangesInMargin: fix Undo/Redo of deleted paragraphLászló Németh
Tracked deletion of paragraph(s) consists of several hidden redlines in "Show changes in margin" mode. Fix Undo by setting them all visible with recovering the original deletion range. Follow-up of commit 469f472fb31c4ef1a57f8ec54ba750c1332feec2 (tdf#138479 tdf#137769 sw ChangesInMargin: fix Undo in paragraphs). Change-Id: Ib92aa5055eaf3e0754a154a2c78172378f6e6f6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106608 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-26tdf#138479 tdf#137769 sw ChangesInMargin: fix Undo in paragraphsLászló Németh
Fix Undo of embedded tracked deletions in paragraphs, for example Undo of deletions Lorem->Loem->Lm resulted only Loem, moreover a crash in the case of typing (not tracked) text before the tracked deletions. Now the last tracked deletion is chosen by the biggest SwRangeRedline ID during Undo instead of the lost/modified redline range in case of hidden redlines of the ChangesInMargin mode. Note: revert commit 4ad0459494303745b377c848c681a747f294fc64 (tdf#138135: sw ChangesInMargin: join characters at backspac) to avoid crash on extra Undo (tdf#137769). Showing deleted character sequence in margin needs grouping of hidden redlines, as for managing tracked changes. Change-Id: Ia9dab5cbbc08f39e05ff8e499efff37bc825c624 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106582 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-26Refactor SwFormatDropBjoern Michaelsen
... and get rid of the SwClientNotifyCall. Change-Id: I2118290944c21e9773c359109e60e7778459a41f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106365 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-25tdf#138130: sw_uiwriter: Add unittestXisco Fauli
Change-Id: If7eca097e83003d657cc39ae617eaccabcf62a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-25Removed executable bits on odt fileAndrea Gelmini
Change-Id: Ia1b0792f7988a816018a2fa6df1e66e83cba24d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106584 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-25Use sal_Int64 to printf tools::Long valuesStephan Bergmann
(The "%l" format specifiers had now caused -Werror,-Wformat with clang-cl for a Windows 64-bit build.) Change-Id: I86b9617310f7348d72172cc7a29f0976c7030dd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106576 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25crashtesting: null deref on load of ooo72915-2.odtCaolán McNamara
since... commit aacaa2aa91f705d64b929b5cff2872f160021b9f Date: Tue Nov 3 22:11:59 2020 +0100 sw_fieldmarkhide: let CheckParaRedlineMerge() hide fieldmarks HideIterator finds the next delete redline or fieldmark, whichever is closer. Change-Id: Ibe4373255356d9fe235f787c5672e72ae7032f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106578 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-11-25lok: Don't even iterate through the redlines when they are disabled.Jan Holesovsky
It is not necessary, when we are not issuing any output anyway. Change-Id: Id952549befb1bef04a2dd9237d286922939eaae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 8f44a939ad09d0365607ae8960e2abfe77e3fe72) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106517 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-11-25tdf#137894 separate associated character propertiesMark Hung
in ww8filter/RtfAttributeOutput and treat \dbch as CJK and \hich Western in order to roundtrip the RTF document. ww8filter mix all the associated style, including properties for CJK and CTL scripts. Both RtfAttributeOutput::CharFontCJK and RtfAttributeOutput::CharFontCTL output \dbch, that result in incorrect assocation. CharFontCTL should use \rtlch, but it was already in RtfAttributeOutput::MoveCharacterProperties. To make the order correct, I separate the associated character properties that were stored in m_aSyltesAssoc into m_aSyltesAssocRtlch, and m_aSyltesAssocDbch by their script types. Note that it is not clear what associated character properties that we should adopt for \hich and \ltrch. In theory RTL scripts can output high ANSI chars too, so \hich may get properties from either Western or CTL scripts. However, examining Hebrew RTF documents, I didn't see any sign that \hich is used in that way. Use RTL as CTL might be a problem for Mongolian, Manchu and Xibe. They are CTL but top-to-bottom (aka LTR) . But I don't think they will be expressed as high ANSI chars either. Change-Id: I214edbb00a67c2ffe19c5a37254c8988a0828f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106355 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-25Fix --disable-pch build on WindowsMike Kaganski
Restore inclusion of <unotools/transliterationwrapper.hxx>, added in 63f7efe613f4f7436eddd90933c1916d2e689648 to fix exactly the same problem that reappeared now after removing it in commit fe88ffb661053f8fff9bd77affdf4de820c43ca8. This partially reverts fe88ffb661053f8fff9bd77affdf4de820c43ca8, making the inclusion conditional. Change-Id: Iab6893549377e1b8f2f96150b09b7294c9476fa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106555 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-24sw tiled rendering: fix paint->invalidation loop when paint is started by vclMiklos Vajna
SwViewShell::PaintTile() already calls comphelper::LibreOfficeKit::setTiledPainting(), so by the time it would rearch SwViewShell::Paint(), callbacks (e.g. invalidations) are ignored during paint. Do the same for SwEditWin::Paint(), where we processed invalidations during paint, potentially leading to paint->invalidation loops. Change-Id: I8280f5c2571beeae6c0f2986d275dde3c2d33161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106542 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-24ofz#27817 null derefCaolán McNamara
Change-Id: I16da6f6f78dfd0a4bc17017275a6644d6e4340c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24sw: fix SwXTextRange::createEnumeration() inside table cellMichael Stahl
This would set CursorType::SelectionInTable but leave m_pOwnTable and m_pOwnStartNode uninitialised, causing sw/source/core/unocore/unoobj2.cxx:399: SwXParagraphEnumeration: table type but no start node or table and then the enumeration would return the table it's in as the first element, which is quite annoying. Refactor the creation of SwXParagraphEnumeration to prevent this. Change-Id: I4e9e3456bdf66b9822d19ad985a20b094e6bbba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106532 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-24tdf#124176: Use pragma once instead of include guardsBayram Çiçek
Change-Id: I8df8d454ff1b65a5df2f1920b4d01f0925cbce33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106489 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-24tdf#42949 Fix new IWYU warnings in directory swGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4bb84c3f401aba8a3dede9cec3a7f2187a2ba02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106473 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24sw: fix copying and deleting of section content via APIMichael Stahl
The problem happens if a section starts or ends with a table: SwXTextSection::getAnchor() may return a SwXTextRange with one position in a table cell and another position in a different table cell, or outside the table, neither of which is valid to set the cursor via SwXTextViewCurosor::gotoRange(). Introduce a new special mode for SwXTextRange, RANGE_IS_SECTION, analogous to RANGE_IS_TABLE but actually working. Only SwXTextView can be used to create XTransferables, and it requires selecting first via either the SwXTextViewCursor or select(). It's currently not possible to select the content of a section in the ViewShell in these problematic cases, and would be some effort to add. So add a new interface XTransferableTextSupplier that can be used to create XTransferable from the SwXTextRange with RANGE_IS_SECTION. The core CopyRange() and DeleteRange() functions can deal with SwPaMs that start or end in non-text-nodes, so pass the whole section content to these in SwXTextRange::setString() and in SwXTextView::getTransferableFromTextRange(). Change-Id: If7e3210e8a26f5618317c294f2b2f3ed5c217f1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106293 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-24sw: exception messages for SwXTextRangeMichael Stahl
Change-Id: Iee53473ead4151348c2f02f4a83bd0bd17c46758 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106292 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-24tdf#137546 sw: fix text position at textbox alignmentAttila Bakos (NISZ)
Follow-up of commit 06fd06597796d9e92117602245f3968c93707708 (tdf#124430 Writer Editing: Fix textbox aligning). Testing: 1. Insert a shape. Choose menu item "Add Text Box" of its local menu, and write a short text in it. 2. Choose menu item "Align->Right" of the local menu of the shape. The textbox is aligned to the right margin and before the fix, text position had changed slightly within the shape. (Only moving the textbox fixed it.) Change-Id: I758e0f65c8b51e09ac15a96e19819cb3ad3beacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105253 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-24Avoid unnecessary, wrong downcast from SwFormatRowSplit to SwFormatFrameSizeStephan Bergmann
...after b28e514d5e0ea45490b3cab30e1d97dd3da2c794 "callnk: Replace needless SwClientNotifyCall with CallSwClientNotify", as seen during e.g. CppunitTest_sw_ooxmlexport3 CPPUNIT_TEST_NAME=testDontSplitTable::Load_Verify_Reload_Verify (see <https://ci.libreoffice.org/job/lo_ubsan/1834/>): > /sw/source/core/layout/tabfrm.cxx:3900:30: runtime error: downcast of address 0x6020001b9990 which does not point to an object of type 'const SwFormatFrameSize' > 0x6020001b9990: note: object is of type 'SwFormatRowSplit' > bd 0e 00 2f 70 4c 61 a4 c2 2a 00 00 02 00 00 00 7a 00 00 00 00 00 00 00 00 00 00 04 10 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwFormatRowSplit' > #0 0x2ac29baf508b in SwRowFrame::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/tabfrm.cxx:3900:30 > #1 0x2ac2988d9b4d in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:367:18 > #2 0x2ac2988d9e45 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:372:15 > #3 0x2ac2988d7025 in SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/calbck.cxx:184:5 > #4 0x2ac2989205c8 in SwFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/format.cxx:325:9 > #5 0x2ac29b2746d9 in SwFrameFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/layout/atrfrm.cxx:2619:15 > #6 0x2ac2988d5208 in SwClient::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:115:9 > #7 0x2ac2988df973 in SwClient::SwClientNotifyCall(SwModify const&, SfxHint const&) /sw/inc/calbck.hxx:161:80 > #8 0x2ac2988da413 in sw::ClientNotifyAttrChg(SwModify&, SwAttrSet const&, SwAttrSet&, SwAttrSet&) /sw/source/core/attr/calbck.cxx:381:13 > #9 0x2ac298927a44 in SwFormat::SetFormatAttr(SfxPoolItem const&) /sw/source/core/attr/format.cxx:536:13 > #10 0x2ac2f953e607 in MSWordExportBase::OutputTextNode(SwTextNode&) /sw/source/filter/ww8/wrtw8nds.cxx:2257:54 > #11 0x2ac2f9571ace in MSWordExportBase::OutputContentNode(SwContentNode&) /sw/source/filter/ww8/wrtw8nds.cxx:3505:13 > #12 0x2ac2f98681dc in MSWordExportBase::WriteText() /sw/source/filter/ww8/wrtww8.cxx:2804:13 > #13 0x2ac2f8e8e01b in DocxExport::WriteMainText() /sw/source/filter/ww8/docxexport.cxx:1670:5 > #14 0x2ac2f8e8abf4 in DocxExport::ExportDocument_Impl() /sw/source/filter/ww8/docxexport.cxx:520:5 > #15 0x2ac2f98b52f3 in MSWordExportBase::ExportDocument(bool) /sw/source/filter/ww8/wrtww8.cxx:3360:19 > #16 0x2ac2f8f106a1 in DocxExportFilter::exportDocument() /sw/source/filter/ww8/docxexportfilter.cxx:86:17 > #17 0x2ac2dc707424 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /oox/source/core/filterbase.cxx:492:49 > #18 0x2ac2eddb9010 in (anonymous namespace)::WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /writerfilter/source/filter/WriterFilter.cxx:155:23 > #19 0x2ac28d79c39b in SfxObjectShell::ExportTo(SfxMedium&) /sfx2/source/doc/objstor.cxx:2451:25 > #20 0x2ac28d78b3ac in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1539:19 > #21 0x2ac28d7be9f7 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:2926:39 > #22 0x2ac28d7b6d1c in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:2717:9 > #23 0x2ac28d724080 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objserv.cxx:315:19 > #24 0x2ac28d93df20 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) /sfx2/source/doc/sfxbasemodel.cxx:3086:42 > #25 0x2ac28d944909 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1728:13 > #26 0x2ac2a93a73b7 in SwModelTestBase::reload(char const*, char const*, char const*) /sw/qa/unit/swmodeltestbase.cxx:554:16 > #27 0x2ac2a93a56e3 in SwModelTestBase::executeLoadVerifyReloadVerify(char const*, char const*) /sw/qa/unit/swmodeltestbase.cxx:110:5 > #28 0x2ac286939928 in testDontSplitTable::Load_Verify_Reload_Verify() /sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:936:1 > #29 0x2ac28693d184 in void std::__invoke_impl<void, void (testDontSplitTable::*&)(), testDontSplitTable*&>(std::__invoke_memfun_deref, void (testDontSplitTable::*&)(), testDontSplitTable*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14 > #30 0x2ac28693cd5e in std::__invoke_result<void (testDontSplitTable::*&)(), testDontSplitTable*&>::type std::__invoke<void (testDontSplitTable::*&)(), testDontSplitTable*&>(void (testDontSplitTable::*&)(), testDontSplitTable*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14 > #31 0x2ac28693cbb2 in void std::_Bind<void (testDontSplitTable::* (testDontSplitTable*))()>::__call<void, 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:467:11 > #32 0x2ac28693c812 in void std::_Bind<void (testDontSplitTable::* (testDontSplitTable*))()>::operator()<void>() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:549:17 > #33 0x2ac28693b8a1 in std::_Function_handler<void (), std::_Bind<void (testDontSplitTable::* (testDontSplitTable*))()> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:316:2 > #34 0x2ac2868427b1 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706:14 > #35 0x2ac28693ab84 in CppUnit::TestCaller<testDontSplitTable>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 > #36 0x2ac23bbb05ba in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #37 0x2ac25698b937 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:46:14 > #38 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #39 0x2ac24aff3fd7 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:78:12 > #40 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #41 0x2ac247b490a8 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:61:16 > #42 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #43 0x2ac23bb18f84 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #44 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #45 0x2ac23bb7b697 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #46 0x2ac23bc1aa79 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 > #47 0x2ac23bbaec21 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #48 0x2ac23bbb2a52 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #49 0x2ac23bbb1c4a in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #50 0x2ac23bbb2a52 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #51 0x2ac23bbb1c4a in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #52 0x2ac23bc4860e in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #53 0x2ac23bc194de in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 > #54 0x2ac23bc4956b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #55 0x4fedce in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:323:20 > #56 0x4fb4c0 in sal_main() /sal/cppunittester/cppunittester.cxx:473:20 > #57 0x4fa4ae in main /sal/cppunittester/cppunittester.cxx:380:1 > #58 0x2ac23d859554 in __libc_start_main (/lib64/libc.so.6+0x22554) > #59 0x425ea4 in _start (/workdir/LinkTarget/Executable/cppunittester+0x425ea4) Change-Id: Icd1fdd2a7b11106761d17cd22b1f9a4fe9f8896d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106472 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24tdf#138194 Chart OOXML import: set text break to trueTünde Tóth
of rotated category axis label, if the rotation is 90 or 270 degree and the inner size of the chart is not fixed. Change-Id: I02e1fd940af8a277435aa46d4ad93a42b6723710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106422 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24tdf#138253 sw textbox: fix content of draw format on undoMiklos Vajna
Regression from commit da4f9b77a6cd39b1ae5babdd476d1575c8b9371c (tdf#135149 sw: fix deleting textbox of as-char shapes, 2020-09-07), the crash was caused by a user-after-free triggered from the X11 clipboard code. This could happen beause the clipboard document had a draw frame format, which has an SwNode pointer, but the SwNode instance was outside that clipboard document, and the owning document is already gone. So by the time the clipboard document would be deleted, the SwNodeIndex can't de-register itself. The root cause was that the doc model was corrupted after a cut of a textbox + undo: the textbox pointers of the fly/draw formats were OK, but not the SwFormatContent of the draw format. Change-Id: I5761b72948caca397320aed801559e8493c33e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-23tdf#138374: sw_ooxmlexport15: Add unittestXisco Fauli
Change-Id: Ie0bb8fa230f092fa3b0c96e47af4d553c6ff2db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106424 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-23tdf#124176: Use pragma once instead of include guardslastirembender
Change-Id: Idd8dda6abecdb04356dd00d7dabcc6ff6bd85208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-23sw: prefix members of SwFrame, SwFrameAreaDefinition, SwLayVout and SwLineRectMiklos Vajna
See tdf#94879 for motivation. Change-Id: I93627e54ba9330e8e1ff2136ab00ecd743c0dd79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106397 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-23tdf#124176: Use pragma once instead of include guardsMuhammet Kara
Change-Id: I6182d5b123b183603708b6d0d83e4aeac7c85dc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106304 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-11-23tdf#120290 sw: comment no longer needs any widthJustin Luth
Way back in 2001 with commit dca044e9572144c1ba9ce423b10f7a5456837cda, Fix #93831#: Larger range for tip help on notes, comments were called Notes, and looked similar to Calc's comments - just a tooltip kind of note that you hover over. Adding some fake space to the comment anchor probably helped to get access to that note. But now that comments are always visible in a side panel, there doesn't seem to be any need to pretend that the comment anchor takes up any space, which fixes a few corner cases where that fake width exceeded the real width of small portions that followed. Change-Id: I4e9dac12dce0545e0ac79e46597f6e441dc066a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105747 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-23section.cxx: Remove remaining SwClientNotifyCallsBjoern Michaelsen
Change-Id: I569c5952a7491c37c677ad6b6d5f803a50b2e701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106341 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-23Similarly, the proper noun “SmartArt” shouldn’t be pluralizedAdolfo Jayme Barrientos
This completes commit ab97fe1b9b988936bf96b198387eaf3ff00fed61. Change-Id: Ie73ee1ee763034cb03a5a6d7acf20f145e34056f
2020-11-23Copyedit: “Fontwork” is uncountable, “be sure” ≠ “make sure”, ↵Adolfo Jayme Barrientos
“in order to” redundant Change-Id: I0f361823d7f9af5de4e8c62011f66d59670346d4
2020-11-23fastparser in SwXMLTableContextNoel Grandin
Change-Id: I52ea773993a19384c5a7ad3eb95b518446ea5e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-22Fix typosAndrea Gelmini
Change-Id: I89ffb8e99aef3e71f723d25a757a26520dcdf71a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106337 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-11-22fastparser in SwXMLDocContext_ImplNoel Grandin
Change-Id: I21fa16d473660e06b73a75964f3317b13e2e05e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106359 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-22Removed executable bits on data fileAndrea Gelmini
Change-Id: Ibf469c30fc10587d57a3a97193c847c7c7b86c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106339 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-11-22tdf#124176: Use pragma once instead of include guardsGökhan Özeloğlu
Change-Id: Idab6bdb8574887c224eafbae100c2495998ca76f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106334 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-22Refactor SwSectionFormat::UpdateParentBjoern Michaelsen
- This ancient piece of code managed to stack premature optimization on premature optimization all the while obfuscating the intend pretty well. - It also ultimately resulted in a pessimization, e.g. when a SwSectionFormat is found first, in which case GetSection() is called, which starts a new loop from the start. Change-Id: I8e33b3bc592740d7d144e7d4463eb62b27bc8fe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106327 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-22tdf#124176: Use pragma once instead of include guardsGökhan Özeloğlu
Change-Id: I6ec0bb025e715b34a7c0ba80875de23c5eb418b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106332 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-22tdf#124176: Use pragma once instead of include guardsGökhan Özeloğlu
Change-Id: Icbd13762abaaaed0d2c90d31469fc931900ffd5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106333 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-22tdf#124176: Use pragma once instead of include guardsGökhan Özeloğlu
Change-Id: Id2cf80a9a89530e8ed15ec8c0c87e4e45840ff0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106335 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-22tdf#124176: Use pragma once instead of include guardsTolunay Dündar
Change-Id: Iecc46d37ff7c79543f7bbd2111e2effdb3f71c90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106324 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-22tdf#124176: Use pragma once instead of include guardsTolunay Dündar
Change-Id: I74f5f128e739e199002c60388243a5a7c60dee0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106325 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-03-12 19:51:00 +0000