summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2014-05-10coverity#708472 Uninitialized scalar fieldCaolán McNamara
Change-Id: I09767fe28069e195b568ce91c62770a85cc7c6ab
2014-05-10coverity#708513 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ifcc2356717de7227c52649351f6c7b29568269fe
2014-05-10coverity#1213553 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia15102812846956fe5ac4c6aee710e845baf4715
2014-05-10Avoid temporary OUStringsMatteo Casalin
Change-Id: I25bd1c5900ba5a934c8cb87797e5d06313b75e9f
2014-05-10Function description says negative values mean errorsMatteo Casalin
Change-Id: Ief7639dc857c3123a1696d2221e6c64cd2276397
2014-05-10Simplify sw_GetCellPositionMatteo Casalin
Change-Id: If672256b85c1e0a6534055844c3df936c0636c3f
2014-05-10OUString: remove temporaries and concatenated appends, constifyMatteo Casalin
Change-Id: Iea37617435e69a51bb0d70740092f0489f58e41a
2014-05-10Use more proper integer typesMatteo Casalin
Change-Id: Ia16638564b54d4ac0fb1ce2ede41f0c76cc7df53
2014-05-10OUString: avoid temporaries and concatenated appendsMatteo Casalin
Change-Id: I55843e876f1a01c7800cd638fc0ec0bae4933994
2014-05-10sal_uInt16 to size_tMatteo Casalin
Change-Id: I25e92cc92aaa2b5b808b7c369101055b5f77aff3
2014-05-10Simplify IsPreviewPosInDocPreviewPageMatteo Casalin
Change-Id: I6c1a57dc7095125f36ffe5ad0a4fd54ba240287f
2014-05-10Simplify return paths/expressionsMatteo Casalin
Change-Id: I198b3d349934837f7b7e6b49bf4b2a7785736a61
2014-05-10No need of else after a returnMatteo Casalin
Change-Id: I7f7bb520085f0d1855dce8656a54e5f72f2b5ed5
2014-05-10Constify sal_uInt16 and sal_Int16 to sal_uInt16Matteo Casalin
Change-Id: Ie03f3591279f7cedff6f5acf3af46bebf3d2c1b1
2014-05-10Simplify GetRowOfPage and GetColOfPageMatteo Casalin
Change-Id: Iebe6c17a057999a20a46fb6ea756dc1c0a052dbc
2014-05-10Use GetRowOfPageMatteo Casalin
Change-Id: Ieb6e268223aabea42f5df0d69a8b8d4498eaba77
2014-05-10OUString: avoid temporaries and constifyMatteo Casalin
Change-Id: I12762daed58e8006e95cc10c3ba0b1d7564a012e
2014-05-10sal_uInt16 to sal_uInt32/size_t + constifyMatteo Casalin
Change-Id: I948990f551b4096aa5575090315ab66fc4eb368d
2014-05-10No need to use/store those OUStringsMatteo Casalin
Change-Id: Ied28223690f6672fbd99984fb9a5b44353138594
2014-05-10Constify 2 sal_uInt16Matteo Casalin
Change-Id: I24cdc87e87f3b7d05678eeb86df9a179cba10328
2014-05-10Constify two OUStringsMatteo Casalin
Change-Id: Ia136841959480212b2f7e525544e5e2f52064990
2014-05-10sal_uInt16: constify and reduce scope + int to sal_uInt16Matteo Casalin
Change-Id: I68757c5e8367d97d707c77df2b7cf5ba6404ab58
2014-05-10Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8Julien Nabet
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
2014-05-09update_pch: add a bunch of pch filesThomas Arnhold
I had to fix some source files because of macro redefinitions and such stuff. Small modules like basic have a great win, too: make basic.clean && time make basic: with w/o pch pch accessibility 23s 1m59s basctl 30s 1m42s basic 56s 1m35s comphelper 23s 51s editeng 48s 2m04s forms 40s 1m40s unotools 19s 38s sd 3m37s 4m33s Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f Reviewed-on: https://gerrit.libreoffice.org/9293 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-09warning C4389: '==' : signed/unsigned mismatchMichael Stahl
Change-Id: Ie8bb8a422c2fdda85d2478dd029c2091267212c2
2014-05-09ooxml: Preserve shape 3d effects: top and bottom bevelJacobo Aragunde Pérez
Shapes 3D effects can specify top and bottom bevels like in the following example: <a:sp3d z="488950" extrusionH="63500" contourW="50800"> <a:bevelT w="139700" h="88900" prst="cross"/> <a:bevelB h="88900" prst="relaxedInset"/> </a:sp3d> This patch preserves the a:bevel* tags and their attributes using the shape grab bag and modifies an existing unit test to add this check. Change-Id: I4762111e4d2f75ba2fd3721a126aa324a28a853c
2014-05-09ooxml: Preserve shape 3d effects: z, contour and extrusionJacobo Aragunde Pérez
Shapes can contain 3D effects like in the following example: <a:sp3d z="488950" extrusionH="63500" contourW="50800"/> This patch preserves the a:sp3d tag and its attributes using the shape grab bag and modifies an existing unit test to add this check. Change-Id: Ice3cae39c71784be0f6c7f2700b07c21a5e1fb6e
2014-05-09oox: preserve scene3d/lightRig effects on shapes.Jacobo Aragunde Pérez
Shapes can contain 3D effects like in the following example: <a:scene3d> <a:camera prst="isometricLeftDown" zoom="150000"/> <a:lightRig rig="threePt" dir="t"> <a:rot lat="0" lon="0" rev="4800000"/> </a:lightRig> </a:scene3d> This patch preserves the a:lightRig tag, its attributes and the child element a:rot using the shape grab bag. It also adds a unit test for this case. Change-Id: I66b6de3c2b5ef89223b10da54006e28113b8ba5f
2014-05-09fdo#78292: Tags related to checkbox r being written in text tag for sdt cntnt.umeshkadam
- The parent node for checked, checkedState, uncheckedState is getting overwritten by "text" - text node is a leaf node, and should not have any children. Change-Id: Ic269525001e914adc1aa328c92be5fe4d5d1b3e7 Reviewed-on: https://gerrit.libreoffice.org/9278 Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com> Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2014-05-09Resolves: fdo#78150 Ctrl+Backspace does not erase first characterJulien Nabet
See https://bugs.freedesktop.org/show_bug.cgi?id=78150#c1 and https://bugs.freedesktop.org/show_bug.cgi?id=78150#c2 1) there's a wrong conversion with negative number given to a xub_StrLen parameter, anyway it works on 4.2 2) The existing code can be simplified since we don't need to remove spaces before the word to delete Change-Id: I7e2510038666018059a54ac09c1a599154084b48 Reviewed-on: https://gerrit.libreoffice.org/9245 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-05-09fdo#77720: Mail Merge: reset cursors after clearing documentMichael Stahl
The root cause for the crash is that the shell has an invalid cursor that does not point at a paragraph; this is because first the document is filled and the cursor is pointed at the content of a frame, then the document is cleared from SwFrmCtrlWindow::Resize() [not sure why?] and at that point the cursor remains on an SwEndNode (which is invalid). Change-Id: I47c1e2a34d5579953c1896ff0895568978e72bc7
2014-05-09coverity#735545 Logically dead codeCaolán McNamara
Change-Id: Ifa1bc627da203575b36e7e944c66b945f813016d
2014-05-09coverity#735546 Logically dead codeCaolán McNamara
Change-Id: Ibe25db9809ffc9a91e938fd5e02811492b03afc5
2014-05-09coverity#735523 Logically dead codeCaolán McNamara
Change-Id: I3a8ee3de5862d4d3862f3511e1716f0e4f786150
2014-05-09coverity#1209783 Dereference before null checkCaolán McNamara
Change-Id: Idac50085b04a2520b87bb4912e24fe59eae0a372
2014-05-09coverity#1209804 Dereference before null checkCaolán McNamara
Change-Id: Ie32f71b0f089c0687807f1ef2329f41b35ecf076
2014-05-09coverity#1209816 Dereference before null checkCaolán McNamara
Change-Id: I125daf37f07c7b84289625d046abe8257c82e8d4
2014-05-09fdo#71834 make reproducer document more minimalMiklos Vajna
1,5M -> 21K without loosing anything interesting. Change-Id: I145612b9242dd6570e0b4e90f85171b177214500
2014-05-09fdo#77890: page break exported as section break if different 1st page is setumeshkadam
- Page break was getting exported as section break in case if the different first page was set. - Fixed this issue and added a UT. - For additional details regarding the issue please check the following https://www.libreoffice.org/bugzilla/show_bug.cgi?id=77890#c2 Reviewed on: https://gerrit.libreoffice.org/9234 Change-Id: I6799b204c0d1c80a7e07119e2e3aac337520cb08
2014-05-08Fix 'outset' and 'inset' table border type import in DOCX and RTFAdam Co
In the past, LO did not support 'outset' and 'inset' border types for tables, so when encountering them - LO converted them to other types of border. Now that LO supports it - DOCX and RTF filters were changed to import these border types correctly. DOC filter was not changed, because creating a proper DOC sample file that has these border types (needed for the 'bordertest.hxx' file) was not possible right now. So at least DOCX and RTF filters are fixed. Change-Id: Ida2449d45a0ac138388f3cbfeb41657db1d4cda9 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-05-08fdo#78444 sw: avoid incorrect right shrinking of repaint rectangleMiklos Vajna
The old condition was: set the right edge of the repaint rectangle, in case the result would be wider than the original (if we repaint more, that can't hurt regarding the end result) or in case the left edge was set. But that's problematic, the reproducer situation described in the bug triggers a case when the right edge is shrunk too much, so part of the painted letter is missing. Fix that by only setting the right edge of the repaint rectangle when we know that it won't shrink. Change-Id: I33b78a929021b284d5283fc2c35e0b3c999fa224
2014-05-08Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part6Julien Nabet
Change-Id: Ib523206d67ad13416557be1b37a58ba7a9791ca5
2014-05-08Resolves: #i27364# set line count of dropdown to 9...Tsutomu Uchino
for document list of navigator on Writer (cherry picked from commit c104272ea1274dea87cd66cfaa61b34806708521) Change-Id: Iac9644d513dd1195b3986d79607f336dc6ed9884
2014-05-08use new VCL IsValueChangedFromSaved methodNoel Grandin
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963 "RFC: add IsValueChangedFromSaved to VCL button and listbox" Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08Related: fdo#77720 Writer crashes when running Mail Merge WizardJulien Nabet
Change-Id: I02695420ff4f54ad15b077ab1d16f27ff684e5da Reviewed-on: https://gerrit.libreoffice.org/9111 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-08various: sal_Bool->boolNoel Grandin
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-05-08coverity#1209298 Logically dead codeCaolán McNamara
Change-Id: I370f1ff7df1c19e23560599b86b2274649bd5f73
2014-05-08coverity#1209146 Logically dead codeCaolán McNamara
Change-Id: I6777dffb436471b5df69d40a15bd32b473dcfc40
2014-05-08coverity#736155 Dereference null return valueCaolán McNamara
Change-Id: I781a949abb47b6e845a222a4fa8f685e9a620693
2014-05-08coverity#736152 Dereference null return valueCaolán McNamara
Change-Id: I5582d0481c0b99f92e7a3a07fbe7a904a1696442