summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-04-02weld SwTableWidthDlgCaolán McNamara
Change-Id: I272a783c9b7a8f725314e416fbd81217105ee5a6 Reviewed-on: https://gerrit.libreoffice.org/52266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02drop the spurious invisible_char[_set] propertiesCaolán McNamara
Change-Id: I8264a4f6035fd19c7a892902c41127615eaf6dd3 Reviewed-on: https://gerrit.libreoffice.org/52265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02weld SwPreviewZoomDlgCaolán McNamara
Change-Id: Ie159032cfdf6201aba707a8980845ac15c1fba17 Reviewed-on: https://gerrit.libreoffice.org/52264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02ofz#7285 Integer overflowCaolán McNamara
Change-Id: I56f642013ba8d1047067d69251f8a60bd768ee2e Reviewed-on: https://gerrit.libreoffice.org/52254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02Fix typoAndrea Gelmini
Change-Id: I0289c22c62c4bf7ad93d01571008f34d78d15a1d Reviewed-on: https://gerrit.libreoffice.org/52197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-02ofz#7229 Divide by zeroCaolán McNamara
Change-Id: I7bd2f19d5dc99e9041b3ef0fc10caef6d8b7ca6a Reviewed-on: https://gerrit.libreoffice.org/52253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02tdf#115131 made a common submenu for toolbars and notebookbarsKshitij Pathania
Also added the submenu in base, maths and draw Change-Id: I94850c09c08fd3848eabe2597679634f30fbc735 Reviewed-on: https://gerrit.libreoffice.org/49575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-04-01fix some openoffice bugzilla linksdennisroczek
* remove redirects * use https links * replace old attchment links with working ones Change-Id: Ic9a154f46e142138f0adea7d7b8be3b6cfe8af18 Reviewed-on: https://gerrit.libreoffice.org/52224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-01Fix typoAndrea Gelmini
Change-Id: I8983e1ef73051febd796d737cba1a58558b80bbf Reviewed-on: https://gerrit.libreoffice.org/52209 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-01SwXTextRange::Impl: use WriterMultiListenerBjoern Michaelsen
Change-Id: Ib850916bfed8a5eb6ca97419db9d7be0bdef1257 Reviewed-on: https://gerrit.libreoffice.org/52217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-01SwXDocumentIndexMark::Impl: use WriterMultiListenerBjoern Michaelsen
Change-Id: Ia4e09e1e3b95553fbedba515d70875c1d8aa14f0 Reviewed-on: https://gerrit.libreoffice.org/52215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-04-01NB implementation: finish writer tabbed NBsandreas kainz
Change-Id: Ibaf3ea11c229c4de27c479dab6ab4f2823b840d9 Reviewed-on: https://gerrit.libreoffice.org/52203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-31loplugin:unusedfieldsNoel Grandin
Change-Id: Id2dea1d3a56d5d3be03c5a2a4f2ef530a05f9b19 Reviewed-on: https://gerrit.libreoffice.org/52185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-31restore carelessly removed expandtab for vimhimajin100000
see Miklos' comment on https://gerrit.libreoffice.org/#/c/52168/ Change-Id: Ief0cc781580e9b50c28d5f550189469ffa82d25a Reviewed-on: https://gerrit.libreoffice.org/52191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-31Split ooxmlexport10 into two unit test modules.Mark Hung
Change-Id: Ibd714f81f76717ac159897f6ee9f907a8098cabe Reviewed-on: https://gerrit.libreoffice.org/52153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-31adapt to variable name change in commit ca67dcaehimajin100000
Change-Id: Ie5eef74f76221b45c72a78f53a3f7ce072f02b5c Reviewed-on: https://gerrit.libreoffice.org/52168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-31Writer tabbed notebookbar update home and layout tabandreas kainz
Change-Id: Ife58e6b958395a45378a0efd6f3c805c2c05aa96 Reviewed-on: https://gerrit.libreoffice.org/52177 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-30weld SvxZoomDialogCaolán McNamara
Change-Id: I9d68fdcc9dc27a5aa4f6ec78542ce7822259233e Reviewed-on: https://gerrit.libreoffice.org/52157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-30weld SvxCharacterMap dialogCaolán McNamara
and SmSymDefineDialog There's a whole bunch of interrelated stuff which needs to work at the same time. add menu support, keyboard support, better mouse support, a gtk scrollable adaptor to support pseudo scrolling drawing bodge, plugable uitest support for custom widgets, plugable a11y support for custom widgets via the existing atk_object_wrapper_new wrapper for XAccessible In this specific case, change SvxCharacterMap from something that has an internal scrollbar to a scrolledwindow where the scrollbar is external, which drops the need for the a11y impl of SvxCharacterMap to emulate being a scrolled window and internal table and just needs the table a11y impl Change-Id: Ia2743d6958021c525a1900154dcbb69ae33fc400 Reviewed-on: https://gerrit.libreoffice.org/52084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-30Avoid crash-reporter crash.Michael Meeks
http://crashreport.libreoffice.org/stats/crash_details/f5086a7d-3c67-46e4-945e-e0882a604eee Change-Id: Ic9ceed2e736a4ad1c155a31d3b2dc453e6a562aa Reviewed-on: https://gerrit.libreoffice.org/52119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-30forcepoint#36 avoid dangling SvTextShapeImportHelper in case of exceptionsCaolán McNamara
Change-Id: Ibdbc047029c31d2b06d2349d68e1cbd9b15fd514 Reviewed-on: https://gerrit.libreoffice.org/52135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29tdf#113558 Header missing for table stylesheiko tietze
Change-Id: I3b48e9d8d2acfb33f003a6505737b0c25f5a2637 Reviewed-on: https://gerrit.libreoffice.org/52123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-03-29Clean up copy/paste (of a function called "paste")Stephan Bergmann
Change-Id: Iea48bb3304e2688b440c5c396ed340ffffa11568 Reviewed-on: https://gerrit.libreoffice.org/52121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-29loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ic044a6e4568e707022d87bc5712205fbdf084ba2 Reviewed-on: https://gerrit.libreoffice.org/52067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29tdf#112886 ooxmlimport: skip useless footnote placeholderJustin Luth
Inserting the 0x02 placeholder as the first entry in the line interferes with the aesthetic tab code. lcl_text has code to ignore that placeholder, but lcl_utext doesn't. Ignoring at lcl_utext has the same affect as not processing it at all. Only .docx adds 0x02, so it should be fairly safe to avoid the 0x02 completely. Nothing was detected missing by skipping the placeholder. All of the code was inherited from OOo. Change-Id: Ie8840e5946fec89f270fef5523c88ee5051ca8ef Reviewed-on: https://gerrit.libreoffice.org/51912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-29coverity#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I14cfde619e1280c21d8481fc58c5ba69855c1b5d Reviewed-on: https://gerrit.libreoffice.org/52064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29coverity#1433645 silence Out-of-bounds readCaolán McNamara
Change-Id: Ie098ea6fd2b36e8bc6173f3ca69f2ffc5e312533 Reviewed-on: https://gerrit.libreoffice.org/52062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29Operate on copies of test documentsStephan Bergmann
...as the SwTextBlocks ctor internally calls SwDOCXReader::MakeEntries -> BeginPutDoc which wants to open the document read-write. That would fail if SRCDIR is a read-only tree. Change-Id: I433b80bcec53c8ca4282d1f45c941153a4064eb9 Reviewed-on: https://gerrit.libreoffice.org/52053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-29Propagate BeginPutDoc failure out of SwDOCXReader::MakeEntriesStephan Bergmann
(BeginPutDoc can fail if the document is a read-only file) Change-Id: I2ee6f421e73459daf75adce67dedb47b23931d7c Reviewed-on: https://gerrit.libreoffice.org/52045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-29loplugin:useuniqueptr in SwNumRuleNoel Grandin
Change-Id: Id74c0dac582b1dc52076488332e26c88e5e7b4c3 Reviewed-on: https://gerrit.libreoffice.org/52033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:useuniqueptr in SaveRedlEndPosForRestoreNoel Grandin
Change-Id: I529ca5016ab22a8e57655da7fe5ec4f3344a05d5 Reviewed-on: https://gerrit.libreoffice.org/52032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:useuniqueptr in DocumentFieldsManagerNoel Grandin
Change-Id: I79d18cb8fdb029afbe6008edd058265b1503e5eb Reviewed-on: https://gerrit.libreoffice.org/52031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:useuniqueptr in DocumentDeviceManagerNoel Grandin
Change-Id: I051f63173a7b58819d340b00ea237a4164b1dbad Reviewed-on: https://gerrit.libreoffice.org/52030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:useuniqueptr in CompareDataNoel Grandin
Change-Id: Id089f39a03f3793f2a5d9c24130d25ce6823df5a Reviewed-on: https://gerrit.libreoffice.org/52029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:virtualdown in vclNoel Grandin
Change-Id: Iea173295b7bc5e7f8a5e0215dc13ab32190c6f8f Reviewed-on: https://gerrit.libreoffice.org/51999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29Always pass in a TextInsertModeRangeStephan Bergmann
...otherwise testCopyPastePageStyle would have caused the call to xFilter->filter in paste() to fail, throwing an "End of content node doesn't have the proper start node" RuntimeException in SwXBodyText::createTextCursorByRange (sw/source/core/unocore/unotext.cxx) called from the writerfilter::dmapper::DomainMapper_Impl ctor (writerfilter/source/dmapper/DomainMapper_Impl.cxx) (and which would be caught and swallowed in RtfFilter::filter (writerfilter/source/filter/RtfFilter.cxx), causing it to return false). Change-Id: I83b720a365e06edc41c3d9c82614df488ee33d35 Reviewed-on: https://gerrit.libreoffice.org/52013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-29Fix typosAndrea Gelmini
Change-Id: I0f606816871d90173dedaa9fc4eb7e6ccebe0b1a Reviewed-on: https://gerrit.libreoffice.org/51919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-28tdf#116407 - option "Border" for new table redundantheiko tietze
Function removed Change-Id: I2346a0ba91afb72c7c68a6d50fc103d0409ae374 Reviewed-on: https://gerrit.libreoffice.org/51896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in table Change-Id: I108136bd79dcc603649c996ecd58c74d67d7dab9 Reviewed-on: https://gerrit.libreoffice.org/51805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28Translate German function namesJohnny_M
Akt -> Current in ww8 Change-Id: I3beb046cbce7727c7ff485de9ff956ee087c443c Reviewed-on: https://gerrit.libreoffice.org/51802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28tdf#108122 HTML export: fix lost images on copyMiklos Vajna
As in the copy part of copy&paste. The problem was that the document has an empty base URL during copy, and this was images were not exported at all. An alternative fix would be to use embedded images, but sadly Word's HTML import doesn't understand that markup, so use tempfiles instead. Change-Id: Iab8c555ac244d943c4958f24f8ac61cba4ec3aba Reviewed-on: https://gerrit.libreoffice.org/52003 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-28fix duplicate strings in notebookbarChristian Lohmaier
and also one in alreadyexistsdialog Change-Id: Ib503f742ca6e99246d1e8fc07a9d2cd418ba2133
2018-03-28Pasted-in document need only be opened for readingStephan Bergmann
Otherwise, if SRCDIR is a read-only tree, CppunitTest_sw_rtfimport would fail with the CPPUNIT_ASSERT_EQUAL(ERRCODE_NONE, pStream->GetError()); from <https://gerrit.libreoffice.org/#/c/51992/> "Check successful stream creation". (And before that, it would have more obscurely failed with the CPPUNIT_ASSERT_EQUAL(2, getParagraphs()); in testTdf90260Par failing with 1 vs. 2.) Change-Id: I55fcc932c66e6a4b84cd391f8821257a0de2abb8 Reviewed-on: https://gerrit.libreoffice.org/51993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28Check successful filter operationStephan Bergmann
Change-Id: I220905486cc2287f2157f57b537c0df0b325bd36 Reviewed-on: https://gerrit.libreoffice.org/51994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28tdf#116570 ww8 export: skip sectionbreak for footnotesJustin Luth
An extra CR was added at the start of each footnote. I'm guessing these documents started life as "end of document" footnotes in Word. SectionBreaksAndFrames is only used by .doc, so this will not affect .docx and .rtf (which are both fine anyway). I forgot that I recently fixed the same problem for endnotes in tdf#108448. Nice to have found example footnote documents also. Change-Id: Ib496e02d9ff46dbc2337a6d3dfe164a625b09a83 Reviewed-on: https://gerrit.libreoffice.org/51771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-28Check successful stream creationStephan Bergmann
Change-Id: Iea7dea13684a15ed1960d2c8562253f5a2e64c34 Reviewed-on: https://gerrit.libreoffice.org/51992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28loplugin:virtualdown in swNoel Grandin
Change-Id: Ia4053970a23d62ac7483f18d6caa559ddf43b176 Reviewed-on: https://gerrit.libreoffice.org/51988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28drop newly unused HTMLMODE_NO_BR_AT_PARENDCaolán McNamara
Change-Id: I4e1c0355a10e0334439beb04c54bde24dada0dd2 Reviewed-on: https://gerrit.libreoffice.org/51960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-28sw: fix some IWYU warningsMiklos Vajna
Change-Id: I96a6401f0cc7bf9f219717671e41932d7d8570b7 Reviewed-on: https://gerrit.libreoffice.org/51972 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>