summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-01-30loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb9c91b3e8d6c2dd3a639a239fa41e7d5c7a4ee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30tdf#129659 DOCX check global footnote contextJan-Marek Glogowski
Since tdf#121441 we parse custom footnotes to get at least the DOCX footnote text, even if we can't represent the formating. This might push additional contexts to the parser stack. Therefore it's now not sufficient to check the current context for a footnote, but one has to check the global parser for a footnote context. The actual bug is the unsupported footnote page break, which was not correctly ignored and added a paragraph context to the stack, resulting in the async substream input and output stack size. Change-Id: I143254e7df37a619cb4efb542b58d3eff3afffa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87114 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-01-30tdf#45589 sw: create and paint text portions for bookmarksMichael Stahl
Add a new SwBookmarkPortion, derived from SwControlCharPortion. There is no character for the bookmark in the text so the portion has length of 0, which makes things quite a bit more tricky. Formatting: * SwBookmarkPortion is created last in WhichFirstPortion(). * In an empty paragraph the SwTextFrame::FormatEmpty() must be disabled. * If there's a bookmark at the end of a paragraph, SwTextFormatter::CalcAscent() must use the font of the previous character, not the paragraph font, because that could grow the line if it's higher. * The SwMultiPortion complicates matters, because it uses a nested SwTextFormatInfo and thus we need some extra steps to prevent duplicate SwBookmarkPortions; this is particluarly a problem for rotated text portions. - SwTextFormatter::BuildPortions() must advance the outer SwTextFormatInfo's bookmark position because BuildMultiPortion() has already created the SwBookmarkPortion. - If a SwBookmarkPortion is at the start of a SwMultiPortion, it will be created before the SwMultiPortion but must be painted inside the SwMultiPortion because its font is going to be initialised as inside the SwMultiPortion (e.g. it will be rotated) so its position must also be adapted to be inside, and only SwTextPainter::PaintMultiPortion() does the setup for that; add a hack to move it in SwTextFormatter::BuildMultiPortion(). Painting: * Using the original font seems rather difficult, hard to predict what some character is going to look like, and how it scales if the size is increased; use OpenSymbol instead. Unfortunately OpenSymbol doesn't have a good glyph that could be used for both the end of a bookmark and start of another bookmark at the same position. * SwLinePortion::PrePaint() wants to avoid moving the portion half-outside the frame but often it looks better that way (previously it was misaligned, now it's half-outside). * Not sure if it makes sense to draw a field shading in SwTextPaintInfo::DrawViewOpt() too; let's try it out, but dependent on the same IsViewMetaChars() setting as the bookmark character itself, not on the field shading setting. Change-Id: I1ab94afb417221e278dbb3afd6c978a05fc78497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87364 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: fix rotation bugs in SwLinePortion::PrePaint()Michael Stahl
The sign was flipped for the 90° case, resulting in painting too far up the page, ever since this was added in 293ed704cf15107049578c2e6e5ed00dcac2d4fb. In SwControlCharPortion::Paint() rotation wasn't handled at all. Change-Id: I83a7eef8b2f6126e070d8c48f75378b6cf6d50e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87707 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: reformat bit of SwLinePortion::PrePaint()Michael Stahl
Change-Id: Id088e3f73e6bda3c6b11d421a52c59c67446f8a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87706 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30sw: these SAL_WARN_IF should be assert()Michael Stahl
Change-Id: Ifddea3cd34f419d9b8b87a3f913be590ad4d5ce7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87705 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: split text portions at bookmarksMichael Stahl
Always create the portion, not just when the IsViewMetaChars is active. This has the advantage that nothing has to be invalidated when toggling, and the disadvantage that kerning at bookmark positions will never happen. Change-Id: I78943f337eef5c64cff33f6df6ff1a10acb1b8bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87363 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: add bookmarks to SwScriptInfoMichael Stahl
Add a list of bookmark positions in the text frame to SwScriptInfo. Initialising this turned out to be more complicated than expected. Change-Id: I1738186b057b0eece80177097a03826365107589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87202 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30tdf#45589 sw: invalidate on bookmark insertion/deletionMichael Stahl
Invalidate the text frames when a bookmark is inserted or deleted; also when MarkManager::repositionMark() changes the positions. The other calls of SetMarkPos()/SetOtherMarkPos() look like they're all from code that corrects positions after text insertions or deletions so no additional invalidate should be necessary there. It turns out that one WW8 document in sw_filters_test wants to insert a bookmark on a SwGrfNode; check for that in makeMark(). Change-Id: I293e6da9042bea5992cb27091b9cff77e5c7961d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87157 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-30DOCX export: implement support for user fieldsMiklos Vajna
Updating the field doesn't work yet, that'll need additional markup in settings.xml. Change-Id: I562ae62cebcbd5ca474bd0f7a181773f8e515f5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87720 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-30Revert "SwAutoCompleteClient: SwClient no more"Stephan Bergmann
This reverts commit fa26db1c053a8510ada15fcbaa7e36ae0f6920a5 for now, as it breaks UBSan builds during e.g. JunitTest_sw_unoapi_1 (<https://ci.libreoffice.org/job/lo_ubsan/1518/>): > /sw/source/core/doc/acmplwrd.cxx:138:9: runtime error: member access within address 0x607001517be0 which does not point to an object of type 'SwAutoCompleteClient' > 0x607001517be0: note: object is of type 'SvtListener' > af 07 80 42 d0 8e 97 f4 84 2b 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 04 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvtListener' > #0 0x2b85787e94b6 in SwAutoCompleteClient::Notify(SfxHint const&) /sw/source/core/doc/acmplwrd.cxx:138:9 > #1 0x2b84f3d5d886 in SvtBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/broadcast.cxx:128:25 > #2 0x2b84f3d5c07a in SvtBroadcaster::~SvtBroadcaster() /svl/source/notify/broadcast.cxx:96:5 > #3 0x2b857812fdc4 in sw::BroadcasterMixin::~BroadcasterMixin() /sw/inc/calbck.hxx:84:24 > #4 0x2b857af251c4 in SwPageDesc::~SwPageDesc() /sw/source/core/layout/pagedesc.cxx:127:1 > #5 0x2b857af25234 in SwPageDesc::~SwPageDesc() /sw/source/core/layout/pagedesc.cxx:126:1 > #6 0x2b8578f2c550 in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:466:9 > #7 0x2b857892a9c3 in SwDoc::release() /sw/source/core/doc/doc.cxx:117:9 > #8 0x2b8579d1efae in rtl::Reference<SwDoc>::clear() /include/rtl/ref.hxx:159:19 > #9 0x2b857e12fd44 in SwDocShell::RemoveLink() /sw/source/uibase/app/docshini.cxx:438:16 > #10 0x2b857e12eac7 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:366:5 > #11 0x2b857e12ff2b in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:356:1 > #12 0x2b857e130104 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:356:1 > #13 0x2b84edcb1a4a in SvRefBase::ReleaseRef() /include/tools/ref.hxx:163:29 > #14 0x2b84edcb1020 in tools::SvRef<SfxObjectShell>::~SvRef() /include/tools/ref.hxx:56:36 Change-Id: Iaf1cb698bf898efc66a3abaa1c8bfd3116b389b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87715 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29CID 1458016 - fix uninitialised members in AccessibilityIssueTomaž Vajngerl
Change-Id: I826ed2da7743c99606209862075a0ca4f8e9eb62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87685 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29lok: preserve mouse event logic position and use in calcTomaž Vajngerl
When clicking in online Calc any of the charts, shapes (and other objects), sometimes the cell underneath is selected instead. The problem is that the object is not correctly recognised to be hit. From lok we get the mouse event position in logic coordinates, which we usually can just use in writer and impress. In calc however we need the coordinates in pixels, so we transform them before sending the mouse event to calc. Still calc also uses common SdrObjects (chart, shapes,...), which operate in logic coordinates. So in case of SdrObject we need to convert the coordniates back from pixel to logic again, which causes problems because conversion doesn't have access to the displaying conditions on an stateless online client. OTOH we already had the correct logic coordinates, and we can just send them along. This is what this change does. It adds an optional maLogicPosition to MouseEvent, which is filled with logic position if those is known. Change-Id: I26f6466085baf613850b5861e368f22cad7c1d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87681 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29tdf#42949 Fix IWYU warnings in sw/source/ui/vba/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iafc34cffc3257d785d61f60fc37dc95e5250435c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87308 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-29tdf#128959 DOCX import: fix missing text lines in tablesLászló Németh
Orphan/widow line break settings aren't always ignored by Writer table layout code, in this case, in vertically merged cells, resulting missing paragraph lines. As a workaround for interoperability, disable orphan/widow control in cell paragraphs during the DOCX import to get correct layout in Writer, too. Change-Id: I48fdb0a3bb421fd4df2c729e307a7ef483e3e772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87637 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-29sw: add UI for semi-transparent textMiklos Vajna
Somewhat surprisingly the test passed without the fix, i.e. the uitest operated happily on a hidden widget; so explicitly assert that it's visible. Change-Id: I321c7e0e3cb2d67a07724523c885d50577a116a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87656 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-29tdf#129625 Gray out content types with no contentJim Raykowski
This patch is for Writer Navigator only. Change-Id: I80724a3e24fd38d7b5537e1c923866a914b45898 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87668 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28gtk silence warning about parentless widgetCaolán McNamara
Change-Id: I9aa4b9ba63c5a83e7e27e786e38761721977b33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28tdf#130122 Make content navigation view collapse uniformJim Raykowski
...for root node of all content types This patch makes content navigation view root collapse to it's immediate child entries. This fixes the current behavior of outline root collapse not collapsing and all other content types collapsing to root. Change-Id: If48b4c9f5f92e7a1843557eec51c516fa42f228f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87316 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-28tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorMehmet Emin Başoğlu
Change-Id: I13e5c59aa673100655f38328b4b6515a1946fb76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87524 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28tdf#130214: workaround invalid state resulting from error on importMike Kaganski
Obviously the real error is somewhere else, which results in tdf#126435, and produces unexpected state with missing text append context on stack. This is just a hack to avoid crash. Change-Id: I420ac3b74f5efb9688dc764ac2ad0dcc974ba0e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-28fix unit test testCharacterBorderNoel Grandin
ever since commit ea358f5d5b04a2a8e11a73d35643cd0afc5cb63b Date: Tue Aug 13 18:04:14 2013 +0200 CharBrd 8.2: Tests for UNO API and ODF filter found by my new loplugin:unusedvariableplus Change-Id: I2508192ae2eb0c3e5051b3090d767956752124dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87574 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-01-28SwAutoCompleteClient: SwClient no moreBjoern Michaelsen
- also: lets at least use atomic<> in debug code, when not caring about mutexes Change-Id: I0a32caea46a559607ff973a6f4b8e45f955e4015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87564 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-01-28tdf#130031 Chart OOXML import: fix area chart data label positionTünde Tóth
Default data label positioning of area charts in Excel is vertically centered between the X axes and the data point. In LibreOffice the data labels positioning was above the data point. Change-Id: Icff3e2554dee7b5ee264bc6f9579a84852da6f7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86927 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-28remove some unused local varsNoel Grandin
found by my new loplugin:unusedvariableplus Change-Id: Ic3f55f492d43a53d8850a97d44059ff127fd69a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28tdf#103964 DOCX import: ignore rotation when setting position of group shapesMiklos Vajna
Regression from commit 36ac7749523e0c6f40a77beac278bd9e7a667a9b (DOCX import: make sure rotation does not affect shape position, 2014-09-24), the motivation for tweaking the rotation when setting the position of a shape was for images. By accident, this also happened for group shapes. But the bugdoc shows it's not a good idea to read the rotation of group shapes: the group shape is just a container, it does not have rotation in itself. (The test120551 intention was probably just to verify that the position is not entirely off, so the small required change to the expected value should be OK.) Change-Id: I8e12c28e65c5f64168c3f802546fddf472fcc6eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87551 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-28UItest: Check list of changes is updated accordinglyXisco Fauli
Change-Id: I8a68abc928fd2bedf3d5580a6f45bdb6993560c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87545 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-28New loplugin:unsignedcompareStephan Bergmann
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#130179 sw comments on frames: limit insert UI for at-char and ...Miklos Vajna
... as-char anchor types SwWrtShell::InsertPostIt() only sets the comment anchor for those types, and we would crash without an anchor. Change-Id: I7d2f5d3d8f8e11c46db060c17587e97ecb786ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87542 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-27fix bug in testTdf128304Noel Grandin
Assuming the test actually meant to use these vars Comes from commit b203b9c83d0000c8465dcd92fb6b029a2f28c724 Date: Fri Dec 13 07:23:35 2019 +0800 tdf#128304 export TB_RL writing mode as eaVirt Change-Id: I0649f189019ea764e7ed554dac43932b717eed2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#95033 DOCX import: apply tblPrEx table borderLászló Németh
exceptions of table rows, fixing for example missing cell borders. Change-Id: Id66af2706f564f46a1afd04bad65d1bf086a3232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87514 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-27tdf#129671 add tooltips to Assign Styles dialog boxSeth Chaiklin
There are two radio buttons with arrow images. The labels explain the meaning of their action. The dialog box is used in two different contexts (Table of Contents and User-Defined Indexes) so the tooltips must be generic. Change-Id: I83761d5bd5511060ca9ee28fbf18d5d9ec8d4807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87311 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-27sw: prefix members of StgReader, SwAuthEntry, ...Miklos Vajna
... SwChartLockController_Helper and SwInterHyphInfo See tdf#94879 for motivation. Change-Id: I76b5380eefef63c2c02635ac31eca171906125b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87486 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-27tdf#114090 Create a new paragraph style with name "Appendix"Seth Chaiklin
followed recommendation in bug report: 16pt, bold, centered - inheritance from Heading - when tdf#128858 is resolved then Appendix will inherit outline level 1 One attempt at filter modifications, but maybe there are others? Change-Id: I0f91327cfe5578cd888528b2c6fac5065951eec0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85657 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-27tdf#124176: Use pragma once instead of include guardsSarper Akdemir
Change-Id: Ib83c5cf44537bc1c4552f97c9114357c410a6ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87473 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#124176: Use pragma once instead of include guardsSarper Akdemir
Change-Id: Ieeed31e81d47c01eda2edc792cb2ecf271eac58d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87472 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#130197 give paragraph and table panels column widths of 5 toolbutton widthsCaolán McNamara
Change-Id: Iae4f10eef6b293731d22eec8dcbb85a07d3e6c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-26tdf#124176: Use pragma once instead of include guardsBurak Bala
Change-Id: Ib2465f040f12413560b2cec1c742cf3558461309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87404 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-26Avoid explicit cast to smaller sal_uInt16 from larger longStephan Bergmann
...in what might be an attempt to avoid warnings about signed vs. unsigned comparisons. Change-Id: I43f3efdbd93d1bc9a51ea89ac4a728fc68205379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87449 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26Avoid explicit cast to smaller sal_uInt16 from larger longStephan Bergmann
...in what might be an attempt to avoid warnings about signed vs. unsigned comparisons. Change-Id: I19be3cc0510b8628e961d840f51b0c9480aee746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87450 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26Avoid explicit cast to smaller sal_uInt16 from larger longStephan Bergmann
...in what might be an attempt to avoid warnings about signed vs. unsigned comparisons. Change-Id: Ie3aa77f099df19fc150271b17d06194005bfeec5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87448 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26Avoid explicit cast to smaller sal_uInt16 from larger intStephan Bergmann
...in what might be an attempt to avoid warnings about signed vs. unsigned comparisons. Change-Id: I21381a7df7e0902d3b6ab4de064d6470a9c4a2db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87447 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26move "remove duplicates" for a vector to o3tl/vector_utils.hxxTomaž Vajngerl
Change-Id: I9ecf95a2bf975912b7029cdfb459a9ebc159c75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87429 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-26acc. check: implement goto for a range of text range in a para.Tomaž Vajngerl
Change-Id: I847bc67f886b5dcfe8ec30d7c0bdd3aa61ba2d36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87421 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-26acc. check: check if text format conveys additional meaningTomaž Vajngerl
Change-Id: I8f51248e453018c33ddc64b00cdbc1708309e577 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87420 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-26remove some unused local varsNoel Grandin
found by a more aggressive variant of loplugin:unusedvariables. This is my first pass, committing the simplest and most obviously unnecessary vars Change-Id: I9676a6e39a101937097788548764506c93811c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-26rename some local variablesNoel Grandin
mostly to make the job of my very aggressive unused local vars plugin easier Change-Id: Ifc21a920841f8589f8b7e10de39dba6622a5d501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-25Resolves: tdf#130159 hide writedirection unless CTL is enabledCaolán McNamara
rework as ToolboxControllers registered in Controller.xcu Change-Id: I3e7fea09fe83d1ed6400218c41384f82b38b07a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-25Resolves: tdf#130174 explicitly call SelectHdlCaolán McNamara
Change-Id: Ibda5c3595f8e02bba9faa027f4c90762aa817b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-26 22:45:29 +0000