Age | Commit message (Collapse) | Author |
|
In all the testing I could think of on DOCX and DOC examples
(and only a very few exist in the unit tests)
the actual value of the DocProperty was irrelevant to
what Word shows as the document loads.
It always takes the in-document, as-last-seen static text.
As a way to hack a fix using existing capabilities,
I marked as FIXEDFLD the unknown custom fields
that weren't handled separately.
That fixes what is displayed as the import value,
(which of course means that F9 will no longer
return a modification back to the DocProperty value).
It also means the (fixed) field is lost on export,
but a follow-up patch handles that for DOC/RTF/DOCX.
There were NO DI_CUSTOM examples in existing ww8 tests, but:
-ooxmlexport8: fdo74745.docx, fdo81486.docx
-ooxmlexport10: tdf92157.docx
and in these cases the plain text matched the variable anyway,
but a manual manipulation showed that LO is importing DOCX wrong
as well, so a similar import fix needs to happen for RTF/DOCX.
My fear is that there are some special-magic-associations
that worked properly the old way by accident that I will
break by marking them as fixed. No backporting please
since obviously very few people report bugs about fields.
Change-Id: I3f167eb3bd570b66ee829241bf9d31d557fc8749
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131237
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
If first document element is buried deep in destinations and thus
deep in state stack (m_aStates) initialization of default font
is very local and will be lost after closing these destinations.
So let's initialize entire states stack with default font if none
is provided istead of initialization just a top element.
Change-Id: I966c282f43b84baece909a4c3cd359cbcd317e63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131906
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Which has a backing core C++ class, unlike table columns.
Change-Id: Iebc546b8c3424f976043deceee8307eae764bbb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131914
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I22b71580a79500e169ed9cab775501583975d67f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131911
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Iba19e41fcc9277d428476e876b6a0bf50e7f18d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131912
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Here are two related fixes in one patch:
1. By default current style index is 0, not -1. Due to this we
can assume usage of default "Normal" style during deduplication.
Seems there is no difference in case of no style mentioning in
run or mentioning "Normal" one (\s0), so value -1 looks
unnesesary.
2. During header/footer "substreams" processing StyleTableEntires
was not reused in new domain mapper impl instance. So deduplication
did not work well.
2a. To avoid copying of whole StyleTableEntries between instances
it is stored as pointer in domain mapper impl.
Change-Id: Id003d35554e9b43186238920d9a6373452095121
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131899
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Map between SwLineBreakClear and \lbr<N>.
Change-Id: Ibed94ad74157a08787212a34176590a1dc4d5547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131886
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
This is not quite a NonFunctionalChange because it avoids
adding " (fixed)" to the name. But that is what I want
anyway for bug 147861, so this is an all-around good simplification.
Plus, the writerfilter loop doesn't need to run if an
inside clause will never be true anyway.
Putting this cleanup separately helps highlight the
actual fix and not clutter the real patches.
Change-Id: I12f345cc92627398ad00fe32b64b98b54e5ed14b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131413
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ieb8b6b3c3bfab0ab49bc55cf42db7be4f08e964b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131408
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
See tdf#94879 for motivation.
Change-Id: I86c9fd2c634b2f5422b0820dd5423008b1c0360c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131884
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
There are much more character attributes should be applied
wth default values if style contain them, but they were
not mentioned in current run.
These are obviously not a complete set yet, but most common
ones are included.
Change-Id: Ide52245bc98628febc2f3bd2e25166f0dcdf35cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131853
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
by a search for Frames, Images, and OLE objects
Fixes the search wrapped message being unnoticeably shown before the
search not found message when nothing is found by a search for Frames,
Images, and OLE objects. Also fixes a possible search wrapped message
being shown when SwFEShell::GetBestObject is used by
SwTextShell::ExecMoveMisc for SID_FM_TOGGLECONTROLFOCUS case.
Change-Id: I57e518163d9b61dcf9838e5552a0de53f48faa0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131638
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I68ad11d19fb0c0a20a336cb0888a1229ce12b995
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131851
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If006b66919dcc7f409e9f9a30e1fe09fa592e698
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131838
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Just pass `aOutputSize` as parameter instead
of assigning that to `aSize` again and then
passing that one as parameter in
`WeldEditView::SetDrawingArea` and
overrides in derived classes.
`aSize.setHeight(aSize.Height())` can just be dropped
as an overly complicated way of keeping the
height as it is.
In `SidebarTextControl::SetDrawingArea`, `aOutputSize`
was already passed as param, so the new value of `aSize`
was ignored anyway.
Change-Id: I23192d3c5c85e4371a48774b3b8f854beb751b82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131741
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Map SwLineBreakClear to sprmCLbcCRJ's LBCOperand.
And most importantly, write the newline character: a clearing break was
not "downgraded" to a plain line break previously.
Change-Id: I3bc11a120af09d5c774df992cb17cfc5ee251e1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131732
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Towards adding dumpAsXml() for all portions that have a HandlePortion().
Change-Id: I9cb1f4c1f966e5cfd7ca27e21bf8aa022979f3c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131724
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
also seen with tdf#124116
Change-Id: I211c5b9d58ee5857c8286b2009e4159b35a9e047
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131713
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Make sure that we work with the up to date layout size of the image in
the dialog, otherwise 80% shows up as 237%.
Also fix SfxMacroTabPage::FillItemSet() to not put anything to the
output item set when the macro table is empty, this way clicking OK in
the image dialog results in an unmodified document when the user doesn't
change anything.
Change-Id: I4b987bd3e3818ee737e37ea10861f9043c25bc93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131714
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Last deleted row of a table frame was visible in Hide Changes
mode, if it is deleted in Hide Changes mode.
Fix also missing immediate update of the table layout during
deleting only rows in the table.
Follow-up to commit a74c51025fa4519caaf461492e4ed8e68bd34885
"tdf#146962 sw: hide deleted row at deletion in Hide Changes"
Change-Id: Ic0bf09ac68dd336bd53e84e58f52ebe88ca56238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131701
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Map sprmCLbcCRJ's LBCOperand to SwLineBreakClear.
Change-Id: Ie6a114bcd90a9442295815da68f6b0a9616c3210
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131697
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Which is a bit confusing: there is separation between the views while
running, but only one view saves its config to the user profile, it
seems.
Change-Id: Ie5c5ae782860e1b93dc9096be893acff7e555aac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131674
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
We can skip lots of the table by using the binary search.
Change-Id: I8c85cd4700bd1859cdc61a08159c61b1ab632163
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131693
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The issue here was that simply moving the border around
(which shouldn't change the table size at all)
triggered a miniscule difference in reported table width.
Well, that is not enough reason to change away from automatic
positioning now is it?
Change-Id: Ib40c50a1069d88fa22f4791366eb0a50b4e9b11d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131633
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: I1db018216eb37517192f87c5c22cd0b9e6319687
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130472
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I8ce73250da932d2c308a93a9268170ba9a120301
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131125
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
We can skip lots of the table by using the binary search.
Which is not actually a lot of use for this particular bug, because it
contains bad redline data.
Change-Id: If2a7a807723ec19f15d6f7fa011d75ea82bd6d1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131660
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Tracked insertion/deletion of comments were shown as
plain text insertion/deletion in that case, too, when
there is no other text change in the redline (only
the invisible placeholder character CH_TXTATR_INWORD
of the comment). This was fixed by the new action
icons of the Manage Changes dialog window before,
but for better accessibility, now redline of a newly
inserted/deleted comment gets also a redline comment
"Comment added"/"Comment deleted", shown in Manage
Changes dialog window with the Comment added/Comment
deleted action icons, as suggested by Heiko Tietze.
Note: because the redline comment (at least the
tracked insertions) are stored in the document,
this is a back-compatible solution.
Follow-up to commit 128d3b454467e34538903b2eab45e866f976b314
"tdf#73125 sw: add Insert/Delete Comment Manage Changes action icons".
Change-Id: I7a9e82ae1b9519e4883956f69de0aafc289f7f99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131659
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
... and SwWW8AttrIter
See tdf#94879 for motivation.
Change-Id: Iaa5b84d7ae58ac4b20d3e0f419fbcb44f895b270
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131639
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Provides for sorting content members by order in document or
alphabetically. The option to sort comment and footnote content types
members alphabetically is not done by this patch.
Change-Id: If68c08bb0f1035b32cd1dad1d5bd08a340834b49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131448
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Text node containing a numbering rule with numbering format
with SVX_NUM_NUMBER_NONE is still a numbering: it will display
prefix, suffix and other numbering properties.
Change-Id: I52077824b4a1db2e9220701fdd514670490a59db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131410
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
AddLevel() can be called on w:lvl and on w:lvlOverride. But if
we have level override and some extra level definition level is
recreated and override information is lost.
Change-Id: I6f1b9b50bdd3410b4ae2d403e760e4d6df5677d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131304
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Similar to a2a2e07996a0e49164663eaec5d79481bf7bb3e0
"sw: split CppunitTest_sw_uiwriter2 into uiwriter2 and uiwriter5"
it already had 117 tests
Change-Id: I6bcdcd672c655b853f8f366db3b78d3da49f9078
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131635
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This is fine, the cache is the same as long as the substring is
within the full string size.
Change-Id: I9ad7cbe33db73219d16b3b907f2a9dff694d0923
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131566
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Icc798c2a4e44260d47dc36f7d84487142cf56041
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131558
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
The result depends only on the string, so it's possible to cache it
easily, and caching this for text drawing calls can have a good
hit rate.
Change-Id: I56c6e254cc176ab07afe0df24ed37b19579fe64d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131556
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I87116aeb0c176d67588ecfcff94098346e17dd6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131584
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The bugdoc is 398 pages after initial load and 397 pages after Undo.
There is really only one problem, on page 6 the fly frame 7370 "Figure
3: Hay Rake in Weeds" anchored on SwTextFrame 5896 should be on page 7
and aligned to the top of its paragraph.
First, 5986 moves forward from page 6 to 7, hitting the condition added
in commit c799de145f7e289f31e3669646e5bd12814e6c5e
debug:1170918:1170918: SwObjectFormatterTextFrame::CheckMovedFwdCondition(): o_rbPageHasFlysAnchoredBelowThis because next chain on same page
Then 5986 moves back to page 6. When it is formatted there, the
ConsiderObjWrapInfluenceOnObjPos() is true, preventing a formatting of
the anchor frame - so it does not move forward.
The flag SetTmpConsiderWrapInfluence(true) was set the first time (when
it moved forward).
Setting this flag for any anchor frame that moves forward was added in
2005 in commit 46297c0923c50a12510c7b15b725c8d2fd80f9c0 and apparently
the only way the flag is cleared is when SwDoc's SetModified() is
called (or the frame is in a table or column).
So it is similar to the InsertMovedFwdFrame() case that was addressed by
commit c799de145f7e289f31e3669646e5bd12814e6c5e in that the flag should
not be set if bPageHasFlysAnchoredBelowThis is true.
(reportedly regression from sw_redlinehide
commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c)
Change-Id: I27b2a1becf5f7a760e74e801e23472116d0a5ced
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131560
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
That these are only flagged when building against libc++ and not against
libstdc++ is a consequence of the plugin's dependence on implementation details
of the relevant classes, but so be it.
Change-Id: I6b96f81939edab2b8e618aa53c9fe23492edfbbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131562
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5968dda3b0638576fcc9ce222e47a3c04c949484
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131545
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I80ef9cff8956402d6286741fa52885f66dac6f9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131548
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I91672e31e324cdd17c02ca328863b636beeb5e45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131546
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
this reverts
commit 563af8fd15aa37e75af8882cccbdf8914ebe8e61
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Fri Jan 7 22:50:29 2022 +0200
tdf#144890 Invalid selection area when text in LTR run
and
commit ec50b9e5eaec7c94df35617676077ef0d65cecc7
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu May 27 11:16:11 2021 +0200
no need to allocate Sw2LinesPos separately on heap
No idea why the commits caused trouble, clearing there is some
"interesting" interaction going on.
Change-Id: I606768403db777b61554f378d3f69f9b4d33d493
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131533
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I95b86fc081847da01e06f50a1b2c7e7f5456c638
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131529
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I49f4f98d77f0c5e8caa6471e9c938a472a9aaf96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131526
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I510a48765b2ad286ddc194f6ca1a96211bcb05f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131528
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
when there is no selection, startrect and endrect get the
cursor coordinates, we should not send it. Otherwise this
causes selection handles to appear on online
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I4402e04d4a16a1f840499c57421fd01caf43f116
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130525
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131520
Tested-by: Jenkins
|
|
Change-Id: Iaaf63c49ce94987ab9c4ebc68e963cc3054a3c34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131342
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I259e105c73141744b667f8ab61fd61dac8e4ef9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131500
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Grays out comment members in the Navigator Comments member list that
are in hidden sections and folded outline content. Not showing comment
annotation windows will not cause comment member graying. The patch
also fixes comments sometimes not showing in the member list after
document load due to the document layout of comments not being
completed before the comment content array is initially filled.
Change-Id: Id3ac664480c36f1a3d072f7658cc9269a55b70aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130471
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|