summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
8 hourssw: FindSttNodeByType -> FindStartNodeByTypeXisco Fauli
Change-Id: I37dbe6583ef121fbb2439d413eaa6bcad9d07f73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179257 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
13 hourscrashreporting: check Lower()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SwLayoutFrame::AdjustColumns(SwFormatCol%20const%20*,bool) Change-Id: I690a6358c8964f5511aedf3246384649cf004d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179234 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
13 hourscrashreporting: check Lower()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SwRowFrame::ShouldRowKeepWithNext(bool) Change-Id: I49ac8312e0288471780c405bb2cd7eb66163ab43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179233 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
18 hourstdf#164383 - sw a11y fix unnecessary "Avoid simulated captions" warningBalazs Varga
for caption frame. We should not have "Avoid simulated captions" warning about correct captions. Change-Id: I57fe53c5f9e1aa2affe0aec6520d1d6eed5d6990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178927 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
31 hoursFix typoAndrea Gelmini
Change-Id: I0d22de1cc8e5a9817770c9cee9abbc3833b3b973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178938 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
31 hoursFix typoAndrea Gelmini
Change-Id: I3ded88c7080b8c009937223bc9845367872dd25f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178939 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
31 hourstdf#132111: don't claim a number format for multiselection / no set formatMike Kaganski
The "not set" state for RES_BOXATR_FORMAT is handled explicitly in many places, e.g., in SwTableBox::HasNumContent. This allows to detect number entered into cells without explicit format. Thus, this state is not the same as "text" number format, and it must not be selected in the Number Format dialog. The same is for multiselection with different formats. Change-Id: I4f4aa66a2cbfd1bf2efa8b99a6e7a2cf9c119712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179177 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
36 hourscid#1636856 silence Explicit null dereferencedCaolán McNamara
and cid#1636859 Explicit null dereferenced Change-Id: I6e618bebd0f61a1e796b367343bb98e7a01d29b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
36 hourscid#1529286 silence Explicit null dereferencedCaolán McNamara
Change-Id: I03909c8ed7e9f2bf410412b02790aee0fbca6d58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179138 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
36 hourscid#1636858 Dereference before null checkCaolán McNamara
Change-Id: I03aa87d1a265761ac2f781e33b6136a4c38cbb31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
38 hourscrashreporting: disable load from template during print previewCaolán McNamara
Change-Id: Ifc60a01f0e5e1f6cdab3680e69202f98471c2a7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2 daysSimplify abstract dialog impls using vcl::AbstractDialogImpl* in swMike Kaganski
Change-Id: Ie2816ab4f4ad5f4d703d4f6669ae16a9fa60933e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178984 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2 dayscrash reporting: use SfxRequest to get parent for dialogsCaolán McNamara
0: return pWindow ? pWindow->GetFrameWeld() : nullptr; 2: SfxNewFileDialog aNewFileDlg(GetView()->GetFrameWeld(), SfxNewFileDialogMode::LoadTemplate); Reproducible by adding "LoadStyles" to the menu in writer, then print preview and then use that "LoadStyles" entry. Also dispatch "SID_TEMPLATE_LOAD", as used by "Load Styles from Template" entry in the dropdown from the "Styles Action" toolbar of the style panel, with an explicit frame it is associated with. Change-Id: I3d536b897fbf6be9e20e4238e6a761df56ac9701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179084 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
3 daysmake modcfg ConfigItems listen to the config changes.Caolán McNamara
Change-Id: I9ba49ff8df463519631e698ce5916f0126c5d7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 daysmake SwFmtAidsAutoComplConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: I92f57f9ea8a0ea109fbec9e18665adeb3c6d2837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 daysmake SwWebColorConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: I5190155eb0edb4639b09983cc58101a5a8c82f31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 daysmake SwLayoutViewConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: Id86edc48c304d2ab35a5cb01a20d9dac20e04280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178926 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
3 daysmake SwCursorConfig ConfigItem listen to the config changes.Caolán McNamara
Change-Id: Ia653759378913758f0b2750c9d072b76523fa034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178924 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
3 daysuse member init list and initialize before member LoadsCaolán McNamara
Change-Id: Iaca646e1a36b20adb29b5ff25649d08fc7055e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 daystdf#164179 - Fix crash on BibEntry ComboBox selectVojtěch Doležal
One change in 7b99871635cd48c2a8a1d0afbd7afc60a45cc2ff (to ToxAuthorityField) caused crashing bug in IdentifierHdl due to it trying to call unsupported method on an input field to set its value. This patch not only fixes the crash, but also moves the volatile code into the SetFields method, which is also called in the constructor of the Dialog, meaning if similar change were made in the future, the crash would manifest immediately and hopefully not pass to production. Change-Id: I93abef0cdaa5c533523fbefd9514d1a287fd368b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178448 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
3 daysstray semicolonCaolán McNamara
Change-Id: Ibe57036e31c704b8866de49934a58b0fa6c47496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 daysadd uno:AddToWordbook for adding word to user dictionaryCaolán McNamara
Change-Id: I1c679f62f554bfa112c505a545ceb8b5e31ef453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178921 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
4 daysThe initialization of pResId is not usedStephan Bergmann
Change-Id: Ic8409352e347d01fe5cc15458d18f612084cccab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178913 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
4 dayssw: Remove executable bit from test .odt fileMichael Weghorn
Local fdroid build was warning about it: 2024-12-20 14:07:59,973 WARNING: Found executable binary, possibly code at sw/qa/extras/uiwriter/data/tdf146356.odt Change-Id: Ib574580872d12cd737c3a1fcb221fd1ddc991b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178920 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
4 daysSW: extract transform DocPropertiesAttila Szűcs
Implemented Document Properties extraction, and transformation. For UserDefinedProperties Properties you can use add, and delete commands. If the property already exist, "add" will delete that, before adding the new UserDefinedProperty see the unittest for an example. Change-Id: I036b73bf1539bc25f454aea64c319241177e167a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178918 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
4 dayscool#10782 sfx2 lok: fix bad view id on PDF exportMiklos Vajna
Have 2 views, view 2 dispatches .uno:ExportDirectToPDF, and sometimes view 1 gets the LOK_CALLBACK_EXPORT_FILE callback, which is incorrect. What happens is that the command gets dispatched correctly, but during save the progressbar gets updated in framework::StatusIndicatorFactory::end(), which calls Application::Reschedule(), which processes LOK jobs on the main loop, which may switch back to view 1, so the callback is emitted on that view. Fix the problem by reducing the duration where we work with the "current view". We know that initially the command dispatch has the correct current view since commit ee7ca8e4ea8ed93655f99e77a9e77032ac830c46 (cool#7865 sfx2 lok: fix bad view id on async command dispatch, 2023-12-20), so fetch the current view before the actual filter call and work with that view explicitly later. This is also similar to what SfxObjectShell::ExecFile_Impl() does for the bMailPrepareExport case, which also had trouble with GUIStoreModel() spinning the main loop. Change-Id: Id642056aa55831c54e88c61931753c03fa23b6b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178915 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
4 dayssw: pass by referenceXisco Fauli
Change-Id: I974472bc55104f0487a3406d4885ed0b52441896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178878 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
4 daysRevert "coverity#1430065 silence Uncaught exception"Mike Kaganski
This reverts commit 16d5cbfd38e57a6fccfda018ede2de7e4c448221. Reason for revert: The reverted commit was likely wrong, and was immediately obsoleted by commit 7df7545fc9ac4aa55403998b2d65e1b147a9f037 (coverity#1430074 Uncaught exception, 2018-03-19), where the dtor of SwAutoFormatDlg got a try...catch block. The actual lines changed in the original commit were later modified in commit c91faacfb7dd26fe7b7c93c7af5d4c330779a59f (make auto-format dialog async, 2024-01-31), and this commit removes the use of o3tl::default_delete, appeared in those subsequent changes. Change-Id: Ibd634187d2930f3cc158aa0c36981ca8b327db91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178876 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
4 daystdf#164091 - sw fix Accessibility sidebar gives warning about decorativeBalazs Varga
marked shapes We should not have warning about missing alternative text in case of decorative marked shapes. Change-Id: Ibac7f152886d7db004039eede9b657fa5e84ae87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178795 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
4 daystdf#163660 sw: Treat strong CJK inside RTL runs as Asian scriptJonathan Clark
Previously, Asian-script characters following an explicit direction mark or inside an RTL embedding would be rendered using the Complex font, rather than the Asian font. This change updates script detection to treat these characters as Asian regardless of text direction. This change also consolidates more duplicated script detection code from Writer and Edit Engine. Change-Id: I3931c3ec0cb447f3c504fdbfb3ee62185fd14422 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178817 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
4 daysUITest_writer_tests3: fix indent in insertQrCodeMiklos Vajna
The indent is 4 spaces, and it hurts readability to violate that, given that this is Python, so no curly braces. Change-Id: I45aa85c23ab3468acbc6a6d7a37f7db19cc94836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178814 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
5 daystdf#164263: avoid exception when SAL_DISABLE_PRINTERLIST #2Justin Luth
This fixes a backported to 24.2.1 regression from commit e6f75eb50bc5d1ebccda0c0f80a7b353d991106e Although an empty OUString is returned when IsDisplayPrinter(), using that to setPropertyValue causes an exception. Since IsDisplayPrinter always returns static values for all queries, there is no need to actually attempt to make any changes when IsDisplayPrinter(). This replaces my earlier, very focused patch for writerfilter. I'm afraid that this Exception could evidence itself in many different areas, so this more generic fix ought to resolve any problems triggered by SAL_DISABLE_PRINTERLIST. I don't see any unit test examples from the offending regression, or anything else in SW relating to Printer or environment variables, nor is there any explict call available to set mpDisplayDev, so I don't know how I can create a unit test for this. Change-Id: I3d4054df57ab460833d9994d71133aef64cbb714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178753 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daysIndex Link is a programmatic nameNoel Grandin
Change-Id: Id909800fdd5db5dd2eadec92774c1dda4a435c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178735 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 dayscrashtesting: unknown 'IsContentEmpty' property reloading rtf exportCaolán McNamara
of forum-mso-en4-218597.doc where the XText is a TextFrame, presumably a problem since: commit cfd3b14fd4e1ee889dd356523e5cdaa639786d37 CommitDate: Fri Aug 2 10:37:31 2024 +0200 tdf#162295 DOCX import: optimize the check if the header/footer is empty Change-Id: I14e851aea66ad66024e9a8e38b1d1cdef0bf570c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 daystdf#163620 [API CHANGE] Add UI for libreoffice themesSahil Gautam
Instead of Color, we have Light and Dark in the registry. So each theme extension will specify dark and light color values for each "customizable element" like DocColor etc. Under appearance we have three radio buttons - light/dark/system. If system is selected then light/dark colors are switched based on the system's theme. if explicitly light/dark is selected - that color is used from the registry. ColorConfigValue now has three entries nColor, nLightColor, nDarkColor. nColor is used as a cache for the color being used at the moment. This is to avoid otherwise expensive function calls + hundreds of modifications in the codebase just to change nColor. nColor is cached either when the theme is loaded or when changes are committed in `ColorConfig_Impl::ImplCommit()`. Now, if Automatic theme is selected then themes is disabled and the application uses the system colors. If some other scheme is selected like "CustomTheme" etc, then LibreOffice themes/UI color customization is enabled and the theme colors are used. Instead of a scroll window, now we have a combobox for the registry entries and a single color dropdown to select the color value. This color dropdown is for convinience in case the user wants to change some specific color that's bothering him. For themeing, theme extensions should be used. API CHANGE + remove Color in favour of Light and Dark + AppBackground has additional two - BackgroundType and Bitmap + remove officecfg::Office::Common::Misc::Appearnce in favor of officecfg::Office::Common::Appearance::ApplicationAppearance + move LibreofficeTheme under officecfg::Office::Common::Appearance UI + it looks like https://i.imgur.com/UMxjfuC.png which is a little different from how the [mockup] on the ticket describes it, and that's because of lack of time due to upcomming feature freeze. + system/light/dark allow the user to switch between light/dark modes based on either the system theme (system) or by manually specifying light/dark. + ui themeing and color customization is disabled when automatic theme is selected, and enabled otherwise. [mockup]: https://bug-attachments.documentfoundation.org/attachment.cgi?id=197469 Change-Id: I1a7f70dfe44b81f863814f87e8d46e146c0e3d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174835 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
5 daystdf#163620 [API CHANGE] remove persona/appearance-toggle related codeSahil Gautam
- remove ui and source files related to app colors and personalization tabs - remove persona entries from registry - remove functions related to persona settings from StyleSettings, vcl.. - remove ui and code related to tools - options - view - appearance combo box Change-Id: I98f0c38dc1facddd0e8dd03197c61a92287fdbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176836 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
6 daysuse more concrete UNO in swNoel Grandin
Change-Id: Ie83d957349f123bca0fd46ce3144ce778c3ec101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178704 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
6 daysCppunitTest_sw_tiledrendering2: make this more stable, try 3Miklos Vajna
I got the workaround condition wrong in commit d248d8f5271c380e51af9482b6724d471e2cb929 (CppunitTest_sw_tiledrendering2: try to make this more stable, 2024-11-20), the intent was to return early when we get no state changes, but we did the early return when there *were* state changes, fix this. Change-Id: I90abcec062c59360642da87069911f937cc2110a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178706 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
6 daysSome --disable-zxing fixesStephan Bergmann
For one, UITest_writer_tests3 would crash soffie.bin in an --enable-dbgutil build with > include/vcl/vclptr.hxx:109: VclPtr<reference_type>::~VclPtr() [with reference_type = AbstractQrCodeGenDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. from within that test_insert_qr_code. But even with that out of the way, the test would still hang (in any kind of --disable-zxing build, not just --enable-dbgutil), with the Python process at > File "uitest/uitest/test.py", line 129, in wait_and_yield_dialog > time.sleep(DEFAULT_SLEEP) > File "uitest/uitest/test.py", line 151, in execute_dialog_through_command > yield from self.wait_and_yield_dialog(event, xDialogParent, close_button) > <built-in method next of module object at remote 0x7fb6fc6a0230> > File "instdir/program/python-core-3.10.16/lib/contextlib.py", line 135, in __enter__ > return next(self.gen) > File "sw/qa/uitest/writer_tests3/insertQrCodeGen.py", line 18, in test_insert_qr_code > with self.ui_test.execute_dialog_through_command(".uno:InsertQrCode") as xDialog: and the soffice.bin process idly yielding at > #14 0x00007fa582369b78 in Application::Yield () at vcl/source/app/svapp.cxx:473 > #15 0x00007fa582368a40 in Application::Execute () at vcl/source/app/svapp.cxx:360 > #16 0x00007fa58ca42fba in desktop::Desktop::Main (this=0x7fffe69ca960) at desktop/source/app/app.cxx:1679 Change-Id: I007d1497e6f0c968039af3649f6252794e222226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178696 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
6 daysa11y: Merge accessibility module into vclMichael Weghorn
Now that the accessibility module no longer depends on toolkit and svtools and there's therefore no more cyclic dependency, merge it into the vcl library, where the vcl widgets are located, for which the classes in the accessibility module (primarily) provide the a11y classes. Initially, take over the existing UNO service "com.sun.star.accessibility.comp.GetStandardAccessibleFactoryService" to vcl as is. It used to be necessary to break the cyclic dependency between the vcl, svtools, toolkit and accessibility module. (vcl is the lowest and accessibility used to be furthest up in the dependency chain; yet vcl needed it to create the objects providing the XAccessible/XAccessibleContext for its widgets.) Further simplification can happen in upcoming commits. Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178647 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
6 daysPort SwTableColumnPage to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I75184bd5522c9ae53981a7260ee5de110b7565f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178637 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
6 dayssw: Resave tablecolumnpage.ui with glade 3.40Michael Weghorn
Change-Id: I671a272f60dfd12325f760681cb3c6f988467c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178635 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
6 daysPort SwCreateAuthEntryDlg_Impl to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Deduplicate the code a bit by introducing a `pTargetGrid` local var that points either to `m_xLeft` or `m_xRight`. This dialog can be triggered in Writer via "Insert" -> "Table of Contents and Index" -> "Bibliography Entry", then clicking the "Edit" button. Change-Id: Ib75c5f1225d9590849f1eaed083857dbe30ce551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178634 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
6 daysPort SwTOXWidget subclasses to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I7d6d23f0d1fec640c1de38c896f3e9b7e06ed70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178633 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
6 daysPort SwAssignFragment to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I6ba9008c4ab9b049d9703c13c15d3df262436e26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178632 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
6 daysPort SwAddressFragment to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I1ee227fbf9eaa4048e1a9c86ae0280ef473d6af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178631 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
6 dayssw: silence warning C6011Xisco Fauli
C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sw/source/core/fields/reffld.cxx(1419): error C2220: the following warning is treated as an error C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sw\source\core\fields\reffld.cxx(1313) : warning C6011: Dereferencing NULL pointer 'pStart'. : Lines: 1299, 1301, 1302, 1303, 1305, 1307, 1308, 1309, 1312, 1313 make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/sw/source/core/fields/reffld.o] Error 2 Change-Id: I7ab3a8906738ed0cd64c890cabdf04234c80afd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178666 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
6 daystdf#132274 Clarify wording of default Writer zoom behaviourThorsten Behrens
There was apparently some confusion what 'latest setting' was referring to (in fact, it's the latest setting that was stored in the document, for most cases). Change-Id: I30d36567cde602ba18b0b721dec0c9e76b560edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178660 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
7 dayscrashtesting: unable to import rtf export of forum-mso-en-14843.docCaolán McNamara
user field names have control chars in them and import from rtf hits the code added by: commit a6516c76c01b92f7d35bfb352b63af7de42b5707 CommitDate: Wed Oct 30 14:44:09 2019 +0100 writerfilter: rtftok: filter control characters so control chars are stripped out, which results in a duplicate user field name which throws. Filtering out at doc import time seems to work better, so lets do that as well. Change-Id: I463e30b223bfb5639de23c696d112eda2c27b428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178657 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
7 daysuse more concrete UNO in swNoel Grandin
Change-Id: I664c7eff512625f988a2a278062719d3084845dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-24 02:52:26 +0000