summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
89 min.use more concrete UNO classes in writerfilter (SwXTextDefaults)Noel Grandin
Change-Id: I44eb8d4561798980ff7008d843bf076fc29582c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166769 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 hoursuse more concrete UNO classes in writerfilter (SwXDocumentSettings)Noel Grandin
Change-Id: Id668946233d55d641199634d7ceda2607107e76b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
11 hoursFix dc:date export for midnight timeMike Kaganski
Change-Id: I2fc40055e8949348925159a7e10f231a2573950c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166757 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
20 hoursMake sure that collecting redline autostyles succeedsMike Kaganski
This step was called separately in SwXMLExport::ExportAutoStyles_, after collectAutoStyles. collectTextAutoStylesAndNodeExportOrder (which is called from collectAutoStyles) sets mbCollected to true, and then all the code checking mbCollected/isAutoStylesCollected stops collecting autostyles. This moves exportTrackedChanges call to the place where all auto- styles are collected. Change-Id: I3f4bd0e0ff906a35b69c052e34adb6d66ef80d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166735 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
27 hoursrun gperf via wsl in wsl-as-helper caseChristian Lohmaier
also split up the gperf commands when generating sw/generated/tokens.cxx wsl has trouble appending using shell redirects, so use separate targets and use cat in the final processing step for tokens.cxx see also https://github.com/microsoft/WSL/issues/4400 Change-Id: Id7a24d060e9be71113ec2827a389d347456f6522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166338 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
27 hourssimplify some sed rules/statements and use proper quotingChristian Lohmaier
make removes partially built targets in case the rule exits with non-zero status, so creating a temp file and moving it is not necessary also use single quotes for cases where characters might be interpreted by the shell Also combine multiple sed calls into a single call of sed with multiple expressions and replace additional "grep -v foo" with corresponding sed delete command Change-Id: Iff7e3b962175e347e5ed100a87c96fbaeef39985 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166410 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
28 hoursuse more concrete UNO in writerfilterNoel Grandin
elimate the TextFactory stuff, since it is the same object as the TextDocument Change-Id: I10577f2ac9ffa4d079b96052f7879a83e38f1cf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
28 hourstdf#114287 tdf#159366 xmloff: ODF import: revert text:list overrideMichael Stahl
This reverts commit ade0a153f453500f15343380ac937252992733e0 "tdf#114287 xmloff: ODF import: fix text:list override of list style" and subsequent commits 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d and 1b2a6b98291cf8b7022951be19b915fe2a9e18e6. It turns out that there is actually a paragraph in ODF 1.2 and later that gives paragraph's indent priority over the list style's, which i unfortunately missed when investigating the above issues: 17.20 <style:list-level-label-alignment> ... The fo:text-indent and fo:margin-left attributes are evaluated only for paragraphs inside list items whose paragraph styles do not specify them. If one of the two properties, or both, are specified by the paragraph style, the text indent and/or left margin are taken from the paragraph style. In this case the paragraph style's properties are used to determine the indent and margin for the text lines and thus also the alignment position. This is usually interpreted as "on the same level", so applying a list-style at a paragraph style overrides the indents inherited from a parent paragraph style, but if the style then specifies its own indents that overrides the list style's indents. Furthermore it turns out that Google Docs now imports this bugdoc the same way as LO 7.5 does; unclear if that changed recently (it shows it like Word does in the preview, but like LO 7.5 does after opening it). This means the way MS Word imports the bugdoc, which remains unchanged, now looks like a bug and we should not change LO to be compatible with it (when the same structure is created in Word, storing to ODF and loading again, it looks different too). Change-Id: I0c65bde38de9e6fcbccec55899c60c3245adb5ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166309 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
28 hourstdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuseMichael Stahl
This is obviously wrong, as ALG just pointed out: the aIter is at the end after the 1st loop, so the 2nd loop does nothing. Thx Gabor for checking all the reported bugs. (regression from commit db115bec9254417ef7a3faf687478fe5424ab378) Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
32 hourssw: check GetUserCallXisco Fauli
It might return nullptr See https://crashreport.libreoffice.org/stats/signature/SwFEShell::ShouldObjectBeSelected(Point%20const%20&) Change-Id: Ia0ed355a7eb9084b9f57163ffbfe6b549c8bdb3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166642 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
33 hoursSave with newer Glade versionSamuel Mehrbrodt
Change-Id: I37188d82d87724c70b8e33bc65e56f091d5587e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166623 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
33 hoursSave with newer Glade versionSamuel Mehrbrodt
Change-Id: I0c546633d4d5db4de59ba7a3819c4631fa50e192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166624 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
33 hoursSimplify a bitMike Kaganski
Change-Id: Ia724b8dcfbd3e1b3744bbc26e005831d30b5ce38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166691 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
36 hoursMake sure to export autostyles from inside frames anchored to pageMike Kaganski
These frames need to export content when collecting autostyles, too. Regression after commit 69ed893087f89d176a5ec4b263ce8d75774be72b (tdf#160253: fix list identifier export decision code, 2024-04-24). Change-Id: If036cab9327e33d32f494fc765bae8e2d685907c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166650 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
44 hoursFix typoAndrea Gelmini
Change-Id: I8ab3728b0b5cf414582849e9efe36a3c9df43f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166646 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
44 hoursRemove exec bits on docxAndrea Gelmini
Change-Id: I9920aef83472dfc4f70e0f707a83eb0f4eef2dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166644 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
47 hoursuse more concrete UNO classes in writerfilterNoel Grandin
starting with SwXTextDocument. Replace some UNO_QUERY_THROW with if (!foo) throw uno::RuntimeException() because rtl::Reference does not have UNO_QUERY_THROW constructors Change-Id: I98e34f2faa6e94d0afbdfbd4e9e92a43b0a921f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166565 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2 daystdf#141525: sw unit test: line w/ arrow/circle endpointsKira Tubo
Unit test checks that the "Line with Arrow/Circle" shape is inserted with "Arrow" at the start of the line and "Circle" at the end of the line. Without the fix from tdf#141525, the "Circle" is missing at the end of the line. Change-Id: I2c952deffea908b3daf855dabd9d19f1f6133268 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166576 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2 daysCppunitTest_sw_writerfilter_rtftok: turn on set_non_application_font_useMiklos Vajna
Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix CppunitTest_sd_import_tests-smartart non_application_font_use, 2023-10-23), got rid of a case where the font name was not explicit. Change-Id: I06963f97d90e5a6c9efa0490890b30770b31dba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166611 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2 daystdf#154369: sw unit test: numbered list color in docxKira Tubo
Unit test checks that the color of the ordered list number is the same color as paragraph color in the docx file. Change-Id: I5e620ace079d6cba6d0aa0ba11c97e05a9db55c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166423 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2 daystdf#76005 add TabsRelativeToIndent, TabOverMargin compat option to dialogMohit Marathe
Change-Id: I17703c2fe388f485462bd82982664f0b4a14d537 Signed-off-by: Mohit Marathe <mohitmarathe@proton.me> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166040 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2 daystdf#160598 SwNavigator enhancement to delete footnotes/endnotesJim Raykowski
m_bDocHasChanged is checked first in the tooltip and mouse move handlers to prevent crashes/asserts that happen when SfxPoolItemHolder m_aAttr references a delete poolitem or poolitem data. Without this check the following types of crashes/asserts can happen: ---- Unspecified Application Error Fatal exception: Signal 6 Stack: 0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/ unx/backtraceapi.cxx:42 (discriminator 3) 1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/ osl/unx/signal.cxx:289 2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at / home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330 3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427 4 __restore_rt at libc_sigaction.c:? 5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27 7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21) 8 SalAbort(rtl::OUString const&, bool) at /home/lo/Dev/LO1/core/vcl/ source/app/salplug.cxx:412 9 Application::Abort(rtl::OUString const&) at /home/lo/Dev/LO1/core/ vcl/source/app/svapp.cxx:316 10 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/ core/desktop/source/app/app.cxx:1203 (discriminator 2) 11 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/ core/vcl/source/app/svmain.cxx:176 12 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/ all/signalshared.cxx:47 13 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423 14 __restore_rt at libc_sigaction.c:? 15 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/ poolitem.hxx:225 16 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/ svl/itemset.hxx:74 (discriminator 1) 17 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:223 (discriminator 1) 18 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 19 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 20 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 21 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 22 SalInstanceTreeView::TooltipHdl(SvTreeListEntry*) at /home/lo/Dev/ LO1/core/vcl/source/app/salvtables.cxx:5154 23 SalInstanceTreeView::LinkStubTooltipHdl(void*, SvTreeListEntry*) at /home/lo/Dev/LO1/core/vcl/source/app/salvtables.cxx:5151 24 Link<SvTreeListEntry*, rtl::OUString>::Call(SvTreeListEntry*) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 25 SvTreeListBox::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/treelist/treelistbox.cxx:3284 26 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/ Dev/LO1/core/vcl/source/window/winproc.cxx:186 27 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740 28 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332 29 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1) 30 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1) 31 QtFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/qt5/QtFrame.hxx:228 32 QtWidget::mouseMoveEvent(QMouseEvent*) at /home/lo/Dev/LO1/core/vcl/ qt5/QtWidget.cxx:202 33 QWidget::event(QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5 34 QtWidget::event(QEvent*) at /home/lo/Dev/LO1/core/vcl/qt5/ QtWidget.cxx:738 (discriminator 2) 35 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 36 QApplication::notify(QObject*, QEvent*) in /lib/x86_64-linux-gnu/ libQt5Widgets.so.5 37 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64- linux-gnu/libQt5Core.so.5 38 QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 39 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 40 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 41 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 42 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64- linux-gnu/libQt5Core.so.5 43 QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) in /lib/x86_64-linux-gnu/libQt5Gui.so.5 44 QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Gui.so.5 45 QXcbNativeInterface::dumpNativeWindows(unsigned long long) const in /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5 46 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 48 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0 49 QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Core.so.5 50 QtInstance::ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/ QtInstance.cxx:453 51 QtInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/ QtInstance.cxx:464 52 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:395 53 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:483 54 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:370 55 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/ app/app.cxx:1617 56 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229 57 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262 58 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/ sofficemain.cxx:93 59 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51 60 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49 61 __libc_start_call_main at ./csu/../sysdeps/nptl/ libc_start_call_main.h:58 62 call_init at ./csu/../csu/libc-start.c:128 63 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin ---- soffice.bin: /home/lo/Dev/LO1/core/sw/inc/txatbase.hxx:223: const SwFormatFootnote& SwTextAttr::GetFootnote() const: Assertion `m_aAttr && m_aAttr.Which() == RES_TXTATR_FTN' failed. Fatal exception: Signal 6 Stack: 0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/ unx/backtraceapi.cxx:42 (discriminator 3) 1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/ osl/unx/signal.cxx:289 2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at / home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330 3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427 4 __restore_rt at libc_sigaction.c:? 5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27 7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21) 8 _nl_load_domain at ./intl/loadmsgcat.c:1177 9 __GI___assert_fail at :? 10 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:224 11 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 12 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 13 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 14 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 15 (anonymous namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int, int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkinst.cxx:14701 (discriminator 2) 16 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 17 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 18 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 19 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 20 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 21 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 22 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 23 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0 24 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0 25 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0 26 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 27 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0 28 g_main_loop_run in /lib/x86_64-linux-gnu/libglib-2.0.so.0 29 main_loop_run(_GMainLoop*) at /home/lo/Dev/LO1/core/vcl/inc/unx/gtk/ gtkdata.hxx:63 30 (anonymous namespace)::DialogRunner::run() at /home/lo/Dev/LO1/core/ vcl/unx/gtk3/gtkinst.cxx:6747 (discriminator 13) 31 (anonymous namespace)::GtkInstanceDialog::run() at /home/lo/Dev/LO1/ core/vcl/unx/gtk3/gtkinst.cxx:10046 32 weld::DialogController::run() at /home/lo/Dev/LO1/core/include/vcl/ weld.hxx:2669 33 (anonymous namespace)::RecoveryUI::impl_doEmergencySave() at /home/ lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:258 (discriminator 1) 34 (anonymous namespace)::RecoveryUI::dispatchWithReturnValue(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at /home/lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:148 35 desktop::(anonymous namespace)::impl_callRecoveryUI(bool, bool) at / home/lo/Dev/LO1/core/desktop/source/app/app.cxx:1022 (discriminator 5) 36 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/ core/desktop/source/app/app.cxx:1177 37 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/ core/vcl/source/app/svmain.cxx:176 38 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/ all/signalshared.cxx:47 39 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423 40 __restore_rt at libc_sigaction.c:? 41 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/ poolitem.hxx:225 42 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/ svl/itemset.hxx:74 (discriminator 1) 43 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:223 (discriminator 1) 44 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 45 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 46 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 47 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 48 (anonymous namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int, int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkinst.cxx:14701 (discriminator 2) 49 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 50 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 51 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 52 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 53 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 54 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 55 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 56 gtk_tooltip_trigger_tooltip_query in /lib/x86_64-linux-gnu/ libgtk-3.so.0 57 GtkSalFrame::ShowTooltip(rtl::OUString const&, tools::Rectangle const&) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3154 58 ImplShowHelpWindow(vcl::Window*, unsigned short, QuickHelpFlags, rtl::OUString const&, Point const&, tools::Rectangle const&) at /home/ lo/Dev/LO1/core/vcl/source/app/help.cxx:492 59 Help::ShowQuickHelp(vcl::Window*, tools::Rectangle const&, rtl::OUString const&, QuickHelpFlags) at /home/lo/Dev/LO1/core/vcl/ source/app/help.cxx:191 (discriminator 5) 60 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 61 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/window/brdwin.cxx:1673 62 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 63 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 64 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/window/brdwin.cxx:1673 65 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 66 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 67 SplitWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/splitwin.cxx:2117 68 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 69 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 70 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 71 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 72 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/ Dev/LO1/core/vcl/source/window/winproc.cxx:186 73 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740 74 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332 75 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1) 76 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1) 77 GtkSalFrame::CallCallbackExc(SalEvent, void const*) const at /home/ lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:6388 78 GtkSalFrame::DrawingAreaMotion(int, int, unsigned int, unsigned int) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3719 79 GtkSalFrame::signalMotion(_GtkWidget*, _GdkEventMotion*, void*) at / home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3756 80 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 81 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 82 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 83 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 84 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 85 gtk_widget_init_template in /lib/x86_64-linux-gnu/libgtk-3.so.0 86 gtk_grab_remove in /lib/x86_64-linux-gnu/libgtk-3.so.0 87 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0 88 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0 89 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0 90 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 91 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0 92 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0 93 GtkSalData::Yield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkdata.cxx:405 (discriminator 6) 94 GtkInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/ gtk3/gtkinst.cxx:436 95 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:395 96 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:483 97 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:370 98 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/ app/app.cxx:1617 99 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229 100 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262 101 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/ sofficemain.cxx:93 102 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51 103 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49 104 __libc_start_call_main at ./csu/../sysdeps/nptl/ libc_start_call_main.h:58 105 call_init at ./csu/../csu/libc-start.c:128 106 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin Change-Id: Id2bad55221a8603a1e12f870bdc1479e7709ee58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166414 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
3 days[API CHANGE] a11y: Use XAccessible for relation targetsMichael Weghorn
Use a Sequence of XAccessible rather than its base interface XInterface for AccessibleRelation's TargetSet. As the targets are accessible objects as well, anything other than XAccessible doesn't make much sense. Using XAccessible right away makes that clearer and avoids the need to query the XAccessible interface. (The winaccessibility bridge was already using `static_cast`, relying on the fact that the objects are XAccessibles.) The a11y UNO API is not published, so an API change should be unproblematic. Change-Id: I7f08e98d1ec303d5343d9a7954187cdd71495ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166586 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
3 daysSwContentTree: Don't show 'Delete' menu item when read-onlyJim Raykowski
Change-Id: Ib3a1ec5635937b2dcb26144f621ee0bf4a0101d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166413 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
3 daysRework SwContentTree context menu item 'Rename' inclusionJim Raykowski
Change-Id: Ice211a3026d07a21b1b6e47ee1c16086401714d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166412 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
3 daysResolves tdf#132253 - Remove hyperlink tab from character dialogHeiko Tietze
Change-Id: Idb7fa74dbe196262cea64946452043f7de6fa20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166553 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
3 daysCppunitTest_sw_rtfexport4: avoid DECLARE_RTFEXPORT_TESTMiklos Vajna
No need to go via Writer-specific macros here. Change-Id: I680ce101de71dab06616658d7abcb4997c4c9bfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166575 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
3 daysBump Glade versionHeiko Tietze
Change-Id: I53c7c6cab10663b50391a45c18e09dc3e81c87cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166546 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
3 daystdf#160253: fix list identifier export decision codeMike Kaganski
Commits 8f48f91009caa86d896f247059874242ed18bf39 (ODT export: omit unreferenced <text:list xml:id="...">, 2022-03-10) and 82bbf63582bdf28e7918e58ebf6657a9144bc9f3 (tdf#155823: Improve the check if the list id is not required, 2023-06-14) tried to improve deterministic ODF output, by omitting the list identifiers in case when those identifiers were unreferenced. The latter of these used document model node numbers to check if other lists appeared after the last occurrence of the list that is continuing in the current node. But it turned out, that this isn't robust. Consider this ODF: <text:list xml:id="list1" text:style-name="L1"> <text:list-item> <text:p>a</text:p> </text:list-item> </text:list> <text:p>b<text:note text:id="ftn1" text:note-class="endnote"><text:note-citation>i</text:note-citation><text:note-body> <text:list text:style-name="L2"> <text:list-item> <text:p>x</text:p> </text:list-item> </text:list></text:note-body></text:note></text:p> <text:list text:continue-list="list1" text:style-name="L1"> <text:list-item> <text:p>c</text:p> </text:list-item> </text:list> The paragraphs a, b, and c are all in the main document body, and have sequential document model node numbers (say, 15, 16, 17). If these numbers are checked, there is no node between node 15 ("a") and node 17 ("c") with a different list (both 15 and 17 belong to a list with style "L1" and identifier "list1", and node 16 doesn't belong to any lists). That suggests that the list identifier isn't needed in this case. Bug when the actual output of node 16 is done, it includes a node from an endnote ("x"), which is located in a different place in the document model, and has a node number like 7 (so not between 15 and 17). The paragraph "x" belongs to another list with style "L2", and is output to ODF between paragraphs "a" and "c". Here, we must refer from paragraph "c" to the list of the paragraph "a" using the list id, but this is not obvious when only considering node numbers, and requires the prior knowledge of the actual order of appearance of lists in the ODF. Unless we build a DOM, this is only possible, if we do a two-pass output, and collect the nodes order in the first pass. The output already does that in a "collect autostyles" pass. The problem here is that the "collect autostyles" pass used an optimized function, XMLTextParagraphExport::collectTextAutoStylesOptimized, introduced in commit 8195d7061ed52ebb98f46d35fe5929762c71e4b3 (INTEGRATION: CWS swautomatic01 (1.126.4); FILE MERGED, 2006-12-01) for #i65476# and which used style::XAutoStylesSupplier for optimization to get the autostyles. This drops XMLTextParagraphExport::collectTextAutoStylesOptimized, and reverts to use of collectTextAutoStyles, which handles nodes in the same order as when writing to ODF. There, we build a vector of the node numbers sequence, used later to sort DocumentListNodes. This uncovered an omission from the work on paragraph mark (commit 1a88efa8e02a6d765dab13c7110443bb9e6acecf tdf#155238: Reimplement how ListAutoFormat is stored to ODF, 2023-05-11). Turns out, that the code in SwTextFormatter::NewNumberPortion introduced in commit cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f (sw, numbering portion format: consider full-para char formats as well, 2022-10-20) was left behind when re-implementing paragraph marks to use dedicated property; empty trailing spans still affected how the lists were rendered, and that allowed to overlook import defects, where the paragraph mark properties weren't properly set. In ODF import (XMLParaContext::endFastElement), for compatibility, this treats empty trailing spans as defining paragraph mark (when the paragraph mark wasn't set explicitly). This way, the trailing spans get converted to the paragraph mark. In WW8 import, last cell paragraphs didn't call the code handling the paragraph marks. This is also fixed now. The changes result in slightly different numbering of autostyles in the ODF. It seems, that the new numbering more closely follows the order of appearance of the autostyles in the output; and some cases of autostyles that were written, but unreferenced, are now eliminated. The unit tests were updated accordingly. I hope that the performance impact on the export time would not be too large. It is unclear why outline numbering exports a list element at all. Fixing that to not emit the list element is a separate task / TODO. Change-Id: I5c99f8d48be77c4454ffac6ffa9f5babfe0d4909 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166572 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
4 daysloplugin:singlevalfieldsNoel Grandin
Change-Id: I4d7b38c90d73a00f4dbc8ad7318fe4573328ed46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daystdf#159379 sw: fix crash on dropping multiple as-char imagesMiklos Vajna
Have an empty Writer document, set preferences so images created via drag&drop are anchored as-char, drop 2 images from a file manager, crash. The root of the problem is that the first image gets dropped fine, but the second one would be anchored to the currently selected graphic node, since commit 651527b4efe9700c8c8dff58ce5aa86ad5681f16 (sw: fix double-click opening frame dialog, not graphic dialog on images, 2022-04-26). The new SwTextCursor::GetModelPositionForViewPoint() returning a graphic node for a point inside the image looks correct, so fix the problem by extending SwFEShell::Insert() to take the anchor position as the anchor for the new image, in case a graphic node is selected. The original use-case would use SwEditWin::ExecuteDrop(), but keep the test simple and invoke the underlying SwFEShell::Insert() instead, that also triggers the problem. Change-Id: Ibba57aa28d0616ded16b4abb314f04974f1b8f9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166499 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daysResolves tdf#160731 Navigate by recency does not work under gtk3 +Jim Raykowski
wayland I think the lines of code removed by this patch were meant to allow recency to remember the cursor position before being moved to a start/ end/previous/next word or sentence position by an UNO dispatch command. These are already taken care of in the slot execute function void SwTextShell::ExecMoveLingu. Change-Id: I8bf231ea4cbb03125f54332a41c5544f9094b768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166350 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
6 days-Werror,-Wunused-variableStephan Bergmann
...ever since the code was introduced in 0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de "tdf#156146 tdf#159903 sw: add unit tests" Change-Id: Ib53b98f6f1ce460bda6b06a7b082a28a49f05a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166388 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
6 daysResolves tdf#58434 - Show formatting marks independently from fieldsHeiko Tietze
Field Shading / .uno:Marks toggles now only fields, footnotes, tox etc. and Tab, SoftHyphen, Blank, as well as ControlChar depends now on Formatting Marks / .uno:ControlCodes. Field Shading also does not toggle HardBlank and SoftHyphen, and what control character is shown respect the options under Formatting Aids Change-Id: I63c826e7fdc09ec95f17aee9735d4f5de9a1b897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166033 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
7 daystdf#81956 vml import: put groupshape in foreground if positive z-indexJustin Luth
no interesting unit tests found, but this one at least lets you add text to the body and visibly see the effect of foreground/background. make CppunitTest_sw_ooxmlimport CPPUNIT_TEST_NAME=testN751077 Change-Id: Ib03e6b429ad4ec6a38d1119f3720bc56a70b98eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166345 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
7 daystdf#146190 Fix move to next drawing object using the tab keyJim Raykowski
after double click on a drawing obect in the Navigator doesn't move to the next/previous drawing object when there is a number rule at the current current cursor position and the current cursor position is at the start of a paragraph. This patch reworks the SwWrtShell::GotoDrawingObject function so the document cursor position gets moved to the position of the drawing object when the object is selected. Another way to get expected results is to leave the GotoDrawingObject function as is and move: else if (rSh.GetSelectionType() & (SelectionType::Graphic | SelectionType::Frame | SelectionType::Ole | SelectionType::DrawObject | SelectionType::DbForm)) above the: else if( rSh.GetNumRuleAtCurrCursorPos() && rSh.IsSttOfPara() && !rSh.HasReadonlySel() ) in the SwEditWin::KeyInput function case KEY_TAB: block. SwWrtShell::GotoDrawingObject is made SW_DLLPUBIC by this patch to able to be used by the included unit test. Change-Id: I047b416ae94a9284d304798924e0c5f2be526f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166089 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
7 daystdf#159910 sw a11y: Set a11y name for Navigator comboboxMichael Weghorn
Set a11y name for this combobox in the Navigator to "Navigate By". This is in line with the tooltip shown when hovering over the combobox, which is set for the combobox's parent, the panel. This makes Orca with the qt6 VCL plugin now announce the a11y name of the combobox with the corresponding role, rather than the panel ("Navigator, panel, Navigate By, combobox" instead of "Navigator, panel, Navigate by, panel, combobox"). For gtk3, Orca still doesn't announce the combobox or it's a11y name set in the .ui file, but still just says "Toggle button, not pressed", which will have to be addressed separately. This is because while there is a combobox with accessible name "Navigate By" in the AT-SPI tree now, the object that gets focus is a toggle button that doesn't have a name set for the gtk3 VCL plugin, which will be addressed in a separate commit. Change-Id: Id6b615f033c78d318611b520d49332714fa40eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166246 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
7 daysloplugin:constantparam in swNoel Grandin
Change-Id: Ibb4d4d1cca59ece6bcd28e887f84d657dedee756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daysloplugin:constantparam in swNoel Grandin
Change-Id: Ia1379762ba957097a1a2134c5d206f254e22683b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daysloplugin:constantparam in swNoel Grandin
Change-Id: Idf7d3abd464b7be87d109d14adf94357a5d49dd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daysloplugin:constantparam in swNoel Grandin
Change-Id: Ia3e1b50954354973ffef701821f661cf782687db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 daystdf#140616 ApplyParagraphMarkFormatToNumbering: including highlightJustin Luth
I was concerned that I might override highlights set in numbering.xml but in that case pFormat && pFormat->hasItem(RES_CHRATR_HIGHLIGHT) so pCleanSet no longer hasItem. (see num3n.docx and TestDoc_highlight2.docx) Note: must use Word 2010+ to see numbering.xml highlights!! This is strictly a visual thing. Unit testing has traditionally used magic tile rendering x,y positions to check the color, which seems completely untrustworthy. Change-Id: I026252f127107e4782d08f72bfd5e2a412142111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166303 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
8 daystdf#156146 tdf#159903 sw: add unit testsMichael Stahl
Unfortunately the actual computed margins are not stored in text formatting data structures so are only available directly from SwTextMargin. Change-Id: Ia7ce5e148194a55b5d9874ed112aaa977ed16c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166258 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
8 daystdf#140616 writerfilter: recognize style rPr under pPrJustin Luth
Although it is completely NOT normal to put any rPr's in the style's pPr (since they normally just go into a stand-alone rPr), MSO is able to read and apply those - while LO just ignored them (as misplaced properties). It seems harmless to me to import it this way as well. make CppunitTest_sw_ooxmlexport14 \ CPPUNIT_TEST_NAME=testHighlightEdit_numbering Change-Id: Ie4a6c4c91a8214f40e34dc58c47b0bb9381bac1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166189 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
8 daysFix typoAndrea Gelmini
Change-Id: I00f6c7696b9b2cdb6f1ac0ae71774795f48daf91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166285 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
8 daysRemove exec bits on docx fileAndrea Gelmini
Change-Id: I69a9fb310e640b68ca4a9987b8b4a8b7cbd744c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166286 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
8 daysFix typoAndrea Gelmini
Change-Id: I8b7aa192fbdc5269b0da527dc2aeb2d535f1f0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166284 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
8 daystdf#158451 - sw unit test - FILEOPEN DOCX crashKira Tubo
Unit text checks if DOCX file crashes when opened. Document contains grouped shapes that is anchored "As character". Change-Id: I7df17de0e1f1bf252593548883ba7959f2002023 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165776 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
8 daysAdd a unit test for commit 3f0220f18a66630e06e3c128980f21a5722f49caMike Kaganski
(Handle empty range properly, 2024-04-18) Change-Id: Ifea60ace8ff864ef092e6a62177d5926ceb60de3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166278 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
8 daystdf#160622: Let SalLayout::GetBoundRect return basegfx::B2DRectangleMike Kaganski
This avoids premature rounding in TextLayouterDevice::getTextBoundRect. The box in D2DWriteTextOutRenderer::performRender needs to be expanded to allow room for the line width (which now will be guaranteed on all sides; previously, the rounding could happen to give no room on some side, even prior to commit 8962141a12c966b2d891829925e6203bf8d51852). Fixes some lines partially cut off in smaller text (or zoomed out). Change-Id: I07335136021f894cf045363b4d736bfab06c64d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166236 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-04-27 15:25:33 +0000