Age | Commit message (Collapse) | Author |
|
Change-Id: I948b0d793085abc973a5e3b2778140d729ff1f59
Reviewed-on: https://gerrit.libreoffice.org/82378
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
This allows KDE Plasma's start menu and task manager to display an icon together with the action
Change-Id: I78a6912809d643046d143690785e30b052573d8a
Reviewed-on: https://gerrit.libreoffice.org/78364
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Iedac37e0e056815e64294c70a233242df6dbf110
Reviewed-on: https://gerrit.libreoffice.org/77278
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
...after 634844354ee6ed884128086a80c3ee32c889d8c9 "sysui: fix rpm errors in
freedesktop-menus (4.14.1)" had moved the INTROSPECTION_SCANNER-related code out
of sysui/desktop/share/create_tree.sh.
Change-Id: Id6208b92abca57ed93f20602619525556c6962b3
Reviewed-on: https://gerrit.libreoffice.org/77078
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
4b4c7e76e6c2ea0d47a42a5107352d3ad7341fbf "Only build LOKDocView-0.1.gir when
necessary" had erroneously assumed that LOKDocView-0.1.{gir,typelib} need to be
built when PKGFORMAT contains "deb" or "rpm". But instead, they need to be
built only for some 3rd-party Linux distro builds, never for TDF builds.
Make that explicit with a new --enable-introspection, which those 3rd-party
Linux distros will now have to specify (probably along with other fixes to where
they pick up those LOKDocView-0.1.{gir,typelib} files after
634844354ee6ed884128086a80c3ee32c889d8c9 "sysui: fix rpm errors in
freedesktop-menus (4.14.1)" had moved them around).
That way, builds that broke after 634844354ee6ed884128086a80c3ee32c889d8c9
"sysui: fix rpm errors in freedesktop-menus (4.14.1)" (like my ASan+UBSan one
that 4b4c7e76e6c2ea0d47a42a5107352d3ad7341fbf "Only build LOKDocView-0.1.gir
when necessary" had tried to fix) can be fixed with an (implicit)
--disable-introspection.
This commit contains a revert of 4b4c7e76e6c2ea0d47a42a5107352d3ad7341fbf "Only
build LOKDocView-0.1.gir when necessary", which it supersedes.
Change-Id: Idb618e3353da7d68a2e552b0f290775c02327733
Reviewed-on: https://gerrit.libreoffice.org/76997
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Prior to 634844354ee6ed884128086a80c3ee32c889d8c9 "sysui: fix rpm errors in
freedesktop-menus (4.14.1)" it had been build as part of
sysui/desktop/share/create_tree.sh, which is presumably only called when
building for deb or rpm PKGFORMAT. Building it now in more cases started to
cause issues, like
> g-ir-scanner: link: /home/sbergman/llvm/inst/bin/clang --gcc-toolchain=/home/sbergman/gcc/trunk/inst -fdiagnostics-color -fsanitize=address -fsanitize-address-globals-dead-stripping -fsanitize-address-use-after-scope -fsanitize=undefined -fsanitize=local-bounds -fsanitize=nullability -o /home/sbergman/lo/core/tmp-introspectga_nlzjv/LOKDocView-0.1 /home/sbergman/lo/core/tmp-introspectga_nlzjv/LOKDocView-0.1.o -L. -Wl,-rpath,. -Wl,--no-as-needed -L/home/sbergman/lo/core/instdir/program -Wl,-rpath,/home/sbergman/lo/core/instdir/program -llibreofficekitgtk -lgio-2.0 -lgobject-2.0 -Wl,--export-dynamic -pthread -lgmodule-2.0 -lglib-2.0
> /usr/bin/ld: /home/sbergman/lo/core/instdir/program/liblibreofficekitgtk.so: undefined reference to `__ubsan_handle_function_type_mismatch_v1'
> /usr/bin/ld: /home/sbergman/lo/core/instdir/program/liblibreofficekitgtk.so: undefined reference to `__ubsan_vptr_type_cache'
> /usr/bin/ld: /home/sbergman/lo/core/instdir/program/liblibreofficekitgtk.so: undefined reference to `__ubsan_handle_dynamic_type_cache_miss'
in an ASan+UBSan build (where g-ir-scanner should apparently use CXX instead of
CC for linking, but there appears to be no easy way to tell g-ir-scanner to do
so).
Change-Id: I5a960c6ed387722138d4b3d156c87038f3e5b8ca
Reviewed-on: https://gerrit.libreoffice.org/76769
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
RPM build errors:
Explicit %attr() mode not applicable to symlink: /workdir/CustomTarget/sysui/rpm/libreofficedev/freedesktop/usr/bin/libreofficedev6.1
Installed (but unpackaged) file(s) found:
/usr/local/lib/girepository-1.0/LOKDocView-0.1.typelib
/usr/share/gir-1.0/LOKDocView-0.1.gir
The LOKDocView problem turned out to be the result of the first
incremental build after adding --with-package-format, and previously it
was avoided with a if in configure; moving the commands out of
create_tree.sh should be more obvious and reliable though.
Change-Id: I69c1566e26eeaa1d8bf88a3650a78da6ddfb5a3b
Reviewed-on: https://gerrit.libreoffice.org/76596
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
...as otherwise languages like Slovenian (which do not have a full system
integration) fall back to other LibreOffice.app/Contents/Resource/*.lproj
localizations instead of to English (whose Info.plist is stored as
LibreOffice.app/Contents/Info.plist, not as some
LibreOffice.app/Contents/Resources/en.lproj/InfoPlist.strings as is done for
other languages).
Change-Id: Ic69907a066e9afe1d66045016ad6bf9d997c67d0
Reviewed-on: https://gerrit.libreoffice.org/75728
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
At least building on Flathub makes presence of this information a hard
requirement now (see <https://blogs.gnome.org/hughsie/2019/03/28/
new-appstream-validation-requirements/> and witness the failed
<https://flathub.org/builds/#/builders/32/builds/3597>).
The suggested way to calculate that information is via the form at
<https://hughsie.github.io/oars/generate.html>, which I filled in as follows
(the answers I selected are prefixed with "=>"):
> By answering all the questions you can generate AppStream-compatible markup
> for the upstream AppData file.
>
> If the user is able to "enable" NSFW or "adult" content, then this should be
> included in the assessment even if it is turned off by default.
>
> What type of component are you generating content for:
=> Application that can connect to the Internet
> OARS has multiple versions, and the newer versions include more questions
> involving specific cultural and religious sensitivities. What version of OARS
> metadata do you want to produce:
=> 1.0 (works with all clients)
> Advertising
>
> Defined as the activity of producing advertisements for commercial products or
> services.
>
> For example, this would include banners showing the Coca-Cola logo shown in a
> Soccer game.
=> None
> Gambling
>
> Defined as taking a risky action in the hope of a desired result.
>
> For example, this would include spinning a wheel to get in-app credits.
=> None
> In-App Purchases
>
> Defined as items or points that a user can buy for use within a virtual world
> to improve a character or enhance the playing experience.
=> None
> Online Text-only Messaging
>
> Defined as any messaging system connected to the Internet.
=> None
> Online Audio and Video Messaging
>
> Defined as any multimedia messaging system connected to the Internet.
=> None
> Contact Details
>
> Defined as sharing identifiable details with other users to allow out-of-band
> communication.
=> None
> Information Sharing
>
> Defined as sharing information with a legal entity typically used for
> advertising or for sending back diagnostic data.
>
> For example, this would include sending your purchasing history to Amazon.
=> None
> Location Sharing
>
> Defined as sharing your physical real-time location.
>
> For example, this would include uploading the GPS co-ordinates of your current
> location. NOTE: This does not include heuristic based location services, e.g.
> GeoIP and others.
=> None
> The following markup can be pasted into the existing application AppData file.
>
> <content_rating type="oars-1.0" />
Change-Id: I063484d8031892c20f88999c5a9beeae3666511c
Reviewed-on: https://gerrit.libreoffice.org/72581
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Don't know how this got broken, presumably somewhere along the line from
01344a8ca57636ac87108c22f777a02fe6d963d5 "convert sysui to gbuild and add to
tail_build" through 4430ace32a8dfd534d5e1c64ec7855edad11e5c4 "tdf#90753:
AutoInstall more packages" to the current state, where a spurious bin directory
containing InfoPlist_*.zip files containing (empty) InfoPlist.strings files is
placed in instdir/ and in the root window of .dmg files.
As discussed in the <https://developer.apple.com/library/archive/documentation/
General/Reference/InfoPlistKeyReference/Articles/
AboutInformationPropertyListFiles.html> "Localizing Property List Values"
section, those InfoPlist.strings files shall apparently be placed into the
Contents/Resources/*.lproj/ directories. (And the zip wrappers were presumably
needed in the past to transport their payload to the proper places in the
installation set, and are now obsolete.)
The list of Apple language IDs for the *.lproj directories was already
duplicated in Makefile.in (test-install target) and
solenv/bin/modules/installer/simplepackage.pm (sub create_package). Ultimately
those lists should all be consolidated. Also, mapping from our language IDs
(see solenv/inc/langlist.mk) to the Apple *.lproj ones needs some fixing (e.g.,
from zh-CN to zh_CN), and it is not clear to me why the old code explicilty
added en-US to the gb_WITH_LANG list of languages for which to generate
InfoPlist_*.zip and InfoPlist.strings files (when that would presumably be the
non-localized strings stored in Info.plist itself). But as mentiond, those
InfoPlist.strings files are all empty anyway (which may be due to another bug?),
so it shouldn't matter much---at least for now---what
Contents/Resources/*.lproj/InfoPlist.strings files exactly are present in an
installation set.
Change-Id: Iaadce2375ed319928891bace44f9866622ec3084
Reviewed-on: https://gerrit.libreoffice.org/71277
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ie91f0bf21e6f5c3f7a7aa4ae3d1dff6cc8e15a86
Reviewed-on: https://gerrit.libreoffice.org/69597
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I8058bad949c973981013d099dba78b3e64cee0aa
Reviewed-on: https://gerrit.libreoffice.org/68735
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
KDE4 is out of maintenance upstream since Nov. 2014, and binaries
provided by TDF have switched to KDE5 as the official backend.
Change-Id: I165465b56d3ba3a18912b203c06ae8fc6111c0c9
Reviewed-on: https://gerrit.libreoffice.org/60014
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
It's hard to find an application that can display these file types
on Linux, so suggest LO for those.
Change-Id: I9b32b4ee2057e82a13b8fc95478f2bc2cf7ffca5
Reviewed-on: https://gerrit.libreoffice.org/63372
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
the actual .desktop files are in the main rpm, the freedesktop-menus
package only has symlinks pointing to it
Change-Id: I0816255dd56cd2281b441836871d281e112a659a
|
|
Change-Id: I3feef220283d57fd07cff836ddd22937b1b8c77f
Reviewed-on: https://gerrit.libreoffice.org/57593
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
AppArmor denies writing to .ps files and dealing with temporaries needed
for "Print to file" functionality. Add .ps to the allowed extensions
list, also giving access to rm executable together with writing
printing-related temporary file.
Change-Id: I415e1401878bff6459f42162d4e8b517261b9cec
Reviewed-on: https://gerrit.libreoffice.org/59114
Tested-by: Jenkins
Reviewed-by: Rene Engelhard <rene@debian.org>
|
|
Change-Id: I3082130a39a55609fa38fbf9a667fb95fe6d60ea
Reviewed-on: https://gerrit.libreoffice.org/59612
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Exporting document to .xhtml produces AppArmor deny log entry. Add
AppArmor rule for accessing /etc/xml/catalog as it is needed by libxml2.
Change-Id: If62046059c4e1d458cca895f14f7d1e3f537c527
Reviewed-on: https://gerrit.libreoffice.org/59005
Tested-by: Jenkins
Reviewed-by: Rene Engelhard <rene@debian.org>
|
|
Currently, exporting document to .epub fails if AppArmor profile is
enabled. This patch fixes it by registering .epub extension within
AppArmor profile.
Change-Id: I5075ac803ffd9157c2f2cc6546895149b0fdd5f2
Reviewed-on: https://gerrit.libreoffice.org/59004
Tested-by: Jenkins
Reviewed-by: Rene Engelhard <rene@debian.org>
|
|
Commit c86e4ad53391d17d1eb54845b5999889f7e65061 introduced qt-related
rules, like linking to ~/.config/#[0-9]* files, though does not allow to
write the files themselves, in result producing DENIED log entries if
AppArmor profile is enabled. This is fixed by adding read-write rule for
particular files.
Change-Id: I6441398c4fcfbfcf59ba5f5b3178682c1e5d1cd5
Reviewed-on: https://gerrit.libreoffice.org/59007
Tested-by: Jenkins
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
|
|
Change-Id: Ia717a116056bddc7968a3e451058a94cb2bbbd29
Reviewed-on: https://gerrit.libreoffice.org/59003
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
|
|
Taken from https://www.libreoffice.org/discover/screenshots/
Thanks to guilhem for creating the hub redirection
Change-Id: I57a8fb928e9353d9b305c2e1b09b4f0dd13624f6
Reviewed-on: https://gerrit.libreoffice.org/52767
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Add rules to fix file dialog and other issues with 6.2 alpha1 on Debian
Buster with KDE desktop.
Change-Id: Ib1b20c5809ac9bdea1bf2623eff4345fa42fd4f3
Reviewed-on: https://gerrit.libreoffice.org/58702
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
idea taken from
https://salsa.debian.org/apparmor-team/apparmor-profiles-extra/commit/7fbcc4788d0e94764eeeff2f080796601241f986#546c1096cd506dbb01a47ed87a636a8e94d83b8c
Change-Id: I7e5bda9224d69530af4d30422c2fd3d60c9929d6
Reviewed-on: https://gerrit.libreoffice.org/55770
Tested-by: Jenkins
Tested-by: Rene Engelhard <rene@debian.org>
Reviewed-by: Olivier Tilloy <olivier.tilloy@canonical.com>
Reviewed-by: Rene Engelhard <rene@debian.org>
|
|
Add rule to allow creating temporary files like `lu6924jgpjkq.tmp`,
because without it files cannot be saved.
Change-Id: I640897df5d325e2d01da16840034abbd095fb276
Reviewed-on: https://gerrit.libreoffice.org/58672
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92
Reviewed-on: https://gerrit.libreoffice.org/57028
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
7c6ca00e61c42bb7c43cbb7a3203d8bad5c0ed0e broke the Mac build, because
the files from infoplist Package have double "/" because of the empty
path in the call to gb_Package_add_files.
Change-Id: I3a72e8de0a8f2256b068a491231aaaa3d3b00b6e
|
|
Change-Id: I3ac392f903644281c6a1ccb9183fbe1c72b78311
Reviewed-on: https://gerrit.libreoffice.org/56847
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
thanks Mike Saunders
Change-Id: I7d358a4ccebc008efc67874db5d3f05efc80444a
Reviewed-on: https://gerrit.libreoffice.org/56207
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Ieacbf46f22d4943542ff318aa8236aacab255460
|
|
Change-Id: I2ed73a296b813de722156c69ac64cf9d6cff199d
Reviewed-on: https://gerrit.libreoffice.org/55197
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>
|
|
Change-Id: I421a9e04464f8b722d100982d359b0b8c4a33585
Reviewed-on: https://gerrit.libreoffice.org/55702
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Ibfc58322efb4f038298caff01f644a4ada78b69a
Reviewed-on: https://gerrit.libreoffice.org/55568
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Ic3bc840467e7af6d9f2d0b5f105b316d4d12193e
Reviewed-on: https://gerrit.libreoffice.org/55492
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Id17b0d8e26658bc3b140bd26a37a990e51e08409
Reviewed-on: https://gerrit.libreoffice.org/55356
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I3fc6d8baf9dfb7270eedd7ce0d473a56241c10d5
Reviewed-on: https://gerrit.libreoffice.org/55285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
chmod -x to complete
Change-Id: I966773e0adebf8563343856f18ba25ba84b0a633
Reviewed-on: https://gerrit.libreoffice.org/53666
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I99d47fe7845740b02f85af3de39bc177424894e7
Reviewed-on: https://gerrit.libreoffice.org/55175
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I98dfdff303a6c54db68725799796c89e903c6524
Reviewed-on: https://gerrit.libreoffice.org/54990
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I778feac0b50390f59a3621279636f8b09ed3def2
|
|
since /usr/lib{,32,64}/jvm/**/jre/bin/java doesn't exist since OpenJDK 9
Change-Id: Ic9c052a756ba4a93595595da98148ff22169d333
|
|
Change-Id: Ib9fb7652922dcc8364567953d17d7cae8ad170a7
Reviewed-on: https://gerrit.libreoffice.org/54726
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
|
|
Change-Id: Ie0e8b8b7ad59ee640d6b195dfae1a7cf745056fd
Reviewed-on: https://gerrit.libreoffice.org/54543
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I0f86653ff94cead486f6c158e875f07533e1cb5d
Reviewed-on: https://gerrit.libreoffice.org/53687
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: Ia5bf93d6af6ff301439ef04593fcb1d13ab3aa9f
|
|
This allows opening files with the xlsm and xltm extensions
(Excel macro-enabled workbooks and templates).
Change-Id: I9282f83ff15108a703b98f1752eeee94a2f174c1
Reviewed-on: https://gerrit.libreoffice.org/50514
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
... as used by firefox >= 58
Change-Id: I2769020327d3d097f734ab2c152bee2474b99767
|
|
Use fakeroot to call tar when creating the tar.gz archives
holding the desktop-integration parts to have root:root
as owner of the files inside those.
Change-Id: Idcdcb4dd398f330773671266dafb354711b0f093
Reviewed-on: https://gerrit.libreoffice.org/49827
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|