summaryrefslogtreecommitdiff
path: root/test/source/diff
AgeCommit message (Collapse)Author
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I7a4df11c23a92d0c5538cea4290dcc5e2c9ac3c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2022-04-02Recheck modules t* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I109fa07d52721fd10354de07a2ed995ffa2f27c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132369 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13Revert "loplugin:constfields in sw"Noel Grandin
This reverts commit 4969f4c0d3e2581aaa8a5b5a5769840fa6b6f8ea. Change-Id: I527e9366b05e8a20633720e334395b285991c524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-19tdf#42949 Fix IWYU warnings in test/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id1ee9b6d44315443d023bdfbf9ae8e5aa2158ab2 Reviewed-on: https://gerrit.libreoffice.org/85171 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-03improve assert message in XMLDiffNoel Grandin
Change-Id: I561dca23621075753185d7ea2afc5fd174cd2b3d Reviewed-on: https://gerrit.libreoffice.org/71728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:constfields in swNoel Grandin
Change-Id: I1eb6583bb9ec815bc0564b0d7c676f5b1fb9045f Reviewed-on: https://gerrit.libreoffice.org/61177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-29cppcheck: useInitializationList in test to xmloffJochen Nitschke
Change-Id: I50545784c5412ab7767f401c6e40058a1d0bfab0 Reviewed-on: https://gerrit.libreoffice.org/58262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-26xml diff - report what attribute values actually differTomaž Vajngerl
Change-Id: I16bc122e3f2cce94a5eb8454b528bf484210a4ae Reviewed-on: https://gerrit.libreoffice.org/53369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-23loplugin:includeform: testStephan Bergmann
Change-Id: Ibcbb5b002e8326c484547a825cb295d0f5158a3b
2017-04-28clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a Reviewed-on: https://gerrit.libreoffice.org/36450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I31e61fc91dff70f32143d84ccf308f2bbc9c740e
2015-01-20Some more loplugin:cstylecast: testStephan Bergmann
Change-Id: I48397ba0cc3c0737f6c47808d353245f81050a2b
2014-08-06Improve test failure outputStephan Bergmann
Change-Id: I4417318988ef70639cbcec9d776c783ad69c3990
2014-04-09Remove unused functionStephan Bergmann
Change-Id: I5457124fe584d86953f3167303e92ae6134fa843
2014-04-06whitespace cleanup in testMarkus Mohrhard
Change-Id: Iaf3f7c360cd8d081d706e92ec52c3c96fe68c57c
2014-04-03make the tolerance file optionalMarkus Mohrhard
Change-Id: I172cbd54a231a4f9b621fb85c7f349839286143a
2014-02-18coverity#738915 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1ac675441b50ceab7df78fb9646e4e1bd8e6e36e
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-05-14Improve error messages for the xml-diff based unit tests.Jan Holesovsky
Change-Id: Ided6749ebe4899a6d826d069c38d7b21b467d431
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-03-18fix other problems found by WundefLuboš Luňák
Change-Id: Ib4aba95436f82d2a20b07a092f0fd07e0620fdcf
2012-11-29Improve error messageStephan Bergmann
Change-Id: Ibaee8bd83e9f34e0258b48d87151ec03c8301a3a
2012-07-13test: move XMLDiff implementation details to cxx fileMichael Stahl
This makes it unnecessary to link clients against libxml2. Change-Id: Ifd295623c01bdc6f579afbf81d5b609a2b29f4bf
2012-05-01rework callcatcher makefile to build subsequentcheck testsCaolán McNamara
Change-Id: Idda0262e62e42817b8c0502a38ee16913495233c
2012-04-27add tolerance to chart regression testMarkus Mohrhard
Change-Id: I5e7694571815df48e54488a33435bb7d022e6889
2012-04-27use the correct macroMarkus Mohrhard
don't push at 3a.m. Change-Id: Ia50253fe136bab3ebef7a71ba5dbf87e752c2e1a
2012-04-27improve assert messagesMarkus Mohrhard
2012-04-27use the new xml diff in chart regression testMarkus Mohrhard
2012-04-26std::isnan is c++11; use rtl::math::isNan for nowMarkus Mohrhard
2012-04-26add readme for xmldiffMarkus Mohrhard
2012-04-26add xml diff with toleranceMarkus Mohrhard
# Changes to be committed:
generated by cgit (git 2.34.1) at 2025-02-04 16:12:09 +0000