summaryrefslogtreecommitdiff
path: root/test
AgeCommit message (Collapse)Author
2017-05-04Replace all OUString("") with OUString()Arnaud Versini
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:cppunitassertequals: testStephan Bergmann
Change-Id: I3357b7502fcf9a45095919157ca1530e10c14dd0
2017-04-28clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a Reviewed-on: https://gerrit.libreoffice.org/36450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27vcl: move RegisterDisplay() from ErrorHandler to ErrorRegistryChris Sherlock
It is the error registry that should register the display, not the error handler. Move this function to the class that is responsible for it. Change-Id: I95ca1662b907a7f38a42a39ec729b35fd530bb79 Reviewed-on: https://gerrit.libreoffice.org/36853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-12EnableHeadlessMode bool arg doesn't toggle headlessCaolán McNamara
but refers if a dialog is fatal or autocancelled Change-Id: I7f15ecb26a3e29065caaacb932c7416f4cd96ff6 Reviewed-on: https://gerrit.libreoffice.org/36487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03use actual UNO enums in test..vbahelperNoel Grandin
Change-Id: I2e38462045efedc31903589a3fa4e6f62d74d8de Reviewed-on: https://gerrit.libreoffice.org/36042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18Fix MSVC hang in ThreadPool::shutdown()Michael Stahl
This is the vclbootstrapprotector.cxx part of 9899ffd244dd367ba69dffe1f21f4f0222064a46, which unblocks hanging unit tests on a number of VS2015 tinderbox hosts Change-Id: I6dcfd5a85c078953f0dc6fba0311d9e750f8ce5e Reviewed-on: https://gerrit.libreoffice.org/35393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-13Revert "comphelper: fix MSVC hang in ThreadPool::shutdown()"Miklos Vajna
As it causes "unopkg.bin: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/comphelper/source/misc/threadpool.cxx:96: comphelper::ThreadPool::~ThreadPool(): Assertion `mbTerminate' failed." in <https://ci.libreoffice.org/job/lo_gerrit/8283/Config=linux_clang_dbgutil_64/console> and also locally. Revert till it's clear if that assert() should be a SAL_WARN() or unopkg has to be fixed. This reverts commit 9899ffd244dd367ba69dffe1f21f4f0222064a46. Change-Id: I72902f7da410012340aa8231d84c6871a3f7b976
2017-03-11comphelper: fix MSVC hang in ThreadPool::shutdown()Michael Stahl
Commit aa68c99d88fd7abe08c4aee5206c859a0cdba38e added some code using std::condition_variable to comphelper. Built with MSVC 2017, this causes many cppunittester.exe processes to deadlock in ThreadPool::shutdown(): maTasksChanged.notify_all(); This ultimately calls NtReleaseKeyedEvent(), which never returns. The reason appears to be a bug in Windows 7, for which a "hotfix"[1] is avaiable here, but it's apparently not distributed via Windows Update so we likely can't rely on users or even developers having this installed. However, the documentation of DllMain[2] and ExitProcess[3] indicates that during shutdown, by the time global destructors are invoked all threads other than the one that called ExitProcess have already been terminated. Returning from main() implicitly calls ExitProcess [4]. As it turns out the problem only happens for some CppUnitTests because soffice.bin will call ThreadPool::shutdown() from Desktop::doShutdown() while it is still safe. [1] http://support.microsoft.com/kb/2582203 [2] https://msdn.microsoft.com/en-US/library/windows/desktop/ms682583(v=vs.85).aspx [3] https://msdn.microsoft.com/en-us/library/windows/desktop/ms682658(v=vs.85).aspx [4] https://blogs.msdn.microsoft.com/oldnewthing/20100827-00/?p=13023 Change-Id: I6137461ca7efe9a5fbe4f8f8478fb96de3570469 Reviewed-on: https://gerrit.libreoffice.org/35066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-30expand SVM test (Mask, TextRect, TextLine) and mtfxmldumpTomaž Vajngerl
Change-Id: I13e0882ac7093d6d3ab46914316f303e1ab01b93 Reviewed-on: https://gerrit.libreoffice.org/33686 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-14vcl: add SVM metafile reading and writing test and extend xml dumpTomaž Vajngerl
Change-Id: I88ffb795a9c33ea62d05d599757a287335c7d680 Reviewed-on: https://gerrit.libreoffice.org/32914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-05add ISECTREGIONCLIPREGION to dumperCaolán McNamara
Change-Id: If60e84031cfa8aa3cbbdbb99281d784dcd9e6432 Reviewed-on: https://gerrit.libreoffice.org/32757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-29Add support for ETO_PDY in WMF/EMFMike Kaganski
Currently it is implemented by making all characters different text arrays. Unit test included. Change-Id: I850bf192cf5d978a126d3f37b1084021d37bdf30 Reviewed-on: https://gerrit.libreoffice.org/32490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-16screnshot test: Ignore error when creating directoriesSamuel Mehrbrodt
createPath documentation advises against relying on the E_EXIST error code, so we just ignore it Change-Id: I0e842315e1fd5c661d2b504b196e320f84c58e4f Reviewed-on: https://gerrit.libreoffice.org/32081 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-13cui.screenshot: Show full path when failing to create itSamuel Mehrbrodt
Change-Id: Ic5196e90d7a25665cf9b5a2b039492195b0f00c2
2016-12-02use SvtSysLocaleOptions::GetRealUILanguageTag(), not GetLocaleConfigString()Eike Rathke
Assuming that the screenshots directory suffix * should match the configured UI locale instead of the work locale * should not be empty if configuration says "Default - ..." * actually ScreenshotTest::implSaveScreenshot() explicitly tests (maCurrentLanguage == "en-US") and then sets the suffix to empty, so no other locale should exhibit the same Change-Id: Ie4561315b67c3ade20f3947772af45e471d0752f
2016-12-02Postfix rather than prefix locale to directory nameKatarina Behrens
as this is what vnd.libreoffice.image:// expects for localized images Change-Id: I454ff86b86e11248f47ab65f682fb57e52d0f7e5 Reviewed-on: https://gerrit.libreoffice.org/31057 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-26screenshots: builddir is not neccessarily same as srcdirChristian Lohmaier
Change-Id: Ic7d3d7854eeb5511d5e94e7329fcffa8a3ccba34 Reviewed-on: https://gerrit.libreoffice.org/31160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-17Use ProductName as fallback for dialog titleSamuel Mehrbrodt
Change-Id: Iabdcc0730ccef444119f6fdb752e0470dc16fed5 Reviewed-on: https://gerrit.libreoffice.org/30915 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-17Put generated screenshots in lang-dependant subdirSamuel Mehrbrodt
Change-Id: Ida481fcef52fa70390a539ab8f3a838a15084256 Reviewed-on: https://gerrit.libreoffice.org/30913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-17test: Allow to force a certain locale during unit testsSamuel Mehrbrodt
So that screenshots can be generated in different languages Change-Id: I486e48a49d6f3837058ec7ac93b5d7d3094be90e Reviewed-on: https://gerrit.libreoffice.org/30914 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-10-28convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-06CPPUNIT_ASSERT[_DOUBLES]_EQUALStephan Bergmann
Change-Id: I417cea926abcc511e74a090ee90a851c138ac0c0
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-29Fix naming of makefile to mend make dump-deps.Michael Meeks
Also add error message to make this more clear in the future. Change-Id: Ic9e3a2c89119ef1ec3e6cc1074b7419f7ee268b7 Reviewed-on: https://gerrit.libreoffice.org/29375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-05convert LineStyle to scoped enumNoel Grandin
Change-Id: I30cfa5a0649b806604c443f55683d1f2a430983d
2016-09-05convert RasterOp to scoped enumNoel Grandin
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-04cppcheck: Prefer prefix operatorJulien Nabet
Change-Id: Ie5afc17cd0a27989c11bbf1d107b95ddad1218c3 Reviewed-on: https://gerrit.libreoffice.org/28660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-08-30Break test::setUpVcl into a test-setupvcl library of its ownStephan Bergmann
...so it can be gb_CppunitTest_use_library_objects-included in upcoming <https://gerrit.libreoffice.org/#/c/28322/> "tdf#99402: fix Metafile Font handling". Executable_pdf2xml.mk linked against test since b0da8f00a0d41f2b17639fcee4ed4956421e55c5 "Make pdf2xml usable at least from within buildenv again", but that seems unnecessary and would now cause problems when linking the pdf2xml executable on Linux, as the linker for whatever reason wouldn't find the libtest-setupvcl.so referenced from libtest.so, even though the latter has a proper DT_RPATH. Change-Id: Iba5d80266520ce1f5dafedffa520d18e853f7ec5 Reviewed-on: https://gerrit.libreoffice.org/28473 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-29Remove duplication of "set up VCL" codeStephan Bergmann
The "this is called from pyuno" version in test/source/bootstrapfixture.cxx had had an empty deinitHook, but it appears to not hurt to give it the same deinitHook as the version in test/source/vclbootstrapprotector.cxx had had. Make test::setUpVcl accessible from outside module test for an upcoming use in <https://gerrit.libreoffice.org/#/c/28322/16> "tdf#99402: fix Metafile Font handling". Change-Id: I1d609445690b6ee5e331aa322cd4bf434a3de78e
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-18screenshots: clang plugin & tabpage usage fixesArmin Le Grand
Adapted clang compiler results, made TabDialog implementaions of ScreenShot API work with real UXMLDescription names, including a solution for using multiple tabPages with the same *.ui file Change-Id: I56df878b3db3bcc18fa2b4713b7ad72d42e8eb30
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: fix fallback cases for sd and scArmin Le Grand
Change-Id: I27dab5552e3924df30c8b09c46994b2d645bcde9
2016-08-18screenshots: fallback screenshot to ui filesArmin Le Grand
Besides the already existing methods to dump adapted dialogs and create and dump fallback dialogs I added a possibility to process a given input file which may contain a list of UXMLDescription files (*.ui files), one per line. This file is processed (empty lines and comment lines using '#' allowed) and for each descriptor first tries to find a known, adapted dialog. If found it gets used, else fallback is tried. Added ui-definition files for sd and sc which contain all ui-files from these dialogs. Adapted the test base class to hold the needed functionality. Change-Id: I1d4c64af8cd5d9c89a53b193951c3e49669f5852
2016-08-18screenshots: Use UI string and fallback for UI-String onlyArmin Le Grand
Two changes in this commit: The Dialogs to be dumped are identified in their test files using their UXMLDescription to allow later to 'find' the known dialogs and use the specialized construction for these. Also added a fallback to construct a vcl Dialog based on only the UXMLDescription and the VclBuilder. This will be constructed without any active initialization/layouting, so should only be used for unknown Dialogs. Also added a dumpDialogToPath version to the tooling that can work directly with a vcl Dialog instead of a VclAbstractDialog. Change-Id: I90abb6f59c2fcc5d534907ae7e4b9a15edc2d694
2016-08-18screenshots: move shared code to separate classKatarina Behrens
Change-Id: I1760de221bc53d345c2bbfb4fe878c120073ea45
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: If18ea216cc3416e4a7e2041e50b5a64b1e90886a
2016-06-18uitest: move the uitest files to vclMarkus Mohrhard
This allows us to use them in vcl as well without introducing dependency problems. Change-Id: Ib97af2d559902f1a6b47f9255bb0426411670647
2016-06-18uitest: some more work for the UI testingMarkus Mohrhard
Change-Id: I79193190f8f614b2d6a71032f05a0518eb9d1a1d
2016-06-18uitest: add groundwork for ui testing frameworkMarkus Mohrhard
Change-Id: I51b81da870fd220d56b32c20b9e6c4604912a014