summaryrefslogtreecommitdiff
path: root/test
AgeCommit message (Collapse)Author
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14use common PCH for more librariesLuboš Luňák
Change-Id: I53164be413426691025a63cfba731cf5f9d1b7f8 Reviewed-on: https://gerrit.libreoffice.org/80790 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-11simplify "a = a +" to "a +="Noel Grandin
mostly so that my stringadd loplugin can point out places to improve Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5 Reviewed-on: https://gerrit.libreoffice.org/80618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10support screenshotting .ui files with GtkBuilderCaolán McNamara
so... SAL_USE_VCLPLUGIN=gtk3 make screenshot for the "unknown dialog" cases of make screenshot, which loads .ui files and tries to render them, will render them with the native gtk infrastructure Change-Id: Ifc8fe264155887c4d01b7ce0e2aa53e12acbfcb0 Reviewed-on: https://gerrit.libreoffice.org/80545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09log output filenameCaolán McNamara
Change-Id: Ib6c0045edb5d4a5d86c40f354dc99ab2fb693ca4 Reviewed-on: https://gerrit.libreoffice.org/80534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08implement gtk dialog screenshottingCaolán McNamara
Change-Id: If4e570f775bd1e29dfb75cb7e5dd9d9dfc35e654 Reviewed-on: https://gerrit.libreoffice.org/80416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23toggle default away from legacyCaolán McNamara
Change-Id: If89fec63d91f4d3df38a365a606036517e6b1c37 Reviewed-on: https://gerrit.libreoffice.org/79392 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23fix make screenshotCaolán McNamara
Change-Id: Ic8724e149a2d1507810d19622e4c6e1b9be7907b Reviewed-on: https://gerrit.libreoffice.org/79389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-10Fix typosAndrea Gelmini
Change-Id: I263a4348774051626f57547f3fdab00a18a92f75 Reviewed-on: https://gerrit.libreoffice.org/78792 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-24loplugin:returnconstval in test..writerfilterNoel Grandin
Change-Id: Iea7d15f0a54921514cc4b71c5dc8caaa2ee573c8 Reviewed-on: https://gerrit.libreoffice.org/78063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20loplugin:constvars in test..unotoolsNoel Grandin
Change-Id: I087dc53ca5c18893974bbd9d959de56d5a4cdfa0 Reviewed-on: https://gerrit.libreoffice.org/77827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in test..toolkitNoel Grandin
Change-Id: Ic8dad06c535b0af713bfe7cd46e601c8ea7ba6c7 Reviewed-on: https://gerrit.libreoffice.org/77531 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Iedac37e0e056815e64294c70a233242df6dbf110 Reviewed-on: https://gerrit.libreoffice.org/77278 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:oncevarNoel Grandin
Change-Id: I3c014f53607a849c743a2fd1aa47d03d5af978fb Reviewed-on: https://gerrit.libreoffice.org/76495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-23tdf#42949 Fix IWYU warnings in include/testGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: I527f7c2cf2660a758b13eabb4c444ff79ae35f8c Reviewed-on: https://gerrit.libreoffice.org/75186 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-21loplugin:referencecasting in test..toolkitNoel Grandin
Change-Id: Ib1e6ba9c3849256b81fa5fa395e891226a044f7c Reviewed-on: https://gerrit.libreoffice.org/76029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-20test: check validator exit code *after* checking validator outputMichael Stahl
ODF validator may now actually exit with non-0 since commit b14e2f6c63c18894286c99ee8dde9070e24b41c2 - look for validation errors in this case too. Change-Id: I36f4437c54d9a60afee0663a0b9be206773c5378 Reviewed-on: https://gerrit.libreoffice.org/75964 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-04cid#1448518: Resource leak (test/xmltesttools)Julien Nabet
Change-Id: I7894b65e2b20ce94d53a7ca04eb229347145686c Reviewed-on: https://gerrit.libreoffice.org/75097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-04cid#1448515: Resource leak (test/xmltesttools)Julien Nabet
Change-Id: Ifadb599697fca738a41e4aad098edf4de32e174f Reviewed-on: https://gerrit.libreoffice.org/75096 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-07-01Simplify Sequence iterations in testArkadiy Illarionov
Use range-based loops or replace with STL functions Change-Id: I93efa86f49eb49dbdd3b7572dbd538bc300ded05 Reviewed-on: https://gerrit.libreoffice.org/74932 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-19tdf#45904 Move XShape Java tests to C++Jens Carl
Move XShape Java tests to C++ for ScShapeObj. Change-Id: I349c4abb09c3e9e43285b63ee5f19f55d967b38f Reviewed-on: https://gerrit.libreoffice.org/74331 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-18tdf#45904 Move XGluePointsSupplier Java test to C++Jens Carl
Move XGluePointsSupplier Java test to C++ for ScShapeObj. Change-Id: I75babf46b664cccbb4d1df2af1764c3fa296903a Reviewed-on: https://gerrit.libreoffice.org/74140 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-17tdf#45904 Move XShapeDescriptor Java test to C++Jens Carl
Move XShapeDescriptor Java test to C++ for ScShapeObj. Change-Id: I2d530ea73c6f25e36665db0bd65f734e509d97a6 Reviewed-on: https://gerrit.libreoffice.org/74139 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-11fix assert in make screenshotCaolán McNamara
Change-Id: Ie6cea9a97205a54f806c7e56561f712f8a106fb9 Reviewed-on: https://gerrit.libreoffice.org/73807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-07lok: re-factor getTextSelection.Michael Meeks
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-19Fix typosAndrea Gelmini
Change-Id: If0747801d2b955718aa96b97816307ce14cb11a1 Reviewed-on: https://gerrit.libreoffice.org/72547 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-17Resolves: tdf#69042 - Add a "What's New" infobarheiko tietze
Shows an infobar with a link to the respective wiki page Adds a button to the About dialog Replaces If6eb1542d2ad310226f76850f480f2f99070b803 Change-Id: I1eeb504994a6364feb90cfa447029875e0ec1969 Reviewed-on: https://gerrit.libreoffice.org/72218 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-04tdf#45904 Move XComponent Java tests to C++Jens Carl
Move XComponent Java tests to C++ for ScShapeObj. Change-Id: Ib692827729dbe38eaceb76aa042d76e14d9614f8 Reviewed-on: https://gerrit.libreoffice.org/71787 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-03improve assert message in XMLDiffNoel Grandin
Change-Id: I561dca23621075753185d7ea2afc5fd174cd2b3d Reviewed-on: https://gerrit.libreoffice.org/71728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03Enable testing of multiple service namesJens Carl
Enable testing of multiple service names of the object supports this, by storing all possible names in a vector. Change-Id: Iff2c974cc30a0729cb26b07002582e0786a4de44 Reviewed-on: https://gerrit.libreoffice.org/71713 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02Use hasElements to check Sequence emptiness in [t-u]*Arkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: Idefe55e37f5c837c889548ffe7c5711400012a4d Reviewed-on: https://gerrit.libreoffice.org/71667 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-02tdf#45904 Move XReplaceDescriptor Java tests to C++Jens Carl
Move XReplaceDescriptor Java tests to C++ for ScCellSearchObj. Change-Id: Ica5042ce8b5eac3663a0fb5f66ae0a2830c89d93 Reviewed-on: https://gerrit.libreoffice.org/71645 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02tdf#45904 Move SearchDescriptor Java tests to C++Jens Carl
Move SearchDescriptor Java tests to C++ for ScCellSearchObj. Change-Id: I3c9ffbfc80c7fdc39d0e67fe8aae12605a8d04f5 Reviewed-on: https://gerrit.libreoffice.org/71644 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02tdf#45904 Move XSearchDescriptor Java tests to C++Jens Carl
Move XSearchDescriptor Java tests to C++ for ScCellSearchObj. Change-Id: I1ae50bb586fd742b7cc19f71bcae018ca42139e6 Reviewed-on: https://gerrit.libreoffice.org/71643 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-01Make getXPathPosition assert on requested child foundMike Kaganski
Previously, for an XML like this: <sharedItems> <d v="2017-07-10T09:11:02"/> <d v="2017-07-10T09:11:03"/> <m/> </sharedItems> the call like int pos = getXPathPosition(pDoc, "/x:sharedItems", "absent"); gave 3. That could result in mistakes, when a test would assert on position "3" for a child element which name is mistyped. I made such a mistake when creating a unit test trying to assert on a position of the last element, and writing its name as "x:m", like in rXPath itself; the return was 3, and I initially wrongly assumed that the return is 1-based (like in xpath bracketed expressions). rChildName made const OString&, for consistency with rXPath, or with rAttribute in getXPath: child name is just a part of a longer xpath. Change-Id: I7ba9c4466c75b1b10fce1ccf26ef3b56b4e11e87 Reviewed-on: https://gerrit.libreoffice.org/71614 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-25assertXPath: disallow passing rAttribute without rExpectedValueMike Kaganski
Change-Id: I7fb59039429361dad04fb68507f40545f9c4dd6d Reviewed-on: https://gerrit.libreoffice.org/71290 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-25tdf#45904 Move TableColumn Java tests to C++Jens Carl
Move TableColumn Java tests to C++ for ScTableColumnObj. Change-Id: I3f17fa1f25c2676124b56c384364e36736fac849 Reviewed-on: https://gerrit.libreoffice.org/71261 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-25Improve error messagesJens Carl
Change-Id: I08d5b060b6756a89972eeec57c1f9c85e6f65500 Reviewed-on: https://gerrit.libreoffice.org/71262 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-19tdf#45904 Move XChartData Java tests to C++Jens Carl
Fix tdf#43309: Move XChartData Java tests to C++ for ScCellRangeObj. Change-Id: I6b57db53fdddab2ff382354d32809404224a2e1e Reviewed-on: https://gerrit.libreoffice.org/70956 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-18Add a test to check XPath testing facilities in XmlTestToolsMike Kaganski
... to guarantee that e.g. getXPath will always fail for non-empty non-existing attribute Change-Id: I22cf932eda020abf16608341fcd1769b35478883 Reviewed-on: https://gerrit.libreoffice.org/70891 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-17tdf#45904 Move XTextField Java tests to C++Jens Carl
Move XTextField Java tests to C++ for ScEditFieldObj_Header (formerly ScHeaderFieldObj). Change-Id: I36b723945d9306720846b4a4e2d3eaddb1a1c063 Reviewed-on: https://gerrit.libreoffice.org/70841 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-15loplugin:sequentialassign in test..toolsNoel Grandin
Change-Id: I3a6c5807c3262dde6756551e9e955c4ceae09b4f Reviewed-on: https://gerrit.libreoffice.org/70732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12tdf#45904 Move TextContent Java tests to C++Jens Carl
Move TextContent Java tests to C++ for ScEditFieldObj_Cell and ScEditFieldObj_Header (formerly ScCellFieldObj). Change-Id: Ieed5cdbc128490e66d1797c817d998a932317dd4 Reviewed-on: https://gerrit.libreoffice.org/70615 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-11Fix deadlocks of `make screenshot` testsStephan Bergmann
...like CppunitTest_sw_dialogs_test after a1700d52a47184ee07b91b461a846dc5435f0022 "tdf#124238 - Show a Tip-Of-The-Day dialog on startup" (see my comment from today at <https://gerrit.libreoffice.org/#/c/69498/> "tdf#124238 - Show a Tip-Of-The-Day dialog on startup"). As it is unlikely that any test would actually want the Tip-Of-The-Day dialog to appear, just set the corresponding configuration property to false so that all tests using gb_CppunitTest_use_unittest_configuration no longer show it. (<https://gerrit.libreoffice.org/#/c/69498/21..22/sfx2/source/view/viewfrm.cxx> had added the --nofirststartwizard resp. later --nologo hack to SfxViewFrame::Notify in sfx2/source/view/viewfrm.cxx, in response to <https://gerrit.libreoffice.org/#/c/69498/21> failing in UITest_hide_cols. However, that hack is not obsoleted by this change, as those UITest apparently don't use gb_CppunitTest_use_unittest_configuration.) Change-Id: I365e04eb1a3ec0b50f64d5846fc985f601a2750e Reviewed-on: https://gerrit.libreoffice.org/70595 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-11XmlTestTools::getXPath now asserts that non-empty attribute existsMike Kaganski
It turns out that this change revealed unit tests written incorrectly (and untested), or maybe which became broken (not testing) because of some previous assertXPath change? They incorrectly used 3-arg form of it to check node content equality to passed string, while in fact, an attribute was looked for with that name, and its empty return tested to match default empty 4th argument. Change-Id: If24e18518543102d115a22a6282e4cca9cf694e2 Reviewed-on: https://gerrit.libreoffice.org/70581 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-28 15:40:21 +0000